On Thu, Jun 11, 2015 at 6:40 PM, Alexander Holler wrote:
> Am 11.06.2015 um 14:30 schrieb Linus Walleij:
>> Certainly it is possible to create deadlocks in this scenario, but the
>> scope is not to create an ubreakable system.
>
> IAnd what happens if you run into a deadlock? Do you print "you've
When the fimd is disabled by fimd_disable(), enabled overlay layers also
are disabled. If clocks for fimd are enabled by fimd_enable() on this
case, it can lead IOMMU page fault. The reason is that VIDCON0_ENVID and
VIDCON0_ENVID_F bits of VIDCON0 register are set still even though fimd
is disabled
With atomic modesetting all the control for CRTC, Planes, Encoders and
Connectors should come from DRM core, so the driver is not allowed to
enable or disable planes from inside the crtc_enable()/disable() call.
But it needs to disable planes with crtc_disable in exynos driver
internally. Because
The reason waiting vblank is to be power gated and disabled clocks after
dma operation is completed. The dma operation is stopped already before
be power gated and clocks are disabled when mixer is disabled by commit
381be025ac1a6("drm/exynos: stop mixer before gating clocks during
poweroff"). Don'
On 06/11/2015 11:01 PM, Gustavo Padovan wrote:
> Hi Joonyoung,
>
> 2015-06-11 Joonyoung Shim :
>
>> On 06/10/2015 10:36 PM, Gustavo Padovan wrote:
>>> Hi Marek,
>>>
>>> 2015-06-10 Marek Szyprowski :
>>>
Hello,
On 2015-06-01 17:04, Gustavo Padovan wrote:
> From: Gustavo Padovan
Because of recent update, proper clock-frequency becomes mandatory
for validating the mode of panel. This clock-frequency must be set
appropriately for getting required frame rate.
Signed-off-by: Hyungwon Hwang
---
arch/arm/boot/dts/exynos3250-rinato.dts | 2 +-
1 file changed, 1 insertion(+), 1
Exynos mipi phy driver needs syscon node to be probed successfully.
Signed-off-by: Hyungwon Hwang
---
arch/arm/boot/dts/exynos3250.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos3250.dtsi
b/arch/arm/boot/dts/exynos3250.dtsi
index e3bfb11..f8c02dd 100644
--- a/a
Hello,
On 2015-06-11 17:04, Inki Dae wrote:
On 2015년 06월 03일 17:26, Marek Szyprowski wrote:
One should not do any assumptions on the stare of the fimd hardware
during driver initialization, so to properly reset fimd before enabling
IOMMU, one should ensure that all power domains and clocks are
One should not do any assumptions on the stare of the fimd hardware
during driver initialization, so to properly reset fimd before enabling
IOMMU, one should ensure that all power domains and clocks are really
enabled. This patch adds pm_runtime and clocks management in the
fimd_clear_channel() fun
One should not do any assumptions on the stare of the fimd hardware
during driver initialization, so to properly reset fimd before enabling
IOMMU, one should ensure that all power domains and clocks are really
enabled. This patch adds pm_runtime and clocks management in the
fimd_clear_channel() fun
On 2015년 06월 12일 18:05, Marek Szyprowski wrote:
> Hello,
>
> On 2015-06-11 17:04, Inki Dae wrote:
>> On 2015년 06월 03일 17:26, Marek Szyprowski wrote:
>>> One should not do any assumptions on the stare of the fimd hardware
>>> during driver initialization, so to properly reset fimd before enabling
>
2015-06-12 18:03 GMT+09:00 Hyungwon Hwang :
> Exynos mipi phy driver needs syscon node to be probed successfully.
>
> Signed-off-by: Hyungwon Hwang
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 1 +
> 1 file changed, 1 insertion(+)
Thanks for the patch but actually Beata Michalska (+CC) sent it al
2015-06-12 18:03 GMT+09:00 Hyungwon Hwang :
> Because of recent update, proper clock-frequency becomes mandatory
> for validating the mode of panel. This clock-frequency must be set
> appropriately for getting required frame rate.
>
> Signed-off-by: Hyungwon Hwang
Acked-by: Krzysztof Kozlowski
On Fri, 12 Jun 2015 18:23:18 +0900
Krzysztof Kozlowski wrote:
> 2015-06-12 18:03 GMT+09:00 Hyungwon Hwang :
> > Because of recent update, proper clock-frequency becomes mandatory
> > for validating the mode of panel. This clock-frequency must be set
> > appropriately for getting required frame ra
On 10.06.2015 03:26, Rob Herring wrote:
> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
>
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROB
2015-06-12 18:27 GMT+09:00 Hyungwon Hwang :
> On Fri, 12 Jun 2015 18:23:18 +0900
> Krzysztof Kozlowski wrote:
>
>> 2015-06-12 18:03 GMT+09:00 Hyungwon Hwang :
>> > Because of recent update, proper clock-frequency becomes mandatory
>> > for validating the mode of panel. This clock-frequency must be
After the commit abc0b1447d4974963548777a5ba4a4457c82c426
("drm: Perform basic sanity checks on probed modes"), proper
clock-frequency becomes mandatory for validating the mode of panel.
The display does not work if there is no mode validated. Also, this
clock-frequency must be set appropriately fo
On 12/06/15 06:43, Javier Martinez Canillas wrote:
The Exynos interrupt combiner IP loses its state when the SoC enters
into a low power state during a Suspend-to-RAM. This means that if a
IRQ is used as a source, the interrupts for the devices are disabled
when the system is resumed from a sle
On 12.06.2015 19:10, Sudeep Holla wrote:
>
>
> On 12/06/15 06:43, Javier Martinez Canillas wrote:
>> The Exynos interrupt combiner IP loses its state when the SoC enters
>> into a low power state during a Suspend-to-RAM. This means that if a
>> IRQ is used as a source, the interrupts for the devi
On 12/06/15 11:42, Krzysztof Kozlowski wrote:
On 12.06.2015 19:10, Sudeep Holla wrote:
On 12/06/15 06:43, Javier Martinez Canillas wrote:
The Exynos interrupt combiner IP loses its state when the SoC enters
into a low power state during a Suspend-to-RAM. This means that if a
IRQ is used as
Am 12.06.2015 um 09:25 schrieb Linus Walleij:
On Thu, Jun 11, 2015 at 6:40 PM, Alexander Holler wrote:
Am 11.06.2015 um 14:30 schrieb Linus Walleij:
Certainly it is possible to create deadlocks in this scenario, but the
scope is not to create an ubreakable system.
IAnd what happens if you
Hello Sudeep,
Thanks a lot for the feedback.
On 06/12/2015 12:10 PM, Sudeep Holla wrote:
>
>
> On 12/06/15 06:43, Javier Martinez Canillas wrote:
>> The Exynos interrupt combiner IP loses its state when the SoC enters
>> into a low power state during a Suspend-to-RAM. This means that if a
>> IR
Am 12.06.2015 um 13:19 schrieb Alexander Holler:
Am 12.06.2015 um 09:25 schrieb Linus Walleij:
On Thu, Jun 11, 2015 at 6:40 PM, Alexander Holler
wrote:
Am 11.06.2015 um 14:30 schrieb Linus Walleij:
Certainly it is possible to create deadlocks in this scenario, but the
scope is not to create
On 12/06/15 12:27, Javier Martinez Canillas wrote:
Hello Sudeep,
Thanks a lot for the feedback.
On 06/12/2015 12:10 PM, Sudeep Holla wrote:
On 12/06/15 06:43, Javier Martinez Canillas wrote:
The Exynos interrupt combiner IP loses its state when the SoC enters
into a low power state during
Hello everyone,
I'm just trying to get my kernel built for my Odroid U3, but no matter whether
I use 4.0.x or the latest code from arm-soc repository 4.1.0-rc3, it ends at
this message during boot:
###
U-Boot 2015.07-rc1-00408-g012681b (May 30 2015 - 17:49:11 +)
CPU:Exynos4412@1000MH
On 2015년 06월 12일 18:07, Marek Szyprowski wrote:
> One should not do any assumptions on the stare of the fimd hardware
> during driver initialization, so to properly reset fimd before enabling
> IOMMU, one should ensure that all power domains and clocks are really
> enabled. This patch adds pm_runti
Hello,
On 2015-06-12 14:00, Thomas-Karl Pietrowski wrote:
Hello everyone,
I'm just trying to get my kernel built for my Odroid U3, but no matter whether
I use 4.0.x or the latest code from arm-soc repository 4.1.0-rc3, it ends at
this message during boot:
###
U-Boot 2015.07-rc1-00408-g012681
Hello Sudeep,
On 06/12/2015 01:54 PM, Sudeep Holla wrote:
>
>
> On 12/06/15 12:27, Javier Martinez Canillas wrote:
>> Hello Sudeep,
>>
>> Thanks a lot for the feedback.
>>
>> On 06/12/2015 12:10 PM, Sudeep Holla wrote:
>>>
>>>
>>> On 12/06/15 06:43, Javier Martinez Canillas wrote:
The Exyno
Hello,
On 2015-06-12 14:10, Inki Dae wrote:
On 2015년 06월 12일 18:07, Marek Szyprowski wrote:
One should not do any assumptions on the stare of the fimd hardware
during driver initialization, so to properly reset fimd before enabling
IOMMU, one should ensure that all power domains and clocks are
On Wed, Jun 10, 2015 at 05:22:07PM +0900, Krzysztof Kozlowski wrote:
> > I can now say for sure that the commits 88987d2c75 and aee4d1fac8 are
> > the cause for the problem. Audio was working now for 7 days.
>
> +CC Vinod
>
> Gabriel,
>
> I sent a patch which should fix the issue. Could you giv
This patch resolves page fault issue with iommu and atomic feature
when modetest test application is terminated.
ENWIN_F field of WINCONx register enables or disable a dma channel to
each hardware overlay - the value of the field will be updated to real
register after vsync.
So this patch makes s
On 2015년 06월 12일 21:10, Inki Dae wrote:
> On 2015년 06월 12일 18:07, Marek Szyprowski wrote:
>> One should not do any assumptions on the stare of the fimd hardware
>> during driver initialization, so to properly reset fimd before enabling
>> IOMMU, one should ensure that all power domains and clocks a
Hello again,
first after fixing my booting problems I now get different warnings after boot.
- config: http://pastebin.com/MHUu51pF
- log: http://pastebin.com/9YMgMmFL
- repo: arm-soc
I read the last days that you are still working on the clk drivers, so
as these warnings appear to be related to t
On Tue, 9 Jun 2015, Rob Herring wrote:
> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
>
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PR
On Fri, Jun 12, 2015 at 9:05 AM, Hans Ulli Kroll
wrote:
>
>
> On Tue, 9 Jun 2015, Rob Herring wrote:
>
>> set_irq_flags is ARM specific with custom flags which have genirq
>> equivalents. Convert drivers to use the genirq interfaces directly, so we
>> can kill off set_irq_flags. The translation of
On Fri, Jun 12, 2015 at 07:06:50PM +0900, Hyungwon Hwang wrote:
> After the commit abc0b1447d4974963548777a5ba4a4457c82c426
> ("drm: Perform basic sanity checks on probed modes"), proper
> clock-frequency becomes mandatory for validating the mode of panel.
> The display does not work if there is no
Am Freitag, 12. Juni 2015, 17:46:11 schrieb Mateusz Krawczuk:
> Could you send your config and log using gist.github.com, because
> pastebin.com is forbidden by company IT.
>
>
> Mateusz Krawczuk
> Samsung R&D Institute Poland
>
> W dniu 12.06.2015 o 15:53, Thomas Pietrowski pisze:
> > Hello aga
On 10 June 2015 at 14:42, Tobias Jakobi wrote:
> Even if flushing the command buffer doesn't succeed, the
> G2D calls would still return zero. Fix this by just passing
> the flush return code.
>
> Signed-off-by: Tobias Jakobi
> ---
> exynos/exynos_fimg2d.c | 20 +---
> 1 file cha
On 10 June 2015 at 14:42, Tobias Jakobi wrote:
> Remove all unused struct members.
>
Mentioning if they were used at some point in the past will be great.
Thanks
Emil
> Signed-off-by: Tobias Jakobi
> ---
> tests/exynos/exynos_fimg2d_test.c | 10 --
> 1 file changed, 10 deletions(-)
>
>
On 10 June 2015 at 14:42, Tobias Jakobi wrote:
> No test uses DRM planes at the moment so this function
> is never called.
>
Similar to the other patch - mention if this been used previously. I'm
assuming that the exynos guys might have some work stashed which
depends on this ?
-Emil
--
To unsubs
On 10 June 2015 at 14:42, Tobias Jakobi wrote:
> It doesn't make sense to keep this structure, since we
> can just call all tests directly.
>
Seems like it was designed in mind of having another test case.
Perhaps the exynos guys cannot really upstream it (licensing or other
issues) ?
-Emil
--
To
Hello Emil,
Emil Velikov wrote:
> On 10 June 2015 at 14:42, Tobias Jakobi wrote:
>> Even if flushing the command buffer doesn't succeed, the
>> G2D calls would still return zero. Fix this by just passing
>> the flush return code.
>>
>> Signed-off-by: Tobias Jakobi
>> ---
>> exynos/exynos_fimg2
Hello Emil,
Emil Velikov wrote:
> On 10 June 2015 at 14:42, Tobias Jakobi wrote:
>> Remove all unused struct members.
>>
> Mentioning if they were used at some point in the past will be great.
OK, I'll take a look at git history but AFAIK it is not.
With best wishes,
Tobias
>
> Thanks
> Emil
On Fri, 12 Jun 2015, Rob Herring wrote:
> On Fri, Jun 12, 2015 at 9:05 AM, Hans Ulli Kroll
> wrote:
> >
> >
> > On Tue, 9 Jun 2015, Rob Herring wrote:
> >
> >> set_irq_flags is ARM specific with custom flags which have genirq
> >> equivalents. Convert drivers to use the genirq interfaces direct
Hello Emil,
Emil Velikov wrote:
> On 10 June 2015 at 14:42, Tobias Jakobi wrote:
>> It doesn't make sense to keep this structure, since we
>> can just call all tests directly.
>>
> Seems like it was designed in mind of having another test case.
> Perhaps the exynos guys cannot really upstream it
On 12 June 2015 at 17:25, Tobias Jakobi wrote:
> Hello Emil,
>
> Emil Velikov wrote:
>> On 10 June 2015 at 14:42, Tobias Jakobi
>> wrote:
>>> It doesn't make sense to keep this structure, since we
>>> can just call all tests directly.
>>>
>> Seems like it was designed in mind of having another t
Even if flushing the command buffer doesn't succeed, the
G2D calls would still return zero. Fix this by just passing
the flush return code.
In fact error handling currently ignores the fact that
g2d_add_cmd() can fail. This is going to be handled
in a later patch.
Signed-off-by: Tobias Jakobi
--
free()ing a nullptr is a noop, so remove the check.
Signed-off-by: Tobias Jakobi
---
exynos/exynos_fimg2d.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
index 5ea42e6..24a06d0 100644
--- a/exynos/exynos_fimg2d.c
+++ b/exyno
The 'usage' function already does exit(0), so that this
'return -EINVAL' is never called. Just put a break there
to avoid confusion.
Signed-off-by: Tobias Jakobi
---
tests/exynos/exynos_fimg2d_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/exynos/exynos_fimg2d_t
Hello,
I've split off the Exynos specific bits, so this is just some cleanups and
small fixes. Everything can be reviewed without knowledge about the Exynos
platform. My hope is that I can get at least some of the patches from my last
series upstream.
With best wishes,
Tobias
Changes in v2:
-
It doesn't make sense to keep this structure, since we
can just call all tests directly. An inspection of the
git history shows that no code ever used this
abstraction in the past.
Signed-off-by: Tobias Jakobi
---
tests/exynos/exynos_fimg2d_test.c | 42 +--
1
It doesn't make sense to limit the number of
test cases anyway.
Signed-off-by: Tobias Jakobi
---
tests/exynos/exynos_fimg2d_test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/exynos/exynos_fimg2d_test.c
b/tests/exynos/exynos_fimg2d_test.c
index 6af9277..080d178 100644
--- a/tests/e
Remove all unused struct members. An inspection of the
git history shows that these members were also never
used in the past.
Signed-off-by: Tobias Jakobi
---
tests/exynos/exynos_fimg2d_test.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/tests/exynos/exynos_fimg2d_test.c
b/tes
We can just return 'ret' here, the goto serves no purpose.
Signed-off-by: Tobias Jakobi
---
tests/exynos/exynos_fimg2d_test.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tests/exynos/exynos_fimg2d_test.c
b/tests/exynos/exynos_fimg2d_test.c
index de6a2b7..1ec7340 10
No test uses DRM planes at the moment so this function
is never called. Inspection of the git history shows
that DRM planes were also never used in these tests
in the past.
Signed-off-by: Tobias Jakobi
---
tests/exynos/exynos_fimg2d_test.c | 31 ---
1 file changed, 31
This fixes a compiler warning about missing handling of enum
values in the switch statements.
Also remove the silent mapping to G2D_IMGBUF_GEM when an
unknown buffer type is encountered. We have full control
about the type here, and if it's unknown then we obviously
have a bug in the code.
Signed
Hello Sudeep,
On 06/12/2015 02:57 PM, Javier Martinez Canillas wrote:
> On 06/12/2015 01:54 PM, Sudeep Holla wrote:
[snip]
>
>> registers are lost assuming the combiner was powered down, even the
>> status register will be lost and you will not know exactly the wakeup
>> reason right ?
>>
>
>
Hi,
On Fri, Jun 12, 2015 at 12:36 PM, Javier Martinez Canillas
wrote:
>>> registers are lost assuming the combiner was powered down, even the
>>> status register will be lost and you will not know exactly the wakeup
>>> reason right ?
>>>
>>
>> Good question, I didn't find in the documentation I'
On 06/10/2015 10:22 AM, Krzysztof Kozlowski wrote:
> 2015-06-09 20:25 GMT+09:00 :
>> On 06/03/2015 02:05 AM, Krzysztof Kozlowski wrote:
>>> On 03.06.2015 04:51, gabr...@unseen.is wrote:
On 05/31/2015 08:47 AM, Krzysztof Kozlowski wrote:
> 2015-05-31 2:32 GMT+09:00 :
>>
>> Hello,
W dniu 13.06.2015 o 06:48, gabr...@unseen.is pisze:
> On 06/10/2015 10:22 AM, Krzysztof Kozlowski wrote:
>> 2015-06-09 20:25 GMT+09:00 :
>>> On 06/03/2015 02:05 AM, Krzysztof Kozlowski wrote:
On 03.06.2015 04:51, gabr...@unseen.is wrote:
> On 05/31/2015 08:47 AM, Krzysztof Kozlowski wrote
W dniu 12.06.2015 o 22:53, Thomas Pietrowski pisze:
> Hello again,
>
> first after fixing my booting problems I now get different warnings after
> boot.
> - config: http://pastebin.com/MHUu51pF
> - log: http://pastebin.com/9YMgMmFL
> - repo: arm-soc
> I read the last days that you are still worki
W dniu 12.06.2015 o 19:06, Hyungwon Hwang pisze:
> After the commit abc0b1447d4974963548777a5ba4a4457c82c426
> ("drm: Perform basic sanity checks on probed modes"), proper
> clock-frequency becomes mandatory for validating the mode of panel.
> The display does not work if there is no mode validated
62 matches
Mail list logo
