Re: [PATCH 02/23] drm/exynos: calculate vrefresh instead of use a fixed value

2015-07-02 Thread Gustavo Padovan
Hi Joonyoung, 2015-07-02 Joonyoung Shim : > On 06/24/2015 06:35 AM, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > When mode's vrefresh is zero we should ask DRM core to calculate vrefresh > > for us so we can get the correct value instead of relying on fixed value > > defined in a ma

Re: [PATCH v6 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250

2015-07-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday, July 02, 2015 09:42:38 AM Chanwoo Choi wrote: > This patchset use cpufreq-dt driver to support Exynos3250 cpufreq and tested > it > on Exynos3250-based Rinato board. > > Depends on: > - next-20150701 tag (master branch) of linux-next kernel tree > - This patch-set is based on E

Re: [PATCH] drm/exynos: iommu: fix potential NULL pointer dereference

2015-07-02 Thread Joonyoung Shim
On 06/29/2015 03:35 PM, Hyungwon Hwang wrote: > Dear Marek, > > On Thu, 25 Jun 2015 15:10:12 +0200 > Marek Szyprowski wrote: > >> Some drivers (like Exynos mixer) calls >> drm_iommu_attach_device_if_possible before registering crtc, so >> additional check for NULL crtc pointer is required. > >

Re: [PATCH 19/23] drm/exynos: remove extra call to exynos_dp_commit()

2015-07-02 Thread Joonyoung Shim
+Cc Hyungwon, On 06/24/2015 06:35 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > exynos_dp_commit() was getting called twice by exynos encoder core, once > inside the .enable() call and another time by .commit() itself. > > The remove of the second call caused the wake of a bug, the ope

Re: [PATCH 00/23] drm/exynos: atomic improvements + exynos_encoder removal

2015-07-02 Thread Joonyoung Shim
Hi Gustavo, On 06/24/2015 06:35 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi, > > This set improves exynos in a number of ways. The first five patches are > general clean up/fixes. > > Patches 06 to 12 are improvements on top of the newly added atomic modesetting > support. I'm n

Re: [PATCH 12/23] drm/exynos: don't track enabled state at exynos_crtc

2015-07-02 Thread Joonyoung Shim
On 06/24/2015 06:35 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > struct drm_crtc already stores the enabled state of the crtc > thus we don't need to replicate enabled in exynos_drm_crtc. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 16 ---

Re: [PATCH 08/23] drm/exynos: pass struct exynos_drm_plane in update/enable

2015-07-02 Thread Joonyoung Shim
On 06/24/2015 06:35 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > We already have the plane pointer in before calling .update_plane() or > disable_plane() so pass it directly to those calls avoiding a new > conversion from zpos to struct exynos_drm_plane. > > Signed-off-by: Gustavo Pado

Re: [PATCH 02/23] drm/exynos: calculate vrefresh instead of use a fixed value

2015-07-02 Thread Joonyoung Shim
On 06/24/2015 06:35 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > When mode's vrefresh is zero we should ask DRM core to calculate vrefresh > for us so we can get the correct value instead of relying on fixed value > defined in a macro. But if vrefresh is still zero we should fail the >

Re: [PATCH v3 4/4] cpufreq: exynos: remove Exynos5250 specific cpufreq driver support

2015-07-02 Thread Javier Martinez Canillas
Hello Bartlomiej, On Wed, Jul 1, 2015 at 3:10 PM, Bartlomiej Zolnierkiewicz wrote: > Exynos5250 based platforms have switched over to use generic > cpufreq driver for cpufreq functionality. So the Exynos > specific cpufreq support for these platforms can be removed. > > Based on the earlier work

Re: [PATCH v3 3/4] ARM: Exynos: switch to using generic cpufreq driver for Exynos5250

2015-07-02 Thread Javier Martinez Canillas
On Wed, Jul 1, 2015 at 3:10 PM, Bartlomiej Zolnierkiewicz wrote: > From: Thomas Abraham > > The new CPU clock type allows the use of generic CPUfreq driver. > Switch Exynos5250 to using generic cpufreq driver. > > Changes by Bartlomiej: > - split Exynos5250 support from the original patch > > Cc:

Re: [PATCH v3 2/4] ARM: dts: Exynos5250: add CPU OPP and regulator supply property

2015-07-02 Thread Javier Martinez Canillas
On Thu, Jul 2, 2015 at 1:53 AM, Krzysztof Kozlowski wrote: > On 01.07.2015 22:10, Bartlomiej Zolnierkiewicz wrote: >> From: Thomas Abraham >> >> For Exynos5250 platforms, add CPU operating points and CPU >> regulator supply properties for migrating from Exynos specific >> cpufreq driver to using

Re: [PATCH v3 1/4] clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock

2015-07-02 Thread Javier Martinez Canillas
Hello Bartlomiej, On Wed, Jul 1, 2015 at 3:10 PM, Bartlomiej Zolnierkiewicz wrote: > From: Thomas Abraham > > With the addition of the new Samsung specific cpu-clock type, the > arm clock can be represented as a cpu-clock type. Add the CPU clock > configuration data and instantiate the CPU clock

Re: [PATCH 2/2] thermal: exynos: Remove unused code related to platform_data on probe()

2015-07-02 Thread Krzysztof Kozlowski
On 02.07.2015 15:40, Chanwoo Choi wrote: > This patch removes the unused code related to struct exynos_tmu_platform_data > because exynos_tmu_probe() don't handle the struct exynos_tmu_platform_data > *pdata. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Lukasz Majewski > Signed-off-by: Chanw

Re: [PATCH] ARM: dts: Add CPU cooling binding for Exynos3250-based Rinato/Monk board

2015-07-02 Thread Krzysztof Kozlowski
On 02.07.2015 15:11, Chanwoo Choi wrote: > On 07/02/2015 02:54 PM, Krzysztof Kozlowski wrote: >> On 02.07.2015 14:37, Chanwoo Choi wrote: >>> This patch add the cooling device to control the overheating issue on >>> Exynos3250-based Rinato/Monk board. >>> >>> Cc: Kukjin Kim >>> Cc: Krzysztof Kozlo