Re: [RFC PATCH v4 1/9] mmc: dw_mmc: Add external dma interface support

2015-08-06 Thread Shawn Lin
在 2015/8/6 15:08, Krzysztof Kozlowski 写道: On 06.08.2015 15:44, Shawn Lin wrote: DesignWare MMC Controller can supports two types of DMA mode: external dma and internal dma. We get a RK312x platform integrated dw_mmc and ARM pl330 dma controller. This patch add edmac ops to support these

RE: [RFC PATCH v4 3/9] mips: pistachio_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Govindraj Raja
-Original Message- From: Shawn Lin [mailto:shawn@rock-chips.com] Sent: 06 August 2015 07:45 AM To: jh80.ch...@samsung.com; ulf.hans...@linaro.org Cc: he...@sntech.de; diand...@chromium.org; vineet.gup...@synopsys.com; Wei Xu; Joachim Eastwood; Alexey Brodkin; Kukjin Kim;

Re: [PATCH] drm/exynos/fimc: fix runtime pm support

2015-08-06 Thread Marek Szyprowski
Hello, On 2015-04-09 10:46, Marek Szyprowski wrote: Once pm_runtime_set_active() gets called, the kernel assumes that given device has already enabled runtime pm and will call pm_runtime_suspend() without matching pm_runtime_resume(). In case of DRM FIMC IPP driver, this will result in calling

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-06 Thread Viresh Kumar
Cc'ing Rafael again. Guys please don't miss him for any PM related stuff or use get_maintainers .. Cc'ing Arnd/Olof as well to discuss the merge stuff.. On 07-08-15, 08:53, Kukjin Kim wrote: Depends on: - next-20150806 branch of linux-next kernel tree - [PATCH V3 00/16] OPP: Add code

Re: [PATCH v4 6/6] cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option

2015-08-06 Thread Viresh Kumar
On 06-08-15, 15:41, Bartlomiej Zolnierkiewicz wrote: Remove no longer needed CPU_FREQ_BOOST_SW config option. Cc: Viresh Kumar viresh.ku...@linaro.org Cc: Thomas Abraham thomas...@samsung.com Cc: Javier Martinez Canillas jav...@osg.samsung.com Cc: Krzysztof Kozlowski k.kozlow...@samsung.com

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-06 Thread Viresh Kumar
Fixed Olof's email id.. On 07-08-15, 09:20, Viresh Kumar wrote: Cc'ing Rafael again. Guys please don't miss him for any PM related stuff or use get_maintainers .. Cc'ing Arnd/Olof as well to discuss the merge stuff.. On 07-08-15, 08:53, Kukjin Kim wrote: Depends on: - next-20150806

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-06 Thread Krzysztof Kozlowski
wrote: Depends on: - next-20150806 branch of linux-next kernel tree - [PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings (http://www.spinics.net/lists/arm-kernel/msg435408.html) BTW, hmm...how can we see this series in v4.3?...to be honest, I don't think it can

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-06 Thread Viresh Kumar
On 07-08-15, 13:52, Krzysztof Kozlowski wrote: Thanks for explanation. As fair as I understand, Bartlomiej wanted to merge this in a way which would avoid loosing the boost mode. Kukjin prepared topic branches for previous cpu-freq/clk stuff so maybe everything could go through PM? We aren't

Re: [RFC PATCH v4 4/9] arc: axs10x_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Vineet Gupta
On Thursday 06 August 2015 12:19 PM, Shawn Lin wrote: DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Lin shawn@rock-chips.com Acked-by:

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-06 Thread Krzysztof Kozlowski
On 07.08.2015 13:30, Viresh Kumar wrote: On 07-08-15, 13:13, Krzysztof Kozlowski wrote: Still patches 1/6 and 6/6 need your acks. Is the patch 1/6 a prerequisite for others? It does not look like a prerequisite... but it was put at the beginning of the patchset. Patch 1/6 is required to get

Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-06 Thread Viresh Kumar
Hi, I would suggest you sending such patches as reply to the earlier threads only, instead of a new chain. This will save your time. For example, you will need to resend other patches unnecessarily if I NAK this patch :) On 06-08-15, 15:41, Bartlomiej Zolnierkiewicz wrote: Add

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-06 Thread Viresh Kumar
On 07-08-15, 13:13, Krzysztof Kozlowski wrote: Still patches 1/6 and 6/6 need your acks. Is the patch 1/6 a prerequisite for others? It does not look like a prerequisite... but it was put at the beginning of the patchset. Patch 1/6 is required to get boost working, that's all.. Not sure how

RE: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-06 Thread Kukjin Kim
and Trats2 boards. Sounds good. Depends on: - next-20150806 branch of linux-next kernel tree - [PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings (http://www.spinics.net/lists/arm-kernel/msg435408.html) BTW, hmm...how can we see this series in v4.3?...to be honest, I

Re: [PATCH 0/3] mfd: ChromeOS EC Kconfig dependency cleanup

2015-08-06 Thread Javier Martinez Canillas
Hello Lee, On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: This is a trivial series that do some changes to the dependency for the ChromeOS EC drivers Kconfig symbols. The patches are on top of Paul's patch mfd: fix dependency warning for

Re: [RFC PATCH v4 1/9] mmc: dw_mmc: Add external dma interface support

2015-08-06 Thread Krzysztof Kozlowski
On 06.08.2015 15:44, Shawn Lin wrote: DesignWare MMC Controller can supports two types of DMA mode: external dma and internal dma. We get a RK312x platform integrated dw_mmc and ARM pl330 dma controller. This patch add edmac ops to support these platforms. I've tested it on RK312x platform

Re: [RFC PATCH v4 0/9]

2015-08-06 Thread Jaehoon Chung
Hi, Shawn. I remembered that Krzysztof has mentioned Fix the title of cover letter. Your cover letter's title is nothing.. [RFC PATCH v4 0/9] ?? [RFC PATCH v4 0/9] your title... Best Regards, Jaehoon Chung On 08/06/2015 03:44 PM, Shawn Lin wrote: Add external dma support for Synopsys MSHC

Re: [RFC PATCH v4 5/9] arm: exynos_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Krzysztof Kozlowski
On 06.08.2015 15:45, Shawn Lin wrote: DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Lin shawn@rock-chips.com --- Changes in v4: None

[RFC PATCH v4 3/9] mips: pistachio_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Shawn Lin
DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Lin shawn@rock-chips.com --- Changes in v4: None Changes in v3: None Changes in v2: None

[RFC PATCH v4 5/9] arm: exynos_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Shawn Lin
DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Lin shawn@rock-chips.com --- Changes in v4: None Changes in v3: None Changes in v2: None

[RFC PATCH v4 2/9] Documentation: synopsys-dw-mshc: add bindings for idmac and edmac

2015-08-06 Thread Shawn Lin
synopsys-dw-mshc supports three types of transfer mode. We add bindings and description for how to use them at runtime. Signed-off-by: Shawn Lin shawn@rock-chips.com --- Changes in v4: None Changes in v3: None Changes in v2: None .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 25

[RFC PATCH v4 4/9] arc: axs10x_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Shawn Lin
DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Lin shawn@rock-chips.com --- Changes in v4: None Changes in v3: None Changes in v2: None

Re: [PATCH] drm/exynos/fimc: fix runtime pm support

2015-08-06 Thread Inki Dae
On 2015년 08월 06일 19:13, Marek Szyprowski wrote: Hello, On 2015-04-09 10:46, Marek Szyprowski wrote: Once pm_runtime_set_active() gets called, the kernel assumes that given device has already enabled runtime pm and will call pm_runtime_suspend() without matching pm_runtime_resume(). In case

Re: [RFC PATCH v4 3/9] mips: pistachio_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Ralf Baechle
On Thu, Aug 06, 2015 at 02:45:15PM +0800, Shawn Lin wrote: arch/mips/configs/pistachio_defconfig | 1 - Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder

2015-08-06 Thread Inki Dae
On 2015년 08월 06일 08:24, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Hi, This patchset is another important step in the exynos clean up, it removes two exynos internal structs in favor of wider use of struct drm_encoder. Structs exynos_drm_display and

[PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-06 Thread Bartlomiej Zolnierkiewicz
Hi, This patch series removes the use of Exynos4x12 specific support from cpufreq-exynos driver and enables the use of cpufreq-dt driver for this platform. This patch series has been tested on Exynos4412 based Odroid-U3 and Trats2 boards. Depends on: - next-20150806 branch of linux-next kernel

[PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-06 Thread Bartlomiej Zolnierkiewicz
Add cpufreq_boost_enabled_generic_attr table and use it in cpufreq-dt driver instead of cpufreq_generic_attr one when boost support is enabled. As a result scaling_boost_freqs sysfs attribute is available when cpufreq-dt driver is used and boost support is enabled. Cc: Viresh Kumar

Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode

2015-08-06 Thread Jingoo Han
On Thursday, August 06, 2015 11:07 PM, Yakir Yang wrote: In order to move exynos dp code to bridge directory, we need to convert driver drm bridge mode first. As dp driver already have a ptn3460 bridge, so we need to move ptn bridge to the next bridge of dp bridge. Signed-off-by: Yakir

[RFC PATCH 5/8] drm: bridge/analogix_dp: add platform device type support

2015-08-06 Thread Yakir Yang
Signed-off-by: Yakir Yang y...@rock-chips.com --- drivers/gpu/drm/exynos/analogix_dp-exynos.c | 1 + drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 + include/drm/bridge/analogix_dp.h| 6 ++ 3 files changed, 8 insertions(+) diff --git

[RFC PATCH 7/8] drm: bridge: analogix_dp: try force hpd after plug in lookup failed

2015-08-06 Thread Yakir Yang
Some edp screen do not have hpd signal, so we can't just return failed when hpd plug in detect failed. Besides TRM indicate that if HPD_STATUS(RO) is 0, AUX CH will not work, so we need to give a force hpd action to set HPD_STATUS manually. Signed-off-by: Yakir Yang y...@rock-chips.com ---

Re: [PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder

2015-08-06 Thread Gustavo Padovan
Hi Inki, 2015-08-06 Inki Dae inki@samsung.com: On 2015년 08월 06일 08:24, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Hi, This patchset is another important step in the exynos clean up, it removes two exynos internal structs in favor of wider use of

[PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had only a drm_encoder member and the internal exynos_drm_encoders ops that was directly mapped to the drm_encoder helper funcs. So now exynos DRM uses struct drm_encoder

[PATCH v2 10/11] drm/exynos: fold encoder setup into exynos_drm_load()

2015-08-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk As we are removing the exynos encoder move the encoder setup operation directly inside the exynos_drm_load() Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 12 ++--

[PATCH v4 6/6] cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option

2015-08-06 Thread Bartlomiej Zolnierkiewicz
Remove no longer needed CPU_FREQ_BOOST_SW config option. Cc: Viresh Kumar viresh.ku...@linaro.org Cc: Thomas Abraham thomas...@samsung.com Cc: Javier Martinez Canillas jav...@osg.samsung.com Cc: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH v4 3/6] ARM: dts: Exynos4x12: add CPU OPP and regulator supply property

2015-08-06 Thread Bartlomiej Zolnierkiewicz
For Exynos4x12 platforms, add CPU operating points (using opp-v2 bindings) and CPU regulator supply properties for migrating from Exynos specific cpufreq driver to using generic cpufreq driver. Based on the earlier work by Thomas Abraham. Cc: Kukjin Kim kgene@samsung.com Cc: Doug Anderson

[PATCH v4 5/6] cpufreq: exynos: remove Exynos4x12 specific cpufreq driver support

2015-08-06 Thread Bartlomiej Zolnierkiewicz
Exynos4x12 based platforms have switched over to use generic cpufreq driver for cpufreq functionality. So the Exynos specific cpufreq support for these platforms can be removed. Also once Exynos4x12 based platforms support have been removed the shared exynos-cpufreq driver is no longer needed

[PATCH v4 2/6] clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock

2015-08-06 Thread Bartlomiej Zolnierkiewicz
With the addition of the new Samsung specific cpu-clock type, the arm clock can be represented as a cpu-clock type. Add the CPU clock configuration data and instantiate the CPU clock type for Exynos4x12. Based on the earlier work by Thomas Abraham. Cc: Tomasz Figa tomasz.f...@gmail.com Cc:

[PATCH v4 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12

2015-08-06 Thread Bartlomiej Zolnierkiewicz
The new CPU clock type allows the use of generic CPUfreq driver. Switch Exynos4x12 to using generic cpufreq driver. Previously (when exynos-cpufreq driver was used with boost functionality) ARM_EXYNOS_CPU_FREQ_BOOST_SW config option (which enabled boost functionality) selected EXYNOS_THERMAL one.

[RFC PATCH 0/8] Add Analogix Core Display Port Driver

2015-08-06 Thread Yakir Yang
Hi all, Samsung exynos and Rockchip rk3288 almost share same dp controller, so I split the common code out, then rk3288 and exynos can re-used the same dp core driver. Cause I can't find the exact IP name of exynos dp controller, so I decide to name dp core driver with analogix which I find in

[RFC PATCH 1/8] drm: exynos/dp: fix code style

2015-08-06 Thread Yakir Yang
make checkpatch.pl script happy Signed-off-by: Yakir Yang y...@rock-chips.com --- drivers/gpu/drm/exynos/exynos_dp_core.c | 224 drivers/gpu/drm/exynos/exynos_dp_core.h | 53 drivers/gpu/drm/exynos/exynos_dp_reg.c | 100 +++--- 3 files

[RFC PATCH 1/8] drm: exynos/dp: fix code style

2015-08-06 Thread Yakir Yang
make checkpatch.pl script happy Signed-off-by: Yakir Yang y...@rock-chips.com --- drivers/gpu/drm/exynos/exynos_dp_core.c | 224 drivers/gpu/drm/exynos/exynos_dp_core.h | 53 drivers/gpu/drm/exynos/exynos_dp_reg.c | 100 +++--- 3 files changed,

[RFC PATCH 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-06 Thread Yakir Yang
Rockchip have three clocks for dp controller, we leave pclk_edp to analogix_dp driver control, and keep the sclk_edp_24m and sclk_edp in platform driver. Signed-off-by: Yakir Yang y...@rock-chips.com --- drivers/gpu/drm/rockchip/Kconfig| 10 + drivers/gpu/drm/rockchip/Makefile

[RFC PATCH 6/8] drm: bridge: analogix_dp: add some rk3288 special registers setting

2015-08-06 Thread Yakir Yang
RK3288 need some special registers setting, we can separate them out by the dev_type of plat_data. Signed-off-by: Yakir Yang y...@rock-chips.com --- drivers/gpu/drm/bridge/analogix_dp_reg.c | 76 drivers/gpu/drm/bridge/analogix_dp_reg.h | 12 + 2 files

[RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode

2015-08-06 Thread Yakir Yang
In order to move exynos dp code to bridge directory, we need to convert driver drm bridge mode first. As dp driver already have a ptn3460 bridge, so we need to move ptn bridge to the next bridge of dp bridge. Signed-off-by: Yakir Yang y...@rock-chips.com ---

Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode

2015-08-06 Thread Yakir Yang
Hi Jingoo, 在 2015/8/6 22:19, Jingoo Han 写道: On Thursday, August 06, 2015 11:07 PM, Yakir Yang wrote: In order to move exynos dp code to bridge directory, we need to convert driver drm bridge mode first. As dp driver already have a ptn3460 bridge, so we need to move ptn bridge to the next

Re: [RFC PATCH v4 1/9] mmc: dw_mmc: Add external dma interface support

2015-08-06 Thread Krzysztof Kozlowski
On 06.08.2015 16:26, Shawn Lin wrote: 在 2015/8/6 15:08, Krzysztof Kozlowski 写道: On 06.08.2015 15:44, Shawn Lin wrote: DesignWare MMC Controller can supports two types of DMA mode: external dma and internal dma. We get a RK312x platform integrated dw_mmc and ARM pl330 dma controller. This

Re: [RFC PATCH v4 0/9]

2015-08-06 Thread Shawn Lin
在 2015/8/6 15:08, Jaehoon Chung 写道: Hi, Shawn. I remembered that Krzysztof has mentioned Fix the title of cover letter. Your cover letter's title is nothing.. [RFC PATCH v4 0/9] ?? [RFC PATCH v4 0/9] your title... Sorry, I forgot it, and will fix in next version... Best Regards, Jaehoon

[RFC PATCH v4 7/9] arm: lpc18xx_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Shawn Lin
DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Lin shawn@rock-chips.com --- Changes in v4: None Changes in v3: None Changes in v2: None

[RFC PATCH v4 0/9]

2015-08-06 Thread Shawn Lin
Add external dma support for Synopsys MSHC Synopsys DesignWare mobile storage host controller supports three types of transfer mode: pio, internal dma and external dma. However, dw_mmc can only supports pio and internal dma now. Thus some platforms using dw-mshc integrated with generic dma can't

[RFC PATCH v4 1/9] mmc: dw_mmc: Add external dma interface support

2015-08-06 Thread Shawn Lin
DesignWare MMC Controller can supports two types of DMA mode: external dma and internal dma. We get a RK312x platform integrated dw_mmc and ARM pl330 dma controller. This patch add edmac ops to support these platforms. I've tested it on RK312x platform with edmac mode and RK3288 platform with

[RFC PATCH v4 9/9] arm: zx_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Shawn Lin
DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Lin shawn@rock-chips.com --- Changes in v4: None Changes in v3: None Changes in v2: None

[RFC PATCH v4 8/9] arm: multi_v7_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Shawn Lin
DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Lin shawn@rock-chips.com --- Changes in v4: None Changes in v3: None Changes in v2: None

[RFC PATCH v4 6/9] arm: hisi_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-06 Thread Shawn Lin
DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Lin shawn@rock-chips.com --- Changes in v4: None Changes in v3: None Changes in v2: None

[RFC PATCH 8/8] drm: bridge/analogix_dp: expand the delay time for hpd detect

2015-08-06 Thread Yakir Yang
Some edp screen with no hpd signal would need some delay time to ensure that screen would be ready for work, so we can expand the delay time in hpd detect function, it works prefectly on my rk3288 sdk board. Signed-off-by: Yakir Yang y...@rock-chips.com ---

Re: [RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver to bridge dir

2015-08-06 Thread Yakir Yang
Jingoo, 在 2015/8/6 22:33, Jingoo Han 写道: On Thursday, August 06, 2015 11:19 PM, Yakir Yang wrote: Split the dp core driver from exynos directory to bridge directory, and rename the core driver to analogix_dp_*, leave the platform code to analogix_dp-exynos. Signed-off-by: Yakir Yang

Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver

2015-08-06 Thread Jingoo Han
On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote: Hi all, Samsung exynos and Rockchip rk3288 almost share same dp controller, so I split the common code out, then rk3288 and exynos can re-used the same dp core driver. Cause I can't find the exact IP name of exynos dp controller,

Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver

2015-08-06 Thread Yakir Yang
Jingoo, 在 2015/8/6 22:41, Jingoo Han 写道: On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote: Hi all, Samsung exynos and Rockchip rk3288 almost share same dp controller, so I split the common code out, then rk3288 and exynos can re-used the same dp core driver. Cause I can't find the

Re: [RFC PATCH 1/8] drm: exynos/dp: fix code style

2015-08-06 Thread Joe Perches
On Thu, 2015-08-06 at 09:04 -0500, Yakir Yang wrote: make checkpatch.pl script happy That should not be the primary reason to submit a patch. Making it easier for human code reader to understand what the code does should be though. diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c

Re: [RFC PATCH v4 0/9]

2015-08-06 Thread Jaehoon Chung
On 08/06/2015 04:31 PM, Shawn Lin wrote: 在 2015/8/6 15:08, Jaehoon Chung 写道: Hi, Shawn. I remembered that Krzysztof has mentioned Fix the title of cover letter. Your cover letter's title is nothing.. [RFC PATCH v4 0/9] ?? [RFC PATCH v4 0/9] your title... Sorry, I forgot it, and will fix

Re: [RFC PATCH 1/8] drm: exynos/dp: fix code style

2015-08-06 Thread Yakir Yang
Joe, 在 2015/8/6 23:05, Joe Perches 写道: On Thu, 2015-08-06 at 09:04 -0500, Yakir Yang wrote: make checkpatch.pl script happy That should not be the primary reason to submit a patch. Making it easier for human code reader to understand what the code does should be though. Thanks for your