RE: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-29 Thread Pavel Fedin
Hello! > > Add documentation for new subnode properties, allowing bank configuration. > > Based on u-boot implementation, but heavily reworked. > > Please, carefully look at: > Documentation/devicetree/bindings/net/gpmc-eth.txt > Documentation/devicetree/bindings/bus/ti-gpmc.txt Thank you very

Re: [PATCH 03/13] tests/exynos: add fimg2d performance analysis

2015-10-29 Thread Hyungwon Hwang
On Tue, 22 Sep 2015 17:54:52 +0200 Tobias Jakobi wrote: > Currently only fast solid color clear performance is measured. > A large buffer is allocated and solid color clear operations > are executed on it with randomly chosen properties (position > and size of the region, clear color). Execution

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

2015-10-29 Thread Hyungwon Hwang
On Tue, 22 Sep 2015 17:54:55 +0200 Tobias Jakobi wrote: > This tests async processing of G2D jobs. A separate thread is spawned > to monitor the DRM fd for events and check whether a G2D job was > completed. > > v2: Add GPLv2 header, argument handling and documentation. > Test is only instal

RE: [PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-10-29 Thread Pavel Fedin
Hello! > > .../bindings/arm/samsung/exynos-srom.txt | 50 ++- > > arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 +++ > > arch/arm/boot/dts/exynos5410.dtsi | 15 ++ > > arch/arm/mach-exynos/Kconfig | 2 +-

RE: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410

2015-10-29 Thread Pavel Fedin
Hello! > -Original Message- > From: linux-samsung-soc-ow...@vger.kernel.org > [mailto:linux-samsung-soc-ow...@vger.kernel.org] > On Behalf Of Pankaj Dubey > Sent: Thursday, October 29, 2015 8:28 PM > To: Pavel Fedin > Cc: devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;

Re: [PATCH 07/13] tests/exynos: use XRGB8888 for framebuffer

2015-10-29 Thread Hyungwon Hwang
On Tue, 22 Sep 2015 17:54:56 +0200 Tobias Jakobi wrote: > This matches the G2D color mode that is used in the entire code. > The previous (incorrect) RGBA would only work since the > Exynos mixer did its configuration based on the bpp, and not > based on the actual pixelformat. > > Signed-of

Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-29 Thread Krzysztof Kozlowski
On 29.10.2015 21:42, Pavel Fedin wrote: > Add documentation for new subnode properties, allowing bank configuration. > Based on u-boot implementation, but heavily reworked. Please, carefully look at: Documentation/devicetree/bindings/net/gpmc-eth.txt Documentation/devicetree/bindings/bus/ti-gpmc.t

[PATCH v5 0/4] mfd: sec: add S2MPS15 PMIC support

2015-10-29 Thread Alim Akhtar
Samsung's S2MPS15 PMIC is targetted to be used with Samsung's Exynos7 SoC. The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains 27 LDO and 10 Buck regulators, RTC, three 32.768 KHz clock outputs and allows programming these blocks via a I2C interface. This patch series adds

[PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-10-29 Thread Alim Akhtar
From: Thomas Abraham Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. This also supports RTC and three 32.768KHz clock outputs. Cc: devicet...@vger.kernel.org Signed-off-by: Thomas Abraham Signed

[PATCH v5 3/4] regulator: s2mps11: add support for S2MPS15 regulators

2015-10-29 Thread Alim Akhtar
From: Thomas Abraham The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains 27 LDO and 10 Buck regulators and allows programming these regulators via a I2C interface. This patch adds initial support for LDO/Buck regulators of S2MPS15 PMIC. Signed-off-by: Thomas Abraham Sig

[PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-29 Thread Alim Akhtar
RTC found in s2mps15 is almost same as one found on s2mps13 with few differences in RTC_UPDATE register fields, like: 1> Bit[4] and Bit[1] are reversed - On s2mps13 WUDR -> bit[4], AUDR -> bit[1] - On s2mps15 WUDR -> bit[1], AUDR -> bit[4] 2> In case of s2mps13, for alarm

[PATCH v5 2/4] mfd: sec: Add support for S2MPS15 PMIC

2015-10-29 Thread Alim Akhtar
From: Thomas Abraham Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz clock outputs and battery charger. This patch adds initial support for LDO and buck regulators of S2MPS15 device. Signed-off-b

Re: [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-29 Thread Krzysztof Kozlowski
On 29.10.2015 20:43, Pavel Fedin wrote: > Hello! > Any vendor prefix here? How generic is this? >>> >>> I just don't know... Does *everything* really need a vendor prefix? How >>> readable would that >> be? "compatible" property already says >>> that it's samsung-exynos-specific. And IMHO

[PATCH v9 15/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

2015-10-29 Thread Yakir Yang
Some edp screen do not have hpd signal, so we can't just return failed when hpd plug in detect failed. This is an hardware property, so we need add a devicetree property "analogix,need-force-hpd" to indicate this sutiation. Tested-by: Heiko Stuebner Tested-by: Javier Martinez Canillas Signed-of

Re: [PATCH] ARM: multi_v7_defconfig: enable Exynos DRM Mixer driver

2015-10-29 Thread Krzysztof Kozlowski
On 29.10.2015 23:25, Andrzej Hajda wrote: > Mixer driver is selected by CONFIG_DRM_EXYNOS_HDMI option. Since Exynos5433 > HDMI does not require Mixer and there are separate options to select Mixer > and HDMI. > > Signed-off-by: Andrzej Hajda > --- > arch/arm/configs/multi_v7_defconfig | 1 + > 1

Re: [PATCH v8 0/17] Add Analogix Core Display Port Driver

2015-10-29 Thread Heiko Stuebner
Am Mittwoch, 28. Oktober 2015, 16:15:43 schrieb Yakir Yang: > Hi all, > >The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller > share the same IP, so a lot of parts can be re-used. I split the common > code into bridge directory, then rk3288 and exynos only need to keep > some

Re: [PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-10-29 Thread Pankaj Dubey
On 29 October 2015 at 18:12, Pavel Fedin wrote: > This patch extends Exynos SROM controller driver with ability to configure > controller outputs and enables SMSC9115 Ethernet chip on SMDK5410 board, > which is connected via SROMc bank #3. > > With this patchset, support for the whole existing SMD

Re: [PATCH v4 4/4] ARM: dts: Add Ethernet chip to SMDK5410

2015-10-29 Thread Pankaj Dubey
Hi Pavel, On 29 October 2015 at 18:12, Pavel Fedin wrote: > The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO > initialization is required. > > Signed-off-by: Pavel Fedin > --- > arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 > +++ > 1 file

Re: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410

2015-10-29 Thread Pankaj Dubey
Hi Pavel, On 29 October 2015 at 18:12, Pavel Fedin wrote: > This machine uses own SoC device tree file, add missing part. > > Signed-off-by: Pavel Fedin > --- > arch/arm/boot/dts/exynos5410.dtsi | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos54

Re: [rtc-linux] Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-29 Thread Alim Akhtar
Hi Krzysztof, On Thu, Oct 29, 2015 at 5:05 PM, Krzysztof Kozlowski wrote: > 2015-10-29 20:20 GMT+09:00 Alim Akhtar : I am testing this patch before sending them, what I have found is if you don't update WUDR the time does not changes in rtc. e.g. if you don't do above changes

[PATCH] ARM: multi_v7_defconfig: enable Exynos DRM Mixer driver

2015-10-29 Thread Andrzej Hajda
Mixer driver is selected by CONFIG_DRM_EXYNOS_HDMI option. Since Exynos5433 HDMI does not require Mixer and there are separate options to select Mixer and HDMI. Signed-off-by: Andrzej Hajda --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/confi

[PATCH v4 3/4] drivers: exynos-srom: Add support for bank configuration

2015-10-29 Thread Pavel Fedin
Implement handling properties in subnodes and adding child devices to the system. Child devices will not be added if configuration fails. Since the driver now does more than suspend-resume support, dependency on CONFIG_PM is removed. Signed-off-by: Pavel Fedin --- arch/arm/mach-exynos/Kconfig

[PATCH v4 4/4] ARM: dts: Add Ethernet chip to SMDK5410

2015-10-29 Thread Pavel Fedin
The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO initialization is required. Signed-off-by: Pavel Fedin --- arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 +++ 1 file changed, 41 insertions(+) diff --git a/arch/arm/boot/dts/exynos5410-smdk541

[PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410

2015-10-29 Thread Pavel Fedin
This machine uses own SoC device tree file, add missing part. Signed-off-by: Pavel Fedin --- arch/arm/boot/dts/exynos5410.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi index 4603356..da6a8fa0e 1006

[PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-29 Thread Pavel Fedin
Add documentation for new subnode properties, allowing bank configuration. Based on u-boot implementation, but heavily reworked. Signed-off-by: Pavel Fedin --- .../bindings/arm/samsung/exynos-srom.txt | 50 +- 1 file changed, 48 insertions(+), 2 deletions(-) diff -

[PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-10-29 Thread Pavel Fedin
This patch extends Exynos SROM controller driver with ability to configure controller outputs and enables SMSC9115 Ethernet chip on SMDK5410 board, which is connected via SROMc bank #3. With this patchset, support for the whole existing SMDK range can be added. Actually, only bank number is differ

RE: [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-29 Thread Pavel Fedin
Hello! > >> Any vendor prefix here? How generic is this? > > > > I just don't know... Does *everything* really need a vendor prefix? How > > readable would that > be? "compatible" property already says > > that it's samsung-exynos-specific. And IMHO it's quite obvious that > > properties of ve

Re: [rtc-linux] Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-29 Thread Krzysztof Kozlowski
2015-10-29 20:20 GMT+09:00 Alim Akhtar : >>> I am testing this patch before sending them, what I have found is if you >>> don't update WUDR the time does not changes in rtc. >>> e.g. >>> if you don't do above changes then you will see below: >>> - >>> # date --set="Oct 29 14:10:40 2015" >>> Th

Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-29 Thread Alim Akhtar
On 10/29/2015 04:33 PM, Krzysztof Kozlowski wrote: 2015-10-29 16:47 GMT+09:00 Alim Akhtar : Hello Krzysztof, On 10/29/2015 11:24 AM, Krzysztof Kozlowski wrote: On 29.10.2015 13:58, Alim Akhtar wrote: RTC found in s2mps15 is almost same as one found on s2mps14/13 with few differences in R

Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-29 Thread Krzysztof Kozlowski
2015-10-29 16:47 GMT+09:00 Alim Akhtar : > Hello Krzysztof, > > > On 10/29/2015 11:24 AM, Krzysztof Kozlowski wrote: >> >> On 29.10.2015 13:58, Alim Akhtar wrote: >>> >>> RTC found in s2mps15 is almost same as one found on s2mps14/13 >>> with few differences in RTC_UPDATE register fields, like >>>

Re: [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-29 Thread Krzysztof Kozlowski
2015-10-29 16:45 GMT+09:00 Pavel Fedin : > Hello! > >> You missed here a lot of potential Cc. Please use get_maintainer.pl >> script. It *must* be sent to devicetree list. >> >> Please send it also to DeviceTree maintainers because you are adding >> quite generic names for bindings so they may hav

Re: [PATCH] ARM: exynos: Bring back reboot on Exynos5410

2015-10-29 Thread Pankaj Dubey
On Thursday 29 October 2015 02:13 PM, Pavel Fedin wrote: Hello! These patches are not adding any new code, except DT entry. Infact restart handler will be removed from PMU driver and we will be using generic syscon based implementation for reboot, which is already present in Linux kernel.

RE: [PATCH] ARM: exynos: Bring back reboot on Exynos5410

2015-10-29 Thread Pavel Fedin
Hello! > These patches are not adding any new code, except DT entry. Infact > restart handler will be removed from PMU driver and we will be using > generic syscon based implementation for reboot, which is already present > in Linux kernel. Ah, got it. So syscon is a very generic thing, allowin

Re: [PATCH v4 2/4] mfd: sec: Add support for S2MPS15 PMIC

2015-10-29 Thread Alim Akhtar
Hi On 10/29/2015 01:36 PM, Lee Jones wrote: On Thu, 29 Oct 2015, Alim Akhtar wrote: From: Thomas Abraham Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz clock outputs and battery charger. Thi

Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15 regulators

2015-10-29 Thread Alim Akhtar
Hi, On 10/29/2015 01:43 PM, Krzysztof Kozlowski wrote: On 29.10.2015 17:08, Lee Jones wrote: On Thu, 29 Oct 2015, Alim Akhtar wrote: From: Thomas Abraham The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains 27 LDO and 10 Buck regulators and allows programming these r

Re: [PATCH] ARM: exynos: Bring back reboot on Exynos5410

2015-10-29 Thread Pankaj Dubey
Hi Pavel, On Thursday 29 October 2015 12:40 PM, Pavel Fedin wrote: Hello! Patch looks ok, but after Alim's patch series [1] to handle poweroff and reboot via generic syscon based driver gets merged, this will become redundant entry into PMU driver in the absence of any PMU data for Exynos54

RE: [PATCH v3 3/4] drivers: exynos-srom: Add support for bank configuration

2015-10-29 Thread Pavel Fedin
Hello! > But the system won't get any information about the failure. Device using > these banks should not probe in such case. In order to achieve this effect, i believe, it's not enough to fail SROMc probe. Peripherials (such as smsc) should then be declared as subnodes. There's one problem

Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15 regulators

2015-10-29 Thread Krzysztof Kozlowski
On 29.10.2015 17:08, Lee Jones wrote: > On Thu, 29 Oct 2015, Alim Akhtar wrote: > >> From: Thomas Abraham >> >> The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains >> 27 LDO and 10 Buck regulators and allows programming these regulators via a >> I2C interface. This patch

Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15 regulators

2015-10-29 Thread Lee Jones
On Thu, 29 Oct 2015, Alim Akhtar wrote: > From: Thomas Abraham > > The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains > 27 LDO and 10 Buck regulators and allows programming these regulators via a > I2C interface. This patch adds initial support for LDO/Buck regulators o

Re: [PATCH v4 2/4] mfd: sec: Add support for S2MPS15 PMIC

2015-10-29 Thread Lee Jones
On Thu, 29 Oct 2015, Alim Akhtar wrote: > From: Thomas Abraham > > Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 > PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz > clock outputs and battery charger. This patch adds initial support for > LDO

Re: [PATCH v4 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-10-29 Thread Alim Akhtar
On 10/29/2015 11:27 AM, Krzysztof Kozlowski wrote: On 29.10.2015 13:58, Alim Akhtar wrote: From: Thomas Abraham Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. Cc: devicet...@vger.kernel.org

Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-29 Thread Alim Akhtar
Hello Krzysztof, On 10/29/2015 11:24 AM, Krzysztof Kozlowski wrote: On 29.10.2015 13:58, Alim Akhtar wrote: RTC found in s2mps15 is almost same as one found on s2mps14/13 with few differences in RTC_UPDATE register fields, like bit fields are changed for WUDR and AUDR. This patch add required c

[PATCH v2 RESEND] ARM: exynos: Bring back reboot on Exynos5410

2015-10-29 Thread Pavel Fedin
Since 8cfc7fdd33080e30b86d21b1a8c9ad0686427ddc ("ARM: EXYNOS: move restart code into pmu driver") PMU support is required in order for the reboot to work. Unfortunately, there is currently no PMU support for 5410. This patch adds exynos5410-pmu to the list of recognized devices. It is okay for the

RE: [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-29 Thread Pavel Fedin
Hello! > You missed here a lot of potential Cc. Please use get_maintainer.pl > script. It *must* be sent to devicetree list. > > Please send it also to DeviceTree maintainers because you are adding > quite generic names for bindings so they may have interesting thoughts > on this. > > LKML list

RE: [PATCH] ARM: exynos: Bring back reboot on Exynos5410

2015-10-29 Thread Pavel Fedin
Hello! > Patch looks ok, but after Alim's patch series [1] to handle poweroff > and reboot via generic syscon based driver gets merged, this will > become redundant entry into PMU driver in the absence of any PMU data > for Exynos5410. Alim has taken care of adding power-off and reboot > device

Re: [PATCH v2] ARM: exynos: Bring back reboot on Exynos5410

2015-10-29 Thread Krzysztof Kozlowski
On 29.10.2015 16:01, Pavel Fedin wrote: > Since 8cfc7fdd33080e30b86d21b1a8c9ad0686427ddc > ("ARM: EXYNOS: move restart code into pmu driver") PMU support is required > in order for the reboot to work. Unfortunately, there is currently no PMU > support for 5410. > > This patch adds exynos5410-pmu t

[PATCH v2] ARM: exynos: Bring back reboot on Exynos5410

2015-10-29 Thread Pavel Fedin
Since 8cfc7fdd33080e30b86d21b1a8c9ad0686427ddc ("ARM: EXYNOS: move restart code into pmu driver") PMU support is required in order for the reboot to work. Unfortunately, there is currently no PMU support for 5410. This patch adds exynos5410-pmu to the list of recognized devices. It is okay for the

Re: [PATCH v3 3/4] drivers: exynos-srom: Add support for bank configuration

2015-10-29 Thread Krzysztof Kozlowski
On 29.10.2015 15:54, Pavel Fedin wrote: > Hello! > Where is the contents of email and patch? >>> + for_each_child_of_node(np, child) >>> + decode_sromc(srom, child); >> >> You ignore the return value here so bank may be not configured but >> device probe will return 0. > > Yes, so