Re: [PATCH v8 0/17] Add Analogix Core Display Port Driver

2015-11-17 Thread Yakir Yang
Hi Jingoo & Exynos DRM Maintainers (Inki & Andrzej & Joonyoung) & Bridge Maintainers (Thierry?): Ping... The front part of this series (exynos_dp to analogix_dp) haven't received more comments in the pasted several months. Is it difficult to carry those patches without new changes but

[PATCH v10 10/17] phy: Add driver for rockchip Display Port PHY

2015-11-17 Thread Yakir Yang
Add phy driver for the Rockchip DisplayPort PHY module. This is required to get DisplayPort working in Rockchip SoCs. Reviewed-by: Heiko Stuebner Signed-off-by: Yakir Yang --- Changes in v10: - Fix the wrong macro value of

[PATCHv2] ASoC: samsung: pass DMA channels as pointers

2015-11-17 Thread Arnd Bergmann
ARM64 allmodconfig produces a bunch of warnings when building the samsung ASoC code: sound/soc/samsung/dmaengine.c: In function 'samsung_asoc_init_dma_data': sound/soc/samsung/dmaengine.c:53:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

[PATCHv2 2/3] ASoC: s3c24xx-i2s: pass DMA channels as platform data

2015-11-17 Thread Arnd Bergmann
This is a minor cleanup to make the s3c2412-i2s and s3c24xx-i2s drivers independent of the mach/dma.h header file and to allow removing the dependency on the specific dmaengine driver in the next patch. As a side not, only the s3c24xx-i2s driver seems to still be used, while the definition of the

Re: [PATCH] drm/exynos: only run atomic_check() if crtc is active

2015-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2015 at 03:19:35PM +0100, Andrzej Hajda wrote: > Hi Daniel, > > On 11/17/2015 11:06 AM, Daniel Vetter wrote: > > On Thu, Nov 12, 2015 at 02:49:29PM +0100, Thierry Reding wrote: > >> On Thu, Nov 12, 2015 at 11:11:20AM -0200, Gustavo Padovan wrote: > >>> From: Gustavo Padovan

[PATCHv2 3/3] ASoC: samsung: pass filter function as pointer

2015-11-17 Thread Arnd Bergmann
As we are now passing the filter data as pointers to the drivers, we can take the final step and also pass the filter function the same way. I'm keeping this change separate, as there it's less obvious that this is a net win. Upsides of this are: - The ASoC drivers are completely independent

[PATCH] ARM: multi_v7_defconfig: Build ChromeOS EC drivers as modules

2015-11-17 Thread Javier Martinez Canillas
Since the multi_v7_defconfig is used to build an image for different platforms, the options should be enabled as module whenever possible. Signed-off-by: Javier Martinez Canillas --- The patch was tested on an Exynos5800 Peach Pi Chromebook and the drivers' modules were

Re: [PATCH] SPI: s3c64xx: pass DMA arguments in platform data

2015-11-17 Thread Arnd Bergmann
On Monday 16 November 2015 17:00:21 Arnd Bergmann wrote: > The s3c64xx platform data already contains a pointer to the > DMA filter function, but not to the associated data. > > This simplifies the code and makes it more generic by > passing the data along with the filter function like > we do

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

2015-11-17 Thread Julia Lawall
On Tue, 17 Nov 2015, Boris Brezillon wrote: > Hi Julia, > > On Tue, 17 Nov 2015 10:05:03 +0100 (CET) > Julia Lawall wrote: > > > > > (This isn't the worst one, but it just happens to be one of the first.) > > > > There are many cases where the typical style would be to

[PATCH v2] SPI: s3c64xx: pass DMA arguments in platform data

2015-11-17 Thread Arnd Bergmann
The s3c64xx platform data already contains a pointer to the DMA filter function, but not to the associated data. This simplifies the code and makes it more generic by passing the data along with the filter function like we do for other drivers. Signed-off-by: Arnd Bergmann ---

[PATCH] drm/exynos: fix building without CONFIG_PM_SLEEP

2015-11-17 Thread Arnd Bergmann
The runtime PM operations use the suspend/resume functions even when CONFIG_PM_SLEEP is not set, but this now fails for the exynos DRM driver: exynos_mixer.c:1289:61: error: 'exynos_mixer_resume' undeclared here (not in a function) SET_RUNTIME_PM_OPS(exynos_mixer_suspend, exynos_mixer_resume,

[PATCH] drm/exynos: remove unused variables

2015-11-17 Thread Arnd Bergmann
After a recent change, two variables were left unused: exynos/exynos5433_drm_decon.c: In function 'decon_enable': exynos/exynos5433_drm_decon.c:381:6: warning: unused variable 'i' [-Wunused-variable] exynos/exynos5433_drm_decon.c:380:6: warning: unused variable 'ret' [-Wunused-variable] This

Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

2015-11-17 Thread Sylwester Nawrocki
On 17/11/15 05:39, Krzysztof Kozlowski wrote: > On 17.11.2015 13:31, pankaj.dubey wrote: >> On Monday 16 November 2015 07:06 AM, Krzysztof Kozlowski wrote: >>> Currently the Exynos5433 (ARMv8 SoC) clock driver depends on ARCH_EXYNOS >>> so it is built also on ARMv7. This does not bring any kind of

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

2015-11-17 Thread Boris Brezillon
Hi Julia, On Tue, 17 Nov 2015 10:05:03 +0100 (CET) Julia Lawall wrote: > > > (This isn't the worst one, but it just happens to be one of the first.) > > > There are many cases where the typical style would be to declare a new > > > variable at the top of the function,

Re: [PATCH] drm/exynos: only run atomic_check() if crtc is active

2015-11-17 Thread Andrzej Hajda
Hi Daniel, On 11/17/2015 11:06 AM, Daniel Vetter wrote: > On Thu, Nov 12, 2015 at 02:49:29PM +0100, Thierry Reding wrote: >> On Thu, Nov 12, 2015 at 11:11:20AM -0200, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> Fixes an regression added by 3ae2436

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

2015-11-17 Thread Yakir Yang
Hi Brian, Thank you for debugging, and fell sorry for the delay reply On 11/06/2015 07:45 AM, Brian Norris wrote: Hi, A few updates: On Tue, Nov 03, 2015 at 05:13:48PM -0800, Brian Norris wrote: On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote: On 11/03/2015 12:38 PM, Brian

Re: [PATCH 17/25] drm/exynos: fix clipping when scalling is enabled

2015-11-17 Thread Tobias Jakobi
Small typo: 'scalling' -> 'scaling' With best wishes, Tobias Marek Szyprowski wrote: > This patch fixes calculation of src x/y offset for negative crtc x/y > values when scalling is enabled. This fixes possible IOMMU fault when > scalling is enabled. > > Signed-off-by: Marek Szyprowski

Re: [PATCH 14/25] drm/exynos: introduce exynos_drm_plane_config structure

2015-11-17 Thread Tobias Jakobi
Hello Marek, Marek Szyprowski wrote: > This patch adds common structure for keeping plane configuration and > capabilities data. This patch is inspired by similar code developed by > Tobias Jakobi. > > Signed-off-by: Marek Szyprowski > --- >

Re: [PATCH 00/25] Exynos DRM: new life of IPP (Image Post Processing) subsystem

2015-11-17 Thread Tobias Jakobi
Hello guys, Daniel Stone wrote: > Hi Marek, > > On 16 November 2015 at 11:35, Marek Szyprowski > wrote: >> On 2015-11-12 15:46, Daniel Stone wrote: >>> On 12 November 2015 at 12:44, Tobias Jakobi >>> wrote: I wonder how this

Re: [PATCH 1/3] ASoC: samsung: pass DMA channels as pointers

2015-11-17 Thread Krzysztof Kozlowski
On 17.11.2015 19:24, Arnd Bergmann wrote: > On Tuesday 17 November 2015 10:16:36 Krzysztof Kozlowski wrote: >> On 14.11.2015 02:22, Arnd Bergmann wrote: >>> ARM64 allmodconfig produces a bunch of warnings when building the >>> samsung ASoC code: >>> >>> sound/soc/samsung/dmaengine.c: In function

Re: [PATCHv2 3/3] ASoC: samsung: pass filter function as pointer

2015-11-17 Thread Krzysztof Kozlowski
On 18.11.2015 00:55, Arnd Bergmann wrote: > As we are now passing the filter data as pointers to the drivers, > we can take the final step and also pass the filter function the > same way. I'm keeping this change separate, as there it's less > obvious that this is a net win. > > Upsides of this

Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init

2015-11-17 Thread Krzysztof Kozlowski
On 17.11.2015 18:01, Arnd Bergmann wrote: > On Tuesday 17 November 2015 10:57:48 Krzysztof Kozlowski wrote: >> On 17.11.2015 07:17, Arnd Bergmann wrote: >>> On Monday 16 November 2015 23:36:42 Rafael J. Wysocki wrote: This should go in through the Samsung tree, so I'll leave it for them

Re: [PATCHv2 2/3] ASoC: s3c24xx-i2s: pass DMA channels as platform data

2015-11-17 Thread Krzysztof Kozlowski
On 18.11.2015 00:54, Arnd Bergmann wrote: > This is a minor cleanup to make the s3c2412-i2s and s3c24xx-i2s > drivers independent of the mach/dma.h header file and to allow > removing the dependency on the specific dmaengine driver in the > next patch. > > As a side not, only the s3c24xx-i2s

Re: [PATCHv2] ASoC: samsung: pass DMA channels as pointers

2015-11-17 Thread Krzysztof Kozlowski
On 18.11.2015 00:53, Arnd Bergmann wrote: > ARM64 allmodconfig produces a bunch of warnings when building the > samsung ASoC code: > > sound/soc/samsung/dmaengine.c: In function 'samsung_asoc_init_dma_data': > sound/soc/samsung/dmaengine.c:53:32: warning: cast to pointer from integer of >

Re: [PATCH v2] SPI: s3c64xx: pass DMA arguments in platform data

2015-11-17 Thread Krzysztof Kozlowski
On 18.11.2015 00:48, Arnd Bergmann wrote: > The s3c64xx platform data already contains a pointer to the > DMA filter function, but not to the associated data. > > This simplifies the code and makes it more generic by > passing the data along with the filter function like > we do for other

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

2015-11-17 Thread Boris Brezillon
Hi Brian, On Mon, 16 Nov 2015 19:00:19 -0800 Brian Norris wrote: > Hi Boris, > > On Mon, Nov 16, 2015 at 02:37:47PM +0100, Boris Brezillon wrote: > > struct nand_chip now embeds an mtd device. Patch all drivers to make use > > of this mtd instance instead of using

Re: [PATCH] drm/exynos: only run atomic_check() if crtc is active

2015-11-17 Thread Daniel Vetter
On Thu, Nov 12, 2015 at 02:49:29PM +0100, Thierry Reding wrote: > On Thu, Nov 12, 2015 at 11:11:20AM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Fixes an regression added by 3ae2436 (drm/exynos/mixer: replace > > direct cross-driver call with

Re: [PATCH 3/3] ASoC: samsung: pass filter function as pointer

2015-11-17 Thread Arnd Bergmann
On Tuesday 17 November 2015 09:45:26 Krzysztof Kozlowski wrote: > On 14.11.2015 02:24, Arnd Bergmann wrote: > > diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c > > index 0945b5de39e7..5a4133b6e6a6 100644 > > --- a/sound/soc/samsung/i2s.c > > +++ b/sound/soc/samsung/i2s.c > > @@

Re: [PATCH 1/3] ASoC: samsung: pass DMA channels as pointers

2015-11-17 Thread Arnd Bergmann
On Tuesday 17 November 2015 10:16:36 Krzysztof Kozlowski wrote: > On 14.11.2015 02:22, Arnd Bergmann wrote: > > ARM64 allmodconfig produces a bunch of warnings when building the > > samsung ASoC code: > > > > sound/soc/samsung/dmaengine.c: In function 'samsung_asoc_init_dma_data': > >

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

2015-11-17 Thread Julia Lawall
> > (This isn't the worst one, but it just happens to be one of the first.) > > There are many cases where the typical style would be to declare a new > > variable at the top of the function, where you perform the > > macro/function-call to convert from one abstraction to another. Like > > > >

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

2015-11-17 Thread Mauro Carvalho Chehab
Em Mon, 16 Nov 2015 13:28:10 +0100 Arnd Bergmann escreveu: > I think we can also move some of the existing platform data headers to the > same > place, but that could be a separate patch: > > $ git grep linux/platform_data drivers/media/ >

Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init

2015-11-17 Thread Arnd Bergmann
On Tuesday 17 November 2015 10:57:48 Krzysztof Kozlowski wrote: > On 17.11.2015 07:17, Arnd Bergmann wrote: > > On Monday 16 November 2015 23:36:42 Rafael J. Wysocki wrote: > >> > >> This should go in through the Samsung tree, so I'll leave it for them to > >> pick > >> it up (at least for the

Re: [PATCH 2/3] ASoC: s3c24xx-i2s: pass DMA channels as platform data

2015-11-17 Thread Arnd Bergmann
On Tuesday 17 November 2015 10:36:46 Krzysztof Kozlowski wrote: > On 14.11.2015 02:23, Arnd Bergmann wrote: > > This is a minor cleanup to make the s3c2412-i2s and s3c24xx-i2s > > drivers independent of the mach/dma.h header file and to allow > > removing the dependency on the specific dmaengine

Re: [PATCH 18/27] mtd: nand: update mtd_to_nand()

2015-11-17 Thread Boris Brezillon
On Mon, 16 Nov 2015 19:03:53 -0800 Brian Norris wrote: > On Mon, Nov 16, 2015 at 02:37:51PM +0100, Boris Brezillon wrote: > > Now that all drivers are using the mtd instance embedded in the nand_chip > > Do you have a script that verifies this? I thought you did at

[PATCH, RESEND] drm/exynos: clean up dma_addr_t use

2015-11-17 Thread Arnd Bergmann
dma_addr_t may be 32 or 64 bits long on 32-bit CPUs, so we cannot cast it to a pointer without getting a compiler warning: drivers/gpu/drm/exynos/exynos_drm_buf.c: In function 'lowlevel_buffer_allocate': drivers/gpu/drm/exynos/exynos_drm_buf.c:109:18: warning: cast from pointer to integer of