Re: [PATCH v2 17/25] mtd: nand: remove useless mtd->priv = chip assignments

On Tue, Dec 01, 2015 at 12:03:14PM +0100, Boris Brezillon wrote: > mtd_to_nand() now uses the container_of() approach to transform an > mtd_info pointer into a nand_chip one. Drop useless mtd->priv > assignments from NAND controller drivers. > > Signed-off-by: Boris Brezillon

Re: [PATCH v2 12/25] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Boris, On Tue, Dec 01, 2015 at 12:03:09PM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris

Re: [PATCH v2 12/25] mtd: nand: use the mtd instance embedded in struct nand_chip

On Tue, Dec 01, 2015 at 12:03:09PM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris Brezillon

Re: [PATCH 3/3] Addition of binding for firmware signals on peach-pi

On 02.12.2015 04:12, Martyn Welch wrote: > The peach pi has a GPIO connected to the firmware write protect, developer > mode and recovery mode lines. This patch adds the required nodes to the > device tree to configure the pinmuxing and allow these to be read from > user space. > > Cc: Rob

[GIT PULL 9/9] ARM: EXYNOS: Defconfig for v4.5

Hi Kukjin, This may conflict with other arm-soc updates... Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at:

[GIT PULL 3/9] ARM64: EXYNOS: clk: Clock dependency for ARM64 for v4.5

Hi Kukjin, Dependency for soc64 changes. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git

[GIT PULL 4/9] ARM64: EXYNOS: Soc specific code for v4.5

Hi Kukjin, ARM64 change touch also defconfig. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at:

Re: [PATCH] drm/exynos: simplify sleep PM ops

Hi Andrzej, 2015년 11월 27일 23:32에 Andrzej Hajda 이(가) 쓴 글: > PM ops in exynos_drm_drv were split into two separate function as they were > used also by drm device. Since PM ops have been removed from drm device, the > functions can be merged together. > > Signed-off-by: Andrzej Hajda

[GIT PULL 6/9] ARM: EXYNOS: clk: Another clock dependency, ARMv7, for v4.5

Hi Kukjin, This is also clock dependency. I put it in separate tag in case clock folks want to pull it also. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository

Re: [RFC PATCH 09/15] PM / devfreq: exynos: Update documentation for bus devices using passive governor

Hi Rob, I'm sorry for delay reply due to the problem of email system on the company. On 2015년 12월 01일 06:14, Rob Herring wrote: > On Thu, Nov 26, 2015 at 10:47:33PM +0900, Chanwoo Choi wrote: >> This patch updates the documentation for passive bus devices and adds the >> detailed example of

[GIT PULL 5/9] ARM: EXYNOS: Drivers for v4.5

Hi Kukjin, Pinctrl for v4.5. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git

[GIT PULL 2/9] ARM: EXYNOS: Exynos SoC/mach specific code for v4.5

Hi Kukjin, SoC/mach specific code. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git

[GIT PULL 1/9] ARM: EXYNOS: dts: Syscon dependency for v4.5

Hi Kukjin, The DT changes are needed before switching to syscon-based reboot and power off method. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at:

[PATCH 1/2] power: Fix unmet dependency on POWER_SUPPLY by POWER_RESET by uncoupling them

Actually reset/power off handlers do not really depend on power supply. Move the power reset out of power supply block so it will appear in main drivers section. This fixes following build warning (encountered on ARM exynos defconfig when POWER_SUPPLY is disabled manually): warning: (ARCH_HISI &&

[PATCH 2/2] power: Build power/avs when POWER_AVS is selected but POWER_SUPPLY is not

POWER_AVS can be selected from top-drivers menu and it does not depend on POWER_SUPPLY. However in such case (POWER_SUPPLY is not enabled) all objects will be skipped by make. Signed-off-by: Krzysztof Kozlowski --- drivers/Makefile | 1 + drivers/power/Makefile |

[PATCH v4 0/3] Exynos4210: fix power domain for MDMA1 device

This patchset fixes mysterious boot hang on Exynos 4210 SoCs, when IOMMU is enabled. There is no direct dependency between IOMMU devices and MDMA1. However enabling IOMMU changes the device probe order, what results in LCD0 power domain being turned off for some time. During that time the

[PATCH v4 3/3] ARM: amba: Properly handle devices with power domains

To read pid/cid registers, the probed device need to be properly turned on. When it is inside a power domain, the bus code should ensure that the given power domain is enabled before trying to access device's registers. Signed-off-by: Marek Szyprowski Reviewed-by: Ulf

[PATCH v4 2/3] ARM: amba: Move reading of periphid to amba_match()

From: Tomeu Vizoso Reading the periphid when the Primecell device is registered means that the apb pclk must be available by then or the device won't be registered at all. By reading the periphid in amba_match() we can return -EPROBE_DEFER if the apb pclk isn't there

[PATCH v4 1/3] driver core: handle -EPROBE_DEFER from bus_type.match()

From: Tomeu Vizoso Allow implementations of the match() callback in struct bus_type to return errors and if it's -EPROBE_DEFER then queue the device for deferred probing. This is useful to buses such as AMBA in which devices are registered before their matching

Re: [PATCH v3 5/5] ARM: exynos: select POWER_RESET_SYSCON and POWER_RESET_SYSCON_POWEROFF

On 01.12.2015 18:03, Pavel Fedin wrote: > Hello! > > Tested it on top of 4.4-rc3. > >> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig >> index 3a10f1a8317a..d279edf9b10d 100644 >> --- a/arch/arm/mach-exynos/Kconfig >> +++ b/arch/arm/mach-exynos/Kconfig >> @@ -27,6

[PATCH 3/3] Addition of binding for firmware signals on peach-pi

The peach pi has a GPIO connected to the firmware write protect, developer mode and recovery mode lines. This patch adds the required nodes to the device tree to configure the pinmuxing and allow these to be read from user space. Cc: Rob Herring Cc: Pawel Moll

Re: [PATCH v2 2/4] driver core: handle -EPROBE_DEFER from bus_type.match()

Hello, On 2015-11-30 14:36, Ulf Hansson wrote: On 26 November 2015 at 13:49, Marek Szyprowski wrote: From: Tomeu Vizoso Lets implementations of the match() callback in struct bus_type to /s/Lets/Allow return errors and if it's

[PATCH v2 22/25] mtd: nand: add helpers to access ->priv

Add two helpers to access the field reserved for private controller data. This makes it clearer what this field is reserved for and ease future refactoring. Signed-off-by: Boris Brezillon --- include/linux/mtd/nand.h | 10 ++ 1 file changed, 10

[PATCH v2 20/25] mtd: nand: simplify nand_dt_init() usage

nand_dt_init() function requires 3 arguments where it actually needs one (dn and mtd can both be retrieved from chip). Drop these parameters. Testing for dn != NULL inside nand_dt_init() also helps simplifying the caller code. Signed-off-by: Boris Brezillon

[PATCH v2 21/25] mtd: nand: kill the chip->flash_node field

Now that the nand_chip struct directly embeds an mtd_info struct we can get rid of the ->flash_node field and forward set/get_flash_node requests to the MTD layer. As a side effect, we no longer need the mtd_set_of_node() call done in nand_dt_init(). Signed-off-by: Boris Brezillon

[PATCH v2 19/25] staging: mt29f_spinand: remove useless mtd->priv = chip assignment

mtd_to_nand() now uses the container_of() approach to transform an mtd_info pointer into a nand_chip one. Drop useless mtd->priv assignments from NAND controller drivers. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle script:

[PATCH v2 23/25] ARM: make use of nand_set/get_controller_data() helpers

New helpers have been added to avoid directly accessing chip->field. Use them where appropriate. Signed-off-by: Boris Brezillon --- arch/arm/mach-ixp4xx/ixdp425-setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 1/3] driver core: handle -EPROBE_DEFER from bus_type.match()

On 1 December 2015 at 14:34, Marek Szyprowski wrote: > From: Tomeu Vizoso > > Allow implementations of the match() callback in struct bus_type to > return errors and if it's -EPROBE_DEFER then queue the device for > deferred probing. > > This

Re: [PATCH v3 3/3] ARM: amba: Properly handle devices with power domains

On 1 December 2015 at 14:34, Marek Szyprowski wrote: > To read pid/cid registers, the probed device need to be properly turned on. > When it is inside a power domain, the bus code should ensure that the > given power domain is enabled before trying to access device's

Re: [PATCH v3 2/3] ARM: amba: Move reading of periphid to amba_match()

On 1 December 2015 at 14:34, Marek Szyprowski wrote: > From: Tomeu Vizoso > > Reading the periphid when the Primecell device is registered means that > the apb pclk must be available by then or the device won't be registered > at all. > > By

Re: [PATCH 03/10] gpio: samsung: move gpio-samsung driver back to platform code

On Tuesday 01 December 2015 09:34:18 Krzysztof Kozlowski wrote: > On 26.11.2015 01:06, Arnd Bergmann wrote: > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig > > index 57729b915003..83697414bfa0 100644 > > --- a/arch/arm/plat-samsung/Kconfig > > +++

Re: [PATCH 02/10] ASoC: samsung/smartq: use dynamic registration

On Tuesday 01 December 2015 09:24:24 Krzysztof Kozlowski wrote: > > +static struct platform_driver smartq_driver = { > > + .driver = { > > + .name = "smartq-audio", > > + .owner = THIS_MODULE, > > The owner should not be needed (coccicheck should also complain). Rest >

Re: [PATCH v3 2/3] ARM: amba: Move reading of periphid to amba_match()

On Tue, Dec 01, 2015 at 02:34:25PM +0100, Marek Szyprowski wrote: > From: Tomeu Vizoso > > Reading the periphid when the Primecell device is registered means that > the apb pclk must be available by then or the device won't be registered > at all. > > By reading the

[PATCH v2 15/25] cris: nand: use the mtd instance embedded in struct nand_chip

struct nand_chip now embeds an mtd device. Patch all drivers to make use of this mtd instance instead of using the instance embedded in their private struct or dynamically allocated. Signed-off-by: Boris Brezillon --- Most of those changes were generated with

[PATCH v2 25/25] staging: mt29f_spinand: make use of nand_set/get_controller_data() helpers

New helpers have been added to avoid directly accessing chip->field. Use them where appropriate. Signed-off-by: Boris Brezillon --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 01/25] ARM: nand: make use of mtd_to_nand() where appropriate

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all ARM specific implementations to use this helper. Signed-off-by: Boris Brezillon --- arch/arm/mach-ep93xx/snappercl15.c | 4 ++-- arch/arm/mach-ep93xx/ts72xx.c

[PATCH v2 00/25] mtd: nand: refactor the NAND subsystem (part 1)

Hello, This huge series aims at clarifying the relationship between the mtd and nand_chip structures and hiding NAND framework internals to NAND controller drivers. The first part of the series provide an mtd_to_nand() helper to hide the way mtd and nand_chip are linked together. The second

Re: [PATCH v2 12/25] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Boris, [auto build test ERROR on next-20151127] [cannot apply to mtd/master v4.4-rc3 v4.4-rc2 v4.4-rc1 v4.4-rc3] url: https://github.com/0day-ci/linux/commits/Boris-Brezillon/mtd-nand-refactor-the-NAND-subsystem-part-1/20151201-190822 config: arm-imx_v6_v7_defconfig (attached as .config

Re: [PATCH v2 2/4] driver core: handle -EPROBE_DEFER from bus_type.match()

[...] >>> @@ -500,8 +501,17 @@ static int __device_attach_driver(struct >>> device_driver *drv, void *_data) >>> if (dev->driver) >>> return -EBUSY; >>> >>> - if (!driver_match_device(drv, dev)) >>> + ret = driver_match_device(drv, dev); >>> + if (!ret)

[PATCH v2 10/25] mtd: nand: add nand_to_mtd() helper

Add a new helper to retrieve the MTD device attached to a NAND chip. Signed-off-by: Boris Brezillon --- include/linux/mtd/nand.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index

Re: [PATCH v2 11/25] coccinelle: nand: detect and correct drivers embedding an mtd_info object

On Tue, 1 Dec 2015, Boris Brezillon wrote: > Add nand-priv-no-mtd.cocci to detect and correct NAND controller drivers > directly embedding an mtd_info struct in their private struct. > > Signed-off-by: Boris Brezillon > Cc: Julia Lawall

[PATCH v2 17/25] mtd: nand: remove useless mtd->priv = chip assignments

mtd_to_nand() now uses the container_of() approach to transform an mtd_info pointer into a nand_chip one. Drop useless mtd->priv assignments from NAND controller drivers. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle script:

[PATCH v2 13/25] mtd: nand: update the documentation to reflect framework changes

The MTD device is now directly embedded in the nand_chip struct. Update the mtdnand documentation to mention this aspect and fix the different examples. Signed-off-by: Boris Brezillon --- Documentation/DocBook/mtdnand.tmpl | 31 +++

[PATCH v2 16/25] mtd: nand: update mtd_to_nand()

Now that all drivers are using the mtd instance embedded in the nand_chip struct we can safely update the mtd_to_nand() implementation to use the container_of macro instead of returning the content of mtd->priv. This will allow us to remove mtd->priv = chip assignments done in all NAND controller

[PATCH v2 18/25] cris: nand: remove useless mtd->priv = chip assignments

mtd_to_nand() now uses the container_of() approach to transform an mtd_info pointer into a nand_chip one. Drop useless mtd->priv assignments from NAND controller drivers. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle script:

[PATCH v2 04/25] mips: nand: make use of mtd_to_nand() where appropriate

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all MIPS specific implementations to use this helper. Signed-off-by: Boris Brezillon --- arch/mips/alchemy/devboards/db1200.c | 2 +-

[PATCH v2 05/25] sh: nand: make use of mtd_to_nand() where appropriate

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all SH specific implementations to use this helper. Signed-off-by: Boris Brezillon --- arch/sh/boards/mach-migor/setup.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 02/25] blackfin: nand: make use of mtd_to_nand() where appropriate

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all blackfin specific implementations to use this helper. Signed-off-by: Boris Brezillon --- arch/blackfin/mach-bf537/boards/stamp.c | 2 +-

[PATCH v2 03/25] cris: nand: make use of mtd_to_nand() where appropriate

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all CRIS specific implementations to use this helper. Signed-off-by: Boris Brezillon --- arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 2 +-

[PATCH v2 06/25] mtd: nand: make use of mtd_to_nand() in NAND core code

mtd_to_nand() was recently introduced to avoid direct access to the mtd->priv field. Update core code to use mtd_to_nand(). Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_base.c | 84 ++--

[PATCH v2 11/25] coccinelle: nand: detect and correct drivers embedding an mtd_info object

Add nand-priv-no-mtd.cocci to detect and correct NAND controller drivers directly embedding an mtd_info struct in their private struct. Signed-off-by: Boris Brezillon Cc: Julia Lawall --- Hi Julia, Not sure this is the correct way to

[PATCH v2 08/25] staging: mt29f_spinand: make use of mtd_to_nand()

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Use it where appropriate. Signed-off-by: Boris Brezillon --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 14/25] staging: mt29f_spinand: use the mtd instance embedded in struct nand_chip

struct nand_chip now embeds an mtd device, use it instead of allocating a new one. Signed-off-by: Boris Brezillon --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v2 09/25] mtd: nand: embed an mtd_info structure into nand_chip

Currently all NAND controller drivers are providing both the mtd_info and nand_chip struct and then let the NAND subsystem to initialize a few things before registering the mtd instance to the MTD layer. Embed an mtd_info field into nand_chip to add some consistency to all NAND controller drivers.

Re: [PATCH v2 11/25] coccinelle: nand: detect and correct drivers embedding an mtd_info object

Hi, On Tue, 1 Dec 2015 12:17:44 +0100 (CET) Julia Lawall wrote: > > > On Tue, 1 Dec 2015, Boris Brezillon wrote: > > > Add nand-priv-no-mtd.cocci to detect and correct NAND controller drivers > > directly embedding an mtd_info struct in their private struct. > > > >

[PATCH v3 2/3] ARM: amba: Move reading of periphid to amba_match()

From: Tomeu Vizoso Reading the periphid when the Primecell device is registered means that the apb pclk must be available by then or the device won't be registered at all. By reading the periphid in amba_match() we can return -EPROBE_DEFER if the apb pclk isn't there

[PATCH v3 0/3] Exynos4210: fix power domain for MDMA1 device

This patchset fixes mysterious boot hang on Exynos 4210 SoCs, when IOMMU is enabled. There is no direct dependency between IOMMU devices and MDMA1. However enabling IOMMU changes the device probe order, what results in LCD0 power domain being turned off for some time. During that time the

[PATCH v3 3/3] ARM: amba: Properly handle devices with power domains

To read pid/cid registers, the probed device need to be properly turned on. When it is inside a power domain, the bus code should ensure that the given power domain is enabled before trying to access device's registers. Signed-off-by: Marek Szyprowski ---

[PATCH v3 1/3] driver core: handle -EPROBE_DEFER from bus_type.match()

From: Tomeu Vizoso Allow implementations of the match() callback in struct bus_type to return errors and if it's -EPROBE_DEFER then queue the device for deferred probing. This is useful to buses such as AMBA in which devices are registered before their matching