Re: [PATCH] iommu: Ignore -ENODEV errors from add_device call-back returning -ENODEV

2015-06-29 Thread Joerg Roedel
On Mon, Jun 29, 2015 at 10:53:43AM +0200, Marek Szyprowski wrote: > On 2015-06-29 10:35, Joerg Roedel wrote: > >The -ENODEV error just means that the device is not > >translated by an IOMMU. We shouldn't bail out of iommu > >driver initialization when that happens, as th

[PATCH] iommu: Ignore -ENODEV errors from add_device call-back returning -ENODEV

2015-06-29 Thread Joerg Roedel
ODEV return value could be of use for the iommu core in the future. Can you please try the attached patch, which just ignores -ENODEV as a return value from add_device? >From 3c9e7507e93ff6c6e05e6ee2cb123b5d35d8c412 Mon Sep 17 00:00:00 2001 From: Joerg Roedel Date: Mon, 29 Jun 2015 10:16:08 +

Re: [PATCH v7 00/25] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-05-29 Thread Joerg Roedel
On Tue, May 19, 2015 at 03:20:20PM +0200, Marek Szyprowski wrote: > Marek Szyprowski (25): > drm/exynos: iommu: detach from default dma-mapping domain on init > drm/exynos: fimd: ensure proper hw state in fimd_clear_channel() > iommu: Init iommu-groups support earlier, in core_initcall > io

Re: [PATCH v7 03/25] iommu: Init iommu-groups support earlier, in core_initcall

2015-05-29 Thread Joerg Roedel
On Sat, May 23, 2015 at 07:23:34PM +0300, Laurent Pinchart wrote: > On Tuesday 19 May 2015 15:20:23 Marek Szyprowski wrote: > > -arch_initcall(iommu_init); > > +core_initcall(iommu_init); > > I'll let Joerg comment on this, but this initcall ordering dance always makes > me feel that something is

Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers

2015-03-31 Thread Joerg Roedel
On Thu, Mar 26, 2015 at 01:43:03PM +0100, Joerg Roedel wrote: > Changes v1-v2: > > * Rebased to v4.0-rc5 > * Converted domain-types to a bit-field Applied this series to the core branch. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc&

Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers

2015-03-31 Thread Joerg Roedel
Hi Will, On Mon, Mar 30, 2015 at 06:43:15PM +0100, Will Deacon wrote: > Whilst I'm still a bit worried about the ability of the IOMMU driver to do > very much in the ->domain_alloc callback (since we don't know which IOMMU > instance the domain is for), it doesn't leave us any worse off than we >

Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers

2015-03-31 Thread Joerg Roedel
Hi Alex, On Fri, Mar 27, 2015 at 10:24:22PM -0600, Alex Williamson wrote: > For 1-5,16 > > Reviewed-by: Alex Williamson Thanks a lot for your review. > My only comment/question is whether you'd want to consider using > ERR_PTR() return values from domain_alloc(). It's an alloc functions, > so

[PATCH 02/16] iommu: Introduce iommu domain types

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel This allows to handle domains differently based on their type in the future. An IOMMU driver can implement certain optimizations for DMA-API domains for example. The domain types can be extended later and some of the existing domain attributes can be migrated to become domain

[PATCH 08/16] iommu/exynos: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/exynos-iommu.c | 87 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a

[PATCH 01/16] iommu: Introduce domain_alloc and domain_free iommu_ops

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel These new call-backs defer the allocation and destruction of 'struct iommu_domain' to the iommu driver. This allows drivers to embed this struct into their private domain structures and to get rid of the domain_init and domain_destroy call-backs when all drivers

[PATCH 07/16] iommu/arm-smmu: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/arm-smmu.c | 46 +++--- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a

[PATCH 09/16] iommu/tegra-smmu: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/tegra-smmu.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a

[PATCH 05/16] iommu/vt-d: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Get rid of domain_init and domain_destroy and implement domain_alloc/domain_free instead. Signed-off-by: Joerg Roedel --- drivers/iommu/intel-iommu.c | 48 ++--- 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/drivers

[PATCH 04/16] iommu/amd: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement the new iommu-ops function pointers and remove the obsolete domain_init and domain_destroy functions. Signed-off-by: Joerg Roedel --- drivers/iommu/amd_iommu.c | 84 ++--- drivers/iommu/amd_iommu_types.h | 7 ++-- 2 files

[PATCH 06/16] iommu/omap: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement the new domain_alloc and domain_free call-backs and remove the old domain_init/destroy ones. Signed-off-by: Joerg Roedel --- drivers/iommu/omap-iommu.c | 49 +++--- 1 file changed, 29 insertions(+), 20 deletions(-) diff

[PATCH 11/16] iommu/msm: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/msm_iommu.c | 73 +++ 1 file changed, 36 insertions(+), 37 deletions(-) diff --git a

[PATCH 13/16] iommu/ipmmu-vmsa: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/ipmmu-vmsa.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a

[PATCH 10/16] iommu/tegra-gart: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/tegra-gart.c | 67 +++--- 1 file changed, 46 insertions(+), 21 deletions(-) diff --git a

[PATCH 14/16] iommu/rockchip: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/rockchip-iommu.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a

[PATCH 03/16] iommu: Only allow iommu_map/unmap for paging domains

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Check for the new __IOMMU_DOMAIN_PAGING flag before calling into the iommu drivers ->map and ->unmap call-backs. Signed-off-by: Joerg Roedel --- drivers/iommu/iommu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/i

[PATCH 12/16] iommu/shmobile: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/shmobile-iommu.c | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a

[PATCH 15/16] iommu/fsl: Make use of domain_alloc and domain_free

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/fsl_pamu_domain.c | 60 ++--- drivers/iommu/fsl_pamu_domain.h | 2 +- 2 files changed, 33

[PATCH 16/16] iommu: Remove domain_init and domain_free iommu_ops

2015-03-26 Thread Joerg Roedel
From: Joerg Roedel All drivers have been converted to the new domain_alloc and domain_free iommu-ops. So remove the old ones and get rid of iommu_domain->priv too, as this is no longer needed when the struct iommu_domain is embedded in the private structures of the iommu drivers. Signed-off

[PATCH 00/16 v2] iommu: Move domain allocation into drivers

2015-03-26 Thread Joerg Roedel
for x86, ARM and PPC and runtime tested on x86 (Intel VT-d and AMD IOMMU). Please review. Thanks, Joerg Joerg Roedel (15): iommu: Introduce domain_alloc and domain_free iommu_ops iommu: Introduce iommu domain types iommu/amd: Make use of domain_alloc and domain_free iommu/vt-d

Re: [PATCH 00/15] iommu: Move domain allocation into drivers

2015-03-23 Thread Joerg Roedel
Hi Yingjoe, On Fri, Mar 20, 2015 at 05:24:18PM +0800, Yingjoe Chen wrote: > What's the status of this patchset? > While porting MTK IOMMU driver[1], we need to use a global variable > because we need to do dma_alloc_coherent in our domain_init. I think we > can remove that global variable if we ba

Re: [PATCH v5 00/18] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-02-04 Thread Joerg Roedel
Hi Marek, On Fri, Jan 23, 2015 at 04:51:10PM +0100, Marek Szyprowski wrote: > 1. All iommu related patches (with 'iommu: exynos') can be merged to > iommu tree. They don't have any direct dependencies on the DTS, DRM and > power domain initialization change - without them the driver will simply >

Re: [PATCH 02/15] iommu: Introduce iommu domain types

2015-01-30 Thread Joerg Roedel
Hi Will, On Wed, Jan 28, 2015 at 02:19:34PM +, Will Deacon wrote: > > +/* This are the possible domain-types */ > > +enum iommu_domain_type { > > + IOMMU_DOMAIN_DMA, /* Domain used for DMA-API */ > > + IOMMU_DOMAIN_IDENTITY, /* Identity mapped domain */ > > What happens if somebod

[PATCH 05/15] iommu/omap: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement the new domain_alloc and domain_free call-backs and remove the old domain_init/destroy ones. Signed-off-by: Joerg Roedel --- drivers/iommu/omap-iommu.c | 49 +++--- 1 file changed, 29 insertions(+), 20 deletions(-) diff

[PATCH 01/15] iommu: Introduce domain_alloc and domain_free iommu_ops

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel These new call-backs defer the allocation and destruction of 'struct iommu_domain' to the iommu driver. This allows drivers to embed this struct into their private domain structures and to get rid of the domain_init and domain_destroy call-backs when all drivers

[PATCH 09/15] iommu/tegra-gart: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/tegra-gart.c | 67 +++--- 1 file changed, 46 insertions(+), 21 deletions(-) diff --git a

[PATCH 04/15] iommu/vt-d: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Get rid of domain_init and domain_destroy and implement domain_alloc/domain_free instead. Signed-off-by: Joerg Roedel --- drivers/iommu/intel-iommu.c | 48 ++--- 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/drivers

[PATCH 10/15] iommu/msm: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/msm_iommu.c | 73 +++ 1 file changed, 36 insertions(+), 37 deletions(-) diff --git a

[PATCH 07/15] iommu/exynos: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/exynos-iommu.c | 87 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a

[PATCH 06/15] iommu/arm-smmu: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/arm-smmu.c | 46 +++--- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a

[PATCH 08/15] iommu/tegra-smmu: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/tegra-smmu.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a

[PATCH 11/15] iommu/shmobile: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/shmobile-iommu.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a

[PATCH 12/15] iommu/ipmmu-vmsa: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/ipmmu-vmsa.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a

[PATCH 14/15] iommu/fsl: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/fsl_pamu_domain.c | 60 ++--- drivers/iommu/fsl_pamu_domain.h | 2 +- 2 files changed, 33

[PATCH 15/15] iommu: Remove domain_init and domain_free iommu_ops

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel All drivers have been converted to the new domain_alloc and domain_free iommu-ops. So remove the old ones and get rid of iommu_domain->priv too, as this is no longer needed when the struct iommu_domain is embedded in the private structures of the iommu drivers. Signed-off

[PATCH 13/15] iommu/rockchip: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel --- drivers/iommu/rockchip-iommu.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a

[PATCH 03/15] iommu/amd: Make use of domain_alloc and domain_free

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Implement the new iommu-ops function pointers and remove the obsolete domain_init and domain_destroy functions. Signed-off-by: Joerg Roedel --- drivers/iommu/amd_iommu.c | 84 ++--- drivers/iommu/amd_iommu_types.h | 7 ++-- 2 files

[PATCH 02/15] iommu: Introduce iommu domain types

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel This allows to handle domains differently based on their type in the future. An IOMMU driver can implement certain optimizations for DMA-API domains for example. Signed-off-by: Joerg Roedel --- drivers/iommu/iommu.c | 5 +++-- include/linux/iommu.h | 11 ++- 2

[PATCH 00/15] iommu: Move domain allocation into drivers

2015-01-26 Thread Joerg Roedel
From: Joerg Roedel Hi, here is patch-set to replace the existing domain_init and domain_destroy iommu-ops with the new domain_alloc and domain_free callbacks The new callbacks move the allocation of iommu domains into the iommu driver, allowing them to put a generic iommu_domain struct into

Re: [PATCH v5 11/18] iommu: exynos: remove useless device_add/remove callbacks

2015-01-26 Thread Joerg Roedel
Hi Laurent, On Mon, Jan 26, 2015 at 03:03:57PM +0200, Laurent Pinchart wrote: > On Monday 26 January 2015 12:00:59 Joerg Roedel wrote: > > My plan is to make IOMMU groups mandatory. I am currently preparing and > > RFC patch-set to introduce default-domains (which will be per grou

Re: [PATCH v5 11/18] iommu: exynos: remove useless device_add/remove callbacks

2015-01-26 Thread Joerg Roedel
Hi Laurent, On Sun, Jan 25, 2015 at 05:38:22PM +0200, Laurent Pinchart wrote: > IOMMU groups still seem a bit unclear to me. Will Deacon has nicely explained > what they represent in > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/310816.html. > The IOMMU core doesn't make g

Re: [PATCH] iommu: Fix build of allmod/allyes config on ARMv8 architecture

2015-01-05 Thread Joerg Roedel
On Mon, Jan 05, 2015 at 12:09:03PM +0100, Krzysztof Kozlowski wrote: > Thanks, but... Few days after my patch Mark Brown posted something > similar: > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/310743.html > > It was merged by Arnd Bergman and sent to Linus around 3.19-rc1

Re: [PATCH] iommu: Fix build of allmod/allyes config on ARMv8 architecture

2015-01-05 Thread Joerg Roedel
On Fri, Dec 05, 2014 at 02:47:37PM +0100, Krzysztof Kozlowski wrote: > drivers/iommu/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to iommu/fixes, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord.

Re: [PATCH 04/29] drivers: base: add notifier for failed driver bind

2014-08-25 Thread Joerg Roedel
On Tue, Aug 05, 2014 at 12:47:32PM +0200, Marek Szyprowski wrote: > + if (failed && dev->bus) > + blocking_notifier_call_chain(&dev->bus->p->bus_notifier, > + BUS_NOTIFY_DRVBIND_FAILED, dev); > + Why can't you just use the notifier for BUS_N

Re: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2014-08-18 Thread Joerg Roedel
On Tue, Aug 05, 2014 at 12:47:28PM +0200, Marek Szyprowski wrote: > .../devicetree/bindings/iommu/samsung,sysmmu.txt | 93 ++- > Documentation/power/notifiers.txt | 14 + > arch/arm/boot/dts/exynos4.dtsi | 118 > arch/arm/boot/dts/exynos4210.dtsi

Re: [PATCH] documentation/iommu: Add note on existing DT binding status

2014-05-14 Thread Joerg Roedel
On Wed, May 14, 2014 at 11:23:33AM +0530, Shaik Ameer Basha wrote: > .../devicetree/bindings/iommu/samsung,sysmmu.txt |5 + > 1 file changed, 5 insertions(+) Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to ma

Re: [PATCH v13 00/19] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-05-13 Thread Joerg Roedel
On Mon, May 12, 2014 at 11:44:45AM +0530, Shaik Ameer Basha wrote: > Cho KyongHo (18): > iommu/exynos: fix build errors > iommu/exynos: change error handling when page table update is failed > iommu/exynos: allocate lv2 page table from own slab > iommu/exynos: fix L2TLB invalidation > iom

Re: [PATCH v12 00/31] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-05-06 Thread Joerg Roedel
On Wed, Apr 30, 2014 at 04:27:10PM +0530, Shaik Ameer Basha wrote: > This series is going on for quite a long time and most of the patches here > doesn't depend on dt bindings. As Exynos IOMMU h/w is introducing new versions > very frequently, maintaining and reviewing all these patches again and >

Re: [PATCH v10 00/20] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-11-01 Thread Joerg Roedel
Hi Cho, On Fri, Nov 01, 2013 at 09:37:45PM +0900, Cho KyongHo wrote: > I am preparing next patches to apply Alex Williamson's comment that > description of IOMMU's masters must be aligned with ARM SMMU. > > It is delayed due to my jobs in the office. > > I will post the next patche series in two

Re: [PATCH v10 00/20] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-11-01 Thread Joerg Roedel
On Mon, Oct 07, 2013 at 10:52:12AM +0900, Cho KyongHo wrote: > Patch summary: > [PATCH 01/20] iommu/exynos: do not include removed header > [PATCH 02/20] iommu/exynos: add missing cache flush for removed page table > entries > [PATCH 03/20] iommu/exynos: change error handling when page table updat

Re: [PATCH 2/2] iommu/exynos: Follow kernel coding style for __sysmmu_enable return type

2013-08-14 Thread 'Joerg Roedel'
KyongHo, On Fri, Jul 26, 2013 at 07:46:01PM +0900, Cho KyongHo wrote: > __sysmmu_enable() must return 1 if it is called with the same page table. > I have fixed it exynos_iommu_attach_device() to always return zero on success > in the next patchset which I will post today. > > Thank you. When yo

Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab

2013-08-14 Thread 'Joerg Roedel'
On Fri, Aug 09, 2013 at 09:55:30AM +0200, Tomasz Figa wrote: > Oh, this is a valid point, but it was more a nitpick about the coding > style. Single path error handling (with goto) is widely used in the kernel > in cases when more than one thing has to be undone and so I suggested this > method

Re: [PATCH v9 03/16] iommu/exynos: fix page table maintenance

2013-08-14 Thread Joerg Roedel
On Thu, Aug 08, 2013 at 11:28:44AM -0700, Grant Grundler wrote: > I can't speak to the previous BUG_ON(). I believe the EADDRESSINUSE > failures could be either WARN_ON or BUG_ON. This condition is > clearly a bug in the generic IOMMU allocator and I think that's why > KyongHo Cho used BUG_ON. >

Re: [PATCH v6 05/12] iommu/exynos: support for device tree

2013-02-01 Thread Joerg Roedel
Cho, On Wed, Jan 02, 2013 at 02:53:49PM +0900, KyongHo Cho wrote: > On Tuesday, January 1, 2013, Sylwester Nawrocki > > Cc: devicetree-disc...@lists.ozlabs.org Since patch 7 of this set is already merged, do you mind to re-post the rest of this patch-set with the latest comments addressed? I ca

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-11 Thread 'Joerg Roedel'
Hi Kukjin, On Thu, Jan 10, 2013 at 11:33:41AM -0800, Kukjin Kim wrote: > Sure, keep going on with > > Acked-by: Kukjin Kim Done that. Applied the patch, some manual work was necessary as the patch didn't apply cleanly to v3.8-rc3. Please double-check if the result is correct. > OK, good. Let m

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread 'Joerg Roedel'
On Thu, Jan 10, 2013 at 10:34:48AM -0800, Kukjin Kim wrote: > Hmm, I think, just one [7/12] patch does matter so if you could create topic > branch and apply [7/12] patch firstly before other drivers/ changes would be > better to me. It's OK on both trees if I just _merge_ the first [7/12] > commit

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread 'Joerg Roedel'
On Thu, Jan 10, 2013 at 10:06:24AM -0800, Kukjin Kim wrote: > You know, we have several options to avoid it. When you take this series in > your tree, you can provide topic branch for me. Or this series should be > separated for arch/arm/ and drivers/ for both trees, then only drivers/iommu > chang

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread 'Joerg Roedel'
On Mon, Dec 31, 2012 at 10:18:46AM -0800, Kukjin Kim wrote: > Cho KyongHo wrote: > > Diffstats: > > arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +- > > arch/arm/boot/dts/exynos5250.dtsi | 27 +- > > arch/arm/mach-exynos/Kconfig |5 - > > arch/arm/mach-exynos/Mak

Re: [PATCH 4/4] iommu/exynos: enhancements of System MMU driver with DT

2012-11-17 Thread 'Joerg Roedel'
On Wed, Nov 14, 2012 at 05:51:12PM +0900, Cho KyongHo wrote: > This commit enhances power management of System MMU and its client > devices with the following changes: > - Each System MMU device becomes the parent device of its client >device while probe(). Thus, exynos-iommu driver must be in

Re: [PATCH] iommu/exynos: Add iommu driver for Exynos Platforms

2012-05-11 Thread Joerg Roedel
t_sysmmu() is defined in > > To compile this patch, > you will need "for-next" branch of the linux-samsung.git: > git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > Other patches needed by this patch are merged to the above branch. > > Cc: Joerg Roe

Re: [PATCH v12 2/3] ARM: EXYNOS: Change System MMU platform device definitions

2012-03-18 Thread Joerg Roedel
On Fri, Mar 16, 2012 at 01:47:50PM -0700, Kukjin Kim wrote: > Anyway Joerg, how do you want to handle this? Do you want to pick up > 1/2/3 all of them in your tree? If so, 2nd patch should be on top of > some samsung topic stuff. Since patch 2 only applies to the Samsung tree, it is best to ca

Re: [PATCH v12 2/3] ARM: EXYNOS: Change System MMU platform device definitions

2012-03-15 Thread Joerg Roedel
On Thu, Mar 15, 2012 at 05:32:39PM +0900, Cho KyongHo wrote: > Handling System MMUs with an identifier is not flexible to manage > System MMU platform devices because of the following reasons: > 1. A device driver which needs to handle System MMU must know the ID. > 2. A System MMU may not present

Re: [PATCH v11 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

2012-03-13 Thread Joerg Roedel
On Tue, Mar 13, 2012 at 05:50:16PM +0900, KyongHo Cho wrote: > >> +struct sysmmu_drvdata { > >> +     struct device *sysmmu; > >> +     char *dbgname; > >> +     int nsfrs; > >> +     void __iomem **sfrbases; > >> +     struct clk *clk[2]; > >> +     int activations; > >> +     rwlock_t lock; > >>

Re: [PATCH v11 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

2012-03-12 Thread Joerg Roedel
On Fri, Mar 09, 2012 at 09:15:24PM +0900, Cho KyongHo wrote: > +/* We does not consider super section mapping (16MB) */ > +struct iommu_client { > + struct list_head node; > + struct device *dev; > +}; > + > +struct exynos_iommu_domain { > + struct list_head clients; /* list of iommu_cl

Re: [PATCH v8 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2012-01-25 Thread Joerg Roedel
On Wed, Jan 25, 2012 at 03:51:58PM +0900, KyongHo Cho wrote: > > This isn't really a problem. We allow destroying a domain with devices > > attached. So this WARN_ON is not necessary. > > > BTW, Isn't it a problem when a device driver does not know that its > iommu domain is destroyed? > Can we reg

Re: [PATCH v8 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2012-01-23 Thread 'Joerg Roedel'
Hi, please also get and inclue Acks from the Exynos maintainer for the next post. Since I have a compiling config for exynos now I will merge the patches when you have the Acks and addressed or explained the issues I pointed out below. On Thu, Dec 29, 2011 at 09:26:08PM +0900, KyongHo Cho wrote:

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-05 Thread Joerg Roedel
On Wed, Jan 04, 2012 at 09:26:20PM +, Russell King - ARM Linux wrote: > On Wed, Jan 04, 2012 at 04:01:01PM +0100, Joerg Roedel wrote: > > On Tue, Jan 03, 2012 at 09:55:27AM +, Russell King - ARM Linux wrote: > > > It comes through when I stick it in my tree because of

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-04 Thread Joerg Roedel
On Tue, Jan 03, 2012 at 09:55:27AM +, Russell King - ARM Linux wrote: > On Mon, Jan 02, 2012 at 04:58:20PM +0100, Joerg Roedel wrote: > > On Tue, Jan 03, 2012 at 12:21:30AM +0900, KyongHo Cho wrote: > > > > I still get > > > > > > > >  LD      .tmp_

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-03 Thread 'Joerg Roedel'
Hi Marek, On Tue, Jan 03, 2012 at 10:37:29AM +0100, Marek Szyprowski wrote: > Yes, there is something a bit wrong with your kernel configuration. You get > this error if > there is no board selected to be compiled-in. Please go to kernel > configuration and select > "System Type -> SAMSUNG EXYN

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-02 Thread Joerg Roedel
On Tue, Jan 03, 2012 at 12:21:30AM +0900, KyongHo Cho wrote: > Ok. I will check my configuration with linux-next git. Btw, after working around the #error problem and fixing another compile-error the same problem still appears with linux-next. Joerg -- AMD Operating System Research Ce

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-02 Thread Joerg Roedel
On Tue, Jan 03, 2012 at 12:21:30AM +0900, KyongHo Cho wrote: > > I still get > > > >  LD      .tmp_vmlinux1 > > /data/cross/gcc-4.6.0-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-ld: > > no machine record defined > > /data/cross/gcc-4.6.0-nolibc/arm-unknown-linux-gnueabi/bin/arm-

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-02 Thread Joerg Roedel
Hi, On Thu, Dec 29, 2011 at 09:24:18PM +0900, KyongHo Cho wrote: > Changes since v7: > - Rebased with the recent commits of the following git branches > * git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/next > * git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git/for-next >

Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-12-18 Thread 'Joerg Roedel'
On Mon, Dec 19, 2011 at 01:04:18AM +0900, Kukjin Kim wrote: > Hmm, I cannot find the iommu/exynos branch what you said in your iommu > tree yet. Maybe you missed or any problem? Problems. I tried to apply the patches and there were conflicts. After solving them I wasn't able to find a kernel-con

Re: [PATCH] iommu: Initialize domain->handler in iommu_domain_alloc()

2011-12-16 Thread 'Joerg Roedel'
On Fri, Dec 16, 2011 at 09:38:25PM +0900, KyongHo Cho wrote: > Subject: [PATCH] iommu: Initialize domain->handler in iommu_domain_alloc() > > Since it is not guaranteed that an iommu driver initializes in its > domain_init() function, it must be initialized with NULL to prevent > calling a functio

Re: [PATCH] iommu: Initialize domain->handler in iommu_domain_alloc()

2011-12-15 Thread Joerg Roedel
On Tue, Dec 13, 2011 at 04:14:26PM +0900, KyongHo Cho wrote: > Since it is not guaranteed that an iommu driver initializes in its > domain_init() function, it must be initialized with NULL to prevent > calling a function in an arbitrary location when iommu fault occurred. > > Signed-off-by: KyongH

Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-12-06 Thread Joerg Roedel
On Mon, Dec 05, 2011 at 04:47:15PM +0100, Joerg Roedel wrote: > Okay, I merged it into arm/exynos, but it is not pushed yet. Actually > there were conflicts while merging, which I resolved. What I failed > to find is a config for Exynos that actually builds for upstream Linux. > Proba

Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-12-06 Thread Joerg Roedel
On Tue, Dec 06, 2011 at 09:13:18PM +0900, KyongHo Cho wrote: > > BTW, how do you test it at mainline kernel? > > > I merged IOMMU mainline branch to our kernel branch and tested it with > our FIMC, MFC, JPEG, 2D. This is not sufficient. Please do it the other way around, merge your outstanding cha

Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-12-05 Thread Joerg Roedel
On Fri, Nov 18, 2011 at 06:47:28PM +0900, KyongHo Cho wrote: > Patch Summary: > [PATCH v7 1/2] ARM: EXYNOS: Change System MMU platform device definitions > [PATCH v7 2/2] iommu/exynos: Add iommu driver for Exynos Platforms Okay, I merged it into arm/exynos, but it is not pushed yet. Actually there

Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-12-02 Thread 'Joerg Roedel'
On Fri, Dec 02, 2011 at 05:43:21PM +0900, Kukjin Kim wrote: > OK, I will merge iommu/exynos into Samsung tree after your creating that. > > I can't look at iommu/exynos branch in your tree, > git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git. That's because I havn't merged any exynos p

Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-12-01 Thread 'Joerg Roedel'
On Thu, Dec 01, 2011 at 04:29:17PM +0900, Kukjin Kim wrote: > Anyway, that touches many Samsung stuff so it would be better if you could > create separate topic branch which can be merged into Samsung tree. And if > required, please add my ack on them. Yes, I use topic-branches a lot :) This will

Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-11-23 Thread Joerg Roedel
On Fri, Nov 18, 2011 at 06:47:28PM +0900, KyongHo Cho wrote: > Changes since v6: > - Totally rewrite exynos_iommu_map() and exynos_iommu_unmap() according > to the change in iommu_map() and iommu_unmap(). > - Change special slab for Lv2 page table to kmalloc(). Okay, the driver looks good to me

Re: [PATCH v2 5/5] iommu/exynos: Use bus_set_iommu instead of register_iommu

2011-10-07 Thread Joerg Roedel
ith bus_set_iommu() according to the > >> suggestion of Joerg Roedel. > > > > This should be part of patch 3 already when the bus_set_iommu() change > > is merged. Otherwise it breaks bisectability too. > > > Ok. > Should I include fault handling feature (patch 4) in the