Re: [PATCH v3 2/3] drm/exynos: add support for exynos5420 mixer

Hello Rahul, This patch is exactly same with v2 2/4 and only rebased on v3 1/3, so my ack is valid for this patch. On 2013년 06월 19일 21:51, Rahul Sharma wrote: > Add support for exynos5420 mixer IP in the drm mixer driver. > > Signed-off-by: Rahul Sharma Acked-by: Seung-Woo Kim Anyway, this p

Re: [PATCH v2 2/4] drm/exynos: add support for exynos5420 mixer

On 2013년 06월 19일 15:50, Rahul Sharma wrote: > Add support for exynos5420 mixer IP in the drm mixer driver. > > Signed-off-by: Rahul Sharma Acked-by: Seung-Woo Kim This patch can be merged after merging "[PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem". Best Regards, - Seu

Re: [PATCH 1/4] drm/exynos: rename compatible strings for hdmi subsystem

Hi Rahul, It looks good, at least, to me. Best Regards, - Seung-Woo Kim On 2013년 06월 18일 21:49, Rahul Sharma wrote: > This patch renames the combatible strings for hdmi, mixer, ddc > and hdmiphy. It follows the convention of using compatible string > which represent the SoC in which the IP was a

Re: [PATCH 3/4] drm/exynos: fix interlace resolutions for exynos5420

Hi Rahul, This patch looks good to me. On 2013년 06월 18일 21:49, Rahul Sharma wrote: > Modified code for calculating hdmi IP register values from drm timing > values. The modification is based on the inputs from hw team and specifically > proposed for 1440x576i and 1440x480i. But same changes holds

Re: [PATCH 2/4] drm/exynos: add support for exynos5420 mixer

Hi Rahul, Code part looks good to me but IMHO, binding document for exynos_mixer is also fixed like following because compitable string samsung,exynos5420-mixer is added with this patch. Required properties: - compatible: value should be: 1) "samsung,exynos4210-mixer" 2) "samsun

Re: [PATCH 7/9] drm/exynos: use of_get_named_gpio to get hdmi hpd gpio

Hello Rahul, this patch is not related with others and it looks good to me. On 2013년 06월 11일 23:11, Rahul Sharma wrote: > Cleanup by removing flags variable from drm_hdmi_dt_parse_pdata > which is not used anywhere. Swtiching to of_get_named_gpio instead > of of_get_named_gpio_flags solved this.

Re: [PATCH 5/9] drm/exynos: add support for exynos5420 mixer

Hello Rahul, This patch looks good to me just with mixer part of 2nd patch because there is no hdmiphy related things. On 2013년 06월 11일 23:11, Rahul Sharma wrote: > Add support for exynos5420 mixer IP in the drm mixer driver. > > Signed-off-by: Rahul Sharma > --- > drivers/gpu/drm/exynos/exyno

Re: [PATCH 1/9] drm/exynos: use SoC name to identify hdmi version

Hello Rahul, On 2013년 06월 11일 23:11, Rahul Sharma wrote: > Exynos hdmi IP version is named after hdmi specification version i.e. > 1.3 and 1.4. This versioning mechanism is not sufficient to handle > the diversity in the hdmi/phy IPs which are present across the exynos > SoC family. > > This patc

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

Hello Kishon, On 2013년 06월 13일 21:54, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 13 June 2013 04:51 PM, Inki Dae wrote: >> >> >>> -Original Message- >>> From: Sylwester Nawrocki [mailto:s.nawro...@samsung.com] >>> Sent: Thursday, June 13, 2013 5:56 PM >>> To: Rahul Sharma >>> Cc:

Re: [PATCH v4] drm/exynos: hdmi: use drm_display_mode to check the supported modes

Hello Rahul, I looks good to me. On 2013년 04월 29일 20:14, Rahul Sharma wrote: > Exynos hdmi driver is using drm_display_mode for setting timing values > for a supported resolution. Conversion to fb_videomode and then comparing > with the mixer/hdmi/phy limits is not required. Instead, drm_display_

Re: [PATCH v2] drm/exynos: hdmi: use drm_display_mode to check the supported modes

Hello Rahul, I agree with basic idea of this patch. However, to avoid confusion, how do you think about fixing all check_timing as check_mode and its second parameter as mode including struct exynos_drm_display_ops? Regards, - Seung-Woo Kim On 2013년 04월 26일 23:03, Rahul Sharma wrote: > Exynos h

Re: [PATCH RFC] drm/exynos: hdmi: move hdmiphy related code to hdmiphy driver

On 2013년 03월 07일 15:45, Rahul Sharma wrote: > Thanks Seung Woo, Mr. Dae, > > On Thu, Mar 7, 2013 at 10:13 AM, Inki Dae wrote: >> 2013/3/7 김승우 : >>> >>> >>> On 2013년 03월 04일 23:05, Rahul Sharma wrote: >>>> Thanks Sean, >>>> &g

Re: [PATCH RFC] drm/exynos: hdmi: move hdmiphy related code to hdmiphy driver

On 2013년 03월 04일 23:05, Rahul Sharma wrote: > Thanks Sean, > > On Wed, Feb 27, 2013 at 9:47 PM, Sean Paul wrote: >> On Wed, Feb 27, 2013 at 8:22 AM, Rahul Sharma >> wrote: >>> Right now hdmiphy operations and configs are kept inside hdmi driver. >>> hdmiphy related >>> code is tightly couple

Re: [PATCH v3 1/3] drm/exynos: Get HDMI version from device tree

On 2013년 02월 06일 09:56, Sean Paul wrote: > On Tue, Feb 5, 2013 at 4:42 PM, Stephen Warren wrote: >> On 02/05/2013 05:37 PM, Sean Paul wrote: >>> On Tue, Feb 5, 2013 at 4:22 PM, Stephen Warren >>> wrote: n 02/05/2013 04:42 PM, Sean Paul wrote: > Use the compatible string in the device

Re: [PATCH v5] ARM: EXYNOS: Add MFC device tree support

Hi Arun, On 2012년 09월 28일 02:09, Arun Kumar K wrote: > This patch adds device tree entry for MFC v6 in the Exynos5 > SoC. Makes the required changes in the clock files and adds > MFC to the DT device list. > > Signed-off-by: Naveen Krishna Chatradhi > Signed-off-by: Arun Kumar K > --- > .../de