Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-11 Thread Ben Hutchings
reg = ADVERTISE_ALL | ADVERTISE_CSMA; > + asix_mdio_write(dev->net, dev->mii.phy_id, MII_ADVERTISE, reg); [...] Why is there no sleep after setting the RESET bit? Doesn't that make the following register writes unreliable? Ben. -- Ben Hutchings Experience is directly proportional to the value of equipment destroyed. - Carolyn Scheppner signature.asc Description: This is a digitally signed message part

Re: [PATCH v2 2/2] s5p-mfc: Adding MFC v7 and v8 firmwares

2014-06-15 Thread Ben Hutchings
On Thu, 2014-06-05 at 09:54 +0530, Arun Kumar K wrote: > Hi Ben, > > On Wed, Jun 4, 2014 at 5:43 PM, Ben Hutchings wrote: > > On Wed, 2014-06-04 at 13:08 +0200, Kamil Debski wrote: > >> Hi Arun, Ben, > >> > >> > >> > From: arunkk.

Re: [PATCH v2 2/2] s5p-mfc: Adding MFC v7 and v8 firmwares

2014-06-04 Thread Ben Hutchings
On Wed, 2014-06-04 at 13:08 +0200, Kamil Debski wrote: > Hi Arun, Ben, > > > > From: arunkk.sams...@gmail.com [mailto:arunkk.sams...@gmail.com] On > > Behalf Of Arun Kumar K > > Sent: Wednesday, June 04, 2014 7:32 AM > > > > Hi Ben, > > >

Re: [PATCH v2 2/2] s5p-mfc: Adding MFC v7 and v8 firmwares

2014-06-03 Thread Ben Hutchings
On Tue, 2014-06-03 at 20:34 +0100, Ben Hutchings wrote: > On Wed, 2014-05-21 at 18:11 +0530, Arun Kumar K wrote: > > Adding the following firmware files for MFC > > s5p-mfc-v7.fw: Used in exynos 5420 > > s5p-mfc-v8.fw: Used in exynos 5800 > > > > Signed-off-by:

Re: [PATCH v2 2/2] s5p-mfc: Adding MFC v7 and v8 firmwares

2014-06-03 Thread Ben Hutchings
|2 ++ > s5p-mfc/s5p-mfc-v7.fw | Bin 0 -> 382724 bytes > s5p-mfc/s5p-mfc-v8.fw | Bin 0 -> 360576 bytes > 3 files changed, 2 insertions(+) > create mode 100644 s5p-mfc/s5p-mfc-v7.fw > create mode 100644 s5p-mfc/s5p-mfc-v8.fw [...] Applied, thanks. Ben. -- Ben H

Re: [PATCH v2 1/2] s5p-mfc: Add s5p-mfc-v6-v2 firmware

2014-06-03 Thread Ben Hutchings
v1 > - Made into a new file instead of upgrading old v6 firmware > --- > WHENCE |7 --- > s5p-mfc/s5p-mfc-v6-v2.fw | Bin 0 -> 343756 bytes > 2 files changed, 4 insertions(+), 3 deletions(-) > create mode 100644 s5p-mfc/s5p-mfc-v6-v2.fw [...] A

Re: [PATCH 1/2] s5p-mfc: Update mfc-v6 firmware

2014-05-19 Thread Ben Hutchings
sers will usually install everything from linux-firmware without checking things like that. If the new driver can work with the old firmware, that's a bonus, but less important. Ben. -- Ben Hutchings It is easier to change the specification to fit the program than vice versa. signature.asc Description: This is a digitally signed message part

Re: [PATCH V12 6/7] net: sxgbe: add ethtool related functions support

2014-03-27 Thread Ben Hutchings
less I'm missing something, this only accepts the default values, > so > > it's not actually possible to change the configuration. Why are you > > implementing this operation at all? > It is possible to change the configuration. There is a register write > to the >

Re: [PATCH V12 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-24 Thread Ben Hutchings
not actually possible to change the configuration. Why are you implementing this operation at all? [...] > +static void sxgbe_get_regs(struct net_device *dev, > +struct ethtool_regs *regs, void *space) > +{ > + struct sxgbe_priv_data *priv = netdev_priv(dev); >

Re: [PATCH 0/7] add new Samsung xgmac driver

2014-03-09 Thread Ben Hutchings
On Wed, 2014-03-05 at 20:28 +0900, Byungho An wrote: > Hi all, > > This series adds Samsung xgmac driver. [...] Calxeda already took that driver name. Be more original. Ben. -- Ben Hutchings I say we take off; nuke the site from orbit. It's the only way to be sure.

Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks

2013-09-19 Thread Ben Hutchings
f. I would suggest: "The coherent mask can always be set to the same or a smaller mask than the streaming mask." Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare pr