On 12/21/2011 08:46 AM, Kukjin Kim wrote:
> Denis Kuzmenko wrote:
>>
>> Make s3c24xx LEDS driver use gpiolib. Fix error disabling pull during
>> probe.
>>
>> Signed-off-by: Denis Kuzmenko
>
> Acked-by: Kukjin Kim
>
> Richard, I think, this
Hi Kukjin,
Your patch applies (note that it looks like your email-client have
wrapped long lines thus broke the path) and works OK. Looks good to me.
See some additional comments below.
On 12/28/2011 09:59 AM, Kukjin Kim wrote:
> Denis Kuzmenko wrote:
(snip)
>> +depends on CPU_FRE
On 12/22/2011 12:04 AM, Kukjin Kim wrote:
> Denis Kuzmenko wrote:
>>
>> On 12/21/2011 09:04 AM, Kukjin Kim wrote:
>>> Denis Kuzmenko wrote:
>>>>
>>>> Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.
>>>>
>>>
On 12/21/2011 09:04 AM, Kukjin Kim wrote:
> Denis Kuzmenko wrote:
>>
>> Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.
>>
>> Signed-off-by: Denis Kuzmenko
>> ---
>>
>> Patch is against 3.2-rc4.
>> CONFIG_S3C2410_IOTIMING
or saving
that platform from being removed.
--
Best regards, Denis Kuzmenko.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Make s3c24xx LEDS driver use gpiolib. Fix error disabling pull during probe.
Signed-off-by: Denis Kuzmenko
---
There is a comment "no point in having a pull-up if we are always driving"
but code was actually enabled pull-resistor for that case probably because of
function
On 12/13/2011 11:40 PM, Joe Perches wrote:
> On Tue, 2011-12-13 at 23:33 +0200, Denis Kuzmenko wrote:
>> On 12/13/2011 11:28 PM, Joe Perches wrote:
>>> The LEDF_ACTLOW use is dependent on it being #defined
>>> to 1 when using ^. I think that's unintelligible.
>
On 12/13/2011 11:28 PM, Joe Perches wrote:
> On Tue, 2011-12-13 at 23:21 +0200, Denis Kuzmenko wrote:
>> Hi Joe,
>> Thank you for review.
>>
>> On 12/13/2011 11:06 PM, Joe Perches wrote:
>>> On Tue, 2011-12-13 at 22:22 +0200, Denis Kuzmenko wrote:
>>&g
Hi Joe,
Thank you for review.
On 12/13/2011 11:06 PM, Joe Perches wrote:
> On Tue, 2011-12-13 at 22:22 +0200, Denis Kuzmenko wrote:
>> Make s3c24xx LEDS driver use gpiolib. Fix error disabling pull during probe.
> []
>> diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/l
Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.
Signed-off-by: Denis Kuzmenko
---
Patch is against 3.2-rc4.
CONFIG_S3C2410_IOTIMING is not selected for MACH_MINI2440. Because of this the
file s3c2410-iotiming.c is not ever compiled and enabling
Make s3c24xx LEDS driver use gpiolib. Fix error disabling pull during probe.
Signed-off-by: Denis Kuzmenko
Acked-by: Stephen Warren
---
There is a comment "no point in having a pull-up if we are always driving"
but code was actually enabled pull-resistor for that case probably
Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.
Signed-off-by: Denis Kuzmenko
---
Patch is against 3.2-rc4.
CONFIG_S3C2410_IOTIMING is not selected for MACH_MINI2440. Because of this the
file s3c2410-iotiming.c is not ever compiled and enabling
On 12/06/2011 01:31 PM, Kukjin Kim wrote:
> Denis Kuzmenko wrote:
>>
>> Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.
>>
>> Signed-off-by: Denis Kuzmenko
>> ---
>>
>> Patch is against 3.2-rc3.
>> CONFIG_S3C2410_IOTIM
Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.
Signed-off-by: Denis Kuzmenko
---
Patch is against 3.2-rc3.
CONFIG_S3C2410_IOTIMING wasn't present in Kconfig but was referenced by
Makefile. Because of this the file s3c2410-iotiming.c was not ever compiled
and ena
Add new LCD (W35i) support for Mini2440 board
Signed-off-by: Denis Kuzmenko
---
diff --git a/arch/arm/mach-s3c2440/mach-mini2440.c
b/arch/arm/mach-s3c2440/mach-mini2440.c
index fc2dc0b..951eadd 100644
--- a/arch/arm/mach-s3c2440/mach-mini2440.c
+++ b/arch/arm/mach-s3c2440/mach-mini2440.c
Add new LCD (W35i) support for Mini2440 board
Signed-off-by: Denis Kuzmenko
---
I need to refer this patch but can't find it on lkml.org
Maybe I haven't send it...
Sorry for bothering if I did so.
diff --git a/arch/arm/mach-s3c2440/mach-mini2440.c
b/arch/arm/mach-s3c2440/mach-mini24
Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.
Signed-off-by: Denis Kuzmenko
---
Patch is against 3.2-rc3.
CONFIG_S3C2410_IOTIMING wasn't present in Kconfig but was referenced by
Makefile. Because of this the file s3c2410-iotiming.c was not ever compiled
and ena
17 matches
Mail list logo