Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Doug Anderson
Hi, On Thu, Oct 22, 2015 at 9:07 AM, Javier Martinez Canillas wrote: >> Note that personally I would only choose the "highest" priority as an >> absolute last resort. Leaving a little extra slack in there means >> that when the next person comes up with a really good reason to run >> before you

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Doug Anderson
Krzysztof, On Wed, Oct 21, 2015 at 6:43 PM, Krzysztof Kozlowski wrote: > I think at least one platform may be affected because it used > mmc-pwrseq-emmc and gpio-restart. > > Look at rk3288-veyron.dtsi. > > Both of restart handlers had the priority of 129 which means that the > order of execution

Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support

2015-10-19 Thread Doug Anderson
Hi, On Mon, Oct 19, 2015 at 3:11 AM, Anand Moon wrote: > 1 Drop the cd-gpios changes. pinctrl-0 changes. Right. > 2 Fix the regulator changes for vmmc/vqmmc with disable of > regulator-always-on; I'm not totally sure I understand. You should need to keep vmmc and vqmmc always on because oth

Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support

2015-10-14 Thread Doug Anderson
Hi, On Tue, Oct 13, 2015 at 6:06 PM, Alim Akhtar wrote: > +Doug > Hello, > AFAIR, dw_mmc host controller does support UHS-I [1], specially SDR50 > and SDR104 modes. > > [1]: http://www.spinics.net/lists/linux-mmc/msg28186.html > > What I remember is, one need to set "broken-cd" property also in o

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

2015-09-30 Thread Doug Anderson
Hi, On Wed, Sep 30, 2015 at 4:44 PM, Krzysztof Kozlowski wrote: >> Switching the default meaning of "google,snow" to Rev5 is probably not >> something we'd ever want to do, since it could confuse "rev3" boards >> (which should be serviced by the rev4 dts). From comments in the >> Chrome OS tree:

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

2015-09-30 Thread Doug Anderson
Hi, On Tue, Sep 29, 2015 at 5:30 PM, Krzysztof Kozlowski wrote: > Now the exynos5250-snow.dts means in fact Rev4... but there is no > information in DTS about it. I think adding compatible > "google,snow-rev4" makes sense: > 1. For informational purposes (this could be also handled with a comment

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

2015-09-29 Thread Doug Anderson
Javier, On Tue, Sep 29, 2015 at 4:57 AM, Javier Martinez Canillas wrote: > There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped: > Rev4 and Rev5. The only difference between these 2 revisions is the codec, > Rev4 has a max98095 codec while Rev5 has a max98090. > > Mainline on

Re: [RFC PATCH v5 1/9] mmc: dw_mmc: Add external dma interface support

2015-08-16 Thread Doug Anderson
Heiko, On Fri, Aug 14, 2015 at 3:13 PM, Heiko Stübner wrote: > Hi Shawn, > > Am Freitag, 14. August 2015, 16:34:35 schrieb Shawn Lin: >> DesignWare MMC Controller can supports two types of DMA >> mode: external dma and internal dma. We get a RK312x platform >> integrated dw_mmc and ARM pl330 dma

Re: [RFC PATCH 0/3] clocksource: exynos_mct: allow mct to use 64-bit counter from coprocessor

2015-07-28 Thread Doug Anderson
Hi, On Tue, Jul 28, 2015 at 9:20 AM, Alexey Klimov wrote: > Hi Doug, > > On Tue, Jul 28, 2015 at 6:24 PM, Doug Anderson wrote: >> Alexey, >> >> On Mon, Jul 27, 2015 at 2:28 PM, Alexey Klimov >> wrote: >>> Hi all, >>> >>> year(s

Re: [RFC PATCH 0/3] clocksource: exynos_mct: allow mct to use 64-bit counter from coprocessor

2015-07-28 Thread Doug Anderson
Alexey, On Mon, Jul 27, 2015 at 2:28 PM, Alexey Klimov wrote: > Hi all, > > year(s) ago it was discovered that MCT timer and ARM architectured > timer > are the same hardware with different interface. Here [1]. > > I followed mail-list discussions about removing MCT and using arch > timer for Exy

Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend

2015-06-12 Thread Doug Anderson
Hi, On Fri, Jun 12, 2015 at 12:36 PM, Javier Martinez Canillas wrote: >>> registers are lost assuming the combiner was powered down, even the >>> status register will be lost and you will not know exactly the wakeup >>> reason right ? >>> >> >> Good question, I didn't find in the documentation I'

Re: [PATCH 1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards

2015-04-07 Thread Doug Anderson
z Canillas > --- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 + > arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 + > 2 files changed, 2 insertions(+) Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a

Re: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089

2015-02-19 Thread Doug Anderson
Andreas, On Thu, Feb 19, 2015 at 9:56 AM, Andreas Färber wrote: > Am 19.02.2015 um 18:44 schrieb Doug Anderson: >> On Thu, Feb 19, 2015 at 1:44 AM, Mark Brown wrote: >>> On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas Färber wrote: >>> >>>> static

Re: [PATCH 1/6] ASoC: max98088: Document DT bindings

2015-02-19 Thread Doug Anderson
Andreas, On Thu, Feb 19, 2015 at 6:13 AM, Andreas Färber wrote: >> I see that a master clock (mclk) is added in patch 6/6 but the >> max98088 codec driver does handle this clock. >> >> If the SoC XCLKOUT provides the master clock to the max98089 >> codec in Spring like is the case for the max9809

Re: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089

2015-02-19 Thread Doug Anderson
Mark, On Thu, Feb 19, 2015 at 1:44 AM, Mark Brown wrote: > On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas Färber wrote: > >> static const struct of_device_id snow_of_match[] = { >> + { .compatible = "google,snow-audio-max98089", }, >> { .compatible = "google,snow-audio-max98090", },

Re: [PATCH] mmc: dw_mmc: exynos: remove incorrect __exit_p()

2015-01-26 Thread Doug Anderson
t; 1 file changed, 1 insertion(+), 1 deletion(-) Nice catch, thanks! Reviewed-by: Doug Anderson Tested-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH v3 1/4] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2015-01-05 Thread Doug Anderson
Alim, On Sun, Jan 4, 2015 at 2:43 PM, Alim Akhtar wrote: >> You are breaking backward compatibility here. If your change is >> merged then all old boards will instantly break. Since the "dts" and >> code changes will likely be merged through different trees you'll end >> up with a bunch of brok

Re: [PATCH v3 1/4] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2015-01-02 Thread Doug Anderson
Alim, On Tue, Dec 30, 2014 at 10:43 PM, Alim Akhtar wrote: > From: Seungwon Jeon > > ciu_div may not be common value for all speed mode. > So, it needs to be attached to CLKSEL timing. The more time I've spent looking at all of this stuff the less I like the exynos bindings. Personally I'd pre

Re: [PATCH 1/3] ARM: dts: Add SPI flash node for Peach boards

2014-11-19 Thread Doug Anderson
Javier, On Wed, Nov 19, 2014 at 2:07 AM, Javier Martinez Canillas wrote: > Hello Doug, > > Thanks for your feedback. > > On 11/18/2014 06:50 PM, Doug Anderson wrote: >> This is common practice in the Chrome OS tree, but we've gotten >> pushback from upstream quest

Re: [PATCH 1/3] ARM: dts: Add SPI flash node for Peach boards

2014-11-18 Thread Doug Anderson
Javier, On Mon, Nov 17, 2014 at 9:43 AM, Javier Martinez Canillas wrote: > +&spi_1 { > + status = "okay"; > + samsung,spi-src-clk = <0>; > + num-cs = <1>; > + cs-gpios = <&gpa2 5 0>; > + > + spidev@0 { > + compatible = "spidev"; This is common practice

Re: [PATCH] clocksource: exynos_mct: fix exynos4_mct_write

2014-10-22 Thread Doug Anderson
variable in mct controller driver), so 1.5 years. The broken code has been running for a long time, but that doesn't mean that there isn't a subtle issue... In any case, it seems like we should take this fix, assuming someone has tested it well. Reviewed-by: Doug Anderson -- To unsubscr

Re: [PATCH v3 1/2] Revert "mfd: sec-core: Prepare regulators for suspend state to reduce power-consumption"

2014-10-20 Thread Doug Anderson
ithin a device driver. > > It is better to call the regulator suspend prepare/finish functions > from platform code instead so this patch reverts the mentioned commit. > > Suggested-by: Doug Anderson > Signed-off-by: Javier Martinez Canillas Reviewed-by: Doug Anderson -- To

Re: [PATCH v3 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-20 Thread Doug Anderson
handlers > defined by regulator drivers are not called when the system is suspended. > > Suggested-by: Doug Anderson > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Doug Anderson I think you forgot to carry Chanwoo's review: Reviewed-by: Chanwoo Choi I don't

Re: [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-20 Thread Doug Anderson
Javier, On Mon, Oct 20, 2014 at 9:58 AM, Javier Martinez Canillas wrote: >> It turns out that regulator_suspend_finish() actually returns an error >> code. Could you print a warning if you see it? >> > > Yes, I noticed this when looking at Chris patch for Rockchip but didn't > re-spin > because

Re: [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-20 Thread Doug Anderson
handlers > defined by regulator drivers are not called when the system is suspended. > > Suggested-by: Doug Anderson > Signed-off-by: Javier Martinez Canillas > --- > arch/arm/mach-exynos/suspend.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --

Re: [PATCH 1/1] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-15 Thread Doug Anderson
handlers > defined in regulator drivers are never called when the system is suspended. > > Suggested-by: Doug Anderson > Signed-off-by: Javier Martinez Canillas Could you also add a patch to your series ripping out the call in "drivers/mfd/sec-core.c" since it doesn't

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-08 Thread Doug Anderson
Hi, On Wed, Oct 8, 2014 at 8:20 AM, Arnd Bergmann wrote: > Why does it cause a regression though? Does this mean you are breaking > any boot with an old DT file and a new kernel? That would be very > bad, the driver is supposed to keep working with an existing dtb. The old dts file specified com

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-06 Thread Doug Anderson
Bartlomiej, On Thu, Oct 2, 2014 at 10:24 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday, October 02, 2014 09:45:41 AM Doug Anderson wrote: >> Bartiomiej >> >> On Thu, Oct 2, 2014 at 9:39 AM, Bartlomiej Zolnierkiewicz >> wrote: >> > O

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Doug Anderson
Bartiomiej On Thu, Oct 2, 2014 at 9:39 AM, Bartlomiej Zolnierkiewicz wrote: > On Thursday, October 02, 2014 09:19:08 AM Doug Anderson wrote: >> Bartiomiej, >> >> On Thu, Oct 2, 2014 at 9:10 AM, Bartlomiej Zolnierkiewicz >> wrote: >> > Regulators for MMC2

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Doug Anderson
is > not specified. Fix it. > > Without this patch: > - "mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators" > patch causes a SD card detection to fail > - "mmc: dw_mmc: Support voltage changes" patch causes a boot hang > > This patch fixes both

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-10-01 Thread Doug Anderson
Hi, On Wed, Oct 1, 2014 at 7:00 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, October 01, 2014 12:47:52 AM YUVARAJ CD wrote: > >> Since I am out of station, i dont have an access to my work set up. >> Can you send me the dts entries of sd crad and their corresponding regulator >

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-10-01 Thread Doug Anderson
Hi, On Wed, Oct 1, 2014 at 6:06 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, September 30, 2014 10:22:34 AM Doug Anderson wrote: >> Bartlomiej >> >> On Mon, Sep 29, 2014 at 5:31 AM, Bartlomiej Zolnierkiewicz >> wrote: >> > >>

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-09-30 Thread Doug Anderson
Bartlomiej On Mon, Sep 29, 2014 at 5:31 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Friday, August 29, 2014 01:34:44 PM Ulf Hansson wrote: >> On 22 August 2014 15:47, Yuvaraj Kumar C D wrote: >> > This patch makes use of mmc_regulator_get_supply() to handle >> > the vmmc and vqmmc regula

Re: [PATCH v7] mfd: syscon: Decouple syscon interface from platform devices

2014-09-30 Thread Doug Anderson
king over >author for this patchset from Tomasz Figa. > > [1]: https://lkml.org/lkml/2014/9/29/99 > [2]: https://lkml.org/lkml/2014/9/18/130 > [3]: https://lkml.org/lkml/2014/9/27/2 > drivers/mfd/syscon.c | 96 > ++ > 1

Re: [PATCH v10 0/6] Add Maxim 77802 RTC support

2014-09-19 Thread Doug Anderson
ted most of these. They may not show up in linuxnext yet, but that doesn't mean Andrew hasn't taken them (I think). > Doug Anderson (1): > rtc: max77686: Allow the max77686 rtc to wakeup the system http://ozlabs.org/~akpm/mmots/broken-out/rtc-max77686-allow-the-max77686-rt

Re: [PATCHv3 4/5] rtc: s3c: Add support for RTC of Exynos3250 SoC

2014-09-17 Thread Doug Anderson
Daniel, On Wed, Sep 17, 2014 at 9:49 AM, Daniel Drake wrote: > On Tue, Sep 16, 2014 at 4:15 PM, Doug Anderson wrote: >> NOTE: I don't think that the builtin RTC is terribly important for any >> exynos-based Chromebooks that I'm aware of. We rely on the RTC that&#x

Re: [PATCH 2/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos5250-snow

2014-09-17 Thread Doug Anderson
9 { > compatible = "maxim,max77686"; > interrupt-parent = <&gpx3>; > interrupts = <2 0>; In any case, there's nothing wrong with Javier's patch other than the fact that it will eventually need to get merged with Andreas's, so: Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos Peach boards

2014-09-17 Thread Doug Anderson
/boot/dts/exynos5800-peach-pi.dts | 5 - > 2 files changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv3 4/5] rtc: s3c: Add support for RTC of Exynos3250 SoC

2014-09-16 Thread Doug Anderson
Hi, On Tue, Sep 16, 2014 at 8:20 AM, Javier Martinez Canillas wrote: > Hello Daniel, > > On Tue, Sep 16, 2014 at 5:03 PM, Daniel Drake wrote: >> On Tue, Sep 16, 2014 at 7:48 AM, Javier Martinez Canillas >> wrote: Clock list for s3c-rtc device: - rtc : CLK_RTC of CLK_GATE_IP_PERIR is g

Re: [PATCH RESEND] ARM: DTS: correct the capability string for mmc0

2014-09-16 Thread Doug Anderson
to use recommended reset procedure > are now merged in upstream. > So you can go ahead and pick this change. > > arch/arm/boot/dts/exynos5420-peach-pit.dts |2 +- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletion

Re: [PATCH RESEND v9 1/5] rtc: max77686: Allow the max77686 rtc to wakeup the system

2014-09-12 Thread Doug Anderson
Hi, On Fri, Sep 12, 2014 at 8:54 AM, Javier Martinez Canillas wrote: > You are right, I completely forgot to check if that actually landed and to > remove the note in that case... > > Maybe when the set is applied the note can be removed from this patch or do > you think that I should re-spin the

Re: [PATCH RESEND v9 1/5] rtc: max77686: Allow the max77686 rtc to wakeup the system

2014-09-12 Thread Doug Anderson
Hi, On Fri, Sep 12, 2014 at 1:17 AM, Javier Martinez Canillas wrote: > From: Doug Anderson > > The max77686 includes an RTC that keeps power during suspend. It's > convenient to be able to use it as a wakeup source. > > NOTE: due to wakeup ordering problems this patc

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-11 Thread Doug Anderson
Hi, On Thu, Sep 11, 2014 at 11:03 AM, Mark Brown wrote: > On Thu, Sep 11, 2014 at 10:22:32AM +0100, Grant Likely wrote: >> On Wed, 10 Sep 2014 17:57:23 +0100, Mark Brown wrote: > >> > It's not quite as simple as just disabling PM - for example in the >> > clocks case we've also got to worry abou

Re: [PATCH v3 7/7] ARM: exynos_defconfig: Enable MAX77802

2014-09-10 Thread Doug Anderson
es. > > Signed-off-by: Vivek Gautam > Signed-off-by: Javier Martinez Canillas > --- > arch/arm/configs/exynos_defconfig | 3 +++ > 1 file changed, 3 insertions(+) I've no complaints about any of that. Reviewed-by: Doug Anderson -- To unsubscribe from this list: send th

Re: [PATCH v3 6/7] ARM: dts: Set i2c7 clock at 400kHz for Peach boards

2014-09-10 Thread Doug Anderson
Javier, On Wed, Sep 10, 2014 at 3:19 AM, Javier Martinez Canillas wrote: > The downstream ChromeOS 3.8 kernel sets the clock frequency > for the I2C bus 7 at 400kHz. Do the same change in mainline. > > Suggested-by: Doug Anderson > Signed-off-by: Javier Martinez Canillas > --

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-10 Thread Doug Anderson
Mark, On Wed, Sep 10, 2014 at 12:45 PM, Mark Brown wrote: > On Wed, Sep 10, 2014 at 09:45:21AM -0700, Doug Anderson wrote: > >> Right now I know that clock disabling is supposed to be inhibited >> during the early boot process. I think regulators too? > > No, for regula

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-10 Thread Doug Anderson
Grant, On Wed, Sep 10, 2014 at 9:29 AM, Grant Likely wrote: > On Wed, Sep 10, 2014 at 4:39 PM, Mark Brown wrote: >> On Wed, Sep 10, 2014 at 03:56:16PM +0100, Grant Likely wrote: >>> On Wed, Sep 10, 2014 at 3:31 PM, Mark Brown wrote: >> >>> > As far as I can tell the problem here is coming from

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-10 Thread Doug Anderson
Will, On Wed, Sep 10, 2014 at 4:17 AM, Will Deacon wrote: > On Mon, Sep 08, 2014 at 03:05:40PM +0100, Javier Martinez Canillas wrote: >> Hello Will, > > Hi Javier, > >> Since many folks don't agree that hacking different subsystems is the way >> forward I'll hold the patches and don't post them.

Re: [PATCH v2 0/5] Add max77802 support for Peach boards

2014-09-09 Thread Doug Anderson
Hi, On Mon, Sep 8, 2014 at 8:47 PM, wrote: > Javier Martinez Canillas wrote: >> >> Hello Kukjin, >> > Hi, > >> On Wed, Aug 20, 2014 at 1:19 PM, Javier Martinez Canillas >> wrote: >> > >> > This is a second version of the series that adds max77802 support for >> > the Peach Pit and Pi boards. Th

Re: [PATCH v2 5/5] ARM: dts: Add Peach Pit and Pi dts entry for ISL29018 sensor

2014-09-09 Thread Doug Anderson
insertions(+) I would note that the downstream dts file has this i2c bus at 400kHz. ...but that's not a problem with your patch. Perhaps you could submit that as a separate patch? Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-s

Re: [PATCH v2 4/5] ARM: dts: Add thermistor dts fragment used by exynos based Peach boards

2014-09-09 Thread Doug Anderson
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 6 > 3 files changed, 56 insertions(+) Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/5] ARM: dts: add hdmi regulators for exynos5420 based peach-pit board

2014-09-09 Thread Doug Anderson
gt; --- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH 2/6] ARM: dts: add hdmi regulators for exynos5800 based peach-pi board

2014-09-09 Thread Doug Anderson
Hi, On Tue, Sep 9, 2014 at 9:44 PM, Doug Anderson wrote: > Javier / Rahul, > > On Tue, Aug 19, 2014 at 8:08 AM, Javier Martinez Canillas > wrote: >> From: Rahul Sharma >> >> Adding regulators for HDMI for Peach-pi board. >> >> Signed-off-by: Rah

Re: [PATCH v2 2/5] ARM: dts: add hdmi regulators for exynos5800 based peach-pi board

2014-09-09 Thread Doug Anderson
gt; --- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/6] ARM: dts: add hdmi regulators for exynos5800 based peach-pi board

2014-09-09 Thread Doug Anderson
> --- > > v2: 1) Add blank line before hdmi regulators. > > arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a me

Re: [PATCH v2 1/5] ARM: dts: Add Peach Pit and Pi dts entry for max77802 PMIC

2014-09-09 Thread Doug Anderson
Javier, On Wed, Aug 20, 2014 at 4:19 AM, Javier Martinez Canillas wrote: > Exynos5420 based Peach Pit and Exynos5800 based Peach Pi boards > uses a Maxim 77802 power management IC to drive regulators and > its Real Time Clock. This patch adds support for this chip. > > These are the device nodes

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-08 Thread Doug Anderson
Will, On Mon, Sep 8, 2014 at 9:07 AM, Will Deacon wrote: > On Mon, Sep 08, 2014 at 04:55:31PM +0100, Doug Anderson wrote: >> So "simple-framebuffer" is added to the device tree here: >> >> https://chromium-review.googlesource.com/#/c/49358/2/board/samsung/smdk5250

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-08 Thread Doug Anderson
Grant, On Mon, Sep 8, 2014 at 5:20 AM, Grant Likely wrote: > On Mon, Sep 8, 2014 at 12:21 PM, Will Deacon wrote: >> On Sun, Sep 07, 2014 at 05:19:03PM +0100, Tomasz Figa wrote: >>> At least for next 3.17-rc I'd suggest fixing this up in respective clock >>> driver and dropping the hack only afte

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-08 Thread Doug Anderson
Javier, On Sun, Sep 7, 2014 at 11:09 PM, Javier Martinez Canillas wrote: > Hello Doug, > > On 09/08/2014 06:36 AM, Doug Anderson wrote: >> >> One (ugly?) solution would be to add a feature to your bootloader to >> modify the device tree to mark regulators as "alw

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-07 Thread Doug Anderson
Hi, On Sun, Sep 7, 2014 at 8:52 AM, Tomasz Figa wrote: > Now with regulators this is pretty straightforward, but with clocks I > believe it's an open issue. AFAIR we've discussed this on MLs some time > ago (at least I remember Doug commenting on that topic) and kind of > concluded that SoC clock

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-07 Thread Doug Anderson
Hi, On Sun, Sep 7, 2014 at 8:52 AM, Tomasz Figa wrote: > So I believe we've got a process issue here. If you don't have normal > support for display hardware, but you want to keep the display > operational thanks to bootloader already initializing it, you should not > add anything to the kernel w

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-05 Thread Doug Anderson
Will, On Fri, Sep 5, 2014 at 5:22 AM, Will Deacon wrote: > [Looks like it's not just Rutland that can't spell the address of the > mailing list today. Fixed here, so please use this post in any replies]. > > On Fri, Sep 05, 2014 at 12:57:04PM +0100, Will Deacon wrote: >> Hi all, >> >> I'm one of

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-28 Thread Doug Anderson
Hi, On Thu, Aug 28, 2014 at 10:50 AM, Sonny Rao wrote: > On Thu, Aug 28, 2014 at 8:50 AM, Doug Anderson wrote: >> Ulf, >> >> On Thu, Aug 28, 2014 at 12:25 AM, Ulf Hansson wrote: >>> On 27 August 2014 17:52, Doug Anderson wrote: >>>> Ulf, >>>

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-28 Thread Doug Anderson
Jaehoon, On Thu, Aug 28, 2014 at 1:43 AM, Jaehoon Chung wrote: > On 08/28/2014 12:49 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Tue, Aug 26, 2014 at 9:47 PM, Jaehoon Chung >> wrote: >>> Doug, >>> >>> On 08/27/2014 01:14 PM, Doug Anders

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-28 Thread Doug Anderson
Ulf, On Thu, Aug 28, 2014 at 12:25 AM, Ulf Hansson wrote: > On 27 August 2014 17:52, Doug Anderson wrote: >> Ulf, >> >> On Wed, Aug 27, 2014 at 4:17 AM, Ulf Hansson wrote: >>>> Now, we've got MMC_CAP_NEEDS_POLL, so dw_mmc will periodically be >>>&

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-27 Thread Doug Anderson
Ulf, On Wed, Aug 27, 2014 at 4:17 AM, Ulf Hansson wrote: >> Now, we've got MMC_CAP_NEEDS_POLL, so dw_mmc will periodically be >> called to check the card detect line, but with vmmc and vqmmc off. It >> will be unable to return a sensible value without actually turning on >> vmmc and vqmmc. > > C

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-27 Thread Doug Anderson
Jaehoon, On Tue, Aug 26, 2014 at 9:47 PM, Jaehoon Chung wrote: > Doug, > > On 08/27/2014 01:14 PM, Doug Anderson wrote: >> Jaehoon, >> >> On Tue, Aug 26, 2014 at 8:48 PM, Jaehoon Chung >> wrote: >>> Hi, Doug, >>> >>> On 08/26/2014 1

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-26 Thread Doug Anderson
Jaehoon, On Tue, Aug 26, 2014 at 8:48 PM, Jaehoon Chung wrote: > Hi, Doug, > > On 08/26/2014 12:25 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Mon, Aug 25, 2014 at 1:50 AM, Jaehoon Chung >> wrote: >>> On 08/25/2014 05:13 PM, Ulf Hansson wrote: >

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-26 Thread Doug Anderson
Ulf, On Tue, Aug 26, 2014 at 12:37 AM, Ulf Hansson wrote: > On 25 August 2014 17:20, Doug Anderson wrote: >> Ulf, >> >> On Mon, Aug 25, 2014 at 1:13 AM, Ulf Hansson wrote: >>> On 22 August 2014 20:27, Sonny Rao wrote: >>>> On Fri, Aug 22, 2014 at 8:31

Re: [PATCH 1/1] regulator: max77802: set opmode to normal if off is read from hw

2014-08-26 Thread Doug Anderson
* the hardware reports OFF as the regulator operating mode. > +* Default to operating mode NORMAL in that case. > +*/ > + if (val == MAX77802_OPMODE_OFF) > + max77802->opmode[id] = MAX77802_OPMODE_NORMAL; > +

Re: [PATCH V2 2/3] mmc: dw_mmc: Support voltage changes

2014-08-25 Thread Doug Anderson
Ulf, On Mon, Aug 25, 2014 at 1:31 AM, Ulf Hansson wrote: > On 22 August 2014 22:38, Doug Anderson wrote: >> Ulf, >> >> On Fri, Aug 22, 2014 at 8:35 AM, Ulf Hansson wrote: >>> On 22 August 2014 15:47, Yuvaraj Kumar C D wrote: >>>> From: Doug And

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-25 Thread Doug Anderson
Javier, On Mon, Aug 25, 2014 at 2:07 AM, Javier Martinez Canillas wrote: > Hello Yuvaraj, > > On 08/25/2014 10:22 AM, Yuvaraj Cd wrote: Good question. I'm not that familiar with the dw_mmc host controller nor its driver implementation so I'll let Yuvaraj or Doug to answer that. >> Well,

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-25 Thread Doug Anderson
Jaehoon, On Mon, Aug 25, 2014 at 1:50 AM, Jaehoon Chung wrote: > On 08/25/2014 05:13 PM, Ulf Hansson wrote: >> On 22 August 2014 20:27, Sonny Rao wrote: >>> On Fri, Aug 22, 2014 at 8:31 AM, Ulf Hansson wrote: On 22 August 2014 15:47, Yuvaraj Kumar C D wrote: > Exynos 5250 and 5420 bas

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-25 Thread Doug Anderson
Ulf, On Mon, Aug 25, 2014 at 1:13 AM, Ulf Hansson wrote: > On 22 August 2014 20:27, Sonny Rao wrote: >> On Fri, Aug 22, 2014 at 8:31 AM, Ulf Hansson wrote: >>> On 22 August 2014 15:47, Yuvaraj Kumar C D wrote: Exynos 5250 and 5420 based boards uses built-in CD# line for card detectio

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-08-25 Thread Doug Anderson
Jaehoon, On Mon, Aug 25, 2014 at 5:32 AM, Jaehoon Chung wrote: > On 08/22/2014 10:47 PM, Yuvaraj Kumar C D wrote: >> This patch makes use of mmc_regulator_get_supply() to handle >> the vmmc and vqmmc regulators.Also it moves the code handling >> the these regulators to dw_mci_set_ios().It turned

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-22 Thread Doug Anderson
Hi, On Fri, Aug 22, 2014 at 3:02 PM, Javier Martinez Canillas wrote: > Hello Mark, > > On 08/22/2014 08:30 PM, Mark Brown wrote: >> >>> The problem is that one of these regulators is used as the vqmmc-supply >>> (VCCQ/VDD_IO) so the mmc host controller driver disables it on >>> MMC_POWER_OFF. Now

Re: [PATCH V2 2/3] mmc: dw_mmc: Support voltage changes

2014-08-22 Thread Doug Anderson
Ulf, On Fri, Aug 22, 2014 at 8:35 AM, Ulf Hansson wrote: > On 22 August 2014 15:47, Yuvaraj Kumar C D wrote: >> From: Doug Anderson >> >> For UHS cards we need the ability to switch voltages from 3.3V to >> 1.8V. Add support to the dw_mmc driver to handle this.

Re: [PATCH v7] ARM: dts: Prepare node labels for exynos5250

2014-08-22 Thread Doug Anderson
Kukjin, On Fri, Aug 22, 2014 at 3:49 AM, Kukjin Kim wrote: > Andreas Färber wrote: >> >> Allows them to be extended by reference. >> >> Reviewed-by: Doug Anderson >> Signed-off-by: Andreas Färber >> --- >> v6 -> v7: >> * Dropped uart* la

Re: [PATCH v7 02/11] power/restart: Call machine_restart instead of arm_pm_restart

2014-08-21 Thread Doug Anderson
Guenter, On Wed, Aug 20, 2014 at 9:42 PM, Guenter Roeck wrote: > On Wed, Aug 20, 2014 at 09:10:31PM -0700, Doug Anderson wrote: >> Guenter, >> >> On Tue, Aug 19, 2014 at 5:45 PM, Guenter Roeck wrote: >> > machine_restart is supported on non-ARM platf

Re: [PATCH v7 11/11] clk: rockchip: add restart handler

2014-08-20 Thread Doug Anderson
| 1 + > 4 files changed, 30 insertions(+) This patch doesn't apply cleanly with the in-flight (clk: rockchip: protect critical clocks from getting disabled) patch from Heiko. It's trivial to resolve and unclear which will land first, so I think it's fine... Reviewed-by: Doug Ande

Re: [PATCH v7 03/11] arm64: Support restart through restart handler call chain

2014-08-20 Thread Doug Anderson
t; > arch/arm64/kernel/process.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 08/11] arm/arm64: Unexport restart handlers

2014-08-20 Thread Doug Anderson
rm64/kernel/process.c | 1 - > 2 files changed, 2 deletions(-) Reviewed-by: Doug Anderson Tested-by: Doug Anderson (FYI: all patches tested by me were tested on rk3288-evb) -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to

Re: [PATCH v7 02/11] power/restart: Call machine_restart instead of arm_pm_restart

2014-08-20 Thread Doug Anderson
Stuebner > --- > v7: No change. > v6: No change. > v5: No change. > v4: No change. > v3: No change. > v2: Added patch. > > drivers/power/reset/restart-poweroff.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Doug Anderson Tested-by: Doug And

Re: [PATCH v7 04/11] arm: Support restart through restart handler call chain

2014-08-20 Thread Doug Anderson
ile changed, 5 insertions(+), 6 deletions(-) Reviewed-by: Doug Anderson Tested-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 01/11] kernel: Add support for kernel restart handler call chain

2014-08-20 Thread Doug Anderson
gt; v2: No change. > > include/linux/reboot.h | 3 ++ > kernel/reboot.c| 81 > ++ > 2 files changed, 84 insertions(+) Reviewed-by: Doug Anderson Tested-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RESEND PATCH 4/7] mfd: cros_ec: move locking into cros_ec_cmd_xfer

2014-08-20 Thread Doug Anderson
s(+), 12 deletions(-) After comment nitfix: Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RESEND PATCH 3/7] mfd: cros_ec: stop calling ->cmd_xfer() directly

2014-08-20 Thread Doug Anderson
nel.c | 2 +- > drivers/input/keyboard/cros_ec_keyb.c | 2 +- > drivers/mfd/cros_ec.c | 7 +++ > include/linux/mfd/cros_ec.h | 24 ++-- > 4 files changed, 27 insertions(+), 8 deletions(-) Reviewed-by: Doug Anderson -- To unsubscri

Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

2014-08-19 Thread Doug Anderson
Javier, On Tue, Aug 19, 2014 at 8:08 AM, Javier Martinez Canillas wrote: > The VCC/VDD and VCCQ/VDD_IO power supplies for the MMC are > provided by the tps65090 fet4 and max77802 ldo4 regulators > respectively. Add the phandle to the regulators tree nodes > for the the dw_mmc device device. > > T

[REPOST PATCH v2] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-08-13 Thread Doug Anderson
e're not going to do anything else we end the request and unblock anyone waiting. Signed-off-by: Doug Anderson Signed-off-by: Yuvaraj Kumar C D Acked-by: Seungwon Jeon --- Changes in v2: - Removed TODO - Set cmd to NULL before calling dw_mci_request_end() drive

Re: [PATCH v2] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-08-13 Thread Doug Anderson
Hi, On Wed, May 21, 2014 at 2:08 AM, Seungwon Jeon wrote: > On Wed, May 21, 2014, Doug Anderson wrote: >> If we happened to get a data error at just the wrong time the dw_mmc >> driver could get into a state where it would never complete its >> request. That would leave th

Re: [PATCH 3/6] ARM: dts: Create cros-tps65090 fragment

2014-08-12 Thread Doug Anderson
Javier, On Tue, Aug 12, 2014 at 9:44 AM, Javier Martinez Canillas wrote: > The tps65090 PMU is a component used in many ChromeOS devices > so instead of having the same device tree definitions in many > files, create a .dtsi fragment that can be included in DTS. > > This fragment is based on the

Re: [RESEND PATCH 1/1] ARM: exynos_defconfig: Enable SBS battery support

2014-08-11 Thread Doug Anderson
Hi, On Mon, Aug 11, 2014 at 10:28 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday, August 11, 2014 06:23:01 PM Javier Martinez Canillas wrote: >> Hello, >> >> On 08/11/2014 05:59 PM, Doug Anderson wrote: >> > Bartlomiej, >> >

Re: [RESEND PATCH 1/1] ARM: exynos_defconfig: Enable SBS battery support

2014-08-11 Thread Doug Anderson
Bartlomiej, On Mon, Aug 11, 2014 at 8:42 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday, August 11, 2014 02:52:27 PM Javier Martinez Canillas wrote: >> Hello Bartlomiej, >> >> On 08/11/2014 02:40 PM, Bartlomiej Zolnierkiewicz wrote: >> >> index fc7d168..c390bb9 100644 >> >> --- a/arch

Re: [RESEND PATCH 2/2] ARM: dts: Add tps65090 FET constraints on Peach Pit and Pi

2014-08-11 Thread Doug Anderson
Javier, On Mon, Aug 11, 2014 at 4:38 AM, Javier Martinez Canillas wrote: > Both Exynos5420 Peach Pit and Exynos5800 Peach Pi boards > have a tps65090 PMU that has a number of switches (FETs) > that are just on/off devices but they do have a current > limit and the output voltage of the switch is

Re: [RESEND PATCH 1/2] ARM: dts: Improve Peach Pit and Pi power scheme

2014-08-11 Thread Doug Anderson
s/exynos5420-peach-pit.dts | 12 ++-- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 ++-- > 2 files changed, 12 insertions(+), 12 deletions(-) Matches my schematics. Kukjin: I think this could be applied to for-next whenever it's convenient. Acked-by: Doug Anderson

Re: [RESEND PATCH 1/1] ARM: exynos_defconfig: Enable SBS battery support

2014-08-11 Thread Doug Anderson
Javier, On Mon, Aug 11, 2014 at 4:06 AM, Javier Martinez Canillas wrote: > Many Exynos5 boards (e.g: Snow, Peach Pit and Pi) have > a SBS-compliant gas gauge battery. Enable it as module > so the needed support is available for these boards. > > Suggested-by: Doug Anderson

Re: [PATCH v2 1/1] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting

2014-08-08 Thread Doug Anderson
Javier, On Fri, Aug 8, 2014 at 3:26 PM, Javier Martinez Canillas wrote: >> I have some vague recollection that I set interrupts to pin-function >> "0" by default for some reason (assuming they would go to 0xf when >> interrupts were enabled). ...but I can't for the life of me remember >> if it w

Re: [PATCH v2 1/1] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting

2014-08-08 Thread Doug Anderson
Hi, On Fri, Aug 8, 2014 at 11:29 AM, Javier Martinez Canillas wrote: > Hello, > > On 08/08/2014 06:38 PM, Javier Martinez Canillas wrote: >> >> >> It seems as if the first call to exynos_irq_set_type() that is made by OF is >> a >> no-op while the second call is the one that actually setups the

Re: [PATCH 1/1] ARM: dts: Add Peach Pit and Pi dts entry for atmel touchpad

2014-08-06 Thread Doug Anderson
Fabio, On Wed, Aug 6, 2014 at 6:35 PM, Fabio Estevam wrote: > On Wed, Aug 6, 2014 at 10:08 PM, Javier Martinez Canillas > wrote: > >> +&hsi2c_8 { >> + status = "okay"; >> + clock-frequency = <333000>; > > Doesn't it work at the more standard 400kHz i2c frequency? I'm pretty sure tha

Re: [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring

2014-08-04 Thread Doug Anderson
Andreas, On Sat, Aug 2, 2014 at 3:25 AM, Andreas Färber wrote: > Hi, > > Am 02.08.2014 06:57, schrieb Doug Anderson: >> On Fri, Aug 1, 2014 at 7:34 PM, Javier Martinez Canillas >> wrote: >>> On 08/02/2014 02:52 AM, Andreas Färber wrote: >>>> >>

  1   2   3   4   5   6   7   8   >