On Mon, Nov 23, 2015 at 07:40:41PM +0530, Saurabh Sengar wrote:
> use of_property_read_u8() for u8 variables,
> also changed the return type to void as this function return type
> is nowhere used.
>
I would be good if you could split both changes into two patches.
Also, I still do not understand
Adding COMPILE_TEST flag to exynos driver to facilitate
maintenance.
Cc: Lukasz Majewski
Cc: Zhang Rui
Cc: linux...@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Eduardo Valentin
---
drivers/thermal/Kconfig | 2 +-
1 file changed, 1
Adding COMPILE_TEST flag to exynos driver to facilitate
maintenance.
Cc: Lukasz Majewski
Cc: Zhang Rui
Cc: linux...@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Eduardo Valentin
---
drivers/thermal/Kconfig | 2 +-
1 file changed, 1
with
> using of_cpufreq_cooling_register()).
>
> Cc: Kukjin Kim
> Cc: Arnd Bergmann
> Cc: Eduardo Valentin
> Cc: Lukasz Majewski
> Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
> Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Eduardo Valentin
> ---
> driv
river to support DT
and OF thermal, decided to create a header with constants. The header is
used by DT files and the driver code. The header was the dependency.
BR,
Eduardo Valentin
>
> http://www.spinics.net/lists/linux-samsung-soc/msg41877.html
>
>
> For HDMI patches, I thought
I will add it to samsung thermal tree, since Viresh has ACK'ed it.
Do we have any dependency with something which is only in the thermal
tree(s)? If not, I suggest the cpufreq changes go via cpufreq tree(s).
BR,
Eduardo Valentin
>
> > ---
> > Changes for v2:
> > - Remove
On Wed, Feb 25, 2015 at 03:11:24PM -0400, Eduardo Valentin wrote:
> On Wed, Feb 25, 2015 at 04:34:17PM +0100, Lukasz Majewski wrote:
> > Explanation of several properties, which allow PWM fan working as a cooling
> > device, have been embraced in this commit.
> >
>
On Wed, Feb 25, 2015 at 04:34:17PM +0100, Lukasz Majewski wrote:
> Explanation of several properties, which allow PWM fan working as a cooling
> device, have been embraced in this commit.
>
> Signed-off-by: Lukasz Majewski
> ---
> Changes for v2:
> - Rename cooling-pwm-values to cooling-levels
>
of PD_DET_EN (power down
> > >> detection mode) for Exynos7 because exynos7_tmu_control() always
> > >> enables the power down detection mode regardless 'on' parameter.
> > >>
> > >> Cc: Zhang Rui
> > >> Cc: Eduardo Valentin
> &
On Wed, Feb 25, 2015 at 04:34:19PM +0100, Lukasz Majewski wrote:
> With those bindings it is possible to use pwm-fan device available in
> Odroid U3 as a cooling device.
>
> Signed-off-by: Lukasz Majewski
Acked-by: Eduardo Valentin
> ---
> Changes for v2:
> - Rena
On Wed, Feb 25, 2015 at 02:28:15PM +0100, Lukasz Majewski wrote:
> Hi Eduardo,
>
> > On Wed, Feb 18, 2015 at 11:07:33AM +0100, Lukasz Majewski wrote:
> > > With those bindings it is possible to use pwm-fan device available
> > > in Odroid U3 as a cooling device.
> > >
> > > Signed-off-by: Lukasz
believe the series should go via your tree, yes. I had only minor
comments in the code added for the cooling device code, as it lacks the
unregistration call in the .remove callback.
Also, the DTS changes may generate conflicts with platform code. Lukasz
may probably ask Kukjin Kim to add them via the samsung tree.
BR,
Eduardo Valentin
>
> Thanks,
> Guenter
signature.asc
Description: Digital signature
(IS_ENABLED(CONFIG_THERMAL)) {
> + cdev = thermal_of_cooling_device_register(pdev->dev.of_node,
> + "pwm-fan", ctx,
> + &pwm_fan_c
On Wed, Feb 18, 2015 at 11:07:33AM +0100, Lukasz Majewski wrote:
> With those bindings it is possible to use pwm-fan device available in
> Odroid U3 as a cooling device.
>
> Signed-off-by: Lukasz Majewski
> ---
> Changes for v2:
> - Rename cooling-pwm-values property to cooling-levels
> Changes f
On Wed, Feb 18, 2015 at 11:07:31AM +0100, Lukasz Majewski wrote:
> Explanation of several properties, which allow PWM fan working as a cooling
> device, have been embraced in this commit.
>
> Signed-off-by: Lukasz Majewski
> ---
> Changes for v2:
> - Rename cooling-pwm-values to cooling-levels
>
On Wed, Feb 18, 2015 at 11:07:29AM +0100, Lukasz Majewski wrote:
> Odroid U3 fan can work without being registered as OF cooling device
> (with CONFIG_THERMAL_OF disabled).
> In this situation it can be controlled via PWM entry at
> /sys/class/hwmon/hwmon0/pwm1.
>
> Therefore, the thermal_of_cooli
On Wed, Feb 18, 2015 at 11:07:30AM +0100, Lukasz Majewski wrote:
> Odroid U3 fan can work without being registered as OF cooling device
> (with CONFIG_THERMAL{_OF|} disabled).
> In this situation it can be controlled via PWM entry at
> /sys/class/hwmon/hwmon0/pwm1.
>
> Therefore, the thermal_cdev_
Cc: Zhang Rui
> Cc: Eduardo Valentin
> Signed-off-by: Chanwoo Choi
Lukasz,
Any objections to this code?
BR,
Eduardo Valentin
> ---
> drivers/thermal/samsung/exynos_tmu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/
When error occurs, allow systems to release iomapped area.
Cc: "Rafael J. Wysocki"
Cc: Viresh Kumar
Cc: Kukjin Kim
Cc: linux...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Eduard
ned-off-by: Eduardo Valentin
---
drivers/cpufreq/exynos4210-cpufreq.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/cpufreq/exynos4210-cpufreq.c
b/drivers/cpufreq/exynos4210-cpufreq.c
index 8a25dce..fc02a39 100644
--- a/drivers/cpufreq/
ned-off-by: Eduardo Valentin
---
drivers/cpufreq/exynos5250-cpufreq.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/cpufreq/exynos5250-cpufreq.c
b/drivers/cpufreq/exynos5250-cpufreq.c
index e61d149..d3ce829 100644
--- a/drivers/cpufreq/
Call of_node_put when necessary during init.
Cc: "Rafael J. Wysocki"
Cc: Viresh Kumar
Cc: Kukjin Kim
Cc: linux...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Eduardo Valentin
--
nel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Eduardo Valentin
---
drivers/cpufreq/exynos-cpufreq.c | 2 +-
drivers/cpufreq/exynos-cpufreq.h | 2 +-
drivers/cpufreq/exynos4210-cpuf
linux-ker...@vger.kernel.org
Signed-off-by: Eduardo Valentin
---
drivers/cpufreq/exynos4210-cpufreq.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/cpufreq/exynos4210-cpufreq.c
b/drivers/cpufreq/exynos4210-cpufreq.c
index 00889a4..6757bda 100644
--- a/drivers/cpufreq/exynos4210-cpufr
linux-ker...@vger.kernel.org
Signed-off-by: Eduardo Valentin
---
drivers/cpufreq/exynos5250-cpufreq.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/cpufreq/exynos5250-cpufreq.c
b/drivers/cpufreq/exynos5250-cpufreq.c
index 191a511..ee274c9 100644
--- a/drivers/cpufreq/exynos5250-cpufr
linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Eduardo Valentin
---
drivers/cpufreq/exynos-cpufreq.c | 99 +---
drivers/cpufreq/exynos-cpufreq.h | 5 ++
2 files changed, 67 inserti
When error occurs, allow systems to release iomapped area.
Cc: "Rafael J. Wysocki"
Cc: Viresh Kumar
Cc: Kukjin Kim
Cc: linux...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Eduard
ned-off-by: Eduardo Valentin
---
drivers/cpufreq/exynos4x12-cpufreq.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/cpufreq/exynos4x12-cpufreq.c
b/drivers/cpufreq/exynos4x12-cpufreq.c
index 3da36baf..7e0dd2a 100644
--- a/drivers/cpufreq/
Call of_node_put when necessary during init.
Cc: "Rafael J. Wysocki"
Cc: Viresh Kumar
Cc: Kukjin Kim
Cc: linux...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Eduardo Valentin
--
On Mon, Feb 02, 2015 at 09:33:09AM +0530, Viresh Kumar wrote:
> On 1 February 2015 at 00:29, Eduardo Valentin wrote:
> > From: Arnd Bergmann
> >
>
> Acked-by: Viresh Kumar
Thanks!
>
> Now as these are all compilable as modules, should we look into the drivers
On Tue, Jan 27, 2015 at 11:18:22AM +0530, Abhilash Kesavan wrote:
> Add registers, bit fields and compatible strings for Exynos7 TMU
> (Thermal Management Unit). Following are a few of the differences
> in the Exynos7 TMU from earlier SoCs:
> - 8 trigger levels
> - Different bit off
q
cooling should be registered")
Signed-off-by: Arnd Bergmann
Signed-off-by: Eduardo Valentin
---
drivers/cpufreq/Kconfig.arm | 44 ++--
drivers/cpufreq/Makefile| 9 +
2 files changed, 31 insertions(+), 22 deletions(-)
---
Changes from V1:
-
On Fri, Jan 30, 2015 at 10:24:12PM +0100, Arnd Bergmann wrote:
> On Thursday 29 January 2015 18:21:51 Eduardo Valentin wrote:
> > Hello Arnd and Viresh,
> >
> > On Thu, Jan 29, 2015 at 01:42:32PM +0100, Arnd Bergmann wrote:
> > > On Thursday 29 January 20
On Thu, Jan 22, 2015 at 06:02:07PM +0530, Abhilash Kesavan wrote:
> Hi Lukasz,
>
> On Thu, Jan 22, 2015 at 2:31 PM, Lukasz Majewski
> wrote:
> > Hi Abhilash,
> >
> >> Hi Lukasz,
> >>
> >> On Mon, Jan 19, 2015 at 5:14 PM, Lukasz Majewski
> >> wrote:
> >> > The exynos_map_dt_data() function must
On Wed, Jan 28, 2015 at 04:28:40PM +0100, Lukasz Majewski wrote:
> This commit enables the cpufreq subsystem. Moreover, support for using
> CPU as a cooling device is provided.
>
> Signed-off-by: Lukasz Majewski
I dont see problems with this patch:
Acked-by: Eduardo Valentin
Ag
On Wed, Jan 28, 2015 at 04:28:38PM +0100, Lukasz Majewski wrote:
> After Exynos TMU rework to use device tree for configuration this flag
> can be removed. It is not used anymore.
>
> Signed-off-by: Lukasz Majewski
I dont see problems with this patch:
Acked-by: Eduardo Valentin
On Wed, Jan 28, 2015 at 04:28:39PM +0100, Lukasz Majewski wrote:
> Enabling thermal emulation on Exynos SoCs. New sysfs attribute - emul_temp
> is created.
>
> Signed-off-by: Lukasz Majewski
I dont see problems with this patch:
Acked-by: Eduardo Valentin
> ---
>
xynos_dvfs_info *info)
return -EOPNOTSUPP;
}
#endif
-#ifdef CONFIG_ARM_EXYNOS5250_CPUFREQ
+#if IS_ENABLED(CONFIG_ARM_EXYNOS5250_CPUFREQ)
extern int exynos5250_cpufreq_init(struct exynos_dvfs_info *);
#else
static inline int exynos5250_cpufreq_init(struct exynos_dvfs_info *info)
Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 28, 2015 at 04:21:49PM +0530, Abhilash Kesavan wrote:
> Hi Eduardo,
>
> On Tue, Jan 27, 2015 at 11:18 AM, Abhilash Kesavan
> wrote:
> > Add documentation for exynos7 thermal bindings including compatible
> > name and special clock properties.
> >
> > Signed-off-by: Abhilash Kesavan
>
On Wed, Jan 28, 2015 at 02:16:55PM +0100, Arnd Bergmann wrote:
> The exynos cpufreq driver code recently gained a dependency on the
> cooling code, which may be a loadable module. This breaks an ARM
> allmodconfig build:
>
> drivers/built-in.o: In function `exynos_cpufreq_probe':
> :(.text+0x1748e
On Wed, Jan 28, 2015 at 04:28:38PM +0100, Lukasz Majewski wrote:
> After Exynos TMU rework to use device tree for configuration this flag
> can be removed. It is not used anymore.
>
> Signed-off-by: Lukasz Majewski
Acked-by: Eduardo Valentin
> ---
> arch/arm/configs/ex
On Tue, Jan 27, 2015 at 12:13:59PM +0100, Lukasz Majewski wrote:
> After removing exynos_thermal_common.[c|h] files the CONFIG_EXYNOS_THERMA_CORE
> is not needed anymore.
> This patch removes this entry from Kconfig.
>
> Reported-by: Paul Bolle
> Signed-off-by: Lukasz Majewski
This patch looks
On Sun, Jan 25, 2015 at 07:31:14PM +0530, Viresh Kumar wrote:
> On 23 January 2015 at 19:27, Lukasz Majewski wrote:
> > Please pay a note about following problem:
> >
> > Previously we got: cpu0: cpu@0 for all Exynos devices.
> >
> > Now, however, cpu numbering has changed (due to GIC rework).
> >
On Fri, Jan 23, 2015 at 01:09:53PM +0100, Lukasz Majewski wrote:
> 1. Introduction
>
> Following patches aim to clean up the current implementation of the thermal
> framework on Exynos devices.
>
> The main goal was to use a generic code for reading thermal configuration
> (of-thermal.c). Due to
gt; > > > +++--
> > > > drivers/thermal/samsung/exynos_tmu.h | 68 +---
> > > > drivers/thermal/samsung/exynos_tmu_data.c | 264
> > > > - include/dt-bindings/thermal/thermal_exynos.h |
> > > >
On Wed, Jan 21, 2015 at 09:10:15AM +0100, Lukasz Majewski wrote:
> Hi Eduardo,
>
> > On Thu, Jan 15, 2015 at 04:17:52PM +0100, Lukasz Majewski wrote:
> > > Hi Eduardo,
> > >
> > > > On Wed, Jan 14, 2015 at 02:41:12PM +0100, Lukasz Majewski wrote:
> > > > > This patch brings support for providing
On Wed, Jan 21, 2015 at 09:40:55AM +0100, Lukasz Majewski wrote:
> Hi Eduardo,
>
> > On Mon, Jan 19, 2015 at 12:20:59PM +0100, Lukasz Majewski wrote:
> > > This patch brings support for providing configuration via device
> > > tree. Previously this data has been hardcoded in the
> > > exynos_tmu_d
On Thu, Jan 22, 2015 at 02:06:10AM +0100, Tobias Jakobi wrote:
> Hello!
>
>
> Lukasz Majewski wrote:
> >> The point is that I'm still working with a rather old version of the
> >> cpufreq series, a version which still had the Exynos4x12 code in it
> >> (this was removed later, if I remember corre
On Mon, Jan 19, 2015 at 12:21:02PM +0100, Lukasz Majewski wrote:
> After switching to device tree based configuration those declarations are
> not needed anymore.
>
> Reported-by: Abhilash Kesavan
> Signed-off-by: Lukasz Majewski
> ---
> Changes for v5:
> - New patch
> ---
> drivers/thermal/sam
On Mon, Jan 19, 2015 at 12:20:59PM +0100, Lukasz Majewski wrote:
> This patch brings support for providing configuration via device tree.
> Previously this data has been hardcoded in the exynos_tmu_data.c file.
> Such approach was not scalable and very often required copying the whole
> data.
>
>
On Mon, Jan 19, 2015 at 12:20:59PM +0100, Lukasz Majewski wrote:
> This patch brings support for providing configuration via device tree.
> Previously this data has been hardcoded in the exynos_tmu_data.c file.
> Such approach was not scalable and very often required copying the whole
> data.
>
>
On Mon, Jan 19, 2015 at 12:20:51PM +0100, Lukasz Majewski wrote:
> Up till now exynos_tmu_data.c was used for storing CPU cooling configuration
> data. Now the Exynos thermal core code uses device tree to get this data.
> For this purpose generic thermal code for configuring CPU cooling was
> used.
Hello Arnd,
On Mon, Jan 19, 2015 at 12:20:44PM +0100, Lukasz Majewski wrote:
> 1. Introduction
>
> Following patches aim to clean up the current implementation of the thermal
> framework on Exynos devices.
>
> The main goal was to use a generic code for reading thermal configuration
> (of-therma
On Thu, Jan 15, 2015 at 04:17:52PM +0100, Lukasz Majewski wrote:
> Hi Eduardo,
>
> > On Wed, Jan 14, 2015 at 02:41:12PM +0100, Lukasz Majewski wrote:
> > > This patch brings support for providing configuration via device
> > > tree. Previously this data has been hardcoded in the
> > > exynos_tmu_d
On Wed, Jan 14, 2015 at 02:41:11PM +0100, Lukasz Majewski wrote:
> Presented device tree bindings provide data already hardcoded in the
> exynos_tmu_data.c file.
> After this commit, it should be possible to reuse common thermal core
> framework in Exynos SoCs.
>
> Signed-off-by: Lukasz Majewski
On Wed, Jan 14, 2015 at 02:52:25PM -0400, Eduardo Valentin wrote:
> On Wed, Jan 14, 2015 at 02:41:07PM +0100, Lukasz Majewski wrote:
> > Properties necessary for providing Exynos thermal configuration via device
> > tree.
> >
> > Signed-off-by: Lukasz Majewski
On Wed, Jan 14, 2015 at 02:41:04PM +0100, Lukasz Majewski wrote:
> Presented patch aims to move data necessary for correct CPU cooling device
> configuration from exynos_tmu_data.c to device tree.
>
> Signed-off-by: Lukasz Majewski
> ---
> Changes for v2:
> - None
> Changes for v3:
> - Adjust CPU
On Wed, Jan 14, 2015 at 02:41:07PM +0100, Lukasz Majewski wrote:
> Properties necessary for providing Exynos thermal configuration via device
> tree.
>
> Signed-off-by: Lukasz Majewski
> ---
> Changes for v3:
> - New patch
>
> ---
> .../devicetree/bindings/thermal/exynos-thermal.txt | 17
On Wed, Jan 14, 2015 at 02:41:03PM +0100, Lukasz Majewski wrote:
> This commit enables TMU IP block on the Exynos4412 Odroid U3
> device.
>
The comment about the patch subject applies here too. I would use "arm:
dts: ..." instead of "thermal: dts" ...".
> Signed-off-by: Lukasz Majewski
> ---
>
On Wed, Jan 14, 2015 at 02:41:12PM +0100, Lukasz Majewski wrote:
> This patch brings support for providing configuration via device tree.
> Previously this data has been hardcoded in the exynos_tmu_data.c file.
> Such approach was not scalable and very often required copying the whole
> data.
>
>
On Wed, Jan 14, 2015 at 04:01:06PM +0100, Lukasz Majewski wrote:
> Hi Eduardo,
>
> > On Fri, Jan 02, 2015 at 02:54:28PM -0400, Eduardo Valentin wrote:
> > > On Mon, Dec 22, 2014 at 05:27:41PM +0100, Lukasz Majewski wrote:
> > > > Odroid U3 fan can work witho
ERMAL subsystem (and such configuration is perfectly
> valid).
OK. Now I understand. Then, please resend this one using CONFIG_THERMAL.
Thanks,
Eduardo Valentin
>
> >
> > >
> > > Signed-off-by: Lukasz Majewski
> > > ---
> > > Changes for v2:
&
On Mon, Jan 12, 2015 at 03:09:16PM +0100, Lukasz Majewski wrote:
> Hi Eduardo,
>
> > > Presented patch aims to move data necessary for correct CPU cooling
> > > device configuration from exynos_tmu_data.c to device tree.
> >
> > I believe the patch title is misleading. Looks like you are chang
-)
Good! Take your time.
Cheers,
Eduardo Valentin
>
> >
> > Cheers,
> >
> > Eduardo Valentin.
>
> Best regards,
> Lukasz Majewski
signature.asc
Description: Digital signature
On Fri, Jan 02, 2015 at 02:54:28PM -0400, Eduardo Valentin wrote:
> On Mon, Dec 22, 2014 at 05:27:41PM +0100, Lukasz Majewski wrote:
> > Odroid U3 fan can work without being registered as OF cooling device
> > (with CONFIG_THERMAL_OF disabled).
> > In this situation it can
gt; Therefore, the thermal_of_cooling_device_register() function needs a stub
> to allow clean compilation.
>
> Signed-off-by: Lukasz Majewski
Acked-by: Eduardo Valentin
> ---
> Changes for v2:
> - None
> ---
> include/linux/thermal.h | 14 +++---
> 1 file changed, 11 in
Patch subject should use a prefix like:
'arm: dts:'
On Mon, Dec 22, 2014 at 05:27:45PM +0100, Lukasz Majewski wrote:
> With those bindings it is possible to use pwm-fan device available in
> Odroid U3 as a cooling device.
>
> Signed-off-by: Lukasz Majewski
> ---
> Changes for v2:
> - Rename
On Mon, Dec 22, 2014 at 05:27:43PM +0100, Lukasz Majewski wrote:
> Several new properties to allow PWM fan working as a cooling device have been
> combined into this single commit.
>
Patch prefix should look something like 'dt-bindings: ...', or better
'Documentation: devicetree: ...', or 'Docume
On Mon, Dec 22, 2014 at 05:27:42PM +0100, Lukasz Majewski wrote:
> Odroid U3 fan can work without being registered as OF cooling device
> (with CONFIG_THERMAL_OF disabled).
> In this situation it can be controlled via PWM entry at
> /sys/class/hwmon/hwmon0/pwm1.
>
> Therefore, the thermal_cdev_upd
On Fri, Jan 02, 2015 at 02:11:41PM -0400, Eduardo Valentin wrote:
> Lukasz,
>
> On Wed, Dec 10, 2014 at 01:09:47PM +0100, Lukasz Majewski wrote:
> > Exynos 4 and 5 family of SoCs uses almost identical TMU sensor to measure
> > the
> > on chip temperature. For this rea
too. Only concern is regarding 'type' property (possible
to reuse compatible) and exynos specific data.
> delete mode 100644 drivers/thermal/samsung/exynos_thermal_common.c
> delete mode 100644 drivers/thermal/samsung/exynos_thermal_common.h
> delete mode 100644 drivers/thermal/samsung/exynos_tmu_data.c
> create mode 100644 include/dt-bindings/thermal/thermal_exynos.h
>
> --
> 2.0.0.rc2
>
Apologize for late answer.
Cheers,
Eduardo Valentin.
signature.asc
Description: Digital signature
On Wed, Dec 10, 2014 at 01:09:46PM +0100, Lukasz Majewski wrote:
> Up till now exynos_tmu_data.c was used for storing CPU cooling configuration
> data. Now the Exynos thermal core code uses device tree to get this data.
> For this purpose generic thermal code for configuring CPU cooling was
> used.
On Wed, Dec 10, 2014 at 01:09:45PM +0100, Lukasz Majewski wrote:
> Presented patch aims to move data necessary for correct CPU cooling device
> configuration from exynos_tmu_data.c to device tree.
I believe the patch title is misleading. Looks like you are changing
something at cpu cooling, but in
Lukasz
On Wed, Dec 10, 2014 at 01:09:51PM +0100, Lukasz Majewski wrote:
> Presented device tree bindings provide data already hardcoded in the
> exynos_tmu_data.c file.
> After this commit, it should be possible to reuse common thermal core
> framework in Exynos SoCs.
>
> Signed-off-by: Lukasz Ma
Lukasz,
On Wed, Dec 10, 2014 at 01:09:47PM +0100, Lukasz Majewski wrote:
> Exynos 4 and 5 family of SoCs uses almost identical TMU sensor to measure the
> on chip temperature. For this reason it is possible to group TMU configuration
> parameters in one dts file.
>
> Signed-off-by: Lukasz Majewsk
On Wed, Dec 10, 2014 at 01:09:39PM +0100, Lukasz Majewski wrote:
> 1. Introduction
>
> Following patches aim to clean up the current implementation of the thermal
> framework on Exynos devices.
>
> The main goal was to use a generic code for reading thermal configuration
> (of-thermal.c). Due to
On Thu, Dec 04, 2014 at 09:41:43AM +0530, Viresh Kumar wrote:
> From: Eduardo Valentin
>
> In this patch, the cpu_cooling code checks for the usability of cpufreq
> layer before proceeding with the CPU cooling device registration. The
> main reason is: CPU cooling device i
Russel,
On Fri, Nov 28, 2014 at 05:10:24PM +, Russell King - ARM Linux wrote:
> On Fri, Nov 28, 2014 at 10:53:30AM -0400, Eduardo Valentin wrote:
> > diff --git a/drivers/thermal/samsung/exynos_thermal_common.c
> > b/drivers/thermal/samsung/exynos_thermal_common.c
> > i
: Naveen Krishna Chatradhi
Cc: Rob Herring
Cc: Zhang Rui
Acked-by: Viresh Kumar
Signed-off-by: Eduardo Valentin
---
drivers/thermal/cpu_cooling.c | 3 +++
drivers/thermal/db8500_cpufreq_cooling.c | 5 -
drivers/thermal/imx_thermal.c | 5
Hello Folks,
On Fri, Nov 28, 2014 at 11:18:24AM +0100, Lukasz Majewski wrote:
> On Fri, 28 Nov 2014 13:35:49 +0530
> Viresh Kumar wrote:
>
> > On 27 November 2014 at 19:42, Eduardo Valentin
> > wrote:
> > > (I'm sorry VireshK, I am still using my normal
: Naveen Krishna Chatradhi
Cc: Rob Herring
Cc: Zhang Rui
Acked-by: Viresh Kumar
Signed-off-by: Eduardo Valentin
---
drivers/thermal/cpu_cooling.c | 5 +
drivers/thermal/db8500_cpufreq_cooling.c | 5 -
drivers/thermal/imx_thermal.c | 5
Hello Viresh,
On Thu, Nov 27, 2014 at 09:38:39AM +0530, Viresh Kumar wrote:
> Few nits..
>
> On 26 November 2014 at 23:20, Eduardo Valentin wrote:
>
> > Signed-off-by: Eduardo Valentin
> > ---
>
> The normal practice is to write the non-commitable part here ...
: Naveen Krishna Chatradhi
Cc: Rob Herring
Cc: Zhang Rui
Signed-off-by: Eduardo Valentin
---
drivers/thermal/cpu_cooling.c | 5 +
drivers/thermal/db8500_cpufreq_cooling.c | 5 -
drivers/thermal/imx_thermal.c | 5 -
drivers/thermal
Lukasz,
On Fri, Nov 07, 2014 at 12:20:35PM +0100, Lukasz Majewski wrote:
> Hi Eduardo,
>
> > Hello,
> >
> > On Thu, Oct 09, 2014 at 06:38:40PM +0200, Lukasz Majewski wrote:
> > > Before this change it was only possible to set get_temp() and
> > > get_trend() methods to be used in the common cod
Hello Lukasz,
On Wed, Nov 12, 2014 at 10:42:41AM +0100, Lukasz Majewski wrote:
> Hi Eduardo,
>
> >
> > Hello Lukasz,
> >
> > On Fri, Nov 07, 2014 at 11:05:51AM +0100, Lukasz Majewski wrote:
> > > Hi Eduardo,
> > >
> > > > On Thu, Oct 09, 2014 at 06:38:39PM +0200, Lukasz Majewski wrote:
> > > >
Hello Bartlomiej,
On Thu, Nov 13, 2014 at 04:00:55PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> This patch series replaces the hardware registers abstractions in
> the Exynos thermal driver by the usage of per-SoC type operations.
Good! I think the driver is a bit confusing because it h
fine.
> >
> > Cc: Naveen Krishna Chatradhi
> > Cc: Amit Daniel Kachhap
> > Cc: Lukasz Majewski
> > Cc: Eduardo Valentin
> > Cc: Zhang Rui
> > Signed-off-by: Bartlomiej Zolnierkiewicz
> > Acked-by: Kyungmin Park
> > ---
> > drivers/th
Hello Lukasz,
On Fri, Nov 07, 2014 at 11:05:51AM +0100, Lukasz Majewski wrote:
> Hi Eduardo,
>
> > On Thu, Oct 09, 2014 at 06:38:39PM +0200, Lukasz Majewski wrote:
> > > This patch extends the of-thermal.c to provide information about
> > > number of available non critical (i.e. non HW) trip poi
Hello,
On Thu, Oct 09, 2014 at 06:38:40PM +0200, Lukasz Majewski wrote:
> Before this change it was only possible to set get_temp() and get_trend()
> methods to be used in the common code handling passing parameters via
> device tree to "cpu-thermal" CPU thermal zone device.
>
> Now it is possibl
On Thu, Oct 09, 2014 at 06:38:39PM +0200, Lukasz Majewski wrote:
> This patch extends the of-thermal.c to provide information about number of
> available non critical (i.e. non HW) trip points in the system.
>
> Signed-off-by: Lukasz Majewski
> ---
> drivers/thermal/of-thermal.c | 12 +
Hello Lukasz,
On Thu, Oct 09, 2014 at 06:38:38PM +0200, Lukasz Majewski wrote:
> This patch extends the of-thermal.c to provide check if trip point is
> enabled.
>
> Signed-off-by: Lukasz Majewski
> ---
> drivers/thermal/of-thermal.c | 9 +
> drivers/thermal/thermal_core.h | 5 +
>
Hello Lukasz,
On Thu, Oct 09, 2014 at 06:38:37PM +0200, Lukasz Majewski wrote:
> This patch extends the of-thermal.c to provide information about number of
> available trip points.
>
> Signed-off-by: Lukasz Majewski
> ---
> drivers/thermal/of-thermal.c | 6 ++
> drivers/thermal/thermal_co
Hello Yadwinder,
On Thu, Nov 06, 2014 at 04:26:27PM +0530, Yadwinder Singh Brar wrote:
> Hello Eduardo Valentin,
>
> On Thursday, November 06, 2014 2:17 AM, Eduardo Valentin wrote:
> > Hello Yadwinder,
> >
> > On Wed, Nov 05, 2014 at 05:46:25PM +0530, Yadwinder Singh
ufreq_cooling_device for policy's cpu from cpufreq_dev_list
> when there is any policy update.
OK. Please give real examples of when the current code fails to catch
the event.
BR,
Eduardo Valentin
>
> Signed-off-by: Yadwinder Singh Brar
> ---
> drivers/thermal/cpu_coo
Bartlomiej,
On Thu, Sep 18, 2014 at 05:27:17PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> This patch series replaces the hardware registers abstractions in
> the Exynos thermal driver by the usage of per-SoC type operations.
> Such solution provides simpler, easier to understand code and
>
Hi,
On Wed, Sep 03, 2014 at 12:09:01PM +0900, Chanwoo Choi wrote:
> This patchset add the support of TRIMINFO_RELOAD feature for Exynos3250.
> But Exynos3250 has two TRIMINFO_CTRL register instead other Exynos has only
> one
> TRIMINFO_CTRL register. So, this patchset support the some Exynos SoC
Chanwoo,
On Fri, Aug 29, 2014 at 08:50:41AM +0900, Chanwoo Choi wrote:
> Dear Eduardo,
>
> On 08/28/2014 11:53 PM, Eduardo Valentin wrote:
> > On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote:
> >> Dear Eduardo,
> >>
> >> This patch is wrong.
On Mon, Sep 01, 2014 at 07:05:27AM -0400, edubez...@gmail.com wrote:
> Amit
>
> On Mon, Sep 1, 2014 at 6:53 AM, amit daniel kachhap
> wrote:
> > On Thu, Aug 28, 2014 at 8:19 PM, Eduardo Valentin
> > wrote:
> >> Amit,
> >>
> >> On Thu, Jul 31,
-off-by: Chanwoo Choi
> > Acked-by: Kyungmin Park
> > Cc: Zhang Rui
> > Cc: Eduardo Valentin
> > Cc: Amit Daniel Kachhap
> > Reviewed-by: Amit Daniel Kachhap
> > ---
> > drivers/thermal/samsung/exynos_tmu.c | 4 +---
> > 1 file changed, 1 insert
Amit,
On Thu, Jul 31, 2014 at 07:10:58PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> This patch series contains various cleanups for EXYNOS thermal
> driver. Overall it decreases driver's LOC by 9%. It is based
> on next-20140731 kernel. It should not cause any functionality
> changes.
>
1 - 100 of 231 matches
Mail list logo
