On Thu, Jun 27, 2013 at 09:47:47AM +0200, Andrzej Hajda wrote:
> Hi Felipe,
>
> On 06/27/2013 08:17 AM, Felipe Balbi wrote:
> > On Wed, Jun 26, 2013 at 05:00:34PM +0200, Sylwester Nawrocki wrote:
> >> Hi,
> >>
> >> On 06/25/2013 05:06 PM, Felipe Balbi wr
On Wed, Jun 26, 2013 at 05:00:34PM +0200, Sylwester Nawrocki wrote:
> Hi,
>
> On 06/25/2013 05:06 PM, Felipe Balbi wrote:
> >> +static struct platform_driver exynos_video_phy_driver = {
> >> > +.probe = exynos_video_phy_probe,
> >
> > you *must*
On Wed, Jun 26, 2013 at 02:03:42PM +0200, Sylwester Nawrocki wrote:
> On 06/26/2013 01:21 PM, Kishon Vijay Abraham I wrote:
> > +static int exynos_video_phy_probe(struct platform_device *pdev)
> > +{
> > + struct exynos_video_phy *state;
> > + struct device *dev = &
On Tue, Jun 25, 2013 at 11:47:13PM +0200, Sylwester Nawrocki wrote:
> Hi,
>
> On 06/25/2013 10:54 PM, Felipe Balbi wrote:
> >>>>+static int exynos_video_phy_probe(struct platform_device *pdev)
> >>>>> >> +{
> >>>>> >>
On Tue, Jun 25, 2013 at 10:57:06PM +0200, Tomasz Figa wrote:
> On Tuesday 25 of June 2013 23:46:32 Felipe Balbi wrote:
> > On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote:
> > > This patch adds OF match table to the driver to allow instantiating it
>
Hi,
On Tue, Jun 25, 2013 at 07:44:52PM +0200, Sylwester Nawrocki wrote:
> >> +struct exynos_video_phy {
> >> + spinlock_t slock;
> >> + struct phy *phys[NUM_PHYS];
> >
> > more than one phy ? This means you should instantiate driver multiple
> > drivers. Each phy id should call probe again.
>
On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote:
> This patch adds OF match table to the driver to allow instantiating it
> using device tree.
>
> Signed-off-by: Tomasz Figa
> Signed-off-by: Kyungmin Park
when will this driver get merged into dwc2 ?
--
balbi
signature.asc
Descri
SIM (not any upstream currently) it should use the generic
> PHY API to bind the PHYs to respective PHY consumer drivers.
>
> Signed-off-by: Sylwester Nawrocki
> Signed-off-by: Kyungmin Park
pretty cool stuff
Acked-by: Felipe Balbi
--
balbi
signature.asc
Description: Digital signature
Signed-off-by: Sylwester Nawrocki
> Signed-off-by: Kyungmin Park
Acked-by: Felipe Balbi
--
balbi
signature.asc
Description: Digital signature
>
> Signed-off-by: Sylwester Nawrocki
> Signed-off-by: Kyungmin Park
this is awesome :-)
Acked-by: Felipe Balbi
--
balbi
signature.asc
Description: Digital signature
Hi,
On Tue, Jun 25, 2013 at 04:21:46PM +0200, Sylwester Nawrocki wrote:
> +enum phy_id {
> + PHY_CSIS0,
> + PHY_DSIM0,
> + PHY_CSIS1,
> + PHY_DSIM1,
> + NUM_PHYS
please prepend these with EXYNOS_PHY_ or EXYNOS_MIPI_PHY_
> +struct exynos_video_phy {
> + spinlock_t slock;
>
On Tue, May 28, 2013 at 06:04:07PM +0900, Jingoo Han wrote:
> @@ -165,6 +174,18 @@ static void samsung_usb2phy_enable(struct samsung_usbphy
> *sphy)
> u32 phyclk;
> u32 rstcon;
>
> + switch (sphy->drv_data->cpu_type) {
> + case TYPE_EXYNOS4210:
> + atomic_inc(&sph
Hi,
On Thu, Apr 18, 2013 at 05:20:11PM +0530, Kishon Vijay Abraham I wrote:
> >Adding APIs to handle runtime power management on PHY
> >devices. PHY consumers may need to wake-up/suspend PHYs
> >when they work across autosuspend.
> >
> >Signed-off-by: Vivek Gautam
> >---
Hi,
On Thu, Apr 04, 2013 at 02:26:51PM +0530, Vivek Gautam wrote:
> >> > > Lets suppose DWC3 enables runtime_pm on USB 2 type phy,
> >> > > it will try to go into suspend state and thereby call
> >> > > runtime_suspend(), if any.
> >> > > And PHY will come to active state only when its consumer w
Hi,
On Wed, Apr 03, 2013 at 02:14:02PM -0400, Alan Stern wrote:
> > > Lets suppose DWC3 enables runtime_pm on USB 2 type phy,
> > > it will try to go into suspend state and thereby call runtime_suspend(),
> > > if any.
> > > And PHY will come to active state only when its consumer wakes it up,
>
On Thu, Apr 04, 2013 at 10:34:57AM +0530, Vivek Gautam wrote:
> Hi Sarah,
>
>
> On Wed, Apr 3, 2013 at 10:57 PM, Sarah Sharp
> wrote:
> > Question: Do you still need this patch for 3.10?
>
> Felipe's 'next' is closed for 3.10, so this series won't be making it
> to 3.10 now, as a whole. :-(
ri
Hi,
On Wed, Apr 03, 2013 at 07:40:44PM +0530, Vivek Gautam wrote:
> >> > >> >> +static inline void usb_phy_autopm_enable(struct usb_phy *x)
> >> > >> >> +{
> >> > >> >> + if (!x || !x->dev) {
> >> > >> >> + dev_err(x->dev, "no PHY or attached device
> >> > >> >> available\n");
Hi,
On Wed, Apr 03, 2013 at 04:54:14PM +0300, Felipe Balbi wrote:
> > >> >> +static inline void usb_phy_autopm_enable(struct usb_phy *x)
> > >> >> +{
> > >> >> + if (!x || !x->dev) {
> > >> >> +
HI,
On Wed, Apr 03, 2013 at 06:42:48PM +0530, Vivek Gautam wrote:
> >> >> Adding APIs to handle runtime power management on PHY
> >> >> devices. PHY consumers may need to wake-up/suspend PHYs
> >> >> when they work across autosuspend.
> >> >>
> >> >> Signed-off-by: Vivek Gautam
> >> >> ---
> >>
Hi,
On Wed, Apr 03, 2013 at 11:35:43AM +0530, Vivek Gautam wrote:
> >> The current code in the dwc3 probe effectively disables runtime pm
> >> from ever working because it calls a get() that was never put() until
> >> device removal. Change the runtime pm code to match the standard
> >> formula a
Hi,
On Wed, Apr 03, 2013 at 11:48:39AM +0530, Vivek Gautam wrote:
> >> Adding APIs to handle runtime power management on PHY
> >> devices. PHY consumers may need to wake-up/suspend PHYs
> >> when they work across autosuspend.
> >>
> >> Signed-off-by: Vivek Gautam
> >> ---
> >> include/linux/us
Hi,
On Tue, Apr 02, 2013 at 04:04:01PM +0530, Vivek Gautam wrote:
> > On Mon, Apr 01, 2013 at 07:24:00PM +0530, Vivek Gautam wrote:
> >> Adding APIs to handle runtime power management on PHY
> >> devices. PHY consumers may need to wake-up/suspend PHYs
> >> when they work across autosuspend.
> >>
On Mon, Apr 01, 2013 at 07:24:04PM +0530, Vivek Gautam wrote:
> Enabling runtime power management on dwc3-exynos
> letting dwc3 controller to be autosuspended on exynos
> platform when not in use.
>
> Signed-off-by: Vivek Gautam
> ---
> drivers/usb/dwc3/dwc3-exynos.c | 12
> 1 fil
Hi,
On Mon, Apr 01, 2013 at 07:24:03PM +0530, Vivek Gautam wrote:
> +#else
> +#define dwc3_runtime_suspend NULL
> +#define dwc3_runtime_resume NULL
this #else branch is unnecessary. Look at the definition for
SET_RUNTIME_PM_OPS()
--
balbi
signature.asc
Description: Digital si
On Mon, Apr 01, 2013 at 07:24:01PM +0530, Vivek Gautam wrote:
> The current code in the dwc3 probe effectively disables runtime pm
> from ever working because it calls a get() that was never put() until
> device removal. Change the runtime pm code to match the standard
> formula and allow runtime
On Mon, Apr 01, 2013 at 07:24:00PM +0530, Vivek Gautam wrote:
> Adding APIs to handle runtime power management on PHY
> devices. PHY consumers may need to wake-up/suspend PHYs
> when they work across autosuspend.
>
> Signed-off-by: Vivek Gautam
> ---
> include/linux/usb/phy.h | 141
>
Hi,
On Wed, Mar 27, 2013 at 02:39:08PM +0100, Tomasz Figa wrote:
> On Wednesday 27 of March 2013 15:31:49 Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Mar 27, 2013 at 02:26:08PM +0100, Tomasz Figa wrote:
> > > Hi Felipe,
> > >
> > > On Wednes
Hi,
On Wed, Mar 27, 2013 at 02:26:08PM +0100, Tomasz Figa wrote:
> Hi Felipe,
>
> On Wednesday 27 of March 2013 15:19:58 Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Mar 26, 2013 at 03:53:12PM +0100, Tomasz Figa wrote:
> > > @@ -307,6 +310,7 @@ stat
Hi,
On Tue, Mar 26, 2013 at 03:53:12PM +0100, Tomasz Figa wrote:
> @@ -307,6 +310,7 @@ static int samsung_usb3phy_remove(struct platform_device
> *pdev)
> static struct samsung_usbphy_drvdata usb3phy_exynos5 = {
> .cpu_type = TYPE_EXYNOS5250,
> .devphy_en_mask =
Hi,
On Fri, Mar 15, 2013 at 11:36:00AM +0530, Vivek Gautam wrote:
> >> Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
> >> calls as required by common clock framework.
> >>
> >> Signed-off-by: Vivek Gautam
> &
Hi,
On Thu, Mar 14, 2013 at 04:14:58PM +0530, Vivek Gautam wrote:
> Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
> calls as required by common clock framework.
>
> Signed-off-by: Vivek Gautam
> CC: Felipe Balbi
> CC: Kukjin Kim
> ---
>
Hi,
On Thu, Mar 14, 2013 at 04:14:57PM +0530, Vivek Gautam wrote:
> @@ -170,7 +155,6 @@ static int dwc3_exynos_remove(struct platform_device
> *pdev)
> {
> struct dwc3_exynos *exynos = platform_get_drvdata(pdev);
>
> - platform_device_unregister(exynos->dwc3);
don't you want to
On Wed, Mar 13, 2013 at 03:41:15PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Wed, Feb 27, 2013 at 8:13 PM, Vivek Gautam
> wrote:
> > Based on 'usb-next'
> >
> > Changes from v5:
> > - Squashed the following change from Felipe in this patch-set:
> >[PATCH] usb: phy: samsung: let it b
On Wed, Mar 13, 2013 at 02:42:22PM +0530, Vivek Gautam wrote:
> Hi Balbi,
>
>
> On Sat, Mar 2, 2013 at 6:55 PM, Vivek Gautam wrote:
> > Now that machines may select the mode of working of DWC3 (HOST only,
> > GADGET only or DUAL_ROLE), lets set DWC3 mode based on that
> > rather than fixing it t
Hi,
On Sat, Mar 02, 2013 at 06:53:02PM +0530, Vivek Gautam wrote:
> Adding APIs to handle runtime power management on PHY
> devices. PHY consumers may need to wake-up/suspend PHYs
> when they work across autosuspend.
>
> Signed-off-by: Vivek Gautam
> ---
> include/linux/usb/phy.h | 26 ++
Hi,
On Fri, Mar 01, 2013 at 08:41:29AM +0200, Felipe Balbi wrote:
> > >> >> >> Moreover, SoCs having multiple dwc3 controllers will have multiple
> > >> >> >> PHYs, which eventually be added using usb_add_phy_dev(), and not
> > >> >
Hi,
On Sun, Mar 03, 2013 at 01:21:32AM +0200, Felipe Balbi wrote:
> > I don't know much about clock handling. In general, the
> > pm_runtime_set_active() and pm_runtime_enable() parts should be done by
> > the subsystem, not the driver, whenever possible.
>
> good
Hi,
On Sat, Mar 02, 2013 at 05:02:13PM -0500, Alan Stern wrote:
> On Sat, 2 Mar 2013, Felipe Balbi wrote:
>
> > > > @@ -174,6 +177,10 @@ static int xhci_plat_remove(struct platform_device
> > > > *dev)
> > > > struct usb_hcd *hcd = platfor
Hi,
On Sat, Mar 02, 2013 at 10:53:16AM -0500, Alan Stern wrote:
> On Sat, 2 Mar 2013, Vivek Gautam wrote:
>
> > By enabling runtime pm in this driver allows users of
> > xhci-plat to enter into runtime pm. This is not full
> > runtime pm support (AKA xhci-plat doesn't actually power
> > anything
Hi,
On Thu, Feb 28, 2013 at 08:09:33PM +0530, Vivek Gautam wrote:
> On Thu, Jan 31, 2013 at 9:08 PM, Felipe Balbi wrote:
> > On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote:
> >> Hi Felipe,
> >>
> >>
> >> On Thu, Jan 31, 20
On Wed, Feb 27, 2013 at 05:47:29PM +0530, Vivek Gautam wrote:
> On Wed, Feb 27, 2013 at 5:43 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Feb 27, 2013 at 05:31:53PM +0530, Vivek Gautam wrote:
> >> Hi Felipe,
> >>
> >>
> >> On Wed, Feb 27
Hi,
On Wed, Feb 27, 2013 at 05:31:53PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi wrote:
> > There's no reason not to allow samsung PHY
> > drivers be built as modules. This patch changes
> > Kconfig to allow
There's no reason not to allow samsung PHY
drivers be built as modules. This patch changes
Kconfig to allow that.
Signed-off-by: Felipe Balbi
---
Hi,
I will take your patches but I'm planning to add this on top
as there is no reason not to allow these drivers being built
as module
On Wed, Feb 27, 2013 at 02:00:25PM +0530, Vivek Gautam wrote:
> Hi Balbi,
>
>
> On Wed, Feb 27, 2013 at 1:45 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote:
> >> Changes from v8:
> >> R
Hi,
On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote:
> Changes from v8:
> Resending this patch series after rebasing to the latest usb-next branch.
> Rewording inline comments for better readability.
> Removed IS_ENABLED(CONFIG_OF) as pdev->dev.of_node is enough to check for dt
> s
Hi,
sorry for the delay
On Mon, Jan 28, 2013 at 07:06:56PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Mon, Jan 28, 2013 at 5:15 PM, Felipe Balbi wrote:
> > On Mon, Jan 28, 2013 at 05:12:26PM +0530, Vivek Gautam wrote:
> >> The current code in the dwc3 probe e
On Tue, Feb 12, 2013 at 10:31:00PM -0800, kg...@kernel.org wrote:
> Vivek Gautam wrote:
> >
> > Based on 'usb-next'
> >
> > Changes from v4:
> > - Modifying function names and driver names to follow a common
> >naming convention.
> > "usb2phy" for samsung-usb2phy driver
> > "
On Mon, Jan 28, 2013 at 09:18:29PM +0100, Robert Jarzmik wrote:
> Felipe Balbi writes:
>
> > By simply setting a flag, we can drop some
> > boilerplate code.
> >
> > Signed-off-by: Felipe Balbi
> > ---
> > drivers/usb/gadget/pxa27x_udc.c | 9 +-
Hi,
On Fri, Feb 01, 2013 at 02:23:28PM +0530, Vivek Gautam wrote:
> >> > On Thu, Jan 31, 2013 at 08:53:27PM +0530, Vivek Gautam wrote:
> >>
> >> Moreover, SoCs having multiple dwc3 controllers will have multiple
> >> PHYs, which eventually be added using usb_add_phy_
On Fri, Feb 01, 2013 at 11:54:01AM +0530, Vivek Gautam wrote:
> Hi Balbi,
>
>
> On Fri, Feb 1, 2013 at 11:52 AM, Vivek Gautam
> wrote:
> > Hi Kishon,
> >
> >
> > On Fri, Feb 1, 2013 at 10:51 AM, kishon wrote:
> >> Hi,
> >>
> >
On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Thu, Jan 31, 2013 at 8:55 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Thu, Jan 31, 2013 at 08:53:27PM +0530, Vivek Gautam wrote:
> >> >> Moreover, SoCs having
Hi,
On Thu, Jan 31, 2013 at 08:53:27PM +0530, Vivek Gautam wrote:
> >> Moreover, SoCs having multiple dwc3 controllers will have multiple
> >> PHYs, which eventually be added using usb_add_phy_dev(), and not
> >> using usb_add_phy(). So each dwc3 controller won't be able to
> >> get PHYs by simply
On Tue, Jan 29, 2013 at 10:01:52PM -0800, Kukjin Kim wrote:
> Vivek Gautam wrote:
> >
> > Adding PHY driver support for USB 3.0 controller for Samsung's
> > SoCs.
> >
> > Signed-off-by: Vivek Gautam
> > ---
> >
> > Changes from v3:
> > - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY.
> >
On Mon, Jan 28, 2013 at 06:54:42PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Mon, Jan 28, 2013 at 6:37 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Jan 28, 2013 at 06:34:15PM +0530, Vivek Gautam wrote:
> >> >> @@ -65,7 +67,22 @@
Hi,
On Mon, Jan 28, 2013 at 06:34:15PM +0530, Vivek Gautam wrote:
> >> @@ -65,7 +67,22 @@ static u32 samsung_usb3_phy_set_refclk(struct
> >> samsung_usbphy *sphy)
> >> return reg;
> >> }
> >>
> >> -static int samsung_exynos5_usb3_phy_enable(struct samsung_usbphy *sphy)
> >> +/*
> >> + * Se
On Mon, Jan 28, 2013 at 05:57:04PM +0530, Vivek Gautam wrote:
> On Mon, Jan 28, 2013 at 5:42 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Jan 28, 2013 at 05:28:30PM +0530, Vivek Gautam wrote:
> >> >> +static int dwc3_exynos_runtime_resume(struct device *
Hi,
On Mon, Jan 28, 2013 at 05:28:30PM +0530, Vivek Gautam wrote:
> >> +static int dwc3_exynos_runtime_resume(struct device *dev)
> >> +{
> >> + struct dwc3_exynos *exynos = dev_get_drvdata(dev);
> >> + struct platform_device *pdev_dwc = exynos->dwc3;
> >> + struct dwc3
Hi,
On Mon, Jan 28, 2013 at 05:12:28PM +0530, Vivek Gautam wrote:
> Enabling runtime power management support on samsung-usb3 phy
> and further adding support to turn off the PHY ref_clk PLL.
> It thereby requires PHY ref_clk to be switched between internal
> core clock and external PLL clock.
>
On Mon, Jan 28, 2013 at 05:12:27PM +0530, Vivek Gautam wrote:
> Enabling runtime power management on dwc3-exynos to save
> power and allow its PHY's power to be managed at runtime.
>
> Signed-off-by: Vivek Gautam
> ---
> drivers/usb/dwc3/dwc3-exynos.c | 47
> ++
On Mon, Jan 28, 2013 at 05:12:26PM +0530, Vivek Gautam wrote:
> The current code in the dwc3 probe effectively disables runtime pm
> from ever working because it calls a get() that was never put() until
> device removal. Change the runtime pm code to match the standard
> formula and allow runtime
Hi,
On Thu, Jan 24, 2013 at 01:32:13PM -0800, Greg KH wrote:
> On Thu, Jan 24, 2013 at 07:15:30PM +0530, Vivek Gautam wrote:
> > Using specific chip in compatible strings. Newer SOCs can claim
> > device by using older string in the compatible list.
> >
> > Signed-off-by: Vivek Gautam
> > Acked-
On Thu, Jan 24, 2013 at 07:52:52PM +0100, Tomasz Figa wrote:
> Hi Felipe,
>
> On Thursday 24 of January 2013 17:46:10 Felipe Balbi wrote:
> > We don't need the ->register_my_device flag
> > anymore because all UDC drivers have been
> > properly converted.
> &
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/dummy_hcd.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index 95d584d..8155d4a 100644
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/imx_udc.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/usb/gadget/imx_udc.c b/drivers/usb/gadget/imx_udc.c
index a0eb857..c8b5da3 100644
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/goku_udc.c | 10 +-
drivers/usb/gadget/goku_udc.h | 3 +--
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/mv_u3d_core.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/mv_u3d_core.c b/drivers/usb/gadget/mv_u3d_core.c
index b5cea27..565addc
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/m66592-udc.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/usb/gadget/m66592-udc.c b/drivers/usb/gadget/m66592-udc.c
index 0a35db1..c5d1b39
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/mv_udc_core.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
index 67d72f9
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/r8a66597-udc.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/gadget/r8a66597-udc.c
b/drivers/usb/gadget/r8a66597-udc.c
index 5a80751
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/s3c-hsotg.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index 833d85b..bd8292d
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/renesas_usbhs/mod_gadget.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c
b/drivers/usb/renesas_usbhs/mod_gadget.c
Don't register anything non-generic under
the gadget's device as we don't really *own*
it.
Signed-off-by: Felipe Balbi
---
drivers/usb/chipidea/udc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.
We don't need the ->register_my_device flag
anymore because all UDC drivers have been
properly converted.
Let's remove every history of it.
Signed-off-by: Felipe Balbi
---
drivers/usb/chipidea/udc.c | 1 -
drivers/usb/dwc3/gadget.c | 1 -
drive
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/pxa25x_udc.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c
index fa9c344..9deffd3
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/chipidea/udc.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index f64fbea..e95e8bb 100644
--- a
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/pxa27x_udc.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/pxa27x_udc.c b/drivers/usb/gadget/pxa27x_udc.c
index f7d2579..23a3eed
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/s3c-hsudc.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
index 4a3d620..dee6810
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/s3c2410_udc.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index fc07b43..302e137
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/pch_udc.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
index a787a8e..7032145 100644
--- a
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/net2272.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/net2272.c b/drivers/usb/gadget/net2272.c
index d226058..635248f 100644
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/net2280.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index 708c0b5..630f715 100644
--- a
Fix the following compile warning:
mv_u3d_core.c:1766:12: warning: 'mv_u3d_remove' \
defined but not used [-Wunused-function]
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/mv_u3d_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/lpc32xx_udc.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
index dd1c9b1
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/fusb300_udc.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/usb/gadget/fusb300_udc.c b/drivers/usb/gadget/fusb300_udc.c
index 8c2372f
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/atmel_usba_udc.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/usb/gadget/atmel_usba_udc.c
b/drivers/usb/gadget/atmel_usba_udc.c
index
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/fsl_udc_core.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/fsl_udc_core.c
b/drivers/usb/gadget/fsl_udc_core.c
index 49642d4
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/fsl_qe_udc.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/gadget/fsl_qe_udc.c b/drivers/usb/gadget/fsl_qe_udc.c
index ec50f18
By simply setting a flag, we drop some boilerplate
code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/amd5536udc.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index 3dac001..1827d4c 100644
We don't need to register that device ourselves
if we simply set gadget->register_my_device.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/gadget.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/
Hi folks,
Please comment on this series as I need help testing it
on all UDC controllers so we can send it for v3.10 merge
window.
NOTE: I will queue this series for v3.10 merge window, so
make sure to test and comment.
cheers
Felipe Balbi (32):
usb: gadget: udc-core: allow udc class
By simply setting a flag, we can remove some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/at91_udc.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index 10f45fa..177b56d
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/bcm63xx_udc.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/bcm63xx_udc.c b/drivers/usb/gadget/bcm63xx_udc.c
index 47a4993..10b0475
By simply setting a flag, we drop some boilerplate
code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/omap_udc.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
index d0c87b1..234e82b 100644
By simply setting a flag, we can delete a little
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/musb_gadget.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index 8767874..1c4a8e8
, we're adding
a flag which will be set by UDC driver once
it removes the code for registering the
gadget device.
Once all are converted, the new flag will
be removed.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc-core.c | 23 +++
include/linux/usb/gadget.h
Hi,
On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote:
> Felipe Balbi wrote:
> > Hi,
> >
> Hi Felipe,
>
> [...]
>
> > > Right, DWC has version number, but that being the kind of USB controller
> > > (USB 2.0 and USB 3.0)
> > >
&g
HI,
On Tue, Jan 22, 2013 at 11:29:47AM +0200, Felipe Balbi wrote:
> On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote:
> > Hi Felipe,
> >
> >
> > On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi wrote:
> > > HI,
> > >
> > > On M
On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi wrote:
> > HI,
> >
> > On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote:
> >> Vivek Gautam wrote:
> >> >
HI,
On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote:
> Vivek Gautam wrote:
> >
> > Changes from v5:
> > - Rebased on top of latest patches:
> > usb: phy: samsung: Introducing usb phy driver for hsotg (v9)
> > usb: phy: samsung: Add support to set pmu isolation (v6)
> >
Hi,
On Tue, Jan 22, 2013 at 11:18:55AM +0530, Vivek Gautam wrote:
> On Tue, Jan 22, 2013 at 11:05 AM, Kukjin Kim wrote:
> > Sylwester Nawrocki wrote:
> >>
> >> On 12/24/2012 09:13 AM, Vivek Gautam wrote:
> >> These two changes look good to me. For both of them:
> >>
> >> Reviewed-
101 - 200 of 267 matches
Mail list logo
