Re: [PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-01-21 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 12:15:10PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Mon, Jan 14, 2013 at 6:29 PM, Vivek Gautam > wrote: > > Changes from v2: > > - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating > >usb 2.0 phy controller's driver for Samsung's SoCs. >

Re: [RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2013-01-18 Thread Felipe Balbi
Hi, On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote: > Changes from v8: > Resending this patch series after rebasing to the latest usb-next branch. > Rewording inline comments for better readability. > Removed IS_ENABLED(CONFIG_OF) as pdev->dev.of_node is enough to check for dt > s

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 07:59:52PM +0530, Vivek Gautam wrote: > HI Balbi, > > > On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi wrote: > > On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: > >> Hi Felipe, > >> > >> > >> On Fri, J

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote: > >> This patch adds host phy support to

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote: > This patch adds host phy support to samsung-usbphy driver and > further adds support for samsung's exynos5250 usb-phy. > > Signed-off-by: Praveen Paneri > Signed-off-by: Vivek Gautam Missing Kukjim's Acked-by here -- balbi

Re: [PATCH v6 3/4] USB: ehci-s5p: Add phy driver support

2013-01-18 Thread Felipe Balbi
On Fri, Jan 11, 2013 at 08:32:29PM +0530, Vivek Gautam wrote: > Adding the phy driver to ehci-s5p. Keeping the platform data > for continuing the smooth operation for boards which still uses it > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han Missing Alan's Acked-by here. -- balbi sig

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote: > Hi, > > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: > > This patch-set enables the samsung-usbphy driver on exynos5250, > > which enables the support for USB2 type and USB3 type phys. >

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-18 Thread Felipe Balbi
Hi, On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: > This patch-set enables the samsung-usbphy driver on exynos5250, > which enables the support for USB2 type and USB3 type phys. > The corresponding phy driver patches are available at: > 1) https://lkml.org/lkml/2012/12/18/201 > 2

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 06:10:48PM +0530, Vivek Gautam wrote: > Hi Doug, > > Sorry!! for the delayed response. > > > On Thu, Dec 20, 2012 at 4:31 AM, Doug Anderson wrote: > > Vivek, > > > > I don't really have a good 1 foot view about how all of the USB > > bits fit together, but a fe

Re: [PATCH 2/2] i2c-exynos5: add debugfs support for registers

2012-12-27 Thread Felipe Balbi
On Tue, Dec 25, 2012 at 04:55:55PM +0530, Naveen Krishna Chatradhi wrote: > This patch replaces the dev_vdbg with debugfs function calls > in i2c-exynos5.c driver. > > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v1: > The debugfs implementation is a sugge

Re: [PATCH 1/2] i2c: exynos5: add High Speed I2C controller driver

2012-12-27 Thread Felipe Balbi
kgyun Ko > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v1: > Fixed the comments from Felipe Balbi and Thomas Abraham. > > drivers/i2c/busses/Kconfig |7 + > drivers/i2c/busses/Makefile |1 + >

Re: [PATCH 2/2] i2c-exynos5: add debugfs support for registers

2012-12-27 Thread Felipe Balbi
On Tue, Dec 25, 2012 at 04:55:55PM +0530, Naveen Krishna Chatradhi wrote: > This patch replaces the dev_vdbg with debugfs function calls > in i2c-exynos5.c driver. > > Signed-off-by: Naveen Krishna Chatradhi merge with previous -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-19 Thread Felipe Balbi
Hi, On Wed, Dec 19, 2012 at 11:52:01AM +0530, Vivek Gautam wrote: > >>> @@ -736,7 +1035,41 @@ static int __devinit samsung_usbphy_probe(struct > >>> platform_device *pdev) > >>> > >>> sphy->clk = clk; > >>> > >>> - return usb_add_phy(&sphy->phy, USB_PHY_TYPE_USB2); > >>> + sphy->has

Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-18 Thread Felipe Balbi
On Tue, Dec 18, 2012 at 08:40:26PM +0530, Vivek Gautam wrote: > Adding support for USB3.0 phy for dwc3 controller on > exynos5250 SOC. > > Signed-off-by: Vivek Gautam > --- > drivers/usb/phy/samsung-usbphy.c | 339 > +- let's make the phy names standard from

Re: [PATCH 1/3] i2c: exynos5: add High Speed I2C controller driver

2012-11-27 Thread Felipe Balbi
Hi, On Tue, Nov 27, 2012 at 06:30:34PM +0530, Naveen Krishna Chatradhi wrote: > diff --git a/drivers/i2c/busses/i2c-exynos5.c > b/drivers/i2c/busses/i2c-exynos5.c > new file mode 100644 > index 000..5983aa9 > --- /dev/null > +++ b/drivers/i2c/busses/i2c-exynos5.c > @@ -0,0 +1,758 @@ > +/* lin

Re: [PATCH 431/493] usb: remove use of __devexit

2012-11-19 Thread Felipe Balbi
Hi, On Mon, Nov 19, 2012 at 01:26:20PM -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option so __devexit is no > longer needed. > > Signed-off-by: Bill Pemberton > Cc: Peter Korsgaard > Cc: Alexander Shishkin > Cc: Felipe Balbi > Cc: Li Yang

Re: [PATCH 159/493] usb: remove use of __devinit

2012-11-19 Thread Felipe Balbi
Hi, On Mon, Nov 19, 2012 at 01:21:48PM -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option so __devinit is no longer > needed. > > Signed-off-by: Bill Pemberton > Cc: Peter Korsgaard > Cc: Alexander Shishkin > Cc: Felipe Balbi > Cc: Li Yang

Re: [PATCH 119/493] usb: remove use of __devexit_p

2012-11-19 Thread Felipe Balbi
Hi, On Mon, Nov 19, 2012 at 01:21:08PM -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer > needed. > > Signed-off-by: Bill Pemberton > Cc: Peter Korsgaard > Cc: Alexander Shishkin > Cc: Felipe Balbi > Cc: Li Yang

Re: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2012-11-09 Thread Felipe Balbi
Hi, On Fri, Nov 09, 2012 at 06:50:44PM +0530, Praveen Paneri wrote: > Hi, > > On Fri, Nov 9, 2012 at 6:06 PM, Kyungmin Park wrote: > > On Fri, Nov 9, 2012 at 8:54 PM, Felipe Balbi wrote: > >> Hi, > >> > >> On Tue, Oct 30, 2012 at 10:27:32AM +0530, P

Re: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2012-11-09 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 10:27:32AM +0530, Praveen Paneri wrote: > Changes from v6: > Modified register definitions according to the existing ones. > Changed default PHY clk selection for SoCs. > Improved binding text and rebased to the latest usb-next. > > Changes from v5: > Moved clk_get() t

Re: [PATCH v4 1/5] ARM: EXYNOS: Update & move usb-phy types to generic include layer

2012-11-08 Thread Felipe Balbi
On Tue, Nov 06, 2012 at 08:24:55PM +0530, Vivek Gautam wrote: > Updating the names of usb-phy types to more generic names: > USB_PHY_TYPE_DEIVCE & USB_PHY_TYPE_HOST; and further update its > dependencies. > > Signed-off-by: Praveen Paneri > Signed-off-by: Vivek Gautam Kukjin, I need your ack on

Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-07 Thread Felipe Balbi
Hi, On Wed, Nov 07, 2012 at 06:55:03PM +0530, Vivek Gautam wrote: > Hi, > > > On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi wrote: > > On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: > >> Adding DWC3 device tree node for Exynos5250 along with the &g

Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-06 Thread Felipe Balbi
On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: > Adding DWC3 device tree node for Exynos5250 along with the > device address and clock support needed for the controller. > > Signed-off-by: Vivek Gautam > --- > arch/arm/boot/dts/exynos5250.dtsi |6 ++ > arch/arm/mach-

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-11-06 Thread Felipe Balbi
Hi, On Tue, Nov 06, 2012 at 07:23:12PM +0530, Vivek Gautam wrote: > Hi Balbi, > > > On Tue, Nov 6, 2012 at 6:44 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: > >> This patchset is based on the

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-11-06 Thread Felipe Balbi
Hi, On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: > This patchset is based on the work by Praveen Paneri for > samsung-usbphy driver: > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653 > > Changes from v2: > - Using "EXYNOS5_PHY_" as common prefix along with exact n

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 04:07:23PM +0200, Felipe Balbi wrote: > Hi, > > On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: > > This patchset is based on the work by Praveen Paneri for > > samsung-usbphy driver: > > http://comments.gmane.org/gmane.lin

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-10-31 Thread Felipe Balbi
Hi, On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: > This patchset is based on the work by Praveen Paneri for > samsung-usbphy driver: > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653 > > Changes from v2: > - Using "EXYNOS5_PHY_" as common prefix along with exact n

Re: [PATCH v7 2/5] usb: s3c-hsotg: Adding phy driver support

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 10:27:34AM +0530, Praveen Paneri wrote: > @@ -3501,20 +3511,27 @@ static int __devinit s3c_hsotg_probe(struct > platform_device *pdev) > int ret; > int i; > > - plat = pdev->dev.platform_data; > - if (!plat) { > - dev_err(&pdev->dev, "

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-15 Thread Felipe Balbi
On Fri, Oct 12, 2012 at 03:45:34PM +0530, Praveen Paneri wrote: > platform_set_drvdata() required for driver's remove function, so adding > it back. > > From v6: > Added TODO for phy bindings with controller > Dropped platform_set_drvdata() from driver probe > > This driver uses usb_phy interface

Re: [PATCH v4 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2012-08-10 Thread Felipe Balbi
On Fri, Aug 10, 2012 at 01:04:48PM +0530, Praveen Paneri wrote: > On Fri, Aug 10, 2012 at 12:36 PM, Felipe Balbi wrote: > > On Fri, Aug 10, 2012 at 12:40:26PM +0530, Praveen Paneri wrote: > >> Changes from v3: > >> Replaced susbsys_initcall()/module_exit(

Re: [PATCH v4 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2012-08-10 Thread Felipe Balbi
On Fri, Aug 10, 2012 at 12:40:26PM +0530, Praveen Paneri wrote: > Changes from v3: > Replaced susbsys_initcall()/module_exit() by module_platform_driver(). > Accordingly in the hsotg driver returned -EPROBE_DEFER until phy driver > is registered > Removed unnecessary devm_usb_put_phy() call from th

Re: [PATCH v4 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-08-10 Thread Felipe Balbi
Hi, On Fri, Aug 10, 2012 at 12:40:27PM +0530, Praveen Paneri wrote: > This driver uses usb_phy interface to interact with s3c-hsotg. Supports > phy_init and phy_shutdown functions to enable/disable phy. Tested with > smdk6410 and smdkv310. More SoCs can be brought under later. > > Signed-off-by:

Re: [PATCH v3 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2012-08-09 Thread Felipe Balbi
HI, On Fri, Aug 10, 2012 at 11:17:29AM +0530, Praveen Paneri wrote: > On Fri, Aug 10, 2012 at 7:03 AM, Joonyoung Shim > wrote: > > Hi, Praveen. > > > > > > On 08/08/2012 04:40 PM, Praveen Paneri wrote: > >> > >> Changes from v2: > >> Changed the driver filenames to samsung-usbphy > >> Changed 's

Re: [PATCH v3 2/5] usb: s3c-hsotg: Adding phy driver support

2012-08-09 Thread Felipe Balbi
On Wed, Aug 08, 2012 at 01:10:58PM +0530, Praveen Paneri wrote: > @@ -3689,6 +3706,9 @@ static int __devexit s3c_hsotg_remove(struct > platform_device *pdev) > s3c_hsotg_phy_disable(hsotg); > regulator_bulk_free(ARRAY_SIZE(hsotg->supplies), hsotg->supplies); > > + if (hsotg->phy)

Re: [PATCH v3 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-08-09 Thread Felipe Balbi
On Wed, Aug 08, 2012 at 01:10:57PM +0530, Praveen Paneri wrote: > +static int __init samsung_usbphy_driver_init(void) > +{ > + return platform_driver_register(&samsung_usbphy_driver); > +} > +subsys_initcall(samsung_usbphy_driver_init); let's make use of the module_platform_driver() and have d

Re: [PATCH] usb: gadget: s3c-hsotg: fix kernel panic

2012-03-21 Thread Felipe Balbi
Hi, On Mon, Mar 19, 2012 at 05:52:08PM +0100, Lukasz Majewski wrote: > On Fri, 16 Mar 2012 13:35:20 + > Sangwook Lee wrote: > > > Fix kernel panic from s3c_hsotg_udc_stop. > > if udc_is_newstyle is true, s3c_hsotg_udc_stop should not > > call disconnect, unbind. > > > > As running rmmod g_ma

Re: [PATCH 06/12] ARM: S3C24XX: change the ARCH_S3C2410 to ARCH_S3C24XX

2012-02-16 Thread Felipe Balbi
2 +- > drivers/rtc/Kconfig |2 +- > drivers/spi/Kconfig |2 +- > drivers/usb/Kconfig |2 +- > drivers/usb/gadget/Kconfig|4 ++-- for the gadget part: Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [PATCH 1/4] [SCSI] ufshcd: UFS Host controller driver

2012-02-06 Thread Felipe Balbi
Hi, On Thu, Feb 02, 2012 at 10:27:26AM +0530, Vinayak Holikatti wrote: > +/** > + * ufshcd_uic_cc_handler - handle UIC command completion > + * @work: pointer to a work queue structure > + * > + * Returns 0 on success, non-zero value on failure > + */ > +static void ufshcd_uic_cc_handler (struct w

Re: [PATCH 3/3] USB: EXYNOS USB3.0 device controller driver

2012-02-06 Thread Felipe Balbi
Hi, (please don't top-post) On Tue, Feb 07, 2012 at 03:31:31PM +0900, Anton Tikhomirov wrote: > I'm sorry for the misunderstanding from our side. We will implement > the glue layer for our Exynos SoC and reuse the dwc3 driver. no problem. You could have saved a few months worth of work ;-) --

Re: [PATCH 3/3] USB: EXYNOS USB3.0 device controller driver

2012-02-06 Thread Felipe Balbi
Hi, On Mon, Feb 06, 2012 at 05:13:28PM +0900, Anton Tikhomirov wrote: > Cc: Kukjin Kim samsung.com> > Cc: Greg Kroah-Hartman suse.de> > Cc: Felipe Balbi ti.com> you can add the correct email, actually, but they should follow your Signed-off-by line. > > Adds Exynos

Re: [PATCH 3/3] S3C2443: add power domain for usb phy

2012-01-24 Thread Felipe Balbi
On Tue, Jan 24, 2012 at 02:27:21PM +0100, Heiko Stübner wrote: > Am Dienstag, 24. Januar 2012, 14:07:56 schrieb Felipe Balbi: > > Hi, > > > > On Tue, Jan 24, 2012 at 10:01:33PM +0900, Kukjin Kim wrote: > > > Heiko Stübner wrote: > > > > Am Dienstag, 24.

Re: [PATCH 3/3] S3C2443: add power domain for usb phy

2012-01-24 Thread Felipe Balbi
Hi, On Tue, Jan 24, 2012 at 10:01:33PM +0900, Kukjin Kim wrote: > Heiko Stübner wrote: > > > > Am Dienstag, 24. Januar 2012, 11:15:11 schrieb Felipe Balbi: > > > On Tue, Jan 24, 2012 at 11:13:00AM +0100, Heiko Stübner wrote: > > > > sorry for mail spam :-) >

Re: [PATCH 3/3] S3C2443: add power domain for usb phy

2012-01-24 Thread Felipe Balbi
On Tue, Jan 24, 2012 at 11:13:00AM +0100, Heiko Stübner wrote: > sorry for mail spam :-) > > Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko Stübner wrote: > > > Hi Felipe, > > > > > > Am D

Re: [PATCH 3/3] S3C2443: add power domain for usb phy

2012-01-24 Thread Felipe Balbi
On Tue, Jan 24, 2012 at 11:09:48AM +0100, Heiko Stübner wrote: > Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko Stübner wrote: > > > Hi Felipe, > > > > > > Am Dienstag, 24. Januar 2012, 10:38

Re: [PATCH 3/3] S3C2443: add power domain for usb phy

2012-01-24 Thread Felipe Balbi
On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko Stübner wrote: > Hi Felipe, > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > Hi, > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko Stübner wrote: > > > The phy-power-handling is common

Re: [PATCH 3/3] S3C2443: add power domain for usb phy

2012-01-24 Thread Felipe Balbi
3c-hsudc driver. > > Signed-off-by: Heiko Stuebner I believe this doesn't really depend on previous patches (??) In that case, it can be carried with s3c's tree: Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [PATCH 2/3] s3c-hsudc: add basic runtime_pm calls

2012-01-24 Thread Felipe Balbi
On Sun, Jan 08, 2012 at 09:58:28PM +0100, Heiko Stübner wrote: > This will enable the system to check for activity of the usb gadget > and also in a later patch to control the usbphy power-domain. > When handling the power domain there, it will be possible to remove > another reference to architect

Re: [PATCH 1/3] s3c-hsudc: Use helper functions instead of generic container_of

2012-01-24 Thread Felipe Balbi
On Sun, Jan 08, 2012 at 09:57:55PM +0100, Heiko Stübner wrote: > The helper functions were definied but never used until now. > > Signed-off-by: Heiko Stuebner applied, thanks -- balbi signature.asc Description: Digital signature

Re: [PATCH 1/8] s3c-hsudc: move platform_data struct to global header

2011-12-21 Thread Felipe Balbi
On Wed, Dec 21, 2011 at 01:06:14PM +0900, Kukjin Kim wrote: > Heiko Stübner wrote: > > > > Am Dienstag, 20. Dezember 2011, 12:25:00 schrieb Felipe Balbi: > > > Hi, > > > > > > On Mon, Dec 19, 2011 at 07:39:15PM +0100, Heiko Stübner wrote: > >

Re: [PATCH 7/8] s3c-hsudc: use release_mem_region instead of release_resource

2011-12-20 Thread Felipe Balbi
On Tue, Dec 20, 2011 at 08:10:49PM +, Russell King - ARM Linux wrote: > On Mon, Dec 19, 2011 at 07:42:52PM +0100, Heiko Stübner wrote: > > As the memory region is requested through request_mem_region > > use the correct paired method to release it in the error path > > and don't go "beneath the

Re: [PATCH 8/8] s3c-hsudc: remove the_controller global

2011-12-20 Thread Felipe Balbi
On Mon, Dec 19, 2011 at 07:43:35PM +0100, Heiko Stübner wrote: > Instead use container_of to retrieve the s3c_hsudc from the > struct usb_gadget pointer. > > Signed-off-by: Heiko Stuebner > --- > drivers/usb/gadget/s3c-hsudc.c | 11 ++- > 1 files changed, 6 insertions(+), 5 deletions(-

Re: [PATCH 8/8] s3c-hsudc: remove the_controller global

2011-12-20 Thread Felipe Balbi
Hi, On Mon, Dec 19, 2011 at 07:43:35PM +0100, Heiko Stübner wrote: > Instead use container_of to retrieve the s3c_hsudc from the > struct usb_gadget pointer. > > Signed-off-by: Heiko Stuebner aha, it's here. So I replied too fast. Sorry about that and thanks for doing this. -- balbi signatu

Re: [PATCH 1/8] s3c-hsudc: move platform_data struct to global header

2011-12-20 Thread Felipe Balbi
Hi, On Mon, Dec 19, 2011 at 07:39:15PM +0100, Heiko Stübner wrote: > Gadget drivers should be compilable on all architectures. > This patch removes one dependency on architecture-specific code. > > Signed-off-by: Heiko Stuebner > --- > arch/arm/mach-s3c2416/mach-smdk2416.c|1 + > arch/a

Re: [PATCH 5/8] s3c-hsudc: use udc_start and udc_stop functions

2011-12-20 Thread Felipe Balbi
Hi, On Mon, Dec 19, 2011 at 07:41:45PM +0100, Heiko Stübner wrote: > udc_start and udc_stop reduce code duplication in comparison to > start and stop generalising calls done by all drivers > (i.e. bind and unbind) and moving these calls to common code. > > Signed-off-by: Heiko Stuebner > --- >

Re: [PATCH 5/7] s3c-hsudc: use udc_start and udc_stop functions

2011-12-19 Thread Felipe Balbi
On Mon, Dec 19, 2011 at 02:26:20PM +0100, Heiko Stübner wrote: > udc_start and udc_stop reduce code duplication in comparison to > start and stop generalising calls done by all drivers > (i.e. bind and unbind) and moving these calls to common code. > > Signed-off-by: Heiko Stuebner > --- > drive

Re: [PATCH 2/7] s3c-hsudc: add __devinit to probe function

2011-12-19 Thread Felipe Balbi
On Mon, Dec 19, 2011 at 02:24:57PM +0100, Heiko Stübner wrote: I need a commit log, even if it's an obvious one. Sorry for the nit-picking. > Signed-off-by: Heiko Stuebner > --- > drivers/usb/gadget/s3c-hsudc.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/driv

Re: [PATCH 1/7] s3c-hsudc: move platform_data struct to global header

2011-12-19 Thread Felipe Balbi
Hi, On Mon, Dec 19, 2011 at 02:24:24PM +0100, Heiko Stübner wrote: > diff --git a/include/linux/usb/s3c-hsudc.h b/include/linux/usb/s3c-hsudc.h > new file mode 100644 > index 000..6fa1093 > --- /dev/null > +++ b/include/linux/usb/s3c-hsudc.h > @@ -0,0 +1,34 @@ > +/* > + * S3C24XX USB 2.0 High-

Re: [PATCH] backlight: add regulator support for platform_lcd driver

2011-12-05 Thread Felipe Balbi
Hi, On Mon, Dec 05, 2011 at 02:18:41PM +0530, Thomas Abraham wrote: > The power source to the lcd panel or the lcd interface such as lvds > transmitters could be controlled by a regulator supply. Add support > for enabling/disabling the regulator when switching power to lcd. > > Two new elements

Re: [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations

2011-08-11 Thread Felipe Balbi
Hi, On Thu, Aug 11, 2011 at 04:07:18PM +0100, Russell King - ARM Linux wrote: > On Thu, Aug 11, 2011 at 05:15:31PM +0300, Felipe Balbi wrote: > > On Tue, Aug 09, 2011 at 09:08:01AM +0100, Russell King - ARM Linux wrote: > > > diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/

Re: [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations

2011-08-11 Thread Felipe Balbi
On Tue, Aug 09, 2011 at 09:08:01AM +0100, Russell King - ARM Linux wrote: > Consolidate 24 trivial gpiolib implementions out of mach/gpio.h > into asm/gpio.h. This is basically the include of asm-generic/gpio.h > and the definition of gpio_get_value, gpio_set_value, and gpio_cansleep > as describe

Re: [RFC][PATCH 4/5] ARM: S5P64x0: Adding OTG PHY control code

2011-07-06 Thread Felipe Balbi
Hi, On Wed, Jul 06, 2011 at 11:03:10AM +0530, Praveen Paneri wrote: > >> > drivers should not live in arch/arm/*, why don't you move this to > >> > drivers/usb/otg where the PHYs are staying right now ? > >> PHY init/exit code can vary across SoCs. Wouldn't it be better to have it > >> in the > >

Re: [RFC][PATCH 4/5] ARM: S5P64x0: Adding OTG PHY control code

2011-06-22 Thread Felipe Balbi
Hi, On Wed, Jun 22, 2011 at 01:56:25PM +0530, Praveen Paneri wrote: > > > diff --git a/arch/arm/mach-s5p64x0/Makefile > > > b/arch/arm/mach-s5p64x0/Makefile > > > index ae6bf6f..611fb3a 100644 > > > --- a/arch/arm/mach-s5p64x0/Makefile > > > +++ b/arch/arm/mach-s5p64x0/Makefile > > > @@ -28,3 +28

Re: [RFC][PATCH 2/5] ARM: SAMSUNG: Changing the build condition of OTG platform device for samsung.

2011-06-21 Thread Felipe Balbi
Hi, On Tue, Jun 21, 2011 at 05:20:25PM +0530, Praveen Paneri wrote: > > > @@ -37,7 +39,12 @@ static struct resource s3c_usb_hsotg_resources[] = { > > >  static u64 s3c_hsotg_dmamask = DMA_BIT_MASK(32); > > > > > >  struct platform_device s3c_device_usb_hsotg = { > > > +#ifdef CONFIG_S3C_DEV_USB_HS

Re: [RFC][PATCH 2/5] ARM: SAMSUNG: Changing the build condition of OTG platform device for samsung.

2011-06-21 Thread Felipe Balbi
Hi, On Tue, Jun 21, 2011 at 03:47:04PM +0400, Sergei Shtylyov wrote: > Hello. > > On 21-06-2011 11:03, p.pan...@samsung.com wrote: > > >From: Praveen Paneri > > >Adding dwc driver name in existing platform device > >to probe DWC OTG driver. > >Introduced otg_set_platdata function to pass platfo

Re: [RFC][PATCH 4/5] ARM: S5P64x0: Adding OTG PHY control code

2011-06-21 Thread Felipe Balbi
Hi, On Tue, Jun 21, 2011 at 12:33:46PM +0530, p.pan...@samsung.com wrote: > From: Praveen Paneri > > A generic method to initialize and exit OTG PHY which can be > used for all the samsung SoCs. > OTG platdata structure added in platform to pass required > platform specific functions and data to

Re: [RFC][PATCH 1/5] USB: DWC OTG: Modification in DWC OTG driver for ARM based SoCs.

2011-06-21 Thread Felipe Balbi
Hi, On Tue, Jun 21, 2011 at 12:33:43PM +0530, p.pan...@samsung.com wrote: > From: Praveen Paneri > > This patch modifies DWC OTG for ARM based SoCs. Currently it has > been tested for Samsung S5P6440. Can easily be built for others > as well. > > Following features are tested for basic function

Re: [RFC][PATCH 2/5] ARM: SAMSUNG: Changing the build condition of OTG platform device for samsung.

2011-06-21 Thread Felipe Balbi
Hi, On Tue, Jun 21, 2011 at 12:33:44PM +0530, p.pan...@samsung.com wrote: > From: Praveen Paneri > > Adding dwc driver name in existing platform device > to probe DWC OTG driver. > Introduced otg_set_platdata function to pass platform data > Added selectable config option to add DWC OTG driver f

<    1   2   3