Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-16 Thread Guennadi Liakhovetski
> + reg1: regulator@1 { > + }; > + > +/* SoC properties */ > + > + csis@1188 { > + compatible = "samsung,exynos4210-csis"; > + reg = <0x1188 0x1000>; > + interrupts = <0 78 0>; > + cell-inde

Re: [RFC/PATCH 04/13] devicetree: Add common video devices bindings documentation

2012-07-16 Thread Guennadi Liakhovetski
etrieve this information. 4. sync signals are available and supported by both peers, but for some reason the user prefers to use embedded sync data - is such a case feasible? Even if so, this should be run-time configurable then? So, maybe we don't need these at all. Thanks Guennadi

Re: [RFC/PATCH 05/13] media: s5p-fimc: Add device tree support for FIMC devices

2012-07-16 Thread Guennadi Liakhovetski
> + reg = <0x1188 0x1000>; > + interrupts = <0 78 0>; > + cell-index = <0>; > + }; > + > + camera { > + compatible = "samsung,fimc"; > + #address-cells = <1>; > +

Re: [RFC/PATCH 06/13] media: s5p-fimc: Add device tree support for FIMC-LITE

2012-07-16 Thread Guennadi Liakhovetski
of the device's memory > mapped > +registers; > +- interrupts : should contain FIMC-LITE interrupt; > +- cell-index : FIMC-LITE IP instance index; Same as in an earlier patch - not sure this is needed. Thanks Guennadi > + > + > Example: > > fimc0:

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-16 Thread Guennadi Liakhovetski
= <&gpl2 0 2 0 3>; > + gpio-stby = <&gpl2 1 2 0 3>; > + video-itu-601-bus; > + vdd_core-supply = <®0>; > + vdda-supply = <®1>; > + vdd_reg-supply = <®2>; > + vddio-supply = <®3>; > + }; Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH 12/13] media: s5p-fimc: Add device tree based sensors registration

2012-07-16 Thread Guennadi Liakhovetski
camclk-id : the SoC CAM_MCLK clock output index. These clocks > +are master clocks for external image processors. > +If this property is not specified a default 0 value > + will be used by driver. > + > + "video-bus-type" and &quo

Re: [RFC/PATCH 06/13] media: s5p-fimc: Add device tree support for FIMC-LITE

2012-07-18 Thread Guennadi Liakhovetski
Hi Sylwester On Tue, 17 Jul 2012, Sylwester Nawrocki wrote: > On 07/16/2012 11:15 AM, Guennadi Liakhovetski wrote: > > > --- a/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt > > > +++ b/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt > > &g

Re: [RFC/PATCH 05/13] media: s5p-fimc: Add device tree support for FIMC devices

2012-07-18 Thread Guennadi Liakhovetski
On Tue, 17 Jul 2012, Sylwester Nawrocki wrote: > On 07/16/2012 11:13 AM, Guennadi Liakhovetski wrote: > > On Fri, 25 May 2012, Sylwester Nawrocki wrote: > > > >> Signed-off-by: Sylwester Nawrocki > >> Signed-off-by: Karol Lewandowski > >> Signe

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-31 Thread Guennadi Liakhovetski
On Thu, 26 Jul 2012, Laurent Pinchart wrote: > Hi Sylwester, > > On Tuesday 17 July 2012 20:16:23 Sylwester Nawrocki wrote: > > On 07/16/2012 10:55 AM, Guennadi Liakhovetski wrote: > > > Hi Sylwester > > > > > > Thanks for your comments to my RFC and f

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-31 Thread Guennadi Liakhovetski
On Thu, 26 Jul 2012, Laurent Pinchart wrote: > Hi Sylwester, > > On Wednesday 18 July 2012 11:18:33 Sylwester Nawrocki wrote: > > On 07/16/2012 11:42 AM, Guennadi Liakhovetski wrote: > > > On Fri, 25 May 2012, Sylwester Nawrocki wrote: > > >> The driver init

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-31 Thread Guennadi Liakhovetski
g, not the global SoC pin function configuration? Thanks Guennadi > > > For receivers that can't reroute lanes internally, the data-lanes property > > > would be need to specify lanes in sequence. > > > > > > data-lanes =<1 2 3>; > > > >

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-31 Thread Guennadi Liakhovetski
On Tue, 31 Jul 2012, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday 31 July 2012 11:56:44 Guennadi Liakhovetski wrote: > > On Thu, 26 Jul 2012, Laurent Pinchart wrote: > > > On Wednesday 18 July 2012 11:18:33 Sylwester Nawrocki wrote: > > > > On 07/16/

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-31 Thread Guennadi Liakhovetski
On Tue, 31 Jul 2012, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday 31 July 2012 13:14:13 Guennadi Liakhovetski wrote: > > On Tue, 31 Jul 2012, Laurent Pinchart wrote: > > > On Tuesday 31 July 2012 11:56:44 Guennadi Liakhovetski wrote: > > > > On Thu,

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-31 Thread Guennadi Liakhovetski
On Tue, 31 Jul 2012, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday 31 July 2012 13:29:55 Guennadi Liakhovetski wrote: > > On Tue, 31 Jul 2012, Laurent Pinchart wrote: > > > On Tuesday 31 July 2012 13:14:13 Guennadi Liakhovetski wrote: > > > > On Tue,

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-31 Thread Guennadi Liakhovetski
On Tue, 31 Jul 2012, Sylwester Nawrocki wrote: > On 07/31/2012 02:26 PM, Guennadi Liakhovetski wrote: > >>>> But should we allow host probe() to succeed if the sensor isn't present ? > >>> > >>> I think we should, yes. The host hardware is there an

Re: [PATCH RFC v2 01/15] [media] Add common video interfaces OF bindings documentation

2013-01-02 Thread Guennadi Liakhovetski
Hi Sylwester Thanks for picking up these patches! In general both look good to me, just a couple of nit-picks, that I couldn't help remarking:-) On Mon, 31 Dec 2012, Sylwester Nawrocki wrote: > From: Guennadi Liakhovetski > > This patch adds a document describing common OF bind

Re: [PATCH RFC v2 02/15] [media] Add a V4L2 OF parser

2013-01-02 Thread Guennadi Liakhovetski
4l2-of.c > @@ -0,0 +1,249 @@ > +/* > + * V4L2 OF binding parsing library > + * > + * Copyright (C) 2012 Renesas Electronics Corp. > + * Author: Guennadi Liakhovetski > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms o

Re: [PATCH RFC v2 01/15] [media] Add common video interfaces OF bindings documentation

2013-01-02 Thread Guennadi Liakhovetski
Hi Sylwester On Wed, 2 Jan 2013, Sylwester Nawrocki wrote: > Hi Guennadi, > > On 01/02/2013 12:31 PM, Guennadi Liakhovetski wrote: > > Hi Sylwester > > > > Thanks for picking up these patches! In general both look good to me, just > > a couple of nit-pick

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-19 Thread Guennadi Liakhovetski
if (IS_ERR(clk)) return -EPROBE_DEFER; /* * enable the clock - this needs a subdev pointer, that we stored * in the clock object for the bridge driver to use with * v4l2_clk_get() above */ v4l2_clk_enable(clk); do_probe();

Re: [PATCH 3/7] mmc: dw_mmc: add device tree support

2012-05-03 Thread Guennadi Liakhovetski
if (IS_ERR(host->pdata)) { > + dev_err(&host->dev, "platform data not available\n"); > + return -EINVAL; > + } > } > > if (!host->pdata->select_slot && host->pdata->num_slots

Re: [PATCH 3/7] mmc: dw_mmc: add device tree support

2012-05-12 Thread Guennadi Liakhovetski
Hi Thomas On Sat, 12 May 2012, Thomas Abraham wrote: > On 4 May 2012 04:18, Guennadi Liakhovetski wrote: > > > > What do you think about this patch > > > > http://www.spinics.net/lists/linux-sh/msg11259.html > > > > and about using mmc-generic OF pro

Re: [PATCH v2] mmc: dt: Consolidate DT bindings

2012-05-13 Thread Guennadi Liakhovetski
++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -402,7 +402,7 @@ sdhci_esdhc_imx_probe_dt(struct platform_device *pdev, > if (!np) > return -ENODEV; > > - if (of_get_property(np, "fsl,card-wired", NULL)) > + if (of_get_property(np, "non-removable"