Re: [RESEND PATCH 8/8] mfd: cros_ec: add bus-specific proto v3 code

2015-04-25 Thread Gwendal Grignou
Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou On Mon, Apr 6, 2015 at 9:15 AM, Javier Martinez Canillas wrote: > From: Stephen Barber > > Add proto v3 support to the SPI, I2C, and LPC. > > Signed-off-by: Stephen Barber > Signed-off-by: Javier Martinez Canillas &g

Re: [RESEND PATCH 7/8] mfd: cros_ec: add proto v3 skeleton

2015-04-25 Thread Gwendal Grignou
You can merge change https://chromium-review.googlesource.com/#/c/262870/ with it, that fixes an issue with newer firmware. Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou On Mon, Apr 6, 2015 at 9:15 AM, Javier Martinez Canillas wrote: > From: Stephen Barber > > Add s

Re: [RESEND PATCH 6/8] mfd: cros_ec: rev cros_ec_commands.h

2015-04-25 Thread Gwendal Grignou
Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou On Mon, Apr 6, 2015 at 9:15 AM, Javier Martinez Canillas wrote: > From: Stephen Barber > > Update cros_ec_commands.h to the latest version in the EC > firmware sources and add power domain and passthru commands. > > Als

Re: [RESEND PATCH 3/8] mfd: cros_ec: Instantiate sub-devices from device tree

2015-04-25 Thread Gwendal Grignou
Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou On Mon, Apr 6, 2015 at 9:15 AM, Javier Martinez Canillas wrote: > From: Todd Broch > > If the EC device tree node has sub-nodes, try to instantiate them as > MFD sub-devices. We can configure the EC features provided

Re: [RESEND PATCH 2/8] platform/chrome: cros_ec_lpc - Use existing function to check EC result

2015-04-25 Thread Gwendal Grignou
Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou On Mon, Apr 6, 2015 at 9:15 AM, Javier Martinez Canillas wrote: > Commit 6db07b633658 ("mfd: cros_ec: Check result code from EC messages") > added a common cros_ec_check_result() function that can be used to check > the

Re: [RESEND PATCH 4/8] mfd: cros_ec: Use a zero-length array for command data

2015-04-24 Thread Gwendal Grignou
r-space or having a size that is too small for some big > commands, use a zero-length array that is both 64-bit safe and > flexible. The same buffer is used for both output and input data > so the maximum of these values should be used to allocate it. > > Suggested-by: Gwendal Grignou

Re: [RESEND PATCH 4/8] mfd: cros_ec: Use a zero-length array for command data

2015-04-23 Thread Gwendal Grignou
y that is both 64-bit safe and > flexible. The same buffer is used for both output and input data > so the maximum of these values should be used to allocate it. > > Suggested-by: Gwendal Grignou > Signed-off-by: Javier Martinez Canillas > --- > drivers/i2c/busses/i2c-cros-ec-

Re: [RESEND PATCH 5/8] mfd: cros-ec: Support multiple EC in a system

2015-04-23 Thread Gwendal Grignou
This patch needs https://chromium-review.googlesource.com/217297: /dev/cros_ec0 was not a good idea, because it is difficult to know what it represents. On Mon, Apr 6, 2015 at 9:15 AM, Javier Martinez Canillas wrote: > From: Gwendal Grignou > > Chromebooks can have more than one

Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field

2015-04-23 Thread Gwendal Grignou
Be consistent, use cros_ec instead of "cros ec" or "cros-ec". Otherwise: Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas wrote: > From: Gwendal Grignou > > parent and dev were pointing to the same

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-26 Thread Gwendal Grignou
Tested-by: Gwendal Grignou Reviewed-by: Gwendal Grignou Tested on a chromebook pixel with kernel 4.0.0-rc1 and ectool using the enclosed patch in chromiumos platform/ec tree. I checked the lightbar is working, check the calls with "strace ectool ...", check the sysfs interface calls.

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-25 Thread Gwendal Grignou
gt;> >> This patch adds a device interface to access the >> Chrome OS Embedded Controller from user-space. >> >> Signed-off-by: Bill Richardson >> Reviewed-by: Simon Glass >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Gwendal Grignou >> ---

Re: [PATCH RESEND v2 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-01-13 Thread Gwendal Grignou
ned-off-by: Javier Martinez Canillas Reviewed-by: Gwendal Grignou > --- > > Changes since v1: > - The cros_ec_dev driver does not belong to drivers/mfd (Lee Jones) > - Don't call class_create in the probe function (Gwendal Grignou) > - Don't use the deprecated register