Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Inki Dae
); //- restore the vblank frame count. } [snip] } Tested and worked well with above patch. How about it? Thanks, Inki Dae From 6de01473746af225c688ee430123001d57d9af2a Mon Sep 17 00:00:00 2001 From: Joonyoung Shim jy0922.s...@samsung.com Date: Thu, 2 Oct 2014 17

Re: [PATCH] drm/exynos: remove ifdeferry from initialization code

2014-09-30 Thread Inki Dae
option from second times. 2. error occurs when we try to test unbind. Now we are checking these problems. Can you try to also check it? Thanks, Inki Dae Andrzej On 09/10/2014 01:53 PM, Andrzej Hajda wrote: The patch replaces separate calls to driver (de)registration by loops over the array

[PATCH] drm/exynos: fimd: fix screen shaking issue on i80 mode

2014-09-23 Thread Inki Dae
before updating overlay registers. Signed-off-by: Inki Dae inki@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 2f896df

Re: [PATCH v2] drm/exynos: switch to universal plane API

2014-09-19 Thread Inki Dae
cleanup of crtcs to core, this way planes and crtcs are cleaned in correct order. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- Hi Inki, Joonyoung, This is 2nd version of the patch with addressed comments of Joonyoung. Picked it up. Thanks, Inki Dae Regards Andrzej --- drivers/gpu

Re: [PATCH v2] drm/exynos: switch to universal plane API

2014-09-19 Thread Inki Dae
2014-09-20 1:04 GMT+09:00 Inki Dae inki@samsung.com: 2014-09-19 21:58 GMT+09:00 Andrzej Hajda a.ha...@samsung.com: The patch replaces legacy functions drm_plane_init() / drm_crtc_init() with drm_universal_plane_init() and drm_crtc_init_with_planes(). It allows to replace fake primary

Re: [PATCH] drm/exynos: fix plane-framebuffer linkage

2014-09-17 Thread Inki Dae
to prepare patch switching to universal planes? Maybe other volunteers? If not I can try to do it, as it seems quite straightforward. I think you can do it and you would be a right person to do it. Thanks, Inki Dae Regards Andrzej --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 12

Re: [PATCH 0/9] drm/exynos: initialization/deinitialization fixes

2014-09-17 Thread Inki Dae
patch #5. As of now, it seems good to merge also patch #5 if you couldn't post next version of that patch until the end of this week. In this case, I will have a pull request including that patch so that we can fix it up correctly later. Give me your opinion if there is other plan. Thanks, Inki Dae

[PATCH 1/2] drm/exynos: remove DRM_EXYNOS_GEM_MAP_OFFSET ioctl

2014-09-17 Thread Inki Dae
This interface and relevant codes aren't used anymore. Signed-off-by: Inki Dae inki@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_drv.c |3 --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 17 - drivers/gpu/drm/exynos/exynos_drm_gem.h |4 include/uapi/drm

Re: [PATCH 2/2] drm/exynos: use drm generic mmap interface

2014-09-17 Thread Inki Dae
Thanks for review. Below trivial things you pointed out will be fixed soon. On 2014년 09월 18일 13:56, Joonyoung Shim wrote: Hi, On 09/17/2014 10:48 PM, Inki Dae wrote: This patch removes DRM_EXYNOS_GEM_MMAP ictrl feature specific to Exynos drm and instead uses drm generic mmap. We had

[PATCH v2] drm/exynos: use drm generic mmap interface

2014-09-17 Thread Inki Dae
, VM_DONTEXPEND and VM_DONTDUMP. These flags were already set by drm_gem_mmap - do not include linux/anon_inodes.h, which isn't needed anymore. Signed-off-by: Inki Dae inki@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 26 - drivers/gpu/drm/exynos/exynos_drm_drv.h |1

Re: [PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence

2014-09-12 Thread Inki Dae
to make sure that whole memory region to old_fb is scanned out completely before dropping a reference of old_fb. the reference of old_fb should be dropped at irq handler of each crtc devices, fimd and mixer. Thanks, Inki Dae + return 0; } -- To unsubscribe from this list: send

Re: [PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence

2014-09-12 Thread Inki Dae
On 2014년 09월 12일 17:57, Daniel Vetter wrote: On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote: Hi Andrzej, On 2014년 09월 09일 22:16, Andrzej Hajda wrote: Adding reference to framebuffer should be accompanied with removing reference to old framebuffer assigned to the plane. This patch

Re: [PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence

2014-09-12 Thread Inki Dae
On 2014년 09월 12일 18:27, Andrzej Hajda wrote: On 09/12/2014 10:57 AM, Daniel Vetter wrote: On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote: Hi Andrzej, On 2014년 09월 09일 22:16, Andrzej Hajda wrote: Adding reference to framebuffer should be accompanied with removing reference to old

Re: [PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence

2014-09-12 Thread Inki Dae
On 2014년 09월 12일 20:04, Andrzej Hajda wrote: On 09/12/2014 12:45 PM, Inki Dae wrote: On 2014년 09월 12일 18:27, Andrzej Hajda wrote: On 09/12/2014 10:57 AM, Daniel Vetter wrote: On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote: Hi Andrzej, On 2014년 09월 09일 22:16, Andrzej Hajda wrote

Re: [PATCH] drm/exynos: update to use component match support

2014-09-11 Thread Inki Dae
. Will look into them soon. :) Thanks, Inki Dae Few additional comments below. On 09/01/2014 02:19 PM, Inki Dae wrote: Update Exynos's DRM driver to use component match support rater than add_components. Signed-off-by: Inki Dae inki@samsung.com --- drivers/gpu/drm/exynos

Re: [PATCH v2 00/17] drm/exynos/ipp: image post processing fixes and improvements, part four

2014-09-11 Thread Inki Dae
have included changes proposed by Joonyoung Shim. I have decided to resend whole series because the changes caused merge conflicts and two separate patches have been added to the series. Changes are described in comit messages. Applied. Thanks, Inki Dae Regards Andrzej Andrzej Hajda

[PATCH v2] drm/exynos: update to use component match support

2014-09-11 Thread Inki Dae
Update Exynos's DRM driver to use component match support rater than add_components. Changelog v2: - release devices and drivers if failed. - change compare_of to compare_dev. Signed-off-by: Inki Dae inki@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 44

Re: [PATCH] drm/exynos: update to use component match support

2014-09-10 Thread Inki Dae
successfully your patch with trats and universal_c210 boards. Few additional comments below. On 09/01/2014 02:19 PM, Inki Dae wrote: Update Exynos's DRM driver to use component match support rater than add_components. Signed-off-by: Inki Dae inki@samsung.com --- drivers/gpu/drm

[PATCH] drm/exynos: update to use component match support

2014-09-01 Thread Inki Dae
Update Exynos's DRM driver to use component match support rater than add_components. Signed-off-by: Inki Dae inki@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 40 ++- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 3/5] ARM: dts: add fimd device node to exynos3250.dsti

2014-08-18 Thread Inki Dae
Signed-off-by: Inki Dae inki@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 1d52de6..0ec2584 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b

[PATCH 2/5] drm/exynos: fimd: add Exynos3 SoC support

2014-08-18 Thread Inki Dae
Signed-off-by: Inki Dae inki@samsung.com --- .../devicetree/bindings/video/samsung-fimd.txt |1 + drivers/gpu/drm/exynos/exynos_drm_fimd.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/video/samsung-fimd.txt b

[PATCH 0/5] drm/exynos: support Exynos3250 SoC

2014-08-18 Thread Inki Dae
This patch series adds of_device_id and relevant device nodes for Exynos3250 SoC support. Inki Dae (5): drm/exynos: mipi-dsi: add Exynos3 SoC support drm/exynos: fimd: add Exynos3 SoC support ARM: dts: add fimd device node to exynos3250.dsti ARM: dts: add mipi_phy device node

[PATCH 4/5] ARM: dts: add mipi_phy device node to exynos3250.dtsi

2014-08-18 Thread Inki Dae
This patch adds mipi_phy device node to reset, disable and enable DSIM and CSIS PHY. Signed-off-by: Inki Dae inki@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250

[PATCH 5/5] ARM: dts: add mipi dsi device node to exynos3250.dtsi

2014-08-18 Thread Inki Dae
Signed-off-by: Inki Dae inki@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 2bab12f..480dedf 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi

[PATCH 1/5] drm/exynos: mipi-dsi: add Exynos3 SoC support

2014-08-18 Thread Inki Dae
This patch adds Exynos3250/3472 SoCs support. Signed-off-by: Inki Dae inki@samsung.com --- .../devicetree/bindings/video/exynos_dsim.txt |1 + drivers/gpu/drm/exynos/exynos_drm_dsi.c|8 2 files changed, 9 insertions(+) diff --git a/Documentation/devicetree

Re: [PATCH] drm/exynos: dsi: fix exynos_dsi_set_pll() wrong return value

2014-08-18 Thread Inki Dae
On 2014년 08월 14일 11:22, YoungJun Cho wrote: The type of this function is unsigned long, and it is expected to return proper fout value or zero if something is wrong. So this patch fixes wrong return value for error cases. Applied. Thanks, Inki Dae Signed-off-by: YoungJun Cho yj44

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-12 Thread Inki Dae
On 2014년 08월 12일 20:54, YoungJun Cho wrote: Hi Inki, Andrzej On 08/11/2014 04:09 PM, Inki Dae wrote: On 2014년 08월 08일 18:40, Andrzej Hajda wrote: On 08/08/2014 11:02 AM, Andrzej Hajda wrote: On 08/08/2014 09:37 AM, Inki Dae wrote: On 2014년 08월 08일 16:03, Thierry Reding wrote: On Fri, Aug

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-11 Thread Inki Dae
On 2014년 08월 08일 18:40, Andrzej Hajda wrote: On 08/08/2014 11:02 AM, Andrzej Hajda wrote: On 08/08/2014 09:37 AM, Inki Dae wrote: On 2014년 08월 08일 16:03, Thierry Reding wrote: On Fri, Aug 08, 2014 at 10:45:47AM +0900, Inki Dae wrote: On 2014년 08월 07일 22:55, Thierry Reding wrote: On Thu, Aug

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-11 Thread Inki Dae
On 2014년 08월 11일 16:24, Thierry Reding wrote: On Mon, Aug 11, 2014 at 02:19:21PM +0900, Inki Dae wrote: On 2014년 08월 08일 18:55, Thierry Reding wrote: On Fri, Aug 08, 2014 at 04:37:07PM +0900, Inki Dae wrote: On 2014년 08월 08일 16:03, Thierry Reding wrote: On Fri, Aug 08, 2014 at 10:45:47AM

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-11 Thread Inki Dae
On 2014년 08월 11일 16:44, Andrzej Hajda wrote: On 08/11/2014 09:09 AM, Inki Dae wrote: On 2014년 08월 08일 18:40, Andrzej Hajda wrote: On 08/08/2014 11:02 AM, Andrzej Hajda wrote: On 08/08/2014 09:37 AM, Inki Dae wrote: On 2014년 08월 08일 16:03, Thierry Reding wrote: On Fri, Aug 08, 2014 at 10:45

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-11 Thread Inki Dae
On 2014년 08월 11일 16:50, Thierry Reding wrote: On Mon, Aug 11, 2014 at 04:35:46PM +0900, Inki Dae wrote: On 2014년 08월 11일 16:24, Thierry Reding wrote: On Mon, Aug 11, 2014 at 02:19:21PM +0900, Inki Dae wrote: On 2014년 08월 08일 18:55, Thierry Reding wrote: [...] The above is actually more like

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-11 Thread Inki Dae
On 2014년 08월 11일 18:11, Thierry Reding wrote: On Mon, Aug 11, 2014 at 05:15:35PM +0900, Inki Dae wrote: On 2014년 08월 11일 16:50, Thierry Reding wrote: On Mon, Aug 11, 2014 at 04:35:46PM +0900, Inki Dae wrote: On 2014년 08월 11일 16:24, Thierry Reding wrote: On Mon, Aug 11, 2014 at 02:19:21PM

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-10 Thread Inki Dae
On 2014년 08월 08일 18:55, Thierry Reding wrote: On Fri, Aug 08, 2014 at 04:37:07PM +0900, Inki Dae wrote: On 2014년 08월 08일 16:03, Thierry Reding wrote: On Fri, Aug 08, 2014 at 10:45:47AM +0900, Inki Dae wrote: On 2014년 08월 07일 22:55, Thierry Reding wrote: On Thu, Aug 07, 2014 at 10:39:29PM

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-08 Thread Inki Dae
On 2014년 08월 08일 16:03, Thierry Reding wrote: On Fri, Aug 08, 2014 at 10:45:47AM +0900, Inki Dae wrote: On 2014년 08월 07일 22:55, Thierry Reding wrote: On Thu, Aug 07, 2014 at 10:39:29PM +0900, Inki Dae wrote: On 2014년 08월 07일 22:17, Thierry Reding wrote: On Thu, Aug 07, 2014 at 10:05:44PM

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-07 Thread Inki Dae
On 2014년 08월 07일 15:58, Thierry Reding wrote: On Thu, Aug 07, 2014 at 02:09:19AM +0900, Inki Dae wrote: 2014-08-06 16:43 GMT+09:00 Thierry Reding thierry.red...@gmail.com: On Wed, Aug 06, 2014 at 04:11:54PM +0900, Inki Dae wrote: On 2014년 08월 05일 20:12, Thierry Reding wrote: [...] I think

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-07 Thread Inki Dae
On 2014년 08월 07일 18:09, Thierry Reding wrote: On Thu, Aug 07, 2014 at 04:51:18PM +0900, Inki Dae wrote: On 2014년 08월 07일 15:58, Thierry Reding wrote: On Thu, Aug 07, 2014 at 02:09:19AM +0900, Inki Dae wrote: 2014-08-06 16:43 GMT+09:00 Thierry Reding thierry.red...@gmail.com: [...] As far

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-07 Thread Inki Dae
On 2014년 08월 07일 20:09, Thierry Reding wrote: On Thu, Aug 07, 2014 at 07:49:03PM +0900, Inki Dae wrote: On 2014년 08월 07일 18:09, Thierry Reding wrote: On Thu, Aug 07, 2014 at 04:51:18PM +0900, Inki Dae wrote: On 2014년 08월 07일 15:58, Thierry Reding wrote: On Thu, Aug 07, 2014 at 02:09:19AM

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-07 Thread Inki Dae
On 2014년 08월 07일 22:55, Thierry Reding wrote: On Thu, Aug 07, 2014 at 10:39:29PM +0900, Inki Dae wrote: On 2014년 08월 07일 22:17, Thierry Reding wrote: On Thu, Aug 07, 2014 at 10:05:44PM +0900, Inki Dae wrote: On 2014년 08월 07일 20:09, Thierry Reding wrote: On Thu, Aug 07, 2014 at 07:49:03PM

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-06 Thread Inki Dae
Thanks for comments. On 2014년 08월 05일 20:12, Thierry Reding wrote: On Mon, Jul 28, 2014 at 06:09:58PM +0200, Andrzej Hajda wrote: On 07/28/2014 04:00 AM, Inki Dae wrote: This patch adds below two flags for LPM transfer, and it attaches LPM flags to a msg in accordance with master's

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-06 Thread Inki Dae
2014-08-06 16:43 GMT+09:00 Thierry Reding thierry.red...@gmail.com: On Wed, Aug 06, 2014 at 04:11:54PM +0900, Inki Dae wrote: On 2014년 08월 05일 20:12, Thierry Reding wrote: [...] I think that low power mode is more often used for command transmission (in host-driven mode). I'm not sure how

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-03 Thread Inki Dae
2014-07-29 19:23 GMT+09:00 Andrzej Hajda a.ha...@samsung.com: On 07/29/2014 02:57 AM, YoungJun Cho wrote: Hi Andrzej, On 07/29/2014 01:09 AM, Andrzej Hajda wrote: On 07/28/2014 04:00 AM, Inki Dae wrote: This patch adds below two flags for LPM transfer, and it attaches LPM flags to a msg

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-08-03 Thread Inki Dae
2014-08-03 16:03 GMT+09:00 Inki Dae inki@samsung.com: 2014-07-29 19:23 GMT+09:00 Andrzej Hajda a.ha...@samsung.com: On 07/29/2014 02:57 AM, YoungJun Cho wrote: Hi Andrzej, On 07/29/2014 01:09 AM, Andrzej Hajda wrote: On 07/28/2014 04:00 AM, Inki Dae wrote: This patch adds below two

Re: [PATCH 1/2] drm/exynos: g2d: make ioctls more robust

2014-08-03 Thread Inki Dae
; + + dev = g2d_priv-dev It seems that you have no build test because above line incurs build error. Anyway I fixed it up. Thanks, Inki Dae if (!dev) return -ENODEV; -- 1.8.5.5 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH 07/15] drm/exynos: dsi: Add support for panel prepare and unprepare routines

2014-08-03 Thread Inki Dae
/exynos_drm_dsi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) And this one as well. Acked-by: Inki Dae inki@samsung.com Thanks, Inki Dae Thierry ___ dri-devel mailing list dri-de...@lists.freedesktop.org http

Re: [PATCH 1/2] drm/exynos: g2d: make ioctls more robust

2014-08-03 Thread Inki Dae
On 2014년 08월 03일 18:52, Tobias Jakobi wrote: Inki Dae wrote: It seems that you have no build test because above line incurs build error. Anyway I fixed it up. That's why I have sent v2 of the patch. Oops, sorry. I didn't check v2. Thanks, Inki Dae With best wishes, Tobias

Re: [PATCH 06/15] drm/exynos: dpi: Add support for panel prepare and unprepare routines

2014-08-01 Thread Inki Dae
++-- 1 file changed, 6 insertions(+), 2 deletions(-) Looks good to me. Inki, can I have your Acked-by to take this through the panel tree? Of course. Acked-by: Inki Dae inki@samsung.com Thanks, Inki Dae Thierry -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 15/15] drm/exynos: dp: Modify driver to support drm_panel

2014-08-01 Thread Inki Dae
dependency on earlier patches in this series, so taking it through the panel tree along with the rest is probably easiest. Acked-by: Inki Dae inki@samsung.com Thanks, Inki Dae Thierry -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH v2 2/2] drm/exynos: dsi: add LPM (Low Power Mode) transfer support

2014-07-29 Thread Inki Dae
On 2014년 07월 29일 20:39, Andrzej Hajda wrote: On 07/29/2014 05:42 AM, Inki Dae wrote: On 2014년 07월 29일 00:50, Andrzej Hajda wrote: On 07/28/2014 04:00 AM, Inki Dae wrote: This patch adds LPM transfer support for video or command data. With this patch, Exynos MIPI DSI controller can transfer

Re: [PATCH 0/3] drm/exynos: Allow module to be autoloaded

2014-07-29 Thread Inki Dae
On 2014년 07월 29일 20:59, Andreas Färber wrote: Am 29.07.2014 10:05, schrieb Sjoerd Simons: On Tue, 2014-07-29 at 14:38 +0900, Inki Dae wrote: On 2014년 07월 28일 23:45, Sjoerd Simons wrote: On Mon, 2014-07-28 at 23:17 +0900, Inki Dae wrote: On 2014년 07월 28일 17:30, Sjoerd Simons wrote: I don't

Re: [PATCH 0/3] drm/exynos: Allow module to be autoloaded

2014-07-28 Thread Inki Dae
On 2014년 07월 28일 17:30, Sjoerd Simons wrote: Hey Inki, On Mon, 2014-07-21 at 08:50 +0200, Sjoerd Simons wrote: Hey Inki, On Mon, 2014-07-21 at 12:02 +0900, Inki Dae wrote: On 2014년 07월 19일 05:36, Sjoerd Simons wrote: The exynos DRM module currently is not automatically loaded when build

Re: [PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-07-28 Thread Inki Dae
On 2014년 07월 29일 01:09, Andrzej Hajda wrote: On 07/28/2014 04:00 AM, Inki Dae wrote: This patch adds below two flags for LPM transfer, and it attaches LPM flags to a msg in accordance with master's mode_flags set by LCD Panel driver. MIPI_DSI_MODE_CMD_LPM - If this flag is set by Panel

Re: [PATCH v2 2/2] drm/exynos: dsi: add LPM (Low Power Mode) transfer support

2014-07-28 Thread Inki Dae
On 2014년 07월 29일 00:50, Andrzej Hajda wrote: On 07/28/2014 04:00 AM, Inki Dae wrote: This patch adds LPM transfer support for video or command data. With this patch, Exynos MIPI DSI controller can transfer command or video data with HS or LP mode in accordance with mode_flags set by LCD

Re: [PATCH 0/3] drm/exynos: Allow module to be autoloaded

2014-07-28 Thread Inki Dae
On 2014년 07월 28일 23:45, Sjoerd Simons wrote: Hey Inki, On Mon, 2014-07-28 at 23:17 +0900, Inki Dae wrote: On 2014년 07월 28일 17:30, Sjoerd Simons wrote: Sorry for late, I don't see why Exynos drm driver should be auto-loaded module. I think all devices covered by Exynos drm framework

[PATCH v2 0/2] drm/mipi-dsi: support lpm (low power mode) transfer

2014-07-27 Thread Inki Dae
. Changelog v2: - Add more describtions. - Enable High Speed clock only in case of stand by request. Inki Dae (2): drm/mipi-dsi: add (LPM) Low Power Mode transfer support drm/exynos: dsi: add LPM (Low Power Mode) transfer support drivers/gpu/drm/drm_mipi_dsi.c |3 +++ drivers/gpu/drm

[PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-07-27 Thread Inki Dae
with those requirements. Some LCD Panel devices, nt35502a, would need LPM transfer support because they should receive some initial commands with LPM by default hardware setting. Changelog v2: just add more descriptions. Signed-off-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park

[PATCH v2 2/2] drm/exynos: dsi: add LPM (Low Power Mode) transfer support

2014-07-27 Thread Inki Dae
-off-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos

Re: [PATCH 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-07-25 Thread Inki Dae
On 2014년 07월 24일 19:23, Andrzej Hajda wrote: Hi Inki, +CC: Thierry and Alexandre On 07/18/2014 12:56 PM, Inki Dae wrote: This patch adds below two flags for LPM transfer, and it attaches LPM flags to a msg in accordance with master's mode_flags set by LCD Panel driver

Re: [PATCH 2/2] drm/exynos: dsi: add LPM (Low Power Mode) transfer support

2014-07-25 Thread Inki Dae
On 2014년 07월 24일 19:48, Andrzej Hajda wrote: +CC: Thierry and Alexandre On 07/18/2014 12:56 PM, Inki Dae wrote: This patch adds LPM transfer support for video or command data. With this patch, Exynos MIPI DSI controller can transfer command or video data with HS or LP mode in accordance

Re: [PATCH 00/12] drm/exynos/ipp: image post processing improvements, part three

2014-07-22 Thread Inki Dae
On 2014년 07월 03일 22:10, Andrzej Hajda wrote: This set of independent patches contains various improvement and fixes for exynos_drm ipp framework. The patchset is based on exynos-drm-next branch. Applied. Thanks, Inki Dae Regards Andrzej Andrzej Hajda (12): drm/exynos/ipp: remove

Re: [PATCH v6 00/14] drm/exynos: support LCD I80 interface display

2014-07-22 Thread Inki Dae
: exynos5: add system register property ARM: dts: exynos5420: add mipi-phy node ARM: dts: exynos5420: add dsi node Piked them up except patch 9 and 10. The two patches are needed for more review and consensus Thanks, Inki Dae .../devicetree/bindings/panel/samsung,s6e3fa0.txt | 46

Re: [PATCH V5 00/12] drm/exynos: few patches to enhance bridge chip support

2014-07-21 Thread Inki Dae
. Rob, it seems to need at least your ACK so that I can merge this patch series to exynos-drm-next. Thanks, Inki Dae Ajay Kumar (9): [RESEND PATCH V5 01/12] drm/exynos: Move DP setup out of hotplug workqueue [RESEND PATCH V5 02/12] drm/panel: add prepare and unprepare routines [RESEND

Re: [RESEND PATCH V5 08/12] drm/bridge: ptn3460: Support bridge chaining

2014-07-21 Thread Inki Dae
); if (!bridge) { DRM_ERROR(Failed to allocate drm bridge\n); - return -ENOMEM; + return NULL; I think you could handle error case correctly. Please return ERR_PTR(-ENOMEM) instead of NULL, and below codes also. Thanks, Inki Dae

Re: [PATCH 00/12] drm/exynos/ipp: image post processing improvements, part three

2014-07-21 Thread Inki Dae
On 2014년 07월 21일 18:23, Andrzej Hajda wrote: Hi Inki, On 07/09/2014 04:47 PM, Inki Dae wrote: On 2014년 07월 03일 22:10, Andrzej Hajda wrote: This set of independent patches contains various improvement and fixes for exynos_drm ipp framework. The patchset is based on exynos-drm-next branch

Re: [PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

2014-07-21 Thread Inki Dae
and encoder/connector because these frameworks are common to all architecture including x86 so other architectures wouldn't need TE feature. Thanks, Inki Dae Regards Andrzej Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park

Re: [PATCH 0/3] drm/exynos: Allow module to be autoloaded

2014-07-20 Thread Inki Dae
call. Hi, Exynos drm follows single-driver model. So each usb driver of Exynos drm wouldn't need its own MODULE_DEVICE_TABLE. Thanks, Inki Dae Sjoerd Simons (3): Revert drm/exynos: fix module build error Revert drm/exynos: remove MODULE_DEVICE_TABLE definitions drm/exynos: Add

Re: [PATCH] drm/exynos: g2d: add exynos4212 as a compatible device.

2014-07-20 Thread Inki Dae
On 2014년 07월 20일 05:53, Tobias Jakobi wrote: From: Alban Browaeys pra...@yahoo.com Applied. Thanks, Inki Dae Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm

Re: [PATCH 0/7] Exynos4: enable HDMI support for Odroid and UniversalC210

2014-07-19 Thread Inki Dae
' regulator optional and keep it enabled and drm: hdmi/mixer: enable exynos 4210 and 4x12 soc support) add proper support for Exynos4 SoCs to Exynos DRM drivers. Those patches should go to exynos-drm kernel tree. Picked them up. Thanks, Inki Dae Last patches (Exynos: add support for 'domain-always

[PATCH 2/2] drm/exynos: dsi: add LPM (Low Power Mode) transfer support

2014-07-18 Thread Inki Dae
This patch adds LPM transfer support for video or command data. With this patch, Exynos MIPI DSI controller can transfer command or video data with HS or LP mode in accordance with mode_flags set by LCD Panel driver. Signed-off-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p

[PATCH 0/2] drm/mipi-dsi: support LPM (Low Power Mode) transfer

2014-07-18 Thread Inki Dae
This patch series adds LPM tranfer support for video and command data. For this, this patch adds two flags, and makes MIPI DSI host to send commands to LCD Panel device with LPM if mode_flags of LCD Panel driver includes LPM flag. And also it applies this feature to Exynos MIPI DSI driver. Inki

[PATCH 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

2014-07-18 Thread Inki Dae
in accordance with those requirements. Some LCD Panel devices, nt35502a, would need LPM transfer support because they should receive some initial commands with LPM by default hardware setting. Signed-off-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com

Re: [PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

2014-07-16 Thread Inki Dae
On 2014년 07월 16일 19:12, YoungJun Cho wrote: Hi Thierry, On 07/16/2014 04:54 PM, Thierry Reding wrote: On Wed, Jul 16, 2014 at 11:23:09AM +0900, YoungJun Cho wrote: Hi Inki, On 07/15/2014 11:34 AM, Inki Dae wrote: On 2014년 07월 14일 20:03, Thierry Reding wrote: On Mon, Jul 14, 2014 at 07:45

Re: [PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

2014-07-14 Thread Inki Dae
of notifier. Actually, original patch used this way except TE event. Mr. Cho, let's use remote-endpoint property and this way instead of notifier. Thanks, Inki Dae Thierry -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH V4 00/10] drm: exynos: few patches to enhance bridge chip support

2014-07-14 Thread Inki Dae
it to Daniel, Thierry, and Rob a week ago. If there are no any ACKs from them until this week, I plan to pick them up. So please wait. Thanks, Inki Dae Thanks, -Olof On Tue, Jul 8, 2014 at 11:11 PM, Ajay kumar ajayn...@gmail.com wrote: Hi Daniel, Thierry and Rob, Currently, the following

Re: [RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-07-09 Thread Inki Dae
On 2014년 07월 09일 20:06, Rahul Sharma wrote: On 8 July 2014 21:25, Inki Dae inki@samsung.com wrote: 2014-06-20 0:13 GMT+09:00 Rahul Sharma rahul.sha...@samsung.com: This situation arises when userspace remove the frambuffer object and call setmode ioctl. drm_mode_rmfb

Re: [PATCH 00/12] drm/exynos/ipp: image post processing improvements, part three

2014-07-09 Thread Inki Dae
this patch series before merging them. Mainline libdrm has no any ipp interfaces. Thanks, Inki Dae Regards Andrzej Andrzej Hajda (12): drm/exynos/ipp: remove type casting drm/exynos/ipp: remove unused field from exynos_drm_ipp_private drm/exynos/ipp: remove struct exynos_drm_ipp_private

Re: [PATCH v5 00/14] drm/exynos: support LCD I80 interface display

2014-07-09 Thread Inki Dae
-drm-next branch. Thanks for contributions. Picked them up. Thanks, Inki Dae The previous patches, RFC: http://www.spinics.net/lists/dri-devel/msg58898.html V1: http://www.spinics.net/lists/dri-devel/msg59291.html V2: http://www.spinics.net/lists/dri-devel/msg59867.html V3: http

Re: [PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

2014-07-09 Thread Inki Dae
. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++ include/drm/drm_mipi_dsi.h | 7 +++ 2 files changed, 18 insertions

Re: [PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

2014-07-09 Thread Inki Dae
manager to trigger to transfer video image. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++ include/drm/drm_mipi_dsi.h | 7

Re: [PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

2014-07-09 Thread Inki Dae
On 2014년 07월 10일 10:20, Inki Dae wrote: On 2014년 07월 10일 10:06, YoungJun Cho wrote: On 07/10/2014 12:22 AM, Thierry Reding wrote: On Tue, Jul 08, 2014 at 09:39:38AM +0900, YoungJun Cho wrote: To support LCD I80 interface, the DSI host calls this function to notify the panel tearing effect

Re: [RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-07-08 Thread Inki Dae
exynos_drm_crtc_plane_commit function could be called. Can you give me more details? Thanks, Inki Dae This crashes the system. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- This works fine but I am not confident on the correctness of the solution. drivers/gpu/drm/exynos/exynos_drm_crtc.c |6

Re: [PATCH] drm/exynos: fimd: Keep power enabled during fimd_bind

2014-07-08 Thread Inki Dae
(). Below codes don't access any fimd register. Or move these function calls into fimd_mgr_initialize(). Thanks, Inki Dae exynos_drm_crtc_create(fimd_manager); if (ctx-display) exynos_drm_create_enc_conn(drm_dev, ctx-display); + pm_runtime_put_sync(dev

Re: [PATCH] drm/exynos: Fix NULL pointer exception when suspending without components

2014-07-01 Thread Inki Dae
. Thanks, Inki Dae The NULL pointer exception may theoretically also happen as a effect of race between adding components and main driver: if suspend of the driver happens before adding components. Trace: [1.190295] [drm] Initialized drm 1.1.0 20060810 [1.195209] exynos-drm-ipp

Re: [PATCH V3 1/7] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-30 Thread Inki Dae
drm driver should be considered for above all cases, it'd make Eyxnos drm driver too complicated. If DT people and other SoC maintainers give us your opinions, it would be helpful for us. I will look into other SoC how they are handling similar cases. Thanks, Inki Dae Regards Andrzej Best

Re: [PATCH V2] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-27 Thread Inki Dae
thing, does FIMD ip of Exynos4 series have DP_CLKCON register? No, they have no any DP_CLKCON register so you would need to consider other SoC without DP_CLKCON. For this, a proper volunteer would be fimd_driver_data. Thanks, Inki Dae + writel(val, ctx-regs + VIDCON0); } diff --git

Re: [PATCH V3 0/7] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-27 Thread Inki Dae
+ DT mailing list On 2014년 06월 27일 19:12, Ajay Kumar wrote: This series is based on exynos-drm-next branch of Inki Dae's tree at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git Changes since V2: Add DT property to know the type of FIMD output interface

Re: [PATCH 3/5 v2] drm/exynos: allow mulitple layer updates per vsync for mixer

2014-06-25 Thread Inki Dae
considered. ignore my comment. Thanks, Inki Dae Regards, Rahul Sharma. On 24 June 2014 20:20, Inki Dae inki@samsung.com wrote: 2014-06-24 20:38 GMT+09:00 Andreas Färber afaer...@suse.de: Am 24.06.2014 07:21, schrieb Inki Dae: On 2014년 06월 23일 14:32, Rahul Sharma wrote: Allowing only one

Re: [PATCH 3/5 v2] drm/exynos: allow mulitple layer updates per vsync for mixer

2014-06-24 Thread Inki Dae
2014-06-24 20:38 GMT+09:00 Andreas Färber afaer...@suse.de: Am 24.06.2014 07:21, schrieb Inki Dae: On 2014년 06월 23일 14:32, Rahul Sharma wrote: Allowing only one layer update per vsync can cause issues while there are update available for both layers. There is a good amount of possibility

Re: [PATCH 3/5 v2] drm/exynos: allow mulitple layer updates per vsync for mixer

2014-06-23 Thread Inki Dae
will wait for the additional patch. Thanks, Inki Dae } static void mixer_graph_buffer(struct mixer_context *ctx, int win) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH V4 00/10] drm: exynos: few patches to enhance bridge chip support

2014-06-20 Thread Inki Dae
reviewed-by so that I can pick this patch series up. Thanks, Inki Dae On Wed, Jun 11, 2014 at 11:56 PM, Ajay Kumar ajaykumar...@samsung.com wrote: This series is based on exynos-drm-next branch of Inki Dae's tree at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git I have

Re: [PATCH] drm/exynos: defer hdmi probe when fail to get regulators

2014-06-18 Thread Inki Dae
-EPROBE_DEFER in case of all errors. Thanks, Inki Dae + } } - res-regul_count = ARRAY_SIZE(supply); - return ret; + return 0; fail: DRM_ERROR(HDMI resource init - failed\n); return ret; -- To unsubscribe from this list: send the line

Re: [PATCH] drm/exynos: dpi: Fix NULL pointer dereference with legacy bindings

2014-06-17 Thread Inki Dae
connector_status_connected; Ping. Applied. Thanks, Inki Dae Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch] drm/exynos: change zero to NULL for sparse

2014-06-17 Thread Inki Dae
. Thanks, Inki Dae Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h index 36535f3..06cde45 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b/drivers/gpu/drm/exynos

Re: drm/exynos: consider deferred probe case

2014-06-11 Thread Inki Dae
Hello Dan, On 2014년 06월 10일 21:38, Dan Carpenter wrote: Hello Inki Dae, The patch df5225bc9a87: drm/exynos: consider deferred probe case from May 29, 2014, leads to the following static checker warning: drivers/gpu/drm/exynos/exynos_drm_fimd.c:996 fimd_probe() warn: 'ctx

Re: [PATCH] drm/exynos: remove hardware overlays disable from fimd probe

2014-06-08 Thread Inki Dae
not breaks other stuff. It looks good to me. Can you post it? Thanks, Inki Dae Regards Andrzej Regards Andrzej -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v4 00/14] drm/exynos: support LCD I80 interface display

2014-06-05 Thread Inki Dae
Hi all, Is there anyone who are reviewing this patch series? If there is no any comment, I'd like to pick them up after test. Thanks, Inki Dae On 2014년 06월 05일 15:19, YoungJun Cho wrote: Hi, This series adds LCD I80 interface display support for Exynos DRM driver. The FIMD(display

Re: [PATCH v4 00/14] drm/exynos: support LCD I80 interface display

2014-06-05 Thread Inki Dae
On 2014년 06월 05일 17:20, Thierry Reding wrote: On Thu, Jun 05, 2014 at 05:14:45PM +0900, Inki Dae wrote: Hi all, Is there anyone who are reviewing this patch series? If there is no any comment, I'd like to pick them up after test. What's with the rush? You should at least give people

Re: [PATCH v2] drm/exynos: consider deferred probe case

2014-06-04 Thread Inki Dae
On 2014년 06월 04일 20:24, Andrzej Hajda wrote: On 05/29/2014 11:28 AM, Inki Dae wrote: This patch makes sure that exynos drm framework handles deferred probe case correctly. Sub drivers could be probed before resources, clock, regulator, phy or panel, are ready for them so we should make sure

Re: [PATCH] drm/exynos: remove hardware overlays disable from fimd probe

2014-06-02 Thread Inki Dae
process, X or Weston, will reconfigure fimd overlays after kernel booting. Thanks, Inki Dae Would you please help me by verifying the following patch on 4210? This is an alternate solution to the same problem. http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg31426.html

[PATCH v2] drm/exynos: consider deferred probe case

2014-05-29 Thread Inki Dae
-off-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_dp_core.c | 18 +++- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 22 - drivers/gpu/drm/exynos/exynos_drm_drv.c | 139 +- drivers/gpu/drm

[PATCH] drm/exynos: consider deferred probe case

2014-05-29 Thread Inki Dae
-off-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_dp_core.c | 18 +++- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 22 - drivers/gpu/drm/exynos/exynos_drm_drv.c | 139 +- drivers/gpu/drm

<    1   2   3   4   5   6   >