Re: [PATCH 03/10] media framework: rename pads init function to media_entity_pads_init()

0, NULL); + ret = media_entity_pads_init(>entity, 0, NULL); if (ret < 0) return ERR_PTR(ret); For this part: Acked-by: Jacek Anaszewski <j.anaszew...@samsung.com> -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsu

Re: [PATCH 1/4] s5p-jpeg: generalize clocks handling

(+), 39 deletions(-) Reviewed-by: Jacek Anaszewski <j.anaszew...@samsung.com> -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] MAINTAINERS: add exynos jpeg codec maintainers

On 09/18/2015 04:20 PM, Andrzej Pietrasiewicz wrote: Add Andrzej Pietrasiewicz and Jacek Anaszewski as maintainers of drivers/media/platform/s5p-jpeg. Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff

Re: [PATCH 2/4] s5p-jpeg: add support for 5433

rm/s5p-jpeg/jpeg-hw-exynos4.h | 11 +- drivers/media/platform/s5p-jpeg/jpeg-regs.h| 85 +++-- 6 files changed, 522 insertions(+), 66 deletions(-) Reviewed-by: Jacek Anaszewski <j.anaszew...@samsung.com> -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: s

Re: [PATCHv2 2/2] media: s5p-jpeg: add 5420 family support

hw3250_compat:1; + unsigned inthtbl_reinit:1; struct v4l2_m2m_ops *m2m_ops; irqreturn_t (*jpeg_irq)(int irq, void *priv); }; -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH 1/2] ARM: dts: exynos4: Add JPEG codec node

Please ignore these both patches in favour of the patch: [PATCH v2] ARM: dts: exynos4: add nodes for jpeg codec -- Best Regards, Jacek Anaszewski On 03/05/2015 02:10 PM, Jacek Anaszewski wrote: This patch adds an entry for JPEG codec found in Exynos 4210 and 4x12 SoCs. Signed-off-by: Jacek

[PATCH 2/2] ARM: dts: Add JPEG codec node for exynos4412-trats2

Enable support for JPEG codec on exynos4412-trats2 board. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Cc: Kukjin Kim kg...@kernel.org --- arch/arm/boot/dts/exynos4412-trats2.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b

[PATCH 1/2] ARM: dts: exynos4: Add JPEG codec node

This patch adds an entry for JPEG codec found in Exynos 4210 and 4x12 SoCs. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Cc: Kukjin Kim kg...@kernel.org --- arch/arm/boot/dts/exynos4.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi

Re: [PATCH 2/2] media: s5p-jpeg: add 5420 family support

SJPEG_EXYNOS5420 4 As you are adding a new variant you could turn this into an enum. enum exynos4_jpeg_result { OK_ENC_OR_DEC, -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

[PATCH RESEND] ARM: dts: exynos3250: add JPEG codec device node

Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Pankaj Dubey pankaj.du...@samsung.com Cc: Kukjin Kim kg...@kernel.org --- arch/arm/boot/dts/exynos3250.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCH] ARM: dts: exynos3250-rinato: add support for JPEG codec

Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Kukjin Kim kg...@kernel.org --- arch/arm/boot/dts/exynos3250-rinato.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm

Re: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

Hi Tony, Sorry for late response, just got back from vacation. On 12/19/2014 04:37 AM, Tony K Nadackal wrote: Hi Jacek, On Wednesday, December 17, 2014 7:46 PM Jacek Anaszewski wrote, Hi Tony, Thanks for the patches. Thanks for the review. Please process them with scripts/checkpatch.pl

Re: [PATCH v2 1/2] [media] s5p-jpeg: Fix modification sequence of interrupt enable register

+ EXYNOS4_INT_EN_REG) ~EXYNOS4_INT_EN_MASK; + writel(reg | EXYNOS4_INT_EN_ALL, base + EXYNOS4_INT_EN_REG); } unsigned int exynos4_jpeg_get_int_status(void __iomem *base) -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH v2 2/2] [media] s5p-jpeg: Adding Exynos7 JPEG variant

EXYNOS_SWAP_CHROMA_CBCR(shift) (0 (shift)) /* JPEG HUFF count Register bit */ #define EXYNOS4_HUFF_COUNT_MASK 0x -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v2 2/2] [media] s5p-jpeg: Adding Exynos7 JPEG variant

Hi Tony, On 01/07/2015 12:22 PM, Tony K Nadackal wrote: Hi Jacek, On Wednesday, January 07, 2015 3:43 PM : Jacek Anaszewski wrote, Hi Tony, On 12/19/2014 08:38 AM, Tony K Nadackal wrote: Fimp_jpeg used in Exynos7 is a revised version. Some register configurations are slightly different

Re: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

Hi Tony, On 01/07/2015 01:08 PM, Tony K Nadackal wrote: Dear Jacek, On Wednesday, January 07, 2015 3:15 PM Jacek Anaszewski wrote, Hi Tony, Sorry for late response, just got back from vacation. On 12/19/2014 04:37 AM, Tony K Nadackal wrote: Hi Jacek, On Wednesday, December 17, 2014 7:46

Re: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

*/ #define EXYNOS4_HUFF_COUNT_MASK 0x -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] ARM: dts: exynos3250: add MFC codec device node

Hi Kukjin, On 09/13/2014 07:08 PM, Kukjin Kim wrote: On 09/09/14 22:09, Jacek Anaszewski wrote: Signed-off-by: Jacek Anaszewskij.anaszew...@samsung.com Signed-off-by: Kyungmin Parkkyungmin.p...@samsung.com Cc: Kukjin Kimkgene@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 12

[PATCH v5] ARM: dts: exynos3250 add MFC codec device node

Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Kukjin Kim kgene@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch

[PATCH v4] ARM: dts: exynos3250: add MFC codec device node

Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Kukjin Kim kgene@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch

[PATCH v3] ARM: dts: exynos3250: add JPEG codec device node

Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Kukjin Kim kgene@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch

Re: [PATCH 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST

() couldn't simply be used, since exynos4_jpeg_sw_reset() is called with a spinlock held. Ok. Within few days I will perform some hardware tests, to verify if there is more room for improvement here. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH v3] ARM: dts: exynos3250 add MFC codec device node

Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Kukjin Kim kgene@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch

[PATCH 2/9] s5p-jpeg: return error immediately after get_byte fails

When parsing JPEG header s5p_jpeg_parse_hdr function should return immediately in case there was an error while reading a byte. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-jpeg/jpeg-core.c |4

[PATCH 1/9] s5p-jpeg: Add support for Exynos3250 SoC

This patch adds support for jpeg codec on Exynos3250 SoC to the s5p-jpeg driver. Supported raw formats are: YUYV, YVYU, UYVY, VYUY, RGB565, RGB565X, RGB32, NV12, NV21. The support includes also scaling and cropping features. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off

[PATCH 3/9] s5p-jpeg: Adjust jpeg_bound_align_image to Exynos3250 needs

The jpeg_bound_align_image function needs to know the context in which it is called, as it needs to align image dimensions in a slight different manner for Exynos3250, which crops pixels for specific values in case the format is RGB. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed

[PATCH 5/9] s5p-jpeg: Assure proper crop rectangle initialization

Assure proper crop_rect initialization in case the user space doesn't call S_SELECTION ioctl. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 15 +++ 1 file changed, 15

[PATCH 6/9] s5p-jpeg: Prevent erroneous downscaling for Exynos3250 SoC

JPEG codec on Exynos3250 SoC produces broken raw image if a JPEG is decoded to YUV420 format and downscaling by more then 2 is applied. Prevent this by asserting downscale ratio to 2. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH 4/9] s5p-jpeg: fix g_selection op

V4L2_SEL_TGT_COMPOSE_DEFAULT switch case should select whole available area of the image and V4L2_SEL_TGT_COMPOSE should apply user settings. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-jpeg/jpeg

[PATCH 9/9] ARM: dts: exynos3250: add JPEG codec device node

Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: Kumar Gala ga

[PATCH 8/9] Documentation: devicetree: Document sclk-jpeg clock for exynos3250 SoC

JPEG IP on Exynos3250 SoC requires enabling two clock gates for its operation. This patch documents this requirement. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m

[PATCH 7/9] s5p-jpeg: add chroma subsampling adjustment for Exynos3250

Take into account limitations specific to the Exynos3250 SoC, regarding setting chroma subsampling control value. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 59