Hello Doug,
On 08/19/2014 06:26 PM, Doug Anderson wrote:
While your change is correct, I have a worry that it will break things
if it's merged before some patches that Yuvaraj is working on.
Specifically the problem on pit and pi (and any exynos5250 / 5420 /
5800 / ... boards using the
Hello Andreas,
Thanks a lot for your feedback.
On 08/19/2014 08:37 PM, Andreas Färber wrote:
mmc_2 {
+vmmc-supply = tps65090_fet4;
+vqmmc-supply = vqmmc_sdcard;
status = okay;
num-slots = 1;
supports-highspeed;
A convention that I picked up was to place
Hello Andreas,
On 08/19/2014 08:52 PM, Andreas Färber wrote:
+
+max77802-pmic@9 {
+compatible = maxim,max77802;
+interrupt-parent = gpx3;
+interrupts = 1 0;
1 IRQ_TYPE_NONE?
Indeed, I'll change both on v2. Thanks a lot.
Cheers,
Andreas
Hello Andreas,
On 08/20/2014 12:21 PM, Javier Martinez Canillas wrote:
Hello Andreas,
Thanks a lot for your feedback.
On 08/19/2014 08:37 PM, Andreas Färber wrote:
mmc_2 {
+ vmmc-supply = tps65090_fet4;
+ vqmmc-supply = vqmmc_sdcard;
status = okay;
num-slots = 1
-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 6 ++
arch/arm/boot/dts/exynos5800-peach-pi.dts | 6 ++
2 files changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b/arch/arm/boot/dts/exynos5420
From: Rahul Sharma rahul.sha...@samsung.com
Adding regulators for HDMI for Peach-pi board.
Signed-off-by: Rahul Sharma rahul.sha...@samsung.com
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch
in the
the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 372 +
arch/arm/boot/dts/exynos5800-peach-pi.dts
instead of a magic number as suggested by
Andreas Färber.
The series is composed of the following patches:
Javier Martinez Canillas (2):
ARM: dts: Add Peach Pit and Pi dts entry for max77802 PMIC
ARM: dts: Add Peach Pit and Pi dts entry for ISL29018 sensor
Naveen Krishna Chatradhi (1):
ARM
From: Rahul Sharma rahul.sha...@samsung.com
Adding regulators for hdmi for peach-pit board.
Signed-off-by: Rahul Sharma rahul.sha...@samsung.com
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch
...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/cros-adc-thermistors.dtsi | 44 +
arch/arm/boot/dts/exynos5420-peach-pit.dts | 6
arch/arm/boot/dts/exynos5800-peach-pi.dts | 6
3 files changed, 56
From: Andrew Bresticker abres...@chromium.org
Now that there's a central cros_ec_cmd_xfer(), move the locking
out of the SPI and LPC drivers.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti
...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Acked-by: Wolfram Sang w...@the-dreams.de
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/i2c/busses/i2c-cros-ec-tunnel.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/busses/i2c-cros
From: Todd Broch tbr...@chromium.org
If the EC device tree node has sub-nodes, try to instantiate them as
MFD sub-devices. We can configure the EC features provided by the board.
Signed-off-by: Todd Broch tbr...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti
long term.
* This same logic probably needs to be applied to the i2c driver.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Randall Spangler rspang...@chromium.org
Reviewed-by: Vadim Bendebury vben...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti
it across the different
drivers.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +-
drivers/input/keyboard/cros_ec_keyb.c
to the EC while
it is working on the in-progress command.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/cros_ec.c | 35 ++-
1 file
-by: Andreas Färber afaer...@suse.de
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/input/keyboard/cros_ec_keyb.c | 92 +++
1 file changed, 49 insertions(+), 43 deletions(-)
diff --git a/drivers/input/keyboard/cros_ec_keyb.c
b
Hello,
On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz
b.zolnier...@samsung.com wrote:
IMHO they should go to upstream ASAP as they fix the boot for
ODROID boards and they cannot break anything as they are limited
to ODROID dts files.
Agreed, this is definitely -rc material
Hello Ulf,
On 08/15/2014 04:51 PM, Ulf Hansson wrote:
Just wanted to add some input regarding the errors in the mmc case.
These are of high importance. In principle if you get, Failed getting
OCR mask: -22, likely you will be using a wrong OCR mask while
negotiating the voltage level with
On 08/19/2014 02:43 PM, Ulf Hansson wrote:
Well, currently this seems like the best approach. If we end up having
some new regulator helper function, future wise, we can convert to
such later on.
Great, thanks a lot for your help!
Kind regards
Uffe
Best regards,
Javier
--
To
cleanly on top of linux-next. Also I've taken some DT snippets
from the downstream Chrome OS 3.8 kernel DTS for devices that use
one of the regulators of these regulators has their input supply.
The series is composed of the following patches:
Javier Martinez Canillas (3):
ARM: dts: Add Peach Pit
in the
the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 371 +
arch/arm/boot/dts/exynos5800-peach-pi.dts
From: Rahul Sharma rahul.sha...@samsung.com
Adding regulators for HDMI for Peach-pi board.
Signed-off-by: Rahul Sharma rahul.sha...@samsung.com
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
v2: 1
for Peach Pit and Pi boards.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 ++
arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b
From: Rahul Sharma rahul.sha...@samsung.com
Adding regulators for hdmi for peach-pit board.
Signed-off-by: Rahul Sharma rahul.sha...@samsung.com
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch
...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/cros-adc-thermistors.dtsi | 44 +
arch/arm/boot/dts/exynos5420-peach-pit.dts | 6
arch/arm/boot/dts/exynos5800-peach-pi.dts | 6
3 files changed, 56
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
the patches had been
already acked by you so I hope there won't be issues to get
them merged.
The series were tested on an Exynos5250 Snow (max77686) and
Exynos5420 Peach Pit (max77802) machines and applies cleanly
to both 3.17-rc1 and today's linux-next (20140818).
Javier Martinez Canillas (6):
clk
Add Device Tree binding documentation for the regulators
present in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
.../devicetree/bindings/regulator/max77802.txt | 53 ++
1 file changed, 53 insertions
for the max77686 rtc.
The series were tested on an Exynos5250 Snow (max77686) and
Exynos5420 Peach Pit (max77802) machines and applies cleanly
to both 3.17-rc1 and today's linux-next (20140818).
Doug Anderson (1):
rtc: max77686: Allow the max77686 rtc to wakeup the system
Javier Martinez Canillas (4
the i2c
bus up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v6: None
Changes since v5:
- Fix $SUBJECT since
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be used by both the max77686
clock driver and Device Tree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Reviewed-by: Mike
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
If devm_rtc_device_register() fails a dev_err() is already
reported so there is no need to do an additional dev_info().
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/rtc/rtc-max77686.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/rtc/rtc
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Mike Turquette mturque...@linaro.org
---
Changes since v6: None
Changes since v5:
- Fix typo error in DT
on the max77802 driver
since v7 of the old series.
The series were tested on an Exynos5420 based Peach Pit board
and applies cleanly to both 3.17-rc1 and today's next-20140818.
Javier Martinez Canillas (2):
regulator: Add driver for max77802 PMIC PMIC regulators
regulator: Add DT bindings
the driver was original merged in
commit fca1dd03 (rtc: max77686: add Maxim 77686 driver).
So, since this code has never been built, let's just remove it.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/rtc
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Finally, add clock-output-names as an optional property
since now is supported by the clock driver.
Signed-off-by: Javier Martinez Canillas
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Mike Turquette mturque
instead of getting an OOPS.
Reported-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Fixes the issue reported by Krzystof in: https://lkml.org/lkml/2014/8/8/121
---
drivers/rtc/rtc-max77686.c | 6 ++
1 file changed, 6
Hello Nick,
On 08/15/2014 06:08 PM, Nick Dyer wrote:
Any comments on this? I would really appreciate if you can expand on how
this DT property is supposed to be used so I can re-spin the atmel support
patch for Peach boards.
The below patch improves the documentation for the
Hello Kukjin,
On 08/18/2014 08:27 PM, Kukjin Kim wrote:
On 08/11/14 10:46, Doug Anderson wrote:
OK, I've applied this but 2nd in this series...
Thanks for picking this and yes PATCH 2/2 from this series was dropped.
Acked-by: Doug Andersondiand...@chromium.org
Thanks,
Kukjin
I've
Hello Tim,
On 08/15/2014 07:36 AM, Tim Kryger wrote:
On Thu, Aug 14, 2014 at 8:19 AM, Mark Brown broo...@kernel.org wrote:
Right, there's two things going on here. One is that as you describe we
shouldn't be putting constraints in .dtsi files if we don't know they're
OK for a given board.
Hello Mark,
On 08/15/2014 11:55 AM, Mark Brown wrote:
On Fri, Aug 15, 2014 at 09:48:43AM +0200, Javier Martinez Canillas wrote:
But now I wonder why regulator_list_voltage() even list the voltage for
fixed regulators (desc-fixed_uV) since they don't have the ability to
That's because it's
Hello Nick,
On 08/08/2014 04:52 PM, Javier Martinez Canillas wrote:
On 08/07/2014 02:38 PM, Nick Dyer wrote:
I'm afraid you have misunderstood the impact of this change to the way that
the GPIOs coming in to the touch controller are mapped to key codes. Look
Unfortunately
().
Without this patch, the following warning is reported when
a FET is used as a vmmc-supply:
dwmmc_exynos 1222.mmc: Failed getting OCR mask: -22
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mmc/core/core.c | 14 +++---
1 file changed, 11
Hello Tim,
Thanks for your feedback.
On 08/14/2014 04:13 PM, Tim Kryger wrote:
https://lkml.org/lkml/2014/8/12/377
Perhaps I misunderstood the discussion in that thread but couldn't
this failure also be addressed by adding proper constraints for each
FET in individual DTS files to
Hello Mark,
On 08/12/2014 11:27 PM, Mark Brown wrote:
On Tue, Aug 12, 2014 at 08:49:29PM +0200, Javier Martinez Canillas wrote:
So, is adding these voltages ranges (the design limits) in the Peach Pit DTS
file directly an acceptable solution? Basically what my previous patch [0]
did
On 08/13/2014 02:29 PM, Mark Brown wrote:
Please fix your mailer to word wrap at less than 80 columns, it makes
your mails very hard to read when replying.
Sorry I had my wrap length configured to 80 but just changed to 74 now.
On 08/12/2014 11:27 PM, Mark Brown wrote:
No, that makes
Hello Mark,
On 08/13/2014 05:51 PM, Mark Brown wrote:
On Wed, Aug 13, 2014 at 03:34:12PM +0200, Javier Martinez Canillas wrote:
Indeed. I'll change mmc_regulator_get_ocrmask() in MMC core then to use
regulator_can_change_voltage() to detect if the regulator is a fixed one
and call
Hello Stephen,
On 08/13/2014 06:16 PM, Stephen Warren wrote:
I'm worried that this file represents the limits of the PMIC itself,
whereas the DT should be representing the limits of the circuits that
the various PMIC regulators are attached to on the board.
For example:
diff --git
Peach Pit and Pi machines have the same regulators connection
and regulator name so the cros-tps65090 dtsi file can be used
to remove duplicated code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 95
parent output voltage if the child voltage is queried.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/cros-tps65090.dtsi | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/cros-tps65090.dtsi
b/arch/arm/boot
The tps65090 PMU is a component used in many ChromeOS devices
so instead of having the same device tree definitions in many
files, create a .dtsi fragment that can be included in DTS.
This fragment is based on the DT definitions for Peach boards.
Signed-off-by: Javier Martinez Canillas
and can be done in a follow-up patch as well.
Javier Martinez Canillas (6):
ARM: dts: Create fragment for tps65090 PMU
ARM: dts: Use tps65090 fragment in exynos5250-snow
ARM: dts: Create cros-tps65090 fragment
ARM: dts: Use cros-tps65090 fragment in Peach boards
ARM: dts: Improve cros
The tps65090 PMU data manual [0] has a table that list the
Recommended operating conditions for each regulator. Add
the information about the FET constraints to its dtsi file.
[0]: http://www.ti.com/lit/ds/symlink/tps65090.pdf
Signed-off-by: Javier Martinez Canillas javier.marti
Hello Mark,
On 08/12/2014 06:58 PM, Mark Brown wrote:
On Tue, Aug 12, 2014 at 06:44:23PM +0200, Javier Martinez Canillas wrote:
The tps65090 is a Power Management Unit (PMU) used in several
boards so the same information is described on different DTS.
It is better to create a .dtsi fragment
On 08/12/2014 07:25 PM, Mark Brown wrote:
tps65090_fet1: fet1 {
+regulator-min-microvolt = 500;
+regulator-max-microvolt = 1700;
};
No, this is completely broken and exactly the sort of thing that makes
doing
Hello Doug,
Thanks for your feedback.
On 08/12/2014 07:26 PM, Doug Anderson wrote:
Javier,
On Tue, Aug 12, 2014 at 9:44 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
The tps65090 PMU is a component used in many ChromeOS devices
so instead of having the same device
Hello Linus,
On 08/11/2014 10:32 AM, Linus Walleij wrote:
I guess this discussion is about drivers/pinctrl/samsung/pinctrl-exynos.c?
Or else I'm not really following this... $SUBJECT is a bit confusing.
Yes, the thing is that at the beginning I (wrongly) thought that the IRQ trigger
type
Many Exynos5 boards (e.g: Snow, Peach Pit and Pi) have
a SBS-compliant gas gauge battery. Enable it as module
so the needed support is available for these boards.
Suggested-by: Doug Anderson diand...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked
parent output voltage if the child voltage is queried.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Mark Brown broo...@linaro.org
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 ++--
arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 ++--
2 files
as bounded limits for the timeout. That is what
is used in the board schematics and should be in the DT too.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 14 ++
arch/arm/boot/dts/exynos5800-peach-pi.dts | 14
Hello Bartlomiej,
On 08/11/2014 02:40 PM, Bartlomiej Zolnierkiewicz wrote:
index fc7d168..c390bb9 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -77,6 +77,7 @@ CONFIG_SPI_S3C64XX=y
CONFIG_I2C_S3C2410=y
CONFIG_DEBUG_GPIO=y
CONFIG_POWER_SUPPLY=y
Hello,
On 08/11/2014 05:59 PM, Doug Anderson wrote:
Bartlomiej,
On Mon, Aug 11, 2014 at 8:42 AM, Bartlomiej Zolnierkiewicz
b.zolnier...@samsung.com wrote:
Hi,
On Monday, August 11, 2014 02:52:27 PM Javier Martinez Canillas wrote:
Hello Bartlomiej,
On 08/11/2014 02:40 PM, Bartlomiej
Hello Mark,
On 08/11/2014 06:02 PM, Mark Brown wrote:
On Mon, Aug 11, 2014 at 08:57:24AM -0700, Doug Anderson wrote:
On Mon, Aug 11, 2014 at 4:38 AM, Javier Martinez Canillas
After the switch is turned on, a safety timer is started
and before this timer times out the output voltage must
Hello Bartlomiej,
On 08/11/2014 07:28 PM, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Monday, August 11, 2014 06:23:01 PM Javier Martinez Canillas wrote:
Hello,
On 08/11/2014 05:59 PM, Doug Anderson wrote:
Bartlomiej,
On Mon, Aug 11, 2014 at 8:42 AM, Bartlomiej Zolnierkiewicz
Hello Doug,
On 08/11/2014 05:57 PM, Doug Anderson wrote:
Javier,
On Mon, Aug 11, 2014 at 4:38 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Both Exynos5420 Peach Pit and Exynos5800 Peach Pi boards
have a tps65090 PMU that has a number of switches (FETs)
that are just
Many Exynos5 boards (e.g: Snow, Peach Pit and Pi) have
a SBS-compliant gas gauge battery. Enable to built it
so the needed support is available for these boards.
Suggested-by: Doug Anderson diand...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked
Hello Krzysztof and Bartlomiej,
On 08/08/2014 09:59 AM, Krzysztof Kozlowski wrote:
On czw, 2014-08-07 at 18:09 +0200, Bartlomiej Zolnierkiewicz wrote:
Before commit 6f1c1e71d933 (mfd: max77686: Convert to use regmap_irq)
max77686_irq_init() return value was never checked so devices without
Hello,
On 08/08/2014 10:58 AM, Javier Martinez Canillas wrote:
Not sufficient. You have to also fix RTC driver (OOPS from Trats2
attached). Also consider adding checks for (max77686-irq) to the
suspend and resume.
Right, the max77686 RTC driver assumes that an IRQ domain
Hello Krzysztof,
On 08/08/2014 12:54 PM, Krzysztof Kozlowski wrote:
Not sufficient. You have to also fix RTC driver (OOPS from Trats2
attached). Also consider adding checks for (max77686-irq) to the
suspend and resume.
Right, the max77686 RTC driver assumes that an IRQ domain
On 08/08/2014 02:24 PM, Bartlomiej Zolnierkiewicz wrote:
It seems that Daniel Drake has already fixed ODROID dtsi with:
[PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg34191.html
and
[PATCH 2/2] ARM: dts:
Hello,
On 08/07/2014 06:47 PM, Dmitry Torokhov wrote:
Actually, I take this back. In mainline everything as it should: if
pdata does not specify particular trigger the flags requested end up
being IRQF_ONESHOT, which should preserve trigger bits previously set up
by the board or OF code. In
. The number
4 is wrong, the protocol does allow for up to 8 GPIOs. But it is a hard limit.
Thanks a lot for the explanation, then I guess s/4/8 is enough.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation/devicetree/bindings/input/atmel,maxtouch.txt | 8
+Thomas Gleixner, Jason Cooper, Benjamin Herrenschmidt and Thomas Abraham
Hello Dmitry,
On 08/08/2014 06:21 PM, Dmitry Torokhov wrote:
On Fri, Aug 08, 2014 at 03:07:33PM +0100, Nick Dyer wrote:
On 07/08/14 08:44, Javier Martinez Canillas wrote:
The Atmel maXTouch driver assumed that the IRQ
Hello,
On 08/08/2014 06:38 PM, Javier Martinez Canillas wrote:
It seems as if the first call to exynos_irq_set_type() that is made by OF is a
no-op while the second call is the one that actually setups the hw correctly.
Does this make any sense? Maybe is related to the pin not being muxed
Hello Doug,
On 08/08/2014 10:54 PM, Doug Anderson wrote:
Hi,
To fix the issue a variation of patch [0] will be posted that moves the IRQ
pinmux setup from .irq_set_type to the .irq_request_resources function
handler.
That way the pin will be setup as IRQ regardless of the the trigger type
and expand commit message]
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
This patch solves the issue explained in https://lkml.org/lkml/2014/8/8/461
drivers/pinctrl/samsung/pinctrl-exynos.c | 69 ---
drivers/pinctrl/samsung/pinctrl-samsung.h
type
than IRQ_TYPE_NONE. The right approach is to get the IRQ flags
that was parsed by OF from the interrupt Device Tree propery.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
This patch was first sent as a part of a two part series along
with [PATCH 2/2] Input
Hello Dmitry,
On 08/07/2014 08:09 AM, Dmitry Torokhov wrote:
irq_of_parse_and_map() already sets up IRQ trigger type based on DT
data, by calling irq_create_of_mapping() which in turn calls
irq_set_irq_type().
Right but somehow when the IRQ is actually requested the type is
Hello,
On 08/04/2014 05:42 PM, Doug Anderson wrote:
For the touchpad it seems DT support has landed in the input tree as
atmel,maxtouch. Backporting just that patch does not make it work
though. (Tried the rejected pinctrl approach to be on the safe side.)
type
than IRQ_TYPE_NONE. The right approach is to get the IRQ flags
that was parsed by OF from the interrupt Device Tree propery.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/input/touchscreen/atmel_mxt_ts.c | 9 -
1 file changed, 8 insertions(+), 1
is four entries but the driver dynamically allocates the
keymap array and does not limit the array size.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation/devicetree/bindings/input/atmel,maxtouch.txt | 8 +++-
1 file changed, 7 insertions(+), 1 deletion
-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
With only this patch the touchpad is probed but interrupts are not being
generated. The following is needed to have a fully functional touchpad:
[PATCH 1/2] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting
https
Hello Tomasz,
Thanks a lot for your feedback.
On 08/07/2014 03:14 AM, Tomasz Figa wrote:
Hi Javier,
Have you observed an actual failure due to this? I believe that
Yes, I found this issue since the driver was not taking into account the value
defined in the edge/level type cells from the
Hello Fabio,
On 08/07/2014 03:35 AM, Fabio Estevam wrote:
On Wed, Aug 6, 2014 at 10:08 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
+hsi2c_8 {
+ status = okay;
+ clock-frequency = 333000;
Doesn't it work at the more standard 400kHz i2c frequency
This series add the model_name, manufacturer and voltage_min_design
files from the power supply monitor class sysfs interface that were
missing for the sbs-battery driver. The commits were taken from the
Chrome OS 3.8 downstream kernel and patches were squashed when they
just fixed bugs introduced
.
Signed-off-by: Simon Que s...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
Reviewed-by: Todd Broch tbr...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/power/sbs-battery.c | 10 --
1 file changed, 8 insertions(+), 2 deletions
...@chromium.org
Reviewed-by: Olof Johansson ol...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/power/sbs-battery.c | 115
1 file changed, 115 insertions(+)
diff --git a/drivers/power/sbs-battery.c b
Hello Doug,
On 08/04/2014 05:22 PM, Doug Anderson wrote:
+
+pinctrl_0 {
+ s5m8767_dvs: s5m8767-dvs {
+ samsung,pins = gpd1-0, gpd1-1, gpd1-2;
+ samsung,pin-function = 0;
+ samsung,pin-pud = 1;
+ samsung,pin-drv = 0;
+ };
Hello Doug,
On 08/04/2014 05:42 PM, Doug Anderson wrote:
Both of you mentioned limitations of cros_ec i2c passthrough leading to
a forked tps65090 driver downstream - I don't think I can be of help
there, as I guess simply copying a driver will not be an option. ;)
Hello Wolfram,
On 08/01/2014 07:59 PM, Wolfram Sang wrote:
+#define I2C_MAX_RETRIES 3
I think a define for this is overkill, yet I don't really mind.
Acked-by: Wolfram Sang w...@the-dreams.de
Thanks a lot.
I assume this goes via MFD, let me know if I should take it.
Yes, if
Hello Andreas,
Sorry for missing your v5.
On 08/02/2014 02:52 AM, Andreas Färber wrote:
chosen {
+ bootargs = console=tty1;
};
While I agree with you that having a chosen node with a default bootargs is
better than having an empty one, I second Doug that this
-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
NOTE: I thought that Tomasz Figa gave you his Reviewed-by on v5 for the whole
series as well but I didn't see his tag on the v6 patches.
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
: Doug Anderson diand...@chromium.org
Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk
Cc: Andreas Faerber afaer...@suse.de
Cc: Sachin Kamat sachin.ka...@linaro.org
Signed-off-by: Thomas Abraham thomas...@samsung.com
---
arch/arm/boot/dts/exynos4210-origen.dts |4
for the switches.
Javier Martinez Canillas (2):
ARM: dts: Improve Peach Pit and Pi power scheme model
ARM: dts: Add tps65090 FET constraints on Peach Pit and Pi
arch/arm/boot/dts/exynos5420-peach-pit.dts | 26 --
arch/arm/boot/dts/exynos5800-peach-pi.dts | 26
parent output voltage if the child voltage is queried.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Mark Brown broo...@linaro.org
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 ++--
arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 ++--
2 files
1001 - 1100 of 1325 matches
Mail list logo
