Some Exynos boards have SPI devices such as flash memories that can be
accessed from user-space. Enable support for the SPI usermode interface.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1 insertion
-by: Olof Johansson ol...@chromium.org
[javier.martinez: Extend commit message]
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5250-snow.dts | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250
Anderson diand...@chromium.org
[javier.martinez: Extend commit message]
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 26 ++
arch/arm/boot/dts/exynos5800-peach-pi.dts | 26 ++
2
Hello Kevin,
On 11/17/2014 11:24 PM, Kevin Hilman wrote:
As might have been expected, reverting the change that enables the
DRM/display options in exynos_defconfig fixes the problem.
Kevin
I'm sorry for causing a boot failure but when I first posted that patch,
the Exynos DRM driver was
gadget support.
The patch looks good to me.
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Kukjin,
I think $subject is -rc material since this issue is seen after commit
508423b (ARM: exynos_defconfig: enable USB gadget support) which
landed in 3.18.
Best regards,
Javier
Hello Kukjin,
On 11/13/2014 03:12 AM, Kukjin Kim wrote:
Oh, sorry. I'm here and applying this patch into samsung tree.
Great, thanks a lot!
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to
Hello Kukjin,
On Tue, Oct 28, 2014 at 12:06 PM, Kukjin Kim kg...@kernel.org wrote:
Javier Martinez Canillas wrote:
Commit 6e80e3d87549 (ARM: exynos_defconfig: Enable MAX77802)
enabled support for the max77802 regulators but the PMIC also
has a Real-Time-Clock (RTC) and 2-channel 32kHz clock
Hello Pankaj, Kukjin,
On Tue, Oct 28, 2014 at 10:50 AM, Pankaj Dubey pankaj.du...@samsung.com wrote:
This patch fixes a typo in struct named as exynos5_list_diable_wfi_wfe
by making it exynos5_list_disable_wfi_wfe which is more meaningful.
Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com
Hello Kukjin,
On Thu, Oct 30, 2014 at 11:06 AM, Javier Martinez Canillas
jav...@dowhile0.org wrote:
Hello Kukjin,
On Mon, Oct 20, 2014 at 11:05 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
The regulator framework has a set of helpers functions to be used when
the same configuration found in the ChromeOS 3.8 kernel.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 81 ++
arch/arm/boot/dts/exynos5800-peach-pi.dts | 81 ++
2 files
support their mode to be changed on system suspend.
Extend the max77802 PMIC binding by documenting the possible operating
modes values so the regulators modes can be configured correctly.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
.../devicetree/bindings
to be changed while the system has entered in a
suspend state.
Use the max77802_map_mode() function to translate the device specific
modes to the standard operating modes as used by the regulator core.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator
depends on Krzysztof's series:
[PATCH v2 0/3] regulator: max77686/802: Cleanup [2].
The patch-set is composed of the following patches:
Javier Martinez Canillas (3):
regulator: max77802: Document binding for regulator operating modes
regulator: max77802: Fill regulator modes translation callback
will add the new opmode feature to
the max77802 regulator driver.
The series is composed of the following patches:
Javier Martinez Canillas (5):
regulator: Document binding for initial and suspend modes
regulator: Add mode mapping function to struct regulator_desc
regulator: of: Add regulator desc
so
the parsing logic could use the information in the struct regulator_desc.
of_get_regulator_init_data() relies on of_get_regulation_constraints() to
actually extract the init_data so it has to pass the struct regulator_desc
but that is modified on a later patch.
Signed-off-by: Javier Martinez
the system enters into sleep.
The modes are defined in the Device Tree using the hardware specific
modes supported by the regulators. Regulator drivers have to define a
translation function that is used to map the hardware specific modes
to the standard ones.
Signed-off-by: Javier Martinez Canillas
extract
some DT properties like the regulator initial and suspend modes. Use the
match table to pass that information.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
This patch only adds the struct regulator_desc pointer to the struct
of_regulator_match and does
translation.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes in v6:
- Rename function from .map_modes to .of_map_mode. Suggested by Mark Brown.
- Remove obvious explanation from the function doc. Suggested by Mark Brown.
Changes in v5:
- Add a better explanation
of possible modes that a regulator can operate depends on the
hardware capabilities so a list of generic operating modes can't be
provided. Instead, each hardware binding should define the list of
valid operating modes for the regulators found on that device.
Signed-off-by: Javier Martinez Canillas
of the following patches:
Javier Martinez Canillas (5):
regulator: Document binding for initial and suspend modes
regulator: Add function to map modes to struct regulator_desc
regulator: of: Add regulator desc param to
of_get_regulator_init_data()
regulator: of: Pass the regulator description
the system enters into sleep.
The modes are defined in the Device Tree using the hardware specific
modes supported by the regulators. Regulator drivers have to define a
translation function that is used to map the hardware specific modes
to the standard ones.
Signed-off-by: Javier Martinez Canillas
extract
some DT properties like the regulator initial and suspend modes. Use the
match table to pass that information.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
This patch only adds the struct regulator_desc pointer to the struct
of_regulator_match and does
so
the parsing logic could use the information in the struct regulator_desc.
of_get_regulator_init_data() relies on of_get_regulation_constraints() to
actually extract the init_data so it has to pass the struct regulator_desc
but that is modified on a later patch.
Signed-off-by: Javier Martinez
translation.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes in v5:
- Add a better explanation of what mode is passed as an argument and what
mode is returned. Suggested by Krzysztof Kozlowski.
- Explain that this callback is needed to be able to parse
of possible modes that a regulator can operate depends on the
hardware capabilities so a list of generic operating modes can't be
provided. Instead, each hardware binding should define the list of
valid operating modes for the regulators found on that device.
Signed-off-by: Javier Martinez Canillas
Hello Mark,
Thanks a lot for your feedback.
On 11/07/2014 03:58 PM, Mark Brown wrote:
On Fri, Nov 07, 2014 at 02:00:01PM +0100, Javier Martinez Canillas wrote:
+ The regulator-mode property only takes effect if the regulator is
+ enabled for the given suspend state using regulator
Hello Mark,
On 11/07/2014 04:07 PM, Mark Brown wrote:
This is using the regulator descriptor before it is initialized which
doesn't seem ideal...
You are right, even if most of them are not used currently, that may
change in the future so is safer to use it after all fields have been
Hello Krzysztof,
On 11/07/2014 04:23 PM, Krzysztof Kozlowski wrote:
static struct fan53555_platform_data *fan53555_parse_dt(struct device *dev,
-struct device_node *np)
+struct device_node *np,
On 11/07/2014 04:47 PM, Mark Brown wrote:
On Fri, Nov 07, 2014 at 02:00:05PM +0100, Javier Martinez Canillas wrote:
+if (!of_property_read_u32(np, regulator-initial-mode, pval)) {
+if (desc desc-map_modes)
+constraints-initial_mode = desc-map_modes(pval
On 11/07/2014 04:54 PM, Mark Brown wrote:
of_map_mode - it's only one mode and this is mapping to/from DT.
Ok
+ * If the callback is not defined, the regulator-initial-mode
+ * and suspend states regulator-mode properties won't be
parsed.
Just remove this, it's
Hello Mark,
On 11/07/2014 05:10 PM, Mark Brown wrote:
You're also saying that the OS won't manage the mode here, that's a step
further.
I see
So should I just explain what each property is about without trying to make
assumptions about the limitations that different devices could have
Hello Krzysztof,
On 11/04/2014 11:44 AM, Krzysztof Kozlowski wrote:
Where's a diff stat? It is helpful to see what files were touched and I
believe it is created by default with format-patch.
Yes, I removed the diffstat since it was quite big due the drivers
refactor and the cover letter
Hello Krzysztof,
Thanks a for your feedback.
On 11/04/2014 11:31 AM, Krzysztof Kozlowski wrote:
+ *
+ * @map_modes: Callback invoked to translate between hardware to standard
modes.
Initially I thought it should map from standard to hardware. But then I
looked at max77802 implementation
Hello Krzysztof,
On 11/04/2014 11:41 AM, Krzysztof Kozlowski wrote:
+if (!of_property_read_u32(np, regulator-initial-mode, pval)) {
+if (desc desc-map_modes)
+constraints-initial_mode = desc-map_modes(pval);
+else
+
on [0] and also v2 of patch:
ARM: EXYNOS: Call regulator core suspend prepare and finish functions [1].
Javier Martinez Canillas (14):
regulator: Document binding for initial and suspend modes
regulator: Add function to map modes to struct regulator_desc
regulator: of: Add regulator desc
to be changed while the system has entered in a
suspend state.
Use the max77802_map_mode() function to translate the device specific
modes to the standard operating modes as used by the regulator core.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator
The struct of_regulator_match is declared as a non-static local variable
so the structure members are not auto-initialized.
Initialize the struct at declaration time to avoid the structure members
values to be indeterminate and have sane defaults instead.
Signed-off-by: Javier Martinez Canillas
using the same configuration found in the ChromeOS 3.8 kernel.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes in v4: None
Changes in v3:
- Use the standard suspend state binding as suggested by Mark Brown.
arch/arm/boot/dts/exynos5420-peach-pit.dts | 81
All function dealing with operating modes use unsigned int for modes
so change max77802_map_mode() function signature for consistency.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator/max77802.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
the system enters into sleep.
The modes are defined in the Device Tree using the hardware specific
modes supported by the regulators. Regulator drivers have to define a
translation function that is used to map the hardware specific modes
to the standard ones.
Signed-off-by: Javier Martinez Canillas
support their mode to be changed on system suspend.
Extend the max77802 PMIC bindin by documenting the possible operating
modes values so the regulators modes can be correctly configured.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes in v4: None
Changes
The struct of_regulator_match rmatch[] is declared as a non-static local
variable so the structure members are not auto-initialized.
Initialize the array at declaration time to avoid the structure members
values to be indeterminate and have sane defaults instead.
Signed-off-by: Javier Martinez
The struct of_regulator_match rmatch[] is declared as a non-static local
variable so the structure members are not auto-initialized.
Initialize the array at declaration time to avoid the structure members
values to be indeterminate and have sane defaults instead.
Signed-off-by: Javier Martinez
translation.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
include/linux/regulator/driver.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h
index 28da08e..b54d037 100644
--- a/include/linux/regulator
The struct of_regulator_match is declared as a non-static local variable
so the structure members are not auto-initialized.
Initialize the struct at declaration time to avoid the structure members
values to be indeterminate and have sane defaults instead.
Signed-off-by: Javier Martinez Canillas
Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator/88pm8607.c | 3 ++-
drivers/regulator/anatop-regulator.c | 2 +-
drivers/regulator/arizona-ldo1.c | 3 ++-
drivers/regulator/arizona-micsupp.c| 2 +-
drivers/regulator/da9052-regulator.c | 2
extract
some DT properties like the regulator initial and suspend modes. Use the
match table to pass that information.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator/of_regulator.c | 3 ++-
include/linux/regulator/of_regulator.h | 1 +
2 files
The struct of_regulator_match rmatch[] is declared as a non-static local
variable so the structure members are not auto-initialized.
Initialize the array at declaration time to avoid the structure members
values to be indeterminate and have sane defaults instead.
Signed-off-by: Javier Martinez
of possible modes that a regulator can operate depends on the
hardware capabilities so a list of generic operating modes can't be
provided. Instead, each hardware binding should define the list of
valid operating modes for the regulators found on that device.
Signed-off-by: Javier Martinez Canillas
On 11/03/2014 04:33 PM, Mark Brown wrote:
On Mon, Nov 03, 2014 at 03:40:38PM +0100, Javier Martinez Canillas wrote:
for_each_child_of_node(nproot, np) {
if (!of_node_cmp(np-name, info-desc.name)) {
config-init_data
On 11/03/2014 04:41 PM, Mark Brown wrote:
On Mon, Nov 03, 2014 at 03:40:40PM +0100, Javier Martinez Canillas wrote:
The struct of_regulator_match rmatch[] is declared as a non-static local
variable so the structure members are not auto-initialized.
Applied, thanks.
This is a bug fix
On 11/03/2014 04:54 PM, Mark Brown wrote:
No, it's not. This is a a patch series doing a whole bunch of different
things, there's at least bug fixes to existing drivers, new features and
also this new driver in what I've glanced at so far. These things
shouldn't just be being thrown
On 11/03/2014 04:59 PM, Mark Brown wrote:
No, it's only *currently* used for that. If we don't bother passing the
descriptor in then future additions which make use of it (including
adding mode operations to existing drivers) won't work and it might not
be obvious why.
fair enough.
Hello Kukjin,
On Mon, Aug 25, 2014 at 10:45 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Many Exynos devices have a display panel. Most of them just have
a simple panel while others have more complex configurations that
requires an embedded DisplayPort (eDP) to LVDS
Hello Kukjin,
On Mon, Oct 20, 2014 at 11:05 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
The regulator framework has a set of helpers functions to be used when
the system is entering and leaving from suspend but these are not called
on Exynos platforms. This means
;
+ } else {
+ val = val shift MAX77802_OPMODE_MASK;
+ }
/*
* If the regulator is disabled and the system warm rebooted,
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
Hello Krzysztof,
On 10/30/2014 12:20 PM, Krzysztof Kozlowski wrote:
static int max77802_pmic_probe(struct platform_device *pdev)
{
struct max77686_dev *iodev = dev_get_drvdata(pdev-dev.parent);
- struct max77686_platform_data *pdata = dev_get_platdata(iodev-dev);
struct
Hello Krzysztof,
On 10/30/2014 01:10 PM, Krzysztof Kozlowski wrote:
I may be missing something but I don't understand why a compatible string
for the regulators sub-node is needed. Isn't enough to just fill the
.regulators_node field in the struct regulator_desc? e.g:
.regulators_node
Hello Krzysztof,
On 10/30/2014 01:30 PM, Krzysztof Kozlowski wrote:
tor_of_get_init_data() function?
The regulator_of_get_init_data() searches from dev-of_node or its child
node.
But dev-of_node is NULL.
That's why of_compatible is needed.
Yes but regulator_register() does dev
Hello Krzysztof,
On 10/30/2014 01:53 PM, Krzysztof Kozlowski wrote:
To me a intuitive structure would be:
MFD device
|
- clock device
|
- clock1
- clock2
- regulator device
|
- LDO1
- LDO2
etc.
This also maps to structure in DTS. dev_err*
[adding Linus and Alexandre to the cc list]
Hello Krzysztof,
On 10/29/2014 11:42 AM, Krzysztof Kozlowski wrote:
On wto, 2014-10-28 at 13:11 +0100, Krzysztof Kozlowski wrote:
On wto, 2014-10-28 at 09:52 +0100, Krzysztof Kozlowski wrote:
On pon, 2014-10-27 at 21:03 +0100, Javier Martinez
Hello Krzysztof,
On 10/29/2014 11:44 AM, Krzysztof Kozlowski wrote:
On śro, 2014-10-29 at 10:31 +, Mark Brown wrote:
On Wed, Oct 29, 2014 at 11:18:54AM +0100, Krzysztof Kozlowski wrote:
On śro, 2014-10-29 at 10:01 +, Mark Brown wrote:
No, this isn't suspend enable control - this
explained, I understand this is the right thing to do.
Acked-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Hello Krzysztof,
On 10/29/2014 04:06 PM, Krzysztof Kozlowski wrote:
static int max77802_pmic_probe(struct platform_device *pdev)
{
struct max77686_dev *iodev = dev_get_drvdata(pdev-dev.parent);
- struct max77686_platform_data *pdata = dev_get_platdata(iodev-dev);
struct
Hello Krzysztof,
On 10/28/2014 09:45 AM, Krzysztof Kozlowski wrote:
Thanks! However Mark had some comments which will reorganize the patch
completely. I'll be sending next version and probably I would need your
ack and testing again.
Sure, I can test your patches if you don't have access
Hello Kukjin,
On Wed, Oct 8, 2014 at 7:41 AM, Abhilash Kesavan a.kesa...@samsung.com wrote:
Use the MCPM layer to handle core suspend/resume on Exynos5420.
Also, restore the entry address setup code post-resume.
Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com
Acked-by: Nicolas Pitre
Hello Ajay,
On Thu, Oct 16, 2014 at 11:04 AM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Right. It would be great if you guys come to agreement ASAP!
I don't think we'll agree any time soon, so I believe it's up to you to decide
which option is best based on all arguments that
Exynos boards.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Kevin Hilman khil...@linaro.org
Tested-by: Kevin Hilman khil...@linaro.org
---
This patch supersedes [0] since commit ARM: exynos_defconfig: savedefconfig
is not present in linux-next anymore which
Hello Krzysztof,
On 10/27/2014 10:44 AM, Krzysztof Kozlowski wrote:
Some LDOs of Maxim 77686 PMIC support disabling during system suspend
(LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part
of set_suspend_mode function. In that case the mode was one of:
- disable,
-
On 10/27/2014 11:27 AM, Krzysztof Kozlowski wrote:
Storing opmode in non-shifted form is intuitive also to me. That's way I
slipped the bug in previous version.
Great.
I'll change this to non-shifted opmode. The patch will grow bigger but
the code should be more readable.
Maybe split
. Additionally this will allow adding support LDOs to the
existing set_suspend_disable function.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Suggested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator/max77686.c | 49
.c
+++ b/drivers/regulator/max77686.c
Looks good to me.
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo
Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Krzysztof,
On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote:
The driver is used only on Exynos4 based boards with DTS support.
Convert the driver to DTS-only version.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/regulator/max77686.c | 51
/max77686.c
+++ b/drivers/mfd/max77686.c
As I said in Patch 2/8, I think this driver should depend on OF since
is now DT-only. Regulator drivers don't need to do this since they
already depend on MFD_MAX77686. With that change feel free to add:
Reviewed-by: Javier Martinez Canillas javier.marti
= {
MAX77686_OPMODE_BUCK234_SHIFT, \
}
-static struct regulator_desc regulators[] = {
+static const struct regulator_desc regulators[] = {
regulator_desc_ldo1_low(1),
regulator_desc_ldo_low(2),
regulator_desc_ldo(3),
Reviewed-by: Javier Martinez Canillas javier.marti
Hello Krzysztof,
On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote:
Minor nit: Initialize the opmode for each regulator to normal mode in a
readable explicit way.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Suggested-by: Javier Martinez Canillas javier.marti
Hello Krzysztof,
On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote:
@@ -85,6 +91,9 @@ struct max77686_data {
struct max77686_regulator_data *regulators;
int num_regulators;
+ /* Array of size num_regulators with GPIOs for external control. */
+ int *ext_control_gpio;
Hello Krzysztof,
On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote:
Document usage of gpio property which turns on external control over
regulator.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Documentation/devicetree/bindings/mfd/max77686.txt | 3 +++
1 file changed, 3
Hello Mark,
On 10/24/2014 11:02 PM, Mark Brown wrote:
On Thu, Oct 23, 2014 at 11:28:09AM +0200, Javier Martinez Canillas wrote:
Please fix your mailer to word wrap within paragraphs - you should know
this by now :/ I've reflowed for legibility.
Sorry about that, I was on holidays last
Hello Mark,
On 22/10/2014, at 18:48, Mark Brown broo...@kernel.org wrote:
On Mon, Oct 20, 2014 at 04:47:51PM +0200, Javier Martinez Canillas wrote:
+char *states[PM_SUSPEND_MAX + 1] = {
+[PM_SUSPEND_MEM] = regulator-state-mem,
+[PM_SUSPEND_MAX] = regulator-state-disk
to me.
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Krzysztof,
On 10/21/2014 10:25 AM, Krzysztof Kozlowski wrote:
Some LDOs of Maxim 77686 PMIC support disabling during system suspend
(LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part
You should also document what each regulator support in the max77686 DT binding
doc,
Hello Krzysztof,
On 10/21/2014 11:36 AM, Krzysztof Kozlowski wrote:
On wto, 2014-10-21 at 11:10 +0200, Javier Martinez Canillas wrote:
In general, could you please take a look to the latest patches I posted for
the
max77802? They are in a topic branch in Mark's regulator tree [1]. I would
Hello Krzysztof,
On 10/21/2014 11:23 AM, Krzysztof Kozlowski wrote:
ldo9_reg: ldo9 {
@@ -295,7 +311,9 @@
regulator-name = CAM_ISP_MIPI_1.2V;
regulator-min-microvolt = 120;
-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Suggested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator/max77686.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/drivers/regulator/max77686.c b/drivers
regulator_desc_ldo(num) {
\
Looks good to me.
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord
Hello Krzysztof,
On 10/21/2014 01:23 PM, Krzysztof Kozlowski wrote:
Add information which regulators can be disabled during system suspend.
Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Suggested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation
file changed, 42 insertions(+), 30 deletions(-)
I'm not familiar with the board but the change looks good to me assuming each
regulator is doing the right thing.
I already gave you my Reviewed-by for the previous version but was not carried:
Reviewed-by: Javier Martinez Canillas javier.marti
Hello Krzysztof,
On 10/21/2014 02:22 PM, Krzysztof Kozlowski wrote:
On wto, 2014-10-21 at 13:57 +0200, Javier Martinez Canillas wrote:
+/* On/off controlled by PWRREQ */
+#define MAX77686_OPMODE_OFF_PWRREQ0x1
Minor nit: maybe this should be called MAX77802_OFF_PWRREQ (without
k.kozlow...@samsung.com
Suggested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator/max77686.c | 34 +++---
1 file changed, 27 insertions(+), 7 deletions(-)
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best
capabilities so a list of generic operating modes can't
be provided. Instead, each hardware should define the list of valid
operating modes for the regulators found on that device.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation/devicetree/bindings/regulator
their valid operating modes are and the
driver has to parse those and translate to the standard regulator modes.
This series depend on [2] and also v2 of patch:
ARM: EXYNOS: Call regulator core suspend prepare and finish functions [3].
Javier Martinez Canillas (5):
regulator: of: Decrement
() after finishing using the device node.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/regulator/of_regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index b375ffe..f0d19fc 100644
the regulators state
using the same configuration found in the ChromeOS 3.8 kernel.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v2:
- Use the standard suspend state binding as suggested by Mark Brown.
arch/arm/boot/dts/exynos5420-peach-pit.dts | 81
handlers when the system enters into sleep.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v2:
- Use the standard suspend states binding instead of custom properties.
Suggested by Mark Brown.
Changes since v1:
- Use the static inline max77802_map_mode
support their mode to be changed on system suspend.
Extend the max77802 PMIC binding, documenting the possible operating
modes values so the regulators modes can be correctly configured.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v2:
- Use
[adding Chris Zong as cc who posted a similar patch for Rockchip]
Hello Doug,
On 10/20/2014 06:26 PM, Doug Anderson wrote:
Javier,
On Thu, Oct 16, 2014 at 3:13 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
The regulator framework has a set of helpers functions
[adding Rafael Wysocki to cc as Suspend-to-RAM maintainer]
On 10/20/2014 07:36 PM, Doug Anderson wrote:
Javier,
On Mon, Oct 20, 2014 at 9:58 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
It turns out that regulator_suspend_finish() actually returns an error
code
Hello Mark,
On 10/20/2014 09:56 PM, Mark Brown wrote:
On Mon, Oct 20, 2014 at 09:50:57PM +0200, Javier Martinez Canillas wrote:
On 10/20/2014 07:36 PM, Doug Anderson wrote:
I guess I was just trying to follow the suggestion that was in the
regulator code:
http://lxr.free-electrons.com
701 - 800 of 1325 matches
Mail list logo
