On Thursday, December 24, 2015 10:23 AM, Yakir Yang wrote:
>
> Hi Jingoo,
>
> Okay, fine, I would drop this patch, until I found the the root cause.
OK, I see.
Best regards,
Jingoo Han
>
> - Yakir
>
> On 12/23/2015 11:10 PM, Jingoo Han wrote:
> > On Wednes
On Wednesday, December 23, 2015 3:01 PM, Yakir Yang wrote:
>
> Hi Jingoo,
>
> On 12/23/2015 12:24 PM, Yakir Yang wrote:
> > Hi Jingoo,
> >
> > On 12/22/2015 08:26 PM, Jingoo Han wrote:
> >> On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote:
&g
= New DT;
else
wait_time_aux = 10;
> usleep_range(10, 11);
If there is NO new wait time value from DT file, the default value '10' is
used for sleep.
But, if there is new wait time value from DT file, new wait time value
can be used for sleep.
usl
; timeout_loop++;
> - if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) {
> + if (DP_TIMEOUT_LOOP_COUNT * 10 < timeout_loop) {
No, I hate this coding.
analogix_dp_reg.c is the common code that can be shared by various SoCs.
Please
gt; --- /dev/null
> +++ b/drivers/phy/phy-rockchip-dp.c
> @@ -0,0 +1,151 @@
> +/*
> + * Rockchip DP PHY driver
> + *
> + * Copyright (C) 2015 FuZhou Rockchip Co., Ltd.
> + * Author: Yakir Yang
> + *
> + * This program is free software; you can redistribute it and/or
Javier Martinez Canillas
Reviewed-by: Jingoo Han < jingooh...@gmail.com >
Best regards,
Jingoo Han
> ---
> Changes in v11: None
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6:
> - Fix Peach Pit hpd property
gix/analogix_dp_core.h
> @@ -21,8 +21,9 @@
> #define MAX_EQ_LOOP 5
>
> enum link_rate_type {
> - LINK_RATE_1_62GBPS = 0x06,
> - LINK_RATE_2_70GBPS = 0x0a
> + LINK_RATE_1_62GBPS = DP_LINK_BW_1_62,
> + LINK_RATE_2_70GBPS = DP_LINK_BW_2
sted-by: Javier Martinez Canillas
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Changes in v11: None
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5:
> - Resequence this patch after an
e maintainers to CC list. I don't understand
why you removed them from CC list.
Kukjin Kim
Krzysztof Kozlowski
Without their Ack, you will not change the codes of ARM Exynos Architecture.
Best regards,
Jingoo Han
>
> Best regards,
> Krzysztof
>
>
>>
>>
>
kefile|2 +-
> drivers/gpu/drm/exynos/analogix_dp-exynos.c| 347 +
Would you change this file name to "exynos_dp.c"?
Best regards,
Jingoo Han
> drivers/gpu/drm/exynos/exynos_dp_core.c| 1416
> drivers/
On 2015. 8. 19., at PM 11:52, Yakir Yang wrote:
>
What is the reason to make this patch?
Please make commit message including the reason.
Best regards,
Jingoo Han
> Signed-off-by: Yakir Yang
> ---
> Changes in v3:
> - move dp hpd detect to connector detect function.
>
guration of link rate and link
count
Best regards,
Jingoo Han
> so we don't need to config those repeatly after training finished, just
> remove them out.
>
> Beside Display Port 1.2 already support 5.4Gbps link rate, the maximum sets
> would change from {1.62Gbps, 2.7
On 2015. 8. 20., at PM 3:23, Yakir Yang wrote:
>
> Hi Jingoo & Archit,
>
>
>> On 08/20/2015 12:54 AM, Jingoo Han wrote:
>>> On 2015. 8. 20., at PM 1:29, Archit Taneja wrote:
>>> Hi,
>>>
>>>> On 08/19/2015 08:18 PM, Yakir
o say is that there should not be harmful effect on the existing
Exynos boards, due to unrelated reasons.
Best regards,
Jingoo Han
> Signed-off-by: Yakir Yang
> ---
> Changes in v3: None
> Changes in v2: None
>
> drivers/gpu/drm/bridge/analogix_dp_core.c | 2 +-
> 1 file cha
>> point to get panel node.
>> - Add the new function point analogix_dp_platdata.get_modes init.
>> - Take Heiko suggest, add rockchip dp phy driver,
>> collect the phy clocks and power control.
>> - Add "analogix,need-force-hpd" to indicate whether driver need f
ave to review the code carefully, as others did.
I also cannot find the exact IP name. The "analogix" may be the vendor name
of this IP.
Best regards,
Jingoo Han
>
> Beyond that, there are three light registers setting differents bewteen
> exynos and rk3288.
> 1. RK3288 ha
ynos_dp_core.c
> b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index a8097a4..aa99e23 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
> @@ -3,6 +3,7 @@
> *
> * Copyright (C) 2012 Samsung Electronics Co., Ltd.
> * Author:
> Don't pollute the dmesg with EDID read success message as an error.
> Printing as debug should be fine.
>
> Signed-off-by: Krzysztof Kozlowski
Right, dev_err() is not right.
Thank you for sending the patch.
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
now be changed to depend on
> CONFIG_PM.
>
> Replace CONFIG_PM_RUNTIME with CONFIG_PM in 4 files under
> gpu/drm/exynos/.
>
> Signed-off-by: Rafael J. Wysocki
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Note: This depends on commit b2b49ccbdd54
ding the same to dp-phy
> > node.
> >
> > Signed-off-by: Vivek Gautam
> > Reviewed-by: Jingoo Han
> > Tested-by: Javier Martinez Canillas
> > Cc: Kukjin Kim
>
> Any opinions about $subject?
>
> This patch is -rc material since is needed after commi
exynos_dp_probe(struct platform_device
> > *pdev)
> > exynos_drm_component_del(&pdev->dev,
> >
> > EXYNOS_DEVICE_TYPE_CONNECTOR);
> >
> > +free_dp:
> > + devm_kfree(dev, dp);
vek Gautam
> Cc: Inki Dae
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Changes from V2:
> - Moved devm_phy_get() call out of exynos_dp_dt_parse_phydata() to
>exynos_dp_bind() function and,
>removed exynos_dp_dt_parse_phydata(
On Thursday, October 30, 2014 10:24 PM, Vivek Gautam wrote:
>
> DP PHY now require pmu-system-controller to handle PMU register
> to control PHY's power isolation. Adding the same to dp-phy
> node.
>
> Signed-off-by: Vivek Gautam
> Cc: Jingoo Han
Reviewed-by: Jingoo
placed long time ago.
However, it was not removed for DT compatibility.
I think that now these old DT properties can be removed.
I added some comments below.
>
> Signed-off-by: Vivek Gautam
> Cc: Inki Dae
> Cc: Jingoo Han
> ---
>
> Changes from V1:
> - Reworked error
> Reported-by: Paul Bolle
> Signed-off-by: Sylwester Nawrocki
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/usb/host/Kconfig |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/K
ost drivers too.
>
> Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/usb/host/ohci-exynos.c | 89
> +++-
> 1 file changed, 24 insertions(+), 65 deletions(-)
>
> diff --git a/drivers/usb/hos
ost drivers too.
>
> Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/usb/host/ehci-exynos.c | 81
>
> 1 file changed, 23 insertions(+), 58 deletions(-)
>
> diff --git a/drivers/usb/hos
OHCI driver to hang on probe (as observed
> on Exynos5250 Arndale board). ]
I also agree with this patch, because dwc3 IPs of all Exynos SoCs
do not use "NOP USB Transceiver Driver". So, "usb_phy_generic" can be
removed from Exynos dwc3 driver.
Is there any reason to sup
> + u32 addr, u32 data)
> +{
> + /* Write Address */
> + crport_handshake(phy_drd, EXYNOS5_DRD_PHYREG0_CR_DATA_IN(addr),
> + EXYNOS5_DRD_PHYREG0_CR_CAP_ADDR);
According to the guidance from H/W team, before calling crport_handsha
cz (5):
> > ARM: dts: remove old USB2 PHY node hook for Arndale
> > ARM: dts: remove old USB2 PHY node for Exynos5250
> > usb: phy: samsung: remove old USB 2.0 PHY driver
> > usb: phy: samsung: remove old USB 3.0 PHY driver
> > usb: phy: samsung: remove old c
As Bart said, it is not used for
> > S3C64xx at all. The platform was supposed to be moved to this driver,
> > but that never happened.
Yes, right. As far as I know, you're right.
> > In fact, I already have a patch adding support
> > for S3C64xx to the new driver.
G
On Sunday, August 10, 2014 6:15 PM, Andreas Farber wrote:
> Am 05.08.2014 13:16, schrieb Jingoo Han:
> > On Saturday, August 02, 2014 5:57 AM, Tomasz Figa wrote:
> >> On 01.08.2014 22:54, Andreas Färber wrote:
> >>> Am 01.08.2014 22:33, schrieb Doug Anderson:
> >
t/dts/exynos5420-pinctrl.dts
pinctrl@1340 {
dp_hpd: dp_hpd {
samsung,pins = "gpx0-7";
samsung,pin-function = <3>;
samsung,pin-pud = <0>;
samsung,pin-
issue with ehci-exynos and ohci-exynos, wherein
> in the absence of SAMSUNG_USB2PHY config symbol, we end up getting
> the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs
> are not configured properly.
>
> Reported-by: Sachin Kamat
> Signed-off-by: Vivek Gautam
> Cc:
Signed-off-by: Sachin Kamat
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> No changes since v1.
> ---
> drivers/phy/Kconfig |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 128f8b92b55c..ee
Also, make the sub-drivers silent options enabling
> them based on the SoC platforms that they are meant to work with. This
> will make life easier for end users who do not have any way knowing the
> dependencies.
>
> Signed-off-by: Sachin Kamat
Reviewed-by: Jingoo
have anything to test this. Based
> on your input I will re-spin the patch.
I agree with Tomasz Figa's statement. Personally, I think that it would
be good to amend the commit message and add a dependency on USB_DWC2. :-)
Thank you.
Best regards,
Jingoo Han
>
> --
> Regards,
>
On Tuesday, July 01, 2014 6:32 AM, Kukjin Kim wrote:
>
> This patch removes fimd and fb codes for s5pc100 SoC.
>
> Signed-off-by: Kukjin Kim
> Cc: Tomi Valkeinen
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> .../devicetree/bindings/video/samsung-fimd.txt
On Tuesday, July 01, 2014 6:32 AM, Kukjin Kim wrote:
>
> This patch removes fimd codes for s5p6440 and s5p6450 SoCs.
>
> Signed-off-by: Kukjin Kim
> Cc: Tomi Valkeinen
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> .../devicetree/bindings/video/samsun
On Thursday, June 26, 2014 9:00 PM, Krzysztof Kozlowski wrote:
>
> Array of struct of_device_id may be be const as expected by
> of_match_table field and of_find_matching_node_and_match() function.
>
> Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Jingoo Han
Best rega
performed after VIDCON0 update. If yes the
> > solution of the whole problem
> I will check this.
>
> > seems to be simple:
> > - fimd should provide function fimd_set_dp_clk_gate or sth similar,
> > - this function should be called in exynos_dp_poweron/exynos_dp_powerof
On Friday, June 27, 2014 7:12 PM, Ajay Kumar wrote:
>
> Add the missing setting for DP CLKCON register.
>
> This register is present on Exynos5 based FIMD controllers,
> and needs to be set if we are using DP.
>
> Signed-off-by: Ajay Kumar
Reviewed-by: Jingoo Han
Bes
1 patch.
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Changes since V1:
> - Remove usage of driver_data to configure DP CLKCON register
> drivers/gpu/drm/exynos/exynos_dp_core.c | 2 ++
> drivers/gpu/drm/exynos/exynos_drm_drv.h | 8
> drivers/gpu/drm/exynos
be fine.
No, it should be selectable. Even some exynos5 based boards use MIPI LCD.
>
> Arndale and Arndale-Octa have MIPI/DSI interface with MIPI/LVDS bridge.
>
> >
> > Inki/Andrej - Shall I add it as an optional DT property?
>
> No, property is redundant. The simples
hpd_irq_event() is called, which in turns calls
> exynos_dpi_detect(), which dereferences ctx->panel without a check,
> causing a NULL pointer derefrence.
>
> This patch fixes the issue by adding necessary NULL pointer check.
>
> Signed-off-by: Tomasz Figa
(+cc Inki Dae)
or? Do you really want to print out a warning in that case?
> Should you call devm_regulator_get_optional() instead?
I agree with Alan's suggestion. This warning message is not
proper, when USB controllers that don't need a VDD regulator
are used. The devm_regulator_get_optional() looks better.
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The exynos_hdmi.h has been used for the dedicated i2c drivers
that were already removed. Thus, the unnecessary exynos_hdmi.h
should be removed.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_hdmi.h | 23 ---
1 file changed, 23 deletions(-)
delete mode 100644
#x27;drivers/gpu/drm/exynos/exynos_hdmi.h' was not
removed yet. Thus, additional patch to remove this
'exynos_hdmi.h' should be submitted. Thank you.
[1]
http://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=73c0a75ca9919c
dw_pcie_host_init().
>This is often because add_pcie_port lacks a __init
>annotation or the annotation of dw_pcie_host_init is wrong.
>
> Reported-by: kbuild test robot
> Signed-off-by: Sachin Kamat
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers
On Friday, May 23, 2014 3:09 PM, Sachin Kamat wrote:
>
> Made it as per DT node naming convention .
>
> Signed-off-by: Sachin Kamat
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> arch/arm/boot/dts/exynos5440.dtsi |2 +-
> 1 file changed, 1 ins
On Monday, May 12, 2014 3:45 PM, Rahul Sharma wrote:
>
> From: Rahul Sharma
>
> Enable FIMD for peach-pi board.
>
> Signed-off-by: Rahul Sharma
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> arch/arm/boot/dts/exynos5800-peach-pi.dts |5 +
> 1
On Monday, May 12, 2014 3:45 PM, Rahul Sharma wrote:
>
> From: Rahul Sharma
>
> Enable display controller with timing information for 1080p
> panel in Exynos5800 peach-pi board.
>
> Signed-off-by: Rahul Sharma
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
>
On Friday, May 09, 2014 7:10 PM, Rahul Sharma wrote:
>
> From: Rahul Sharma
>
> Enable dp-controller for peach-pit board.
>
> Signed-off-by: Rahul Sharma
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> arch/arm/boot/dts/exynos5
On Friday, May 09, 2014 7:10 PM, Rahul Sharma wrote:
>
> From: Rahul Sharma
>
> Enable dp-controller for snow board.
>
> Signed-off-by: Rahul Sharma
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 29 ++
On Friday, May 09, 2014 7:10 PM, Rahul Sharma wrote:
>
> From: Rahul Sharma
>
> Enable fimd for peach-pit board.
>
> Signed-off-by: Rahul Sharma
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> arch/arm/boot/dts/exynos5420-peach-pit.dts |5 ++
On Friday, May 09, 2014 7:10 PM, Rahul Sharma wrote:
>
> From: Rahul Sharma
>
> Enable fimd node for snow board.
>
> Signed-off-by: Rahul Sharma
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> arch/arm/boot/dts/exynos5250-snow.dts |6 ++
> 1
On Friday, May 09, 2014 7:16 PM, Rahul Sharma wrote:
>
> + Jingoo Han.
If you want to get Acked-by from maintainer, please add the
maintainer to CC list for all patches.
Anyway, I will review this patch. However, if you don't add me
to CC list in the future, I am not sure that I
gt; Cc: Tomasz Figa
> Cc:
> Cc: Vladimir Zapolskiy
> Cc: Herbert Xu
I checked that these machine specific headers are
unnecessary. Thanks!
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Please apply on top of the other s5p-sss patches
>
> diff --git a/drivers/crypt
On Tuesday, April 22, 2014 4:14 PM, Jingoo Han wrote:
> On Tuesday, April 22, 2014 7:39 AM, Ajay Kumar wrote:
> >
> > From: Andrew Bresticker
> >
> > Certain bridge chips use a GPIO to indicate the cable status instead
> > of the I_DP_HPD pin. This adds
On Thursday, May 08, 2014 6:08 PM, Rahul Sharma wrote:
> On 8 May 2014 12:02, Jingoo Han wrote:
> > On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
> >>
> >> From: Rahul Sharma
> >>
> >> Display controller HPD Gpio line is board specific. This
splay-timings {
For readability, please insert one line as below.
+ samsung,hpd-gpio = <&gpx0 7 0>;
+
+ display-timings {
The same comment applies to the 5th patch.
([PATCH v2 5/5] ARM: dts: enable dp-controller for exynos5420
based peach-pit board)
0>;
> };
> };
> +
> + fimd@1440 {
> + status = "okay";
(+cc Sachin Kamat, Tomasz Figa)
For readability, how about moving 'status' to the last entry of
the node? The same comment applies to other patches, too.
Best r
pinctrl-0 = <&dp_hpd>;
...
samsung,hpd-gpio = <&gpx2 6 0>;
Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts,
'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6",
respe
.
Anyone does not want to waste the time, due to patch breakage.
Best regards,
Jingoo Han
>
> Rahul Sharma (5):
> ARM: dts: move dp hpd line to the board file for exynos5420
> ARM: dts: enable fimd for exynos5250 based snow board
> ARM: dts: enable dp-controller for exyno
On Monday, April 28, 2014 6:26 PM, Vivek Gautam wrote:
>
> Change to use struct device instead of struct platform_device
> for some static functions.
>
> Signed-off-by: Vivek Gautam
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> Cc: Alan Stern
>
On Monday, April 28, 2014 6:25 PM, Vivek Gautam wrote:
>
> Change to use struct device instead of struct platform_device
> for some static functions.
>
> Signed-off-by: Vivek Gautam
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> Cc: Alan Stern
>
th a PCIe switch where one connected
> device is using legacy INTD and another one using
> MSI, but better fix it now.
>
> Signed-off-by: Lucas Stach
(+cc Mohit KUMAR DCG, Pratyush ANAND)
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/pci/host/pci-exynos.c |
On Thursday, April 24, 2014 3:40 PM, Vivek Gautam wrote:
> On Thu, Apr 24, 2014 at 6:56 AM, Jingoo Han wrote:
> > On Thursday, April 24, 2014 9:33 AM, Jingoo Han wrote:
> >> On Thursday, April 24, 2014 9:18 AM, Anton Tikhomirov wrote:
> >> > On Monday, April 21, 20
On Thursday, April 24, 2014 9:33 AM, Jingoo Han wrote:
> On Thursday, April 24, 2014 9:18 AM, Anton Tikhomirov wrote:
> > On Monday, April 21, 2014 9:17 PM, Vivek Gautam wrote:
> > >
> > > Facilitate getting required 3.3V and 1.0V VDD supply for
> > > OHCI co
; +
> > + exynos_ohci->vdd10 = devm_regulator_get(&pdev->dev, "vdd10");
> > + if (IS_ERR(exynos_ohci->vdd10)) {
> > + err = PTR_ERR(exynos_ohci->vdd10);
> > + goto fail_regulator2;
> > + }
> > + err = regulator_
ts: add max77686 pmic node for smdk5250,
>
> certain perripherals will now need to ensure that,
> they request VDD regulators in their drivers, and enable
> them so as to make them working.
>
> Signed-off-by: Vivek Gautam
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best reg
ts: add max77686 pmic node for smdk5250,
>
> certain perripherals will now need to ensure that,
> they request VDD regulators in their drivers, and enable
> them so as to make them working.
>
> Signed-off-by: Vivek Gautam
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best reg
esn't provide it, dwc3-exynos driver probe
> >> shouldn't
> >> > fail here.
> >>
> >> These are the VDD regulators (from PMIC ldo supplies), in absence of
> >> which the controller will not be powered up.
> >> So doesn't it
sn't matter if the regulators are turned off, but something
> + * else might keep them on. In that case, we want to assert the slp gpio
> + * to lower power.
> + */
> + if (gpio_is_valid(ps_bridge->gpio_slp_n))
> + gpio_set_value(ps_bridge->gpio
ig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -30,4 +30,13 @@ config DRM_PANEL_S6E8AA0
> select DRM_MIPI_DSI
> select VIDEOMODE_HELPERS
>
> +config DRM_PANEL_EXYNOS_DP
> + tristate "support for DP panels"
It looks very general. Please fix it as be
ed-off-by: Rahul Sharma
> Signed-off-by: Ajay Kumar
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Changes since V1:
> Address reiew comments from Jingoo Han
>
> .../devicetree/bindings/video/exynos_dp.txt|4 ++
> drivers/gpu/drm/exynos/exynos_d
hci/ohci controller on Exynos5420).
> It will be of great help.
Hi Vevek, Tomasz
Long time no see.
I asked USB S/W engineer and USB H/W engineer.
There are two USB3.0 on Exynos5420; thus there are two sclks
such as 'sclk_usbphy300 and sclk_usbphy301'.
As Tomasz mentioned, 'sclk_u
On Saturday, April 19, 2014 4:43 AM, Ajay kumar wrote:
> On Fri, Apr 18, 2014 at 2:17 PM, Jingoo Han wrote:
> > On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote:
[.]
> > > +struct panel_exynos_dp {
> > > + struct drm_panelbase;
> > > +
On Saturday, April 19, 2014 4:51 AM, Ajay Kumar wrote:
> On Fri, Apr 18, 2014 at 2:27 PM, Jingoo Han wrote:
> > On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote:
[.]
> > > +#ifdef CONFIG_DRM_PANEL_EXYNOS_DP
> > > + platform_driver_unregis
;
> - if (ret)
> + ret = exynos_drm_attach_lcd_bridge(dp->drm_dev, encoder, dp->drm_panel);
> + if (ret) {
> + /* Also set "dp->drm_panel = NULL" so that we don't end up
> + * controlling panel power both in exynos_dp and bridge
&g
"samsung,exynos-dp-panel");
> + if (panel_node) {
> + dp->drm_panel = of_drm_find_panel(panel_node);
> + if (!dp->drm_panel) {
> + of_node_put(panel_node);
> + return -ENODEV;
&g
p;exynos_dp_panel_driver);
> +err_unregister_dp_panel:
> +#endif
Please add platform_driver_unregister() to exynos_drm_platform_remove(),
as well as exynos_drm_platform_probe().
Best regards,
Jingoo Han
> +
> #ifdef CONFIG_DRM_EXYNOS_IPP
> exynos_platform_device_ipp_unregister();
> err_
enable_delay = true;
> + }
> +
> + if (!IS_ERR_OR_NULL(dp_panel->lcd_fet)) {
> + regulator_disable(dp_panel->lcd_fet);
> + enable_delay = true;
> + }
> +
> + if (enable_delay)
> + msleep(dp_panel->pow
eg & PLUG)
+ return DP_IRQ_TYPE_HP_CABLE_IN;
+
+ if (reg & HPD_LOST)
+ return DP_IRQ_TYPE_HP_CABLE_OUT;
+
+ if (reg & HOTPLUG_CHG)
+ return DP_IRQ_TYPE_HP_CHANGE;
+ }
return DP_IRQ_T
-EBUSY as error code if there's a wakeup
> > interrupt.
> > So the platform host controller should not proceed further with
> > its suspend callback, rather should return immediately to avoid
> > powering down the essential things, like phy.
> >
&g
errupt.
> So the platform host controller should not proceed further with
> its suspend callback, rather should return immediately to avoid
> powering down the essential things, like phy.
>
> Signed-off-by: Vivek Gautam
> Cc: Alan Stern
> Cc: Jingoo Han
Acked-by: Jingoo Han
#x27;t need the locks for 'ohci_hcd' anymore.
Right, this spin_lock/unlock is unnecessary, because it is
already used in ohci_suspend().
Acked-by: Jingoo Han
Best regards,
Jingoo Han
>
> Signed-off-by: Vivek Gautam
> Cc: Manjunath Goudar
> Cc: Alan Stern
> ---
> dr
ee with Lucas Stach's opinion. of_irq_parse_and_map_pci() already
prints an error as below. So, additional warning message of host controller
looks superfluous.
ret = of_irq_parse_pci(dev, &oirq);
if (ret) {
dev_err(&dev->dev, "of_irq_parse_pci()
: Jingoo Han
---
Changes since v1:
- Fix unintentional modification of I/O size, per Pratyush Anand.
arch/arm/boot/dts/exynos5440.dtsi | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5440.dtsi
b/arch/arm/boot/dts/exynos5440.dtsi
index
On Tuesday, April 01, 2014 12:44 PM, Pratyush Anand wrote:
> On Tue, Apr 01, 2014 at 10:54:57AM +0800, Jingoo Han wrote:
> > Increase the size of PCIe configuration space to 8kB from 4kB,
> > because 4kB for cfg0 and 4kB for cfg1 are required respectively.
> > If 2kB for cfg0
: Jingoo Han
---
arch/arm/boot/dts/exynos5440.dtsi | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5440.dtsi
b/arch/arm/boot/dts/exynos5440.dtsi
index d600733..5d08be8 100644
--- a/arch/arm/boot/dts/exynos5440.dtsi
+++ b/arch/arm/boot/dts
On Monday, March 31, 2014 12:37 PM, Axel Lin wrote:
>
> Simplify the cleanup code.
>
> Signed-off-by: Axel Lin
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/spi/spi-s3c24xx.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
&g
On Tuesday, April 01, 2014 2:53 AM, Tejun Heo wrote:
>
> Add missing clk_disable() call to ata_host_activate() failure path.
>
> Cc: Ben Dooks
> Cc: Kukjin Kim
> Signed-off-by: Bartlomiej Zolnierkiewicz
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
&g
.
> >>
> >
> > Yes but devm_ioremap_resource() just tells that the given 'res' is not
> > correct. I think the message in the driver is more informative.
>
> The common practice used in Linux kernel is to not duplicate such
> messages. It is obvious th
DEV_PM_OPS instead of SET_SYSTEM_SLEEP_PM_OPS?
SIMPLE_DEV_PM_OPS is simpler as below.
static SIMPLE_DEV_PM_OPS(exynos4_busfreq_pm, NULL, exynos4_busfreq_resume);
However, if runtime pm functions will be added later,
SIMPLE_DEV_PM_OPS is not necessary.
Best regards,
Jingoo Han
> };
>
>
e this is appropriate: it is an incentive
> to update the dts files, but doesn't look too urgent as long as everything
> still works.
+1
I agree with Arnd's opinion. I think that all dts files should be
updated properly. This error message can be the good way to do
Pratyush Anand, Marek Vasut,
Kishon Vijay Abraham I)
Acked-by: Jingoo Han
It works properly on Exynos platform.
Thank you.
Best regards,
Jingoo Han
> ---
> v2: pass in parent dev to relevant functions, to make DT parsing
> work (spotted by Tim Harvey )
> ---
> dri
On Wednesday, March 05, 2014 10:26 PM, Lucas Stach wrote:
>
> So it actually works.
>
> Signed-off-by: Lucas Stach
> Acked-by: Arnd Bergmann
Acked-by: Jingoo Han
It works properly on Exynos platform.
Thank you.
Best regards,
Jingoo Han
> ---
> v2: fix build breakage b
(pp) {
pp->root_bus_nr = sys->busnr;
- bus = pci_scan_root_bus(NULL, sys->busnr, &dw_pcie_ops,
+ bus = pci_scan_root_bus(pp->dev, sys->busnr, &dw_pcie_ops,
sys, &sys->resources);
} el
On Monday, March 03, 2014 4:41 PM, Jingoo Han wrote:
> On Saturday, March 01, 2014 2:29 AM, Lucas Stach wrote:
> >
> > So it actually works.
> >
> > Signed-off-by: Lucas Stach
> > ---
> > arch/arm/boot/dts/exynos5440.dtsi | 4 ++--
> > 1 file changed,
1 - 100 of 593 matches
Mail list logo
