RE: [PATCH 5/7] v4l: s5p-fimc: add pm_runtime support

2011-04-05 Thread Jonghun Han
. Best regards, Jonghun Han On Tuesday, April 05, 2011 11:07 PM Marek Szyprowski wrote: > This patch adds basic support for pm_runtime to s5p-fimc driver. PM runtime > support is required to enable the driver on S5PV310 series with power domain > driver enabled. > > Signed-off-by: M

RE: [RFC/PATCH 0/2] FrameBuffer emulator for V4L2/VideoBuf2

2011-04-01 Thread Jonghun Han
Hi Marek, On Wednesday, March 30, 2011 4:01 PM Marek Szyprowski wrote: > Hello, > > On V4L2 brainstorming meeting in Warsaw we discussed the need of a > framebuffer userspace interface for video output devices. Such > framebuffer interface is aimed mainly for legacy applications and/or > interop

RE: [PATCH 1/2] media: vb2: add frame buffer emulator for video output devices

2011-04-01 Thread Jonghun Han
Hi Marek, Here is my comments. On Wednesday, March 30, 2011 4:01 PM Marek Szyprowski wrote: > > This patch adds generic frame buffer emulator for any video output device > that uses videobuf2 framework. This emulator assumes that the driver is > capable of working in single-buffering mode and u

[RFC 0/1] v4l: videobuf2: Add Exynos devices based allocator, named SDVMM

2011-03-07 Thread Jonghun Han
== Introduction == The purpose of this RFC is to discuss the vb2-allocator for multimedia devices available in upcoming Samsung SoC Exynos. Not all of them are merged or submitted by now, but I decided to post this for starting discussion about buffer management. vb

[RFC 1/1] v4l: videobuf2: Add Exynos devices based allocator, named SDVMM

2011-03-07 Thread Jonghun Han
), suggested by ARM. VCM (Virtual Contiguous Memory framework), submitted by Samsung CMA (Contiguous Memory Allocator), submitted by Samsung SYS.MMU (System MMU), submitted by Samsung. Signed-off-by: Jonghun Han --- drivers/media/video/videobuf2-sdvmm.c | 659

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-01-14 Thread Jonghun Han
ards, > -Original Message- > From: Kamil Debski [mailto:k.deb...@samsung.com] > Sent: Friday, January 14, 2011 4:24 PM > To: 'Jonghun Han'; linux-me...@vger.kernel.org; linux-samsung- > s...@vger.kernel.org > Cc: Marek Szyprowski; pa...@osciak.com; kyungmin.p...@sa

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-01-13 Thread Jonghun Han
Hi, Kamil Debski wrote: > +/* Reqeust buffers */ > +static int vidioc_reqbufs(struct file *file, void *priv, > + struct v4l2_requestbuffers *reqbufs) > +{ > + struct s5p_mfc_dev *dev = video_drvdata(file); > + struct s5p_mfc_ctx *ctx = priv; > +

RE: [PATCH 7/9] media: MFC: Add MFC v5.1 V4L2 driver

2011-01-06 Thread Jonghun Han
Hi Kamil, Kamil Debski wrote: > Hi, > > Thanks for the comment. Some of them include my code, which will I comment > below. > > > My review also imply Kamil's original patch. > > > > > > +#define MFC_NUM_CONTEXTS 4 > > > > How about use MFC_NUM_INSTANT instead MFC_NUM_CONTEXTS ? > > Becaus

RE: [PATCH 7/9] media: MFC: Add MFC v5.1 V4L2 driver

2010-12-27 Thread Jonghun Han
My review also imply Kamil's original patch. Jeongtae Park wrote: > Multi Format Codec v5.1 is a module available on S5PC110 and S5PC210 > Samsung SoCs. Hardware is capable of handling a range of video codecs > and this driver provides V4L2 interface for video decoding & encoding. > > Reviewed-b

RE: [PATCH] s3c-fb: add support for runtime pm

2010-12-21 Thread Jonghun Han
Hi Jingoo, How about adding pm_runtime_* in s3c_fb_blank ? In FB_BLANK_POWERDOWN state no need to enable clock or power-domain. Best regards, > -Original Message- > From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev- > ow...@vger.kernel.org] On Behalf Of Jonghun H

RE: [PATCH] s3c-fb: add support for runtime pm

2010-12-21 Thread Jonghun Han
Hi Jingoo, Here is a quick review. Best regards, Jingoo Han wrote: > This patch adds support for runtime pm using the functions. > - pm_runtime_get_sync() > - pm_runtime_put_sync() > > pm_runtime_get_sync() and pm_runtime_put_sync() are called when open or > release function of framebufer dr

RE: [PATCH V2] s3c-fb: Add support S5PV310 FIMD

2010-12-08 Thread Jonghun Han
Hi Paul, Could you please let me know your opinion about following patch. Maybe you missed it. Thanks. Best Regards, Jonghun Han. Kukjin Kim wrote: > > From: Jonghun Han > > This patch adds struct s3c_fb_driverdata s3c_fb_data_s5pv310 for S5PV310 > and S5PC210. The clk_t

RE: [RFC/PATCH 2/4] [media] s5p-fimc: Porting to videobuf 2

2010-12-06 Thread Jonghun Han
Sylwester Nawrocki wrote: > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sylwester Nawrocki > Sent: Wednesday, December 01, 2010 11:36 PM > To: linux-me...@vger.kernel.org; linux-samsung-soc@vger.kernel.org > Cc: m

RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-10-20 Thread Jonghun Han
m'; linux-arm-ker...@lists.infradead.org; linux-samsung- > s...@vger.kernel.org; linux-fb...@vger.kernel.org > Cc: 'Jonghun Han'; a...@linux-foundation.org; kgene@samsung.com; ben- > li...@fluff.org; kyungmin.p...@samsung.com > Subject: RE: [PATCH 3/4] s3c-fb: Add su