Re: [GIT PULL 5/9] ARM: EXYNOS: Drivers for v4.5

2015-12-24 Thread Linus Walleij
linux/kernel/git/krzk/linux.git > tags/samsung-drivers-4.5 > > for you to fetch changes up to 023e06dfa6882f500b9c86fd61f0b1913aa07f36: > > pinctrl: exynos: add exynos5410 SoC specific data (2015-11-16 10:54:43 > +0900) OK I pulled this into the pinctrl tree, cheers! Yours, Linus W

Re: [PATCH 2/3] Add support for monitoring gpio switches

2015-12-22 Thread Linus Walleij
sues in the GPIO subsystem so I am busy refactoring the whole know universe :D But I still intend to persue the series. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] Device tree binding documentation for gpio-switch

2015-12-14 Thread Linus Walleij
On Fri, Dec 11, 2015 at 3:06 PM, Rob Herring wrote: > On Fri, Dec 11, 2015 at 6:39 AM, Linus Walleij > wrote: >> On Fri, Dec 4, 2015 at 6:31 PM, Martyn Welch >> wrote: >> >>> This patch adds documentation for the gpio-switch binding. This binding >>> p

Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-13 Thread Linus Walleij
On Thu, Dec 10, 2015 at 12:08 AM, Michael Welling wrote: > On Wed, Dec 09, 2015 at 02:12:40PM +0100, Linus Walleij wrote: > ... >> - ret = gpiochip_add(&bgc->gc); >> + ret = gpiochip_add_data(gc, NULL); >> if (ret) { > > gpiochip_add is sti

Re: [PATCH 1/3] Device tree binding documentation for gpio-switch

2015-12-11 Thread Linus Walleij
Maybe as an extension of the existing hogs, but that has already been tried. While we can agree on a device tree binding, the kernel still needs major refactoring to actually expose named GPIOs to userspace, and that should be done using the new chardev, not with sysfs links. Yours, Linus Walleij --

Re: [PATCH 2/3] Add support for monitoring gpio switches

2015-12-11 Thread Linus Walleij
tead. See: http://marc.info/?l=linux-gpio&m=144550276512673&w=2 So for the moment, NACK on this, please participate in creating the *right* ABI for GPIO instead of trying to shoehorn stuff into the dying sysfs ABI. Yours, Linus Walleij -- To unsubscribe from this list: send the line "un

[PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-09 Thread Linus Walleij
amsung-soc@vger.kernel.org Cc: bcm-kernel-feedback-l...@broadcom.com Signed-off-by: Linus Walleij --- ARM SoC folks and Lee: it would be great if you could ACK the few lines hitting arch/arm/* and drivers/mfd/* in this so I can take it through the GPIO tree. --- arch/arm/mach-clps711x/board-autcpu12.c | 2 +-

Re: [PATCH 6/6] pinctrl: samsung: Remove unneded semicolon

2015-10-02 Thread Linus Walleij
On Wed, Sep 16, 2015 at 1:28 AM, Javier Martinez Canillas wrote: > It's not needed an is just creating a null statement, so remove it. > > Signed-off-by: Javier Martinez Canillas Patch applied with Krzysztof's Review-tag. Yours, Linus Walleij -- To unsubscribe from this

Re: [PATCH V2] Watchdog: Fix parent of watchdog_devices

2015-08-26 Thread Linus Walleij
for these devices. > > Signed-off-by: Pratyush Anand Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] MAINTAINERS: pinctrl: Move Thomas Abraham to CREDITS

2015-07-28 Thread Linus Walleij
lowski > Cc: Tomasz Figa > Cc: Thomas Abraham > Cc: Linus Walleij > Link: http://lkml.org/lkml/2015/6/15/15 Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vg

Re: [PATCH v3] pinctrl: kill off set_irq_flags usage

2015-07-28 Thread Linus Walleij
move the set_irq_flags calls. Some > users also modify IRQ_NOPROBE and this has been maintained although it > is not clear that is really needed. There appears to be a great deal of > blind copy and paste of this code. > > Signed-off-by: Rob Herring > Acked-by: Linus Walleij > Cc

Re: [patch v2 2/2] pinctrl: samsung: remove "out of memory" messages

2015-07-16 Thread Linus Walleij
going to hit these out of memory situations > but if we did then kmalloc() has pretty good error messages built-in. > > Signed-off-by: Dan Carpenter Patch applied with Krzysztof's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe l

Re: [patch v2 1/2] pinctrl: samsung: don't truncate the last char

2015-07-16 Thread Linus Walleij
re truncated. > > The allocate and sprintf can be done in one step with the kasprintf(). > > Signed-off-by: Dan Carpenter Patch applied with Krzysztof's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"

Re: [PATCH] pinctrl: samsung: Remove old unused defines

2015-06-29 Thread Linus Walleij
owski > Inspired-by: Dan Carpenter Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/21] On-demand device registration

2015-06-15 Thread Linus Walleij
s that you assume we know what hardware we will boot on at compile time. We discarded that development path years ago. We have no clue, this is resolved at runtime. Alas, people still create super-optimized systems using exactly this knowledge, but it is not our main target here, it is a special op

Re: [PATCH 00/21] On-demand device registration

2015-06-12 Thread Linus Walleij
On Thu, Jun 11, 2015 at 6:40 PM, Alexander Holler wrote: > Am 11.06.2015 um 14:30 schrieb Linus Walleij: >> Certainly it is possible to create deadlocks in this scenario, but the >> scope is not to create an ubreakable system. > > IAnd what happens if you run into a d

Re: [PATCH 00/21] On-demand device registration

2015-06-11 Thread Linus Walleij
On Thu, Jun 11, 2015 at 12:17 PM, Alexander Holler wrote: > Am 11.06.2015 um 10:12 schrieb Linus Walleij: >> On Wed, Jun 10, 2015 at 10:28 AM, Alexander Holler >> wrote: >>> You would end up with the same problem of deadlocks as currently, and you >>> would s

Re: [PATCH 00/21] On-demand device registration

2015-06-11 Thread Linus Walleij
On Wed, Jun 10, 2015 at 12:19 PM, Tomeu Vizoso wrote: > On 10 June 2015 at 09:30, Linus Walleij wrote: >> regulator_get(...) -> not available, so: >> - identify target regulator provider - this will need instrumentation >> - probe it >> >> It then turns ou

Re: [PATCH 00/21] On-demand device registration

2015-06-11 Thread Linus Walleij
On Wed, Jun 10, 2015 at 10:28 AM, Alexander Holler wrote: > Am 10.06.2015 um 09:30 schrieb Linus Walleij: >> i2c host comes out, probes the regulator driver, regulator driver >> probes and then the regulator_get() call returns. >> >> This requires instrumentation on an

Re: [PATCH 11/15] pinctrl: kill off set_irq_flags usage

2015-06-10 Thread Linus Walleij
the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring > Cc: Linus Walleij > Cc: Stephe

Re: [PATCH 00/21] On-demand device registration

2015-06-10 Thread Linus Walleij
On Tue, Jun 2, 2015 at 12:14 PM, Tomeu Vizoso wrote: > On 2 June 2015 at 10:48, Linus Walleij wrote: >> This is what systemd is doing in userspace for starting services: >> ask for your dependencies and wait for them if they are not >> there. So drivers ask for resources

Re: [PATCH 00/21] On-demand device registration

2015-06-02 Thread Linus Walleij
pts (!) and DMA channels for example.) So if this should be solved it should be solved in an abstract way in the device driver core available for all, then have calls calling out to DT, ACPI, possibly even PCI or USB (as these enumerate devices themselves) to obtain a certain dependency. Yo

[PATCH] RFT: pinctrl: samsung: separate wakeup irqdomain

2015-04-09 Thread Linus Walleij
ray with copies of the irqdomain (!). This patch mainly adds a new record to the GPIO/pin "bank" for wakeups and use this in the .eint_wkup_init() callbacks to pave the way for more cleanups. Signed-off-by: Linus Walleij --- Tomasz etc: I don't know if I'm just misunderstandin

Re: [PATCH] pinctrl: exynos: Remove eint_gpio_init call-back for exynos7 alive pinctrl block

2015-03-17 Thread Linus Walleij
1058.pinctrl: irq number not available" > > Signed-off-by: Abhilash Kesavan Patch applied with Tomasz ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More maj

Re: [PATCH] pinctrl: exynos: Remove eint_gpio_init call-back for exynos7 alive pinctrl block

2015-03-09 Thread Linus Walleij
1058.pinctrl: irq number not available" > > Signed-off-by: Abhilash Kesavan Tomasz, can you look at this patch? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.k

Re: [PATCH v4] pinctrl: exynos: Add support for Exynos5433

2015-03-06 Thread Linus Walleij
Figa > Cc: Thomas Abraham > Cc: Linus Walleij > Signed-off-by: Chanwoo Choi > Acked-by: Inki Dae > Acked-by: Tomasz Figa > --- > Changes from v3: > - Rebase it on Linux 4.0-rc1 > - Add acked messgae of Tomasz Figa Already merged v3. Thanks anyway! Yours, Linus Walle

Re: [PATCH v3] pinctrl: exynos: Add support for Exynos5433

2015-03-05 Thread Linus Walleij
Figa > Cc: Thomas Abraham > Cc: Linus Walleij > Signed-off-by: Chanwoo Choi > Acked-by: Inki Dae > --- > Changes from v2: > - Rebase it on v3.19-rc5 Patch applied with Tomasz ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH v3] pinctrl: exynos: Add support for Exynos5433

2015-01-29 Thread Linus Walleij
Figa > Cc: Thomas Abraham > Cc: Linus Walleij > Signed-off-by: Chanwoo Choi > Acked-by: Inki Dae > --- > Changes from v2: > - Rebase it on v3.19-rc5 Waiting for Tomasz to review this. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7

2015-01-19 Thread Linus Walleij
On Wed, Jan 14, 2015 at 3:27 PM, Tomasz Figa wrote: > 2015-01-14 20:40 GMT+09:00 Linus Walleij : >> On Fri, Dec 19, 2014 at 2:10 PM, Padmavathi Venna >> wrote: >> >>> Audio IPs on Exynos7 require gpios available in AUDIO >>> pin controller blo

Re: [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7

2015-01-14 Thread Linus Walleij
; - pinctrl8: pin controller of BUS1 block, > +- pinctrl9: pin controller of AUDIO block, This doesn't apply at all, the list has never been in the document merged upstream. Please prepare this patch rebased on a *CLEAN* upstream tree and resend. Include Tomasz ACK on your repost. Yours, Linus Wall

Re: [RFC 05/15] gpio: move DT parsing code to separate functions

2015-01-12 Thread Linus Walleij
n merits. We moves stuff around a bit in the OF code though. Please remember to send this patch to the linux-gpio list and comaintainer Alexandre Courbot on reposts. (Cc-tags in the patch are good for this.) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH v3 14/21] ARM: imx6: convert GPC to stacked domains

2015-01-12 Thread Linus Walleij
Nutcase nitpick on this nice patch series: every time I see "virq" my OCD triggers, as I think the "v" in "virq" stand for virtual. These irqs are no more virtual than any other Linux irq numbers, hwirq is more to the point. I just refer to these as "irq" (s

Re: [PATCH V3 2/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2015-01-12 Thread Linus Walleij
On Wed, Dec 10, 2014 at 9:39 AM, Vivek Gautam wrote: > USB and Power regulator on Exynos7 require gpios available > in BUS1 pin controller block. > So adding the BUS1 pinctrl support. > > Signed-off-by: Naveen Krishna Ch > Signed-off-by: Vivek Gautam > Cc: Tomasz Figa

Re: [PATCH 1/2] Documentation: dt-bindings: Add aliases information for Exynos7 pin controllers

2015-01-12 Thread Linus Walleij
On Wed, Dec 10, 2014 at 9:39 AM, Vivek Gautam wrote: > Adding list of aliases for supported Exynos7 pin controller blocks. > > Signed-off-by: Vivek Gautam > Cc: Tomasz Figa > Cc: Linus Walleij Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the li

Re: [PATCH v4 2/3] pinctrl: exynos: Fix GPIO setup failure because domain clock being gated

2015-01-05 Thread Linus Walleij
ki > Tested-by: Javier Martinez Canillas Tomasz, is this OK and should I apply it for fixes or next? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: DT on s3c24xx

2014-12-18 Thread Linus Walleij
use generic bindings. If the usecase is low power, the latter approach is recommended. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2 1/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-12-03 Thread Linus Walleij
On Mon, Dec 1, 2014 at 3:21 PM, Vivek Gautam wrote: > On Fri, Nov 28, 2014 at 9:15 PM, Linus Walleij > wrote: >> Apart from that, there are *again* a lot of Exynos patches flying around and >> I start to loose track of them. If they do not apply together and start to >&

Re: [PATCH V2 1/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-11-28 Thread Linus Walleij
in BUS1 pin controller block. >>>> So adding the BUS1 pinctrl support. >>>> >>>> Signed-off-by: Naveen Krishna Ch >>>> Signed-off-by: Vivek Gautam >>>> Cc: Linus Walleij > > If the change looks good, will it be possible to pick it

Re: [PATCH v2 3/5] pinctrl: exynos: Fix GPIO setup failure because domain clock being gated

2014-11-28 Thread Linus Walleij
lowski Waiting for Tomasz to review this. Can this patch be applied in separation from the others? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 3/5] pinctrl: exynos: add exynos5410 SoC specific data

2014-11-28 Thread Linus Walleij
tion] > Signed-off-by: Andreas Färber > --- > v2 -> v3: > * Rebased (.svc, .{g,w}eint_{con,mask,pend} fields dropped) > > v1 -> v2: > * Filled in Sob from Hakjoo Kim Is this based on the pinctrl devel branch so I can apply it? I'd like Tomasz ACK on it first thou

Re: Samsung pinctrl patches for v3.19

2014-11-10 Thread Linus Walleij
ou are a hobbyist maintainer now, and then I will tolerate a *lot* more than this, that is one of the privileges that comes with that role, haha :D Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vge

Re: [PATCH v5 0/6] Add initial support for pinctrl on Exynos7

2014-10-28 Thread Linus Walleij
On Fri, Oct 24, 2014 at 4:33 PM, Abhilash Kesavan wrote: > On Fri, Oct 24, 2014 at 5:31 PM, Linus Walleij > wrote: >> On Mon, Oct 20, 2014 at 4:01 PM, Abhilash Kesavan >> wrote: >> >>> Can you please pick this series up. >> >> Yes, sorry for th

Re: [PATCH v2 0/5] pinctrl: samsung: Data structure clean-up

2014-10-24 Thread Linus Walleij
On Wed, Oct 8, 2014 at 12:23 PM, Linus Walleij wrote: > On Thu, Oct 2, 2014 at 8:52 PM, Tomasz Figa wrote: > >> This series intends to clean up data structures used by pinctrl-samsung >> driver. >> More specifically, it separates initial compile time constants from

Re: [PATCH v5 0/6] Add initial support for pinctrl on Exynos7

2014-10-24 Thread Linus Walleij
patches on top of this now. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/5] pinctrl: samsung: Data structure clean-up

2014-10-08 Thread Linus Walleij
d structures > constified to improve safety. Thanks! The patches missed the v3.18 merge window, but I have queued them up as the first thing to go into v3.19. Now I need you to help me check the patch set from Abhilash so I know what to do about that, whenever you have some time... Yours

Re: [PATCH v4 0/6] Add initial support for pinctrl on Exynos7

2014-10-08 Thread Linus Walleij
e been in-flight for a while and he is listed as maintainer for this driver. So could you make sure to get Tomasz review tag and make sure that these patches work on top of his patches? His patches are on my "devel" branch in the pin control tree, but will not be pushed to linux-next unti

Re: [PATCH 0/5] pinctrl: samsung: Data structure clean-up

2014-10-02 Thread Linus Walleij
On Sat, Sep 27, 2014 at 2:50 PM, Tomasz Figa wrote: > On 25.09.2014 09:49, Tomasz Figa wrote: >> On 25.09.2014 09:47, Linus Walleij wrote: >>> On Tue, Sep 23, 2014 at 9:05 PM, Tomasz Figa wrote: >>> >>>> This series intends to clean up data structur

Re: [PATCH 0/5] pinctrl: samsung: Data structure clean-up

2014-09-25 Thread Linus Walleij
and selected structures > constified to improve safety. I like the patch set, tried to apply it but patch 3/5 failed to apply to the devel branch for pinctrl. Can you rebase this on my "devel" branch, include Marek's Tested-by tag and resend, and I'll take it for v3.18. Yours, Linus

Re: [PATCH v2 1/5] pinctrl: exynos: Generalize the eint16_31 demux code

2014-09-23 Thread Linus Walleij
offsets. So generalize > the exynos_irq_demux_eint16_31 function by using the pending/mask register > offset values from the exynos_irq_chip structure. > > Signed-off-by: Abhilash Kesavan > Reviewed-by: Thomas Abraham > Tested-by: Thomas Abraham > Cc: Thomas Abraham > Cc: To

Re: [PATCH 2/3] kbuild: remove unnecessary variable initializaions

2014-09-23 Thread Linus Walleij
-m are also set to empty at the beginning > of scripts/Makefile.build) > > Signed-off-by: Masahiro Yamada Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.ke

Re: [PATCH 05/14] pinctrl: exynos: Add driver data for Exynos7

2014-09-02 Thread Linus Walleij
t; Cc: Tomasz Figa > Cc: linus.wall...@linaro.org > Cc: Thomas Abraham Tomasz can you have a look at this (from your private mail...)? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kerne

Re: [PATCH 06/14] pinctrl: samsung: use CONFIG_PINCTRL_SAMSUNG symbol in makefile

2014-08-29 Thread Linus Walleij
ore places in the Makefile, I was confused by logically thinking that Kconfig symbols used in Makefile cannot be from a Kconfig one level below. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@v

Re: [PATCH] MAINTAINERS: Tomasz has moved

2014-08-29 Thread Linus Walleij
some of the responsibilities, as I will be doing my part in my spare > time. > > Signed-off-by: Tomasz Figa OK I'm taking this patch through pinctrl fixes. Not much controversy here, Mike you need not worry about it. Patch applied. Yours, Linus Walleij -- To unsubscribe from this list:

Re: [PATCH 1/1] pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs

2014-08-21 Thread Linus Walleij
solution for Samsung SoCs but it's definitely a > move in the right direction. > > Signed-off-by: Tomasz Figa > [javier: use request resources instead of startup and expand commit message] > Signed-off-by: Javier Martinez Canillas OK patch applied for fixes, sorry for missing to foll

Re: [PATCH 1/1] pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs

2014-08-11 Thread Linus Walleij
d in https://lkml.org/lkml/2014/8/8/461 Hm, this looks much better atleast, it is not possible to use the irqchip helpers from gpiolib then, because that grabs the request/release resource callbacks. If I get some ACKs on this we can go for this solution. Yours, Linus Walleij -- To un

Re: [PATCH v2 1/1] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting

2014-08-11 Thread Linus Walleij
rqchip must however be solved in the driver itself, the core only helps out in blocking some abuse of the API. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [RFC 3/5] pinctrl: exynos: add exynos5410 SoC specific data

2014-08-08 Thread Linus Walleij
eview this before applying. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] pinctrl: samsung: Group all drivers in a sub-dir

2014-07-10 Thread Linus Walleij
On Thu, Jul 10, 2014 at 2:03 PM, Sachin Kamat wrote: > Group all pin control drivers of Samsung platform together in > a sub-directory for easy maintenance. > > Signed-off-by: Sachin Kamat Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "

Re: [PATCH v7 08/24] mfd: max77686: Add Dynamic Voltage Scaling (DVS) support

2014-07-10 Thread Linus Walleij
gpio = pd->buck_gpio_selb[i]; > + > + /* OK if some GPIOs aren't defined */ > + if (IS_ERR(gpio)) > + continue; > + > + ret = gpiod_direction_output_raw(gpio, 1); Why does this have to be raw? Usually that is n

Re: [PATCH 6/6] pinctrl: samsung: Allow pin value to be initialized using pinfunc

2014-07-09 Thread Linus Walleij
driver, but need certain board-specific setting. > > Signed-off-by: Tomasz Figa > Acked-by: Kyungmin Park Patch applied. It always makes me a little bit sad that we didn't get generic pin config in place before this driver but now we have to live with it. Yours, Linus Walleij -

Re: [PATCH 5/6] pinctrl: samsung: Allow grouping multiple pinmux/pinconf nodes

2014-07-09 Thread Linus Walleij
}; > }; > > Tested on Exynos4210-Trats board and a custom Exynos4212-based one. > > Signed-off-by: Tomasz Figa > Acked-by: Kyungmin Park > Reviewed-by: Stephen Warren > Cc: devicet...@vger.kernel.org > Cc: Rob Herring > Cc: Mark Rutland Patch

Re: [RFC PATCH v3] reset: Add a defer reset object to send board specific reset

2014-07-08 Thread Linus Walleij
On Tue, Jul 8, 2014 at 10:05 AM, Maxime Ripard wrote: > On Tue, Jul 08, 2014 at 09:52:03AM +0200, Linus Walleij wrote: >> On Wed, Jun 18, 2014 at 3:37 PM, Houcheng Lin wrote: >> >> > The Problem >> > --- >> > The reset signal on a hardware board

Re: [PATCH 4/6] pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs

2014-07-08 Thread Linus Walleij
hutdown cannot really fail (ret code is unsigned...), so using the other callbacks is safer. Can you have a quick look at this before I apply any more of the Samsung patches? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the bo

Re: [PATCH 3/6] pinctrl: exynos: Consolidate irq_chips of GPIO and WKUP EINTs

2014-07-08 Thread Linus Walleij
the driver. > > Signed-off-by: Tomasz Figa Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/6] pinctrl: samsung: Handle GPIO request and free using pinctrl helpers

2014-07-08 Thread Linus Walleij
Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] pinctrl: samsung: Decouple direction setting from pinctrl

2014-07-08 Thread Linus Walleij
e.g. i2c-gpio. > > Signed-off-by: Tomasz Figa Well the cross-call function is actually mostly for the case when the pinctrl and GPIO drivers are in different files, or you combine two IP blocks arbitrarily. It's a bit messy anyway. Patch applied. Yours, Linus Walleij -- To unsubscribe

Re: [RFC PATCH v3] reset: Add a defer reset object to send board specific reset

2014-07-08 Thread Linus Walleij
;t already a generic GPIO reset driver, just call this drivers/reset/reset-gpio.c and make the ability to deferral just a configuration detail of the GPIO reset driver. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a messag

Re: [PATCH] ARM: dts: Add mask-tpm-reset to the device tree

2014-07-08 Thread Linus Walleij
egulator { > + compatible = "regulator-fixed"; No matter how the discussion ends up, regulator-fixed is wrong. Either folding it into the TPM driver or using a separate reset driver is fine with me. So what about the generic delayed reset GPIO thing? http://marc.info/?l=linux

Re: [PATCH 09/17] gpio: samsung: remov s5pc100 related gpio codes

2014-07-07 Thread Linus Walleij
On Mon, Jun 30, 2014 at 11:32 PM, Kukjin Kim wrote: > This patch removes gpio codes for s5pc100 SoC. > > Signed-off-by: Kukjin Kim > Cc: Linus Walleij Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-so

Re: [PATCH 02/17] gpio: samsung: remove s5p64x0 related gpio codes

2014-07-07 Thread Linus Walleij
On Mon, Jun 30, 2014 at 11:32 PM, Kukjin Kim wrote: > This patch removes gpio codes for s5p6440 and s5p6450 SoCs. > > Signed-off-by: Kukjin Kim > Cc: Linus Walleij Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH v2 1/6] ARM: mm: cache-l2x0: Add base address argument to write_sec callback

2014-06-27 Thread Linus Walleij
r .write_sec operation. This patch adds base argument to > .write_sec callback so that its implementation can also access registers > directly. > > Signed-off-by: Tomasz Figa > arch/arm/mach-ux500/cache-l2x0.c | 3 ++- In our case just changing the signature of the function I see

Re: [PATCHv2] pinctrl: exynos: Add driver data for Exynos3250

2014-04-23 Thread Linus Walleij
gt; > Changes from v1: > - Add signed-off of sender > - Post only separated patch for pinctrl from following patchset(v1) > : https://lkml.org/lkml/2014/4/10/286 > > Cc: Thomas Abraham > Cc: Linus Walleij > Cc: Kukjin Kim > Signed-off-by: Tomasz Figa > Signed-off

Re: [PATCH 08/27] pinctrl: exynos: Add driver data for Exynos3250

2014-04-10 Thread Linus Walleij
> > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park Ugh can Tomasz send out his patches himself, I get confused... It was also sent two times, the second time with CC:s added. Tomasz, shall I merge this? Yours, Linus Walleij -- To unsubscribe from this list: send the line &qu

Re: [PATCH 49/75] ARM: l2c: fix register naming

2014-03-28 Thread Linus Walleij
Provide full auxiliary control register definitions. > > Signed-off-by: Russell King Acked-by: Linus Walleij For ux500. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2] pinctrl: exynos: add exynos5260 SoC specific data

2014-02-06 Thread Linus Walleij
Signed-off-by: Arun Kumar K Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-15 Thread Linus Walleij
t, the issue also exist in e.g. drivers/gpio/gpio-samsung.c which can be compiled (like for allyesconfig) when PLAT_SAMSUNG is set. And it is also set to y for ARCH_EXYNOS... which doesn't have any custom GPIO header. So this would involve something like creating an empty for Exyno

Re: [PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-15 Thread Linus Walleij
amsung.h. Hm I just applied a fixup from Sachin adding #ifdefs back in but maybe I should try to fix it up like that instead. Just a minute... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger

Re: [PATCH 1/1] ARM: S5P[v210|c100|64x0]: Fix build error

2014-01-15 Thread Linus Walleij
Damned I couldn't get rid of the ifdefs anyway :-( Thanks Sachin, patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] ARM: s3c24xx: explicit dependency on

2014-01-14 Thread Linus Walleij
. Reported-by: Arnd Bergmann Cc: Tomasz Figa Cc: Sylwester Nawrocki Cc: Ben Dooks Cc: Kukjin Kim Cc: Heiko Stuebner Cc: Mark Brown Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Linus Walleij --- Maintainers: this builds on top of the previous patch moving headers back to . This will

[PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-14 Thread Linus Walleij
into the machine-local file and think about the next step. Reported-by: Arnd Bergmann Cc: Tomasz Figa Cc: Sylwester Nawrocki Cc: Ben Dooks Cc: Kukjin Kim Cc: Heiko Stuebner Cc: Mark Brown Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Linus Walleij --- Maintainers (Kukjin especially

Re: [PATCH 1/2 v3] ARM: s3c24xx: get rid of custom

2014-01-14 Thread Linus Walleij
hat > part should be simple enough and helpful at the same time. is used by S5P as well, but I guess you've checked that. If I take it driver-by-driver it should be possible to get rid of it or most of it I think, reducing it to the arch/arm/mach-* folder. Certainly I should be attacking

Re: [PATCH 1/2 v3] ARM: s3c24xx: get rid of custom

2014-01-08 Thread Linus Walleij
On Tue, Jan 7, 2014 at 8:52 PM, Arnd Bergmann wrote: > On Tuesday 07 January 2014, Linus Walleij wrote: >> It appears that these problems appear if you explicitly >> enable the DT board support, can't we just put that into >> the defconfig then, so we don'

Re: [PATCH 1/2 v3] ARM: s3c24xx: get rid of custom

2014-01-07 Thread Linus Walleij
On Tue, Jan 7, 2014 at 12:15 PM, Arnd Bergmann wrote: > On Friday 13 December 2013, Linus Walleij wrote: >> This isolates the custom S3C24xx GPIO definition table to >> as this is >> used in a few different places in the kernel, removing the >> need to depend o

[PATCH] ARM: s3c24xx: fix build error

2014-01-07 Thread Linus Walleij
Signed-off-by: Linus Walleij --- I have tentatively applied this to the GPIO tree so I don't cause build regressions, ACKs are still appreciated from the S3C maintainers. --- arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-s3c24xx

Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.

2014-01-02 Thread Linus Walleij
eiko's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.

2013-12-20 Thread Linus Walleij
On Fri, Dec 13, 2013 at 10:37 AM, Linus Walleij wrote: > On Fri, Dec 13, 2013 at 10:24 AM, wrote: >> José Miguel Gonçalves wrote: > (..) >>> Was this patch forgotten? >>> >> Hi Jose, >> >> Sorry about missing your patch. It's my fault :

[PATCH 2/2 v2] ARM: s3c64xx: get rid of custom

2013-12-13 Thread Linus Walleij
y with the GPIO calculation macros for GPIO_BOARD_START, BOARD_NR_GPIOS and the definition of ARCH_NR_GPIOS. Cc: Mark Brown Cc: Tomasz Figa Acked-by: Kukjin Kim Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Move the movement of the actual gpio.h file into this patch after mistakenly havin

[PATCH 1/2 v3] ARM: s3c24xx: get rid of custom

2013-12-13 Thread Linus Walleij
, as per pattern from other archs. Cc: Tomasz Figa Cc: Sylwester Nawrocki Cc: Ben Dooks Cc: linux-samsung-soc@vger.kernel.org Acked-by: Kukjin Kim Acked-by: Heiko Stuebner Tested-by: Heiko Stuebner Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Move the movement of the S3C64XX gpio.h f

Re: [PATCH 1/2] ARM: s3c24xx: get rid of custom

2013-12-13 Thread Linus Walleij
On Fri, Dec 13, 2013 at 11:30 AM, Tomasz Figa wrote: > On Thursday 12 of December 2013 15:06:50 Linus Walleij wrote: > [snip] >> arch/arm/mach-s3c64xx/include/mach/gpio.h | 93 - > > Hmm, shouldn't this (and other s3c64xx-related changes) be i

Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.

2013-12-13 Thread Linus Walleij
an certainly rebase the patch onto my tree if I just get an ACK for it... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: s3c24xx: get rid of custom

2013-12-13 Thread Linus Walleij
On Fri, Dec 13, 2013 at 8:57 AM, Heiko Stübner wrote: > I'm not the maintainer of s3c24xx, Maybe you should be. I have a hard time getting the generic Samsung maintainers' attention to S3C patches... > but this looks nice ;-) Do you think you can test it on hardware? Your

Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.

2013-12-13 Thread Linus Walleij
On Fri, Dec 13, 2013 at 2:55 AM, José Miguel Gonçalves wrote: > On 27-09-2013 15:17, Linus Walleij wrote: >> On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves >> wrote: >> >>> Some GPIO line limits are incorrectly set which, for instance, >>> does not

Re: [PATCH CFT] ARM:S5P64X0: Enable ARM_PATCH_PHYS_VIRT and AUTO_ZRELADDR by default

2013-12-12 Thread Linus Walleij
On Thu, Dec 12, 2013 at 10:22 PM, Tomasz Figa wrote: > 2013/12/12 Linus Walleij : >> On Thu, Dec 12, 2013 at 10:47 AM, Tomasz Figa wrote: >> >>> This is actually quite a poor platform choice. As of today, the kernel >>> is stuck with supporting just SMDK6440/6

Re: [PATCH CFT] ARM:S5P64X0: Enable ARM_PATCH_PHYS_VIRT and AUTO_ZRELADDR by default

2013-12-12 Thread Linus Walleij
> up in future. Kukjin has actually proposed removing support for this > platform at all and I consider this reasonable. > > Kukjin, should we proceed with removal? Isn't Mark Brown using that platform for some various stuff? Yours, Linus Walleij -- To unsubscribe from this list: s

[PATCH 2/2] ARM: s3c64xx: get rid of custom

2013-12-12 Thread Linus Walleij
y with the GPIO calculation macros for GPIO_BOARD_START, BOARD_NR_GPIOS and the definition of ARCH_NR_GPIOS. Cc: Kukjin Kim Cc: Mark Brown Cc: Tomasz Figa Signed-off-by: Linus Walleij --- This patch depends on "ARM: s3c24xx: get rid of custom " If one of the maintainers give me an AC

[PATCH 1/2] ARM: s3c24xx: get rid of custom

2013-12-12 Thread Linus Walleij
, as per pattern from other archs. Cc: Heiko Stuebner Cc: Tomasz Figa Cc: Sylwester Nawrocki Cc: Ben Dooks Cc: Kukjin Kim Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Added an #ifdef ARCH_S3C24XX around the header inclusion in drivers/gpio/g

Re: [PATCH] pinctrl: samsung: Allow pin value to be initialized using pinfunc.

2013-12-09 Thread Linus Walleij
On Fri, Dec 6, 2013 at 12:54 AM, Stephen Warren wrote: > On 12/03/2013 02:29 AM, Linus Walleij wrote: (skipped the conversation on weak hogs, we are on the same page here, just waiting for someone to start working on it ...) > Related, I prefer to put /all/ static pinctrl configuration in

Re: [PATCH] pinctrl: samsung: Allow pin value to be initialized using pinfunc.

2013-12-09 Thread Linus Walleij
On Thu, Dec 5, 2013 at 4:07 PM, Mark Brown wrote: > On Tue, Dec 03, 2013 at 10:29:42AM +0100, Linus Walleij wrote: > >> So a suggested patch to support weak hogs would be interesting >> to look at. Can you provide details on how you think this would >> work? > > Or s

Re: [PATCH] ARM: s3c24xx: get rid of custom

2013-12-06 Thread Linus Walleij
On Fri, Dec 6, 2013 at 10:31 AM, Linus Walleij wrote: > This isolates the custom S3C24xx GPIO definition table to > Maybe I'm too trigger happy. I'll send a combined series with S3C24xx, S3C64xx and maybe also S5P variants all fixed so you can see the overall idea here. Hold o

[PATCH] ARM: s3c24xx: get rid of custom

2013-12-06 Thread Linus Walleij
, as per pattern from other archs. Cc: Heiko Stuebner Cc: Tomasz Figa Cc: Sylwester Nawrocki Cc: Ben Dooks Cc: Kukjin Kim Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Linus Walleij --- If one of the maintainers give me an ACK for this I will take it through the GPIO tree. --- arch/arm

  1   2   3   4   >