Re: [RFC PATCH 0/3] clocksource: exynos_mct: allow mct to use 64-bit counter from coprocessor

2015-07-28 Thread Mark Rutland
On Mon, Jul 27, 2015 at 10:28:27PM +0100, Alexey Klimov wrote: Hi all, year(s) ago it was discovered that MCT timer and ARM architectured timer are the same hardware with different interface. Here [1]. Are they actually interfaces to the same timer, or are they just fed by the same system

Re: [PATCH v7 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-04-13 Thread Mark Rutland
Hi Chanwoo, Could you please reply to the below? Without an answer I'm going to have to ask for the patch to be unqueued for the moment, and I'd prefer that we came to a solution instead. Thanks, Mark. On Tue, Apr 07, 2015 at 11:25:27AM +0100, Mark Rutland wrote: I'm very worried about

Re: [PATCH v7 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-04-13 Thread Mark Rutland
So NAK to the PSCI node and PSCI enable method in this dts until we either have a working firmware, or a reasonable mechanism to handle the deficiency. There is only CPU0 hotplug issue. Excpet CPU{1-7} are well working. I understand that, but the issue with CPU0 is still a blocker

Re: [PATCH v7 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-04-07 Thread Mark Rutland
I'm very worried about adding a DT that's known broken, especially when we have no idea as to if/when the FW will be fixed judging from prior replies. As I replied, I can not fix the FW because I don't have any code of FW. Surely you are able to contact those who do? I don't

Re: [PATCH v7 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-04-02 Thread Mark Rutland
On Tue, Mar 31, 2015 at 12:56:38AM +0100, Chanwoo Choi wrote: Hi Mark, On 03/31/2015 01:09 AM, Mark Rutland wrote: Hi, On Wed, Mar 18, 2015 at 12:17:28AM +, Chanwoo Choi wrote: This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC based on Octal core CPUs (quad

Re: [PATCH v7 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-03-30 Thread Mark Rutland
Hi, On Wed, Mar 18, 2015 at 12:17:28AM +, Chanwoo Choi wrote: This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC based on Octal core CPUs (quad Cortex-A57 and quad Cortex-A53). And Exynos5433 supports PSCI (Power State Coordination Interface) v0.1. This patch includes

Re: [PATCH v5 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-03-12 Thread Mark Rutland
[...] Do CPUs enter the kernel at EL2 or at EL1? Could you give me a tip how to check the kernel at EL2 or EL1? Hmm... I thought we logged this but it looks like we don't. You could hack in a check of is_hyp_mode_available() and is_hyp_mode_mismatched(). That will tell you if

Re: [PATCH v5 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-03-06 Thread Mark Rutland
CPU0 (boot CPU) is only well working for CPU_OFF. But when I try to turn on the CPU0 after CPU_OFF, I failed it. That's rather worrying. Can you look into what's going on here? I'd rather not have dts describing things which are known to be broken. The board dts don't include any

Re: [PATCH v5 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-03-05 Thread Mark Rutland
Hi, [...] + psci { + compatible = arm,psci; + method = smc; + cpu_off = 0x8402; + cpu_on = 0xC403; + }; Back at v2 you mentioned that CPU_OFF wasn't working [1]. Do both CPU_ON and CPU_OFF work for

Re: [PATCH v5 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-03-05 Thread Mark Rutland
Hi, + psci { + compatible = arm,psci; + method = smc; + cpu_off = 0x8402; + cpu_on = 0xC403; + }; Back at v2 you mentioned that CPU_OFF wasn't working [1]. Do both CPU_ON and CPU_OFF work for

Re: [PATCH v5 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-03-05 Thread Mark Rutland
On Thu, Mar 05, 2015 at 05:38:23AM +, Chanwoo Choi wrote: This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC based on Octal core CPUs (quad Cortex-A57 and quad Cortex-A53). And Exynos5433 supports PSCI (Power State Coordination Interface) v0.1. This patch includes

Re: [RESEND PATCH v3] clocksource: exynos_mct: Add the support for Exynos 64bit SoC

2015-01-15 Thread Mark Rutland
On Wed, Jan 14, 2015 at 11:57:00PM +, Chanwoo Choi wrote: Hi Kukjin, On 01/15/2015 01:02 AM, Daniel Lezcano wrote: On 01/14/2015 04:51 PM, Kukjin Kim wrote: On 01/14/15 14:33, Chanwoo Choi wrote: Hi, + Doug, Olof This patch adds the support for Exynos 64bit SoC. The

Re: [RESEND PATCH v3] clocksource: exynos_mct: Add the support for Exynos 64bit SoC

2015-01-15 Thread Mark Rutland
On Thu, Jan 15, 2015 at 12:52:38PM +, Chanwoo Choi wrote: On Thu, Jan 15, 2015 at 9:46 PM, Chanwoo Choi cwcho...@gmail.com wrote: Hi Mark, On Thu, Jan 15, 2015 at 8:29 PM, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Jan 14, 2015 at 11:57:00PM +, Chanwoo Choi wrote: Hi

Re: [RFC 1/3] devfreq: dt-bindings: Document Exynos3250 devfreq driver

2014-12-05 Thread Mark Rutland
On Fri, Dec 05, 2014 at 04:46:26PM +, Krzysztof Kozlowski wrote: Add documentation for bindings used by Exynos3250 devfreq driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- .../bindings/arm/samsung/exynos3250-devfreq.txt| 66 ++ 1 file

Re: [PATCH 16/19] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2014-12-02 Thread Mark Rutland
On Mon, Dec 01, 2014 at 02:21:46AM +, Chanwoo Choi wrote: Dear Mark, On 11/28/2014 11:00 PM, Mark Rutland wrote: On Fri, Nov 28, 2014 at 01:18:25PM +, Chanwoo Choi wrote: Dear Mark, On 11/27/2014 08:18 PM, Mark Rutland wrote: On Thu, Nov 27, 2014 at 07:35:13AM +, Chanwoo

Re: [PATCH 14/19] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2014-12-02 Thread Mark Rutland
@samsung.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Marc Zyngier marc.zyng...@arm.com Cc: Arnd Bergmann a...@arndb.de Cc: Olof Johansson o...@lixom.net Cc: Catalin Marinas catalin.mari...@arm.com Cc: Will Deacon will.dea...@arm.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com

Re: [PATCH 14/19] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2014-12-02 Thread Mark Rutland
Hi, + psci { + compatible = arm,psci; + method = smc; + cpu_off = 0x8402; + cpu_on = 0xC403; + }; Given your comments on the latest posting, has CPU_OFF been tested, and does it work for _all_ CPUs

Re: [PATCH 16/19] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2014-11-28 Thread Mark Rutland
On Fri, Nov 28, 2014 at 01:18:25PM +, Chanwoo Choi wrote: Dear Mark, On 11/27/2014 08:18 PM, Mark Rutland wrote: On Thu, Nov 27, 2014 at 07:35:13AM +, Chanwoo Choi wrote: This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC based on Octal core CPUs (quad Cortex

Re: [PATCH 16/19] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2014-11-27 Thread Mark Rutland
On Thu, Nov 27, 2014 at 07:35:13AM +, Chanwoo Choi wrote: This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC based on Octal core CPUs (quad Cortex-A57 and quad Cortex-A53). Cc: Kukjin Kim kgene@samsung.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Arnd Bergmann

Re: [PATCH 02/19] clk: samsung: Add binding documentation for Exynos5433 clock controller

2014-11-27 Thread Mark Rutland
On Thu, Nov 27, 2014 at 07:34:59AM +, Chanwoo Choi wrote: This patch add binding documentation for Exynos5433 clock controller. Exynos5433 has various clock domains So, this documentation explains the detailed clock domains ans usage guide. Cc: Sylwester Nawrocki s.nawro...@samsung.com

Re: [PATCH 1/5] regulator: of: Add regulator-initial-mode parse support

2014-10-10 Thread Mark Rutland
On Thu, Oct 09, 2014 at 04:19:47PM +0100, Javier Martinez Canillas wrote: Hello Mark, On 10/09/2014 12:27 PM, Mark Rutland wrote: Well, is not fairly obvious to me. One can also say the opposite, why the kernel is documenting a DT binding that is not (currently) implemented

Re: [PATCH] ARM: dts: add board dts file for Exynos3250-based Monk board

2014-10-02 Thread Mark Rutland
On Thu, Oct 02, 2014 at 01:50:25AM +0100, YoungJun Cho wrote: From: Youngjun Cho yj44@samsung.com This patch adds new board dts file to support Samsung Monk board which is based on Exynos3250 SoC and has different H/W configuration from Rinato. This patch is based on linux-samsung.git

Re: [PATCH v5 4/7] ARM: l2c: Add support for overriding prefetch settings

2014-09-24 Thread Mark Rutland
On Wed, Sep 24, 2014 at 12:05:38PM +0100, Marek Szyprowski wrote: From: Tomasz Figa t.f...@samsung.com Firmware on certain boards (e.g. ODROID-U3) can leave incorrect L2C prefetch settings configured in registers leading to crashes if L2C is enabled without overriding them. This patch

Re: [PATCH v5 4/7] ARM: l2c: Add support for overriding prefetch settings

2014-09-24 Thread Mark Rutland
On Wed, Sep 24, 2014 at 12:19:45PM +0100, Tomasz Figa wrote: On 24.09.2014 13:14, Mark Rutland wrote: On Wed, Sep 24, 2014 at 12:05:38PM +0100, Marek Szyprowski wrote: From: Tomasz Figa t.f...@samsung.com Firmware on certain boards (e.g. ODROID-U3) can leave incorrect L2C prefetch

Re: [PATCH 1/5] usb: dwc3: exynos: Add support for SCLK present on Exynos7

2014-09-02 Thread Mark Rutland
On Tue, Sep 02, 2014 at 11:39:08AM +0100, Vivek Gautam wrote: Hi, On Fri, Aug 29, 2014 at 12:18 AM, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Aug 28, 2014 at 09:01:56AM +0100, Vivek Gautam wrote: Exynos7 also has a separate special gate clock going to the IP apart from the usual

Re: [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:34:33AM +0100, Ajay kumar wrote: On Wed, Aug 27, 2014 at 8:31 PM, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Aug 27, 2014 at 03:48:27PM +0100, Ajay Kumar wrote: Add DT nodes for ptn3460 bridge chip and panel. Add backlight enable pin and backlight power

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
Hi, + cpus { + #address-cells = 2; + #size-cells = 0; Why size-cells=2? Can you not fit a cpuid in 32 bits? As of commit 72aea393a2e7 (arm64: smp: honour #address-size when parsing CPU reg property) Linux can handle single-cell cpu node reg entries where

Re: [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 10:34:32AM +0100, Ajay kumar wrote: On Thu, Aug 28, 2014 at 2:45 PM, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Aug 28, 2014 at 06:34:33AM +0100, Ajay kumar wrote: On Wed, Aug 27, 2014 at 8:31 PM, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Aug 27, 2014

Re: [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 02:10:18PM +0100, Thierry Reding wrote: On Thu, Aug 28, 2014 at 03:04:32PM +0530, Ajay kumar wrote: On Thu, Aug 28, 2014 at 2:45 PM, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Aug 28, 2014 at 06:34:33AM +0100, Ajay kumar wrote: On Wed, Aug 27, 2014 at 8:31 PM

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 05:28:22PM +0100, Olof Johansson wrote: On Thu, Aug 28, 2014 at 2:48 AM, Mark Rutland mark.rutl...@arm.com wrote: Hi, + cpus { + #address-cells = 2; + #size-cells = 0; Why size-cells=2? Can you not fit a cpuid in 32 bits

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:27:04PM +0100, Marc Zyngier wrote: On 28/08/14 18:03, Mark Rutland wrote: From 67104ad5a56e4c18f9c41f06af028b7561740afd Mon Sep 17 00:00:00 2001 From: Mark Rutland mark.rutl...@arm.com Date: Thu, 28 Aug 2014 17:41:03 +0100 Subject: [PATCH] Doc: dt: arch_timer

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:19:00PM +0100, Olof Johansson wrote: On Thu, Aug 28, 2014 at 10:03 AM, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Aug 28, 2014 at 05:28:22PM +0100, Olof Johansson wrote: On Thu, Aug 28, 2014 at 2:48 AM, Mark Rutland mark.rutl...@arm.com wrote: Hi

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:33:13PM +0100, Rob Herring wrote: On Thu, Aug 28, 2014 at 12:27 PM, Marc Zyngier marc.zyng...@arm.com wrote: On 28/08/14 18:03, Mark Rutland wrote: From 67104ad5a56e4c18f9c41f06af028b7561740afd Mon Sep 17 00:00:00 2001 From: Mark Rutland mark.rutl...@arm.com

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:37:19PM +0100, Marc Zyngier wrote: On 28/08/14 18:30, Mark Rutland wrote: On Thu, Aug 28, 2014 at 06:27:04PM +0100, Marc Zyngier wrote: On 28/08/14 18:03, Mark Rutland wrote: From 67104ad5a56e4c18f9c41f06af028b7561740afd Mon Sep 17 00:00:00 2001 From: Mark

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:47:00PM +0100, Geert Uytterhoeven wrote: Hi Mark, On Thu, Aug 28, 2014 at 7:39 PM, Mark Rutland mark.rutl...@arm.com wrote: Ok. If address-cells is kept at 2 the unit address needs to be changed to 0,0. So one or the other has to be changed. I'm happy

Re: [PATCH 2/5] phy: exynos5-usbdrd: Add pipe-clk and utmi-clk support

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 09:01:57AM +0100, Vivek Gautam wrote: Exynos7 SoC has now separate gate control for 125MHz pipe3 phy clock, as well as 60MHz utmi phy clock. So get the same and control in the phy-exynos5-usbdrd driver. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com ---

Re: [PATCH 1/5] usb: dwc3: exynos: Add support for SCLK present on Exynos7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 09:01:56AM +0100, Vivek Gautam wrote: Exynos7 also has a separate special gate clock going to the IP apart from the usual AHB clock. So add support for the same. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/dwc3/dwc3-exynos.c | 16

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-27 Thread Mark Rutland
Hi Naveen, On Wed, Aug 27, 2014 at 10:44:18AM +0100, Naveen Krishna Chatradhi wrote: Add initial device tree nodes for EXYNOS7 SoC. Also, includes the dt-binding definitions for clock ids. Fallout from a rebase? That latter part doesn't seem to be relevant. Signed-off-by: Naveen Krishna

Re: [PATCH 13/14] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support

2014-08-27 Thread Mark Rutland
Hi, On Wed, Aug 27, 2014 at 10:44:20AM +0100, Naveen Krishna Chatradhi wrote: From: Alim Akhtar alim.akh...@samsung.com This patch adds the necessary Kconfig entries to enable support for the ARMv8 based Exynos7 SoC. Signed-off-by: Alim Akhtar alim.akh...@samsung.com Signed-off-by:

Re: [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow

2014-08-27 Thread Mark Rutland
On Wed, Aug 27, 2014 at 03:48:27PM +0100, Ajay Kumar wrote: Add DT nodes for ptn3460 bridge chip and panel. Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow. Note that, snow doesn't support

Re: [PATCH] ARM: dts: add CPU nodes for Exynos4 SoCs

2014-07-18 Thread Mark Rutland
On Fri, Jul 18, 2014 at 05:00:02PM +0100, Bartlomiej Zolnierkiewicz wrote: Recent patch by Tomasz Figa (irqchip: gic: Fix core ID calculation when topology is read from DT) fixed GIC driver to filter cluster ID from values returned by cpu_logical_map() for SoCs having registers mapped without

Re: [PATCH V3 0/7] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-27 Thread Mark Rutland
On Fri, Jun 27, 2014 at 11:24:58AM +0100, Inki Dae wrote: + DT mailing list Thanks for the Cc. Can we get the rest of the series? Judging a series based on its diffstat alone is a little hard... Or is my mailbox filtering hiding the rest of these from me? Any reason for not Ccing lakml?

Re: [PATCH 3/4] Documentation: devicetree: Fix tps65090 typos

2014-06-25 Thread Mark Rutland
; - vsys_l2-supply = some_reg; + vsys-l1-supply = some_reg; + vsys-l2-supply = some_reg; Your change matches the code and all existing device trees in the Linux kernel. Could this fact please be mentioned in the commit message? Given that: Acked-by: Mark Rutland

Re: [PATCH 1/4] devicetree: bindings: Document murata vendor prefix

2014-06-24 Thread Mark Rutland
fine to me. With the order fixed: Acked-by: Mark Rutland mark.rutl...@arm.com Mark. national National Semiconductor neonode Neonode Inc. netgear NETGEAR -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message

Re: [PATCH 2/4] hwmon: ntc_thermistor: Use the manufacturer name properly

2014-06-24 Thread Mark Rutland
On Tue, Jun 24, 2014 at 01:19:14PM +0100, Naveen Krishna Chatradhi wrote: Murata Manufacturing Co., Ltd is the vendor for NTC (Negative Temperature coefficient) based Thermistors. But, the driver extensively uses NTC as the vendor name. This patch corrects the vendor name also updates the

Re: [PATCH 3/4] ARM: DTS: use new compatible string as per the documentation

2014-06-24 Thread Mark Rutland
On Tue, Jun 24, 2014 at 01:19:15PM +0100, Naveen Krishna Chatradhi wrote: As Murata is the Manufactures the NTC thermistors. The vendor name in the compatibility is preposed to change to murata, ncpXXX This patch uses the new compatibility string in exynos4412 based Trats2 board.

Re: [PATCHv3 3/4] mmc: dw_mmc: remove the supports-highspeed property.

2014-06-03 Thread Mark Rutland
On Fri, May 30, 2014 at 09:01:16AM +0100, Ulf Hansson wrote: On 28 May 2014 07:35, Jaehoon Chung jh80.ch...@samsung.com wrote: Removed the parser for supports-highspeed. It can be parsed with cap-mmc-highsped or cap-sd-highspeed at mmc_of_parse(). Signed-off-by: Jaehoon Chung

Re: [PATCH v6 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency

2014-05-30 Thread Mark Rutland
...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: Kumar Gala ga...@codeaurora.org Signed-off-by: Thomas Abraham thomas...@samsung.com Acked-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Nishanth Menon n

Re: [PATCH v6 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency

2014-05-30 Thread Mark Rutland
On Fri, May 30, 2014 at 07:05:43PM +0100, Thomas Abraham wrote: Hi Mark, On Fri, May 30, 2014 at 6:38 PM, Mark Rutland mark.rutl...@arm.com wrote: Hi, Apologies for being somewhat late w.r.t. review on this. On Fri, May 30, 2014 at 10:01:17AM +0100, Thomas Abraham wrote: From

Re: [PATCH 07/27] irqchip: Declare cortex-a7's irqchip to initialize gic from dt

2014-04-10 Thread Mark Rutland
On Thu, Apr 10, 2014 at 11:04:59AM +0100, Marc Zyngier wrote: On Thu, Apr 10 2014 at 10:28:24 am BST, Chanwoo Choi cw00.c...@samsung.com wrote: This patch declare coretex-a7's irqchip to initialze gic from dt with arm,cortex-a7-gic data. Cc: Thomas Gleixner t...@linutronix.de

Re: [PATCH V4 1/8] sxgbe: Add device-tree binding support document

2014-03-21 Thread Mark Rutland
On Wed, Mar 19, 2014 at 10:32:48PM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : On Tue, Mar 18, 2014 at 04:27:46PM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : Hi, As a general note it's helpful for devicetree to be Cc'd on the entire series

Re: [PATCH V8 1/7] sxgbe: Add device-tree binding support document

2014-03-21 Thread Mark Rutland
+Example: + + aliases { + ethernet0 = sxgbe0; + }; + + sxgbe0: ethernet@1a04 { + compatible = samsung,sxgbe-v2.0a; + reg = 0 0x1a04 0 0x1; + interrupt-parent = gic; + interrupts = 0 209 4, 0 185 4, 0 186

Re: [PATCH V8 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-21 Thread Mark Rutland
On Thu, Mar 20, 2014 at 05:26:06PM +, Byungho An wrote: From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An

Re: [PATCH v3 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-21 Thread Mark Rutland
Hi, On Mon, Mar 17, 2014 at 10:14:35PM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari...@arm.com --- arch/arm64/boot/dts/samsung-gh7.dtsi | 134 +++

Re: [PATCH V4 1/8] sxgbe: Add device-tree binding support document

2014-03-19 Thread Mark Rutland
On Tue, Mar 18, 2014 at 04:27:46PM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : Hi, As a general note it's helpful for devicetree to be Cc'd on the entire series (though the binding document should be a separate patch) as it provides useful context for reviewing

Re: [PATCH V4 1/8] sxgbe: Add device-tree binding support document

2014-03-18 Thread Mark Rutland
Hi, As a general note it's helpful for devicetree to be Cc'd on the entire series (though the binding document should be a separate patch) as it provides useful context for reviewing the binding. On Tue, Mar 18, 2014 at 06:47:13AM +, Byungho An wrote: From: Siva Reddy

Re: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-18 Thread Mark Rutland
On Fri, Mar 14, 2014 at 01:26:31AM +, Kukjin Kim wrote: + cpu@000 { + device_type = cpu; + compatible = arm,armv8; The arm,armv8 should be a fallback rather than the only entry. The precise core should be first (see

Re: [PATCH V2 1/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-17 Thread Mark Rutland
On Mon, Mar 17, 2014 at 05:51:21AM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : On Wed, Mar 12, 2014 at 01:28:00PM +, Byungho An wrote: From: Siva Reddy siva.kal...@samsung.com This patch adds support for Samsung 10Gb ethernet driver(sxgbe). - sxgbe core

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-14 Thread Mark Rutland
On Fri, Mar 14, 2014 at 07:14:37AM +, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 02:53 AM, Mark Rutland wrote: On Thu, Mar 13, 2014 at 08:17:29AM +, Chanwoo Choi wrote: This patch add busfreq driver for Exynos4210/Exynos4x12 memory interface and bus to support DVFS(Dynamic

Re: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-13 Thread Mark Rutland
On Wed, Mar 12, 2014 at 04:31:56AM +, Kukjin Kim wrote: Mark Rutland wrote: Hi Mark, On Mon, Mar 10, 2014 at 10:51:17PM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-13 Thread Mark Rutland
On Thu, Mar 13, 2014 at 08:17:29AM +, Chanwoo Choi wrote: This patch add busfreq driver for Exynos4210/Exynos4x12 memory interface and bus to support DVFS(Dynamic Voltage Frequency Scaling) according to PPMU counters. PPMU (Performance Profiling Monitorings Units) of Exynos4 SoC provides

Re: [PATCH V2 1/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-12 Thread Mark Rutland
On Wed, Mar 12, 2014 at 01:28:00PM +, Byungho An wrote: From: Siva Reddy siva.kal...@samsung.com This patch adds support for Samsung 10Gb ethernet driver(sxgbe). - sxgbe core initialization - Tx and Rx support - MDIO support - ISRs for Tx and Rx - ifconfig support to driver

Re: [PATCH v2 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-11 Thread Mark Rutland
On Mon, Mar 10, 2014 at 10:51:17PM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari...@arm.com --- arch/arm64/boot/dts/samsung-gh7.dtsi | 106 +++

Re: [PATCH v4 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-02-21 Thread Mark Rutland
On Thu, Feb 20, 2014 at 07:40:30PM +, Sylwester Nawrocki wrote: This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells property to 'camera' node - the #clock-cells property is needed when the sensor sub-devices use

Re: [PATCH v4 02/10] Documentation: dt: Add DT binding documentation for S5C73M3 camera

2014-02-21 Thread Mark Rutland
; + }; + }; + }; +}; + +spi@1392000 { + ... + s5c73m3_spi: s5c73m3 { Nit: this should have a 0 unit-address to match the reg. + compatible = samsung,s5c73m3; + reg = 0; + ... + }; +}; Otherwise I don't see anything problematic about the binding. Acked-by: Mark

Re: [PATCH v4 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs

2014-02-21 Thread Mark Rutland
On Thu, Feb 20, 2014 at 07:40:34PM +, Sylwester Nawrocki wrote: This patch adds clock provider so the the SCLK_CAM0/1 output clocks can be accessed by image sensor devices through the clk API. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Kyungmin Park

Re: [PATCH] V4L: s5k6a3: Add DT binding documentation

2014-02-19 Thread Mark Rutland
kyungmin.p...@samsung.com --- This patch adds missing documentation [1] for the samsung,s5k6a3 compatible. Rob, can you please merge it through your tree if it looks OK ? Anyone cares to Ack this patch so it can be merged through the media tree ? It looks fine to me: Acked-by: Mark

Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-12 Thread Mark Rutland
+ gic: interrupt-controller@1C00 { + compatible = arm,cortex-a15-gic, arm,cortex-a9-gic; This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc? arm,cortex-a9-gic is definitely wrong (the A9 GIC doesn't have the virt

Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-02-11 Thread Mark Rutland
On Tue, Feb 11, 2014 at 06:29:41AM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari...@arm.com --- arch/arm64/boot/dts/samsung-gh7.dtsi | 108 ++

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2014-02-10 Thread Mark Rutland
On Thu, Nov 07, 2013 at 12:42:34PM +, Naveen Krishna Chatradhi wrote: On Exynos5420 the TMU(4) for GPU has a seperate clock enable bit from the other TMU channels(0 ~ 3). Hence, accessing TRIMINFO for base_second should be acompanied by enabling the respective clock. This patch which

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2014-02-10 Thread Mark Rutland
On Mon, Feb 10, 2014 at 10:50:01AM +, Naveen Krishna Ch wrote: Hello Mark, On 10 February 2014 16:03, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Nov 07, 2013 at 12:42:34PM +, Naveen Krishna Chatradhi wrote: On Exynos5420 the TMU(4) for GPU has a seperate clock enable bit from

Re: [PATCH v10 1/2] [media] exynos5-is: Adds DT binding documentation

2014-02-06 Thread Mark Rutland
://www.spinics.net/lists/devicetree/msg11550.html Please check this and give an ack if it is fine to be merged. Apologies for the delay. As far as I can tell this looks ok: Acked-by: Mark Rutland mark.rutl...@arm.com Regards Arun On Fri, Dec 13, 2013 at 10:42 AM, Arun Kumar K arun

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Mark Rutland
On Thu, Jan 23, 2014 at 05:47:25PM +, Sylwester Nawrocki wrote: On 23/01/14 18:41, Mark Rutland wrote: diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 93cddeb..2da5617 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -22,6 +22,7

Re: [PATCH v9] s5k5baf: add camera sensor driver

2013-12-05 Thread Mark Rutland
: Acked-by: Mark Rutland mark.rutl...@arm.com I think we still need to move the DT binding into a separate patch. If you're going to post the patch again, then please do split the binding into a separate patch. [...] diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt b

Re: [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node

2013-12-02 Thread Mark Rutland
On Sun, Dec 01, 2013 at 10:11:47AM +, Alex Ling wrote: This patch adds biu and ciu clock names for exynos4412 dwmmc node. Without this patch, dwmmc host driver will skip enabling the two clocks and it will break dwmmc host function on exynos4412. Tested on FriendlyARM TINY4412 board. The

Re: [PATCH 3/4 v9] thermal: samsung: Add TMU support for Exynos5420 SoCs

2013-11-18 Thread Mark Rutland
On Mon, Nov 18, 2013 at 03:22:57AM +, Naveen Krishna Ch wrote: Hello All, On 12 November 2013 12:07, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: Exynos5420 has 5 TMU channels, the TRIMINFO register is misplaced for TMU channels 2, 3 and 4 TRIMINFO at 0x1006c000 contains

Re: [PATCH v9 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-11-11 Thread Mark Rutland
On Fri, Sep 27, 2013 at 11:59:06AM +0100, Arun Kumar K wrote: From: Shaik Ameer Basha shaik.am...@samsung.com This patch adds support for media device for EXYNOS5 SoCs. The current media device supports the following ips to connect through the media controller framework. [...] diff --git

Re: [PATCH v9 02/13] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-11-11 Thread Mark Rutland
On Fri, Sep 27, 2013 at 11:59:07AM +0100, Arun Kumar K wrote: The patch adds the DT binding documentation for Samsung Exynos5 SoC series imaging subsystem (FIMC-IS). Signed-off-by: Arun Kumar K arun...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com ---

Re: [PATCH] Documentation/watchdog: Update node name in samsung-wdt example

2013-10-28 Thread Mark Rutland
On Mon, Oct 28, 2013 at 06:24:17AM +, Sachin Kamat wrote: Update the name as per DT naming convention. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Mark Rutland mark.rutl...@arm.com --- .../devicetree/bindings/watchdog/samsung-wdt.txt |2 +- 1 file changed, 1

Re: [PATCH v10 01/12] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-10-28 Thread Mark Rutland
link of these image sensors must be specified using the common video +interfaces bindings, defined in video-interfaces.txt. These don't seem to be in the example and probably should be. Otherwise, this looks fine. With those points fixed up: Acked-by: Mark Rutland mark.rutl...@arm.com Thanks

Re: [PATCH v10 11/12] V4L: Add DT binding doc for s5k4e5 image sensor

2013-10-28 Thread Mark Rutland
: should contain the sensor's EXTCLK clock specifier, from + the common clock bindings I would reword this to reference clock-names so as to make the ordering relationship explicit. With that, as everything else looks sane: Acked-by: Mark Rutland mark.rutl...@arm.com Thanks Mark

Re: [PATCH] ARM: dts: Update arch timer node with clock frequency

2013-10-09 Thread Mark Rutland
On Tue, Oct 08, 2013 at 11:15:47PM +0100, Olof Johansson wrote: [Adding Tony, who reported a mainline booting issue, and Sean who helped me track this down] On Mon, Sep 23, 2013 at 7:15 AM, Mark Rutland mark.rutl...@arm.com wrote: On Sat, Sep 21, 2013 at 04:24:59PM +0100, Tomasz Figa wrote

Re: [PATCH] ARM: dts: Update arch timer node with clock frequency

2013-10-09 Thread Mark Rutland
On Wed, Oct 09, 2013 at 08:46:06PM +0100, Olof Johansson wrote: On Wed, Oct 9, 2013 at 1:25 AM, Mark Rutland mark.rutl...@arm.com wrote: On Tue, Oct 08, 2013 at 11:15:47PM +0100, Olof Johansson wrote: [Adding Tony, who reported a mainline booting issue, and Sean who helped me track

Re: [PATCH v8] s5k5baf: add camera sensor driver

2013-09-30 Thread Mark Rutland
diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt new file mode 100644 index 000..7704a1e --- /dev/null +++ b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt @@ -0,0 +1,58 @@

Re: [PATCH v2] MTD: Onenand: Add device tree support for samsung onenand

2013-09-26 Thread Mark Rutland
On Tue, Sep 24, 2013 at 02:00:01PM +0100, Tomasz Figa wrote: Hi Mateusz, Mark, Hi, On Monday 23 of September 2013 15:08:23 Mark Rutland wrote: On Mon, Sep 23, 2013 at 02:06:48PM +0100, Mateusz Krawczuk wrote: + +Required properties: + - compatible: value should be either

Re: [PATCH v2] MTD: Onenand: Add device tree support for samsung onenand

2013-09-23 Thread Mark Rutland
On Mon, Sep 23, 2013 at 02:06:48PM +0100, Mateusz Krawczuk wrote: This patch add clk and device tree nodes for samsung onenand driver. since v1: Updated Documentation according to Mark Rutland notes. Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com Signed-off-by: Kyungmin

Re: [PATCH] ARM: dts: Update arch timer node with clock frequency

2013-09-23 Thread Mark Rutland
On Sat, Sep 21, 2013 at 04:24:59PM +0100, Tomasz Figa wrote: Hi Yuvaraj, On Wednesday 18 of September 2013 15:41:53 Yuvaraj Kumar C D wrote: Without the clock-frequency property in arch timer node, could able to see the below crash dump. [snip] diff --git

Re: [PATCH v8] s5k5baf: add camera sensor driver

2013-09-20 Thread Mark Rutland
On Fri, Sep 06, 2013 at 11:31:06AM +0100, Andrzej Hajda wrote: Driver for Samsung S5K5BAF UXGA 1/5 2M CMOS Image Sensor with embedded SoC ISP. The driver exposes the sensor as two V4L2 subdevices: - S5K5BAF-CIS - pure CMOS Image Sensor, fixed 1600x1200 format, no controls. - S5K5BAF-ISP -

Re: [PATCH] ARM: dts: Update arch timer node with clock frequency

2013-09-18 Thread Mark Rutland
[adding lakml] On Wed, Sep 18, 2013 at 11:11:53AM +0100, Yuvaraj Kumar C D wrote: Without the clock-frequency property in arch timer node, could able to see the below crash dump. Why does this cause the below crash specifically? What is CNTFRQ reading as? Your firmware or bootloader should

Re: [PATCH] ARM: dts: Disable Exynos5250 I2S controllers by default

2013-09-10 Thread Mark Rutland
devices. Acked-by: Mark Rutland mark.rutl...@arm.com It seems far more sensible to me to mark devices disabled by default in shared dtsi files and then okay them as needed in particular dts files. I'd be happy with more of this. arch/arm/boot/dts/exynos5250-arndale.dts | 4 arch/arm/boot

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-09-02 Thread Mark Rutland
On Mon, Sep 02, 2013 at 05:21:58PM +0100, Sylwester Nawrocki wrote: Hi Mark, Hi Sylwester, On 08/27/2013 11:14 AM, Mark Rutland wrote: +endpoint node +- + +- data-lanes : (optional) specifies MIPI CSI-2 data lanes as covered in + video-interfaces.txt. This property can

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-27 Thread Mark Rutland
Hi, [trimming down to relevant context] +endpoint node +- + +- data-lanes : (optional) specifies MIPI CSI-2 data lanes as covered in + video-interfaces.txt. This property can be only used to specify number + of data lanes, i.e. the array's content is unused, only its length

Re: [PATCH V4] ARM: dts: Add dwmmc DT nodes for exynos5420 SOC

2013-08-27 Thread Mark Rutland
On Tue, Aug 27, 2013 at 10:22:31AM +0100, Yuvaraj Kumar C D wrote: This patch adds the device tree node entries for exynos5420 SOC. Exynos5420 has a different version of DWMMC controller,so a new compatible string is used to distinguish it from the prior SOC's. This patch depends on

Re: [PATCH V4] ARM: dts: Add dwmmc DT nodes for exynos5420 SOC

2013-08-27 Thread Mark Rutland
On Tue, Aug 27, 2013 at 01:02:52PM +0100, Yuvaraj Kumar wrote: On Tue, Aug 27, 2013 at 4:31 PM, Mark Rutland mark.rutl...@arm.com wrote: On Tue, Aug 27, 2013 at 10:22:31AM +0100, Yuvaraj Kumar C D wrote: This patch adds the device tree node entries for exynos5420 SOC. Exynos5420 has

Re: [PATCH RFC v5] s5k5baf: add camera sensor driver

2013-08-19 Thread Mark Rutland
On Mon, Aug 19, 2013 at 02:18:27PM +0100, Andrzej Hajda wrote: Driver for Samsung S5K5BAF UXGA 1/5 2M CMOS Image Sensor with embedded SoC ISP. The driver exposes the sensor as two V4L2 subdevices: - S5K5BAF-CIS - pure CMOS Image Sensor, fixed 1600x1200 format, no controls. - S5K5BAF-ISP -

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-08 Thread Mark Rutland
On Wed, Aug 07, 2013 at 06:06:05PM +0100, Julius Werner wrote: This breaks compatibility, both for an old kernel and a new dt and a new kernel with an old dt. Is anyone using these bindings? They only affect Samsung SoCs and have only been upstream for half a year, so I doubt it's heavily

Re: [PATCH] ARM: EXYNOS: add power domains support for EXYNOS5440

2013-08-08 Thread Mark Rutland
On Tue, Aug 06, 2013 at 05:16:56PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday, August 03, 2013 09:14:11 PM Mark Rutland wrote: On Fri, Aug 02, 2013 at 10:01:52PM +0100, Stephen Warren wrote: (CCing the other DT maintainers, hence quoting binding in full) On 08/02

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-07 Thread Mark Rutland
On Tue, Aug 06, 2013 at 07:00:17PM +0100, Julius Werner wrote: This patch simplifies the way the phy-samsung-usb code finds the correct power management register to enable PHY clock gating. Previously, the code would calculate the register address from a device tree supplied base address and

Re: [PATCH 2/3] Initial skeleton of VFIO support for Device Tree based devices

2013-08-05 Thread Mark Rutland
[adding DT maintainers to Cc] On Mon, Aug 05, 2013 at 02:17:11PM +0100, Antonios Motakis wrote: Platform devices in the Linux kernel are usually managed by the DT interface. This patch forms the base to support these kind of devices with VFIO. Signed-off-by: Antonios Motakis

Re: [PATCH] ARM: EXYNOS: add power domains support for EXYNOS5440

2013-08-03 Thread Mark Rutland
On Fri, Aug 02, 2013 at 10:01:52PM +0100, Stephen Warren wrote: (CCing the other DT maintainers, hence quoting binding in full) On 08/02/2013 07:23 AM, Bartlomiej Zolnierkiewicz wrote: On EXYNOS5440 power domains are handled in a different way than on the previous EXYNOS SoCs. Add support

  1   2   >