Re: [PATCH v4 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-12 Thread Ohad Ben-Cohen
Hi KyongHo, On Wed, Oct 12, 2011 at 10:07 AM, KyongHo Cho wrote: > +static int exynos_iommu_unmap(struct iommu_domain *domain, unsigned long > iova, > +                          int gfp_order) > +{ ... > +       return 0; > +} ->unmap() should return the size of the unmapped region (in page orde

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-27 Thread Ohad Ben-Cohen
On Tue, Sep 27, 2011 at 12:01 PM, KyongHo Cho wrote: > It looks good for me. > > I will prepare new patches with the changed API. Ok, thanks. (I've just submitted it to the iommu ML too) Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a messa

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-27 Thread Ohad Ben-Cohen
d, can do everything directly in exynos_sysmmu_irq() where all the required information is now available. Thanks, Ohad. >From 0f2287abe5761e40d25f0da0c8e7964d18ebb3ef Mon Sep 17 00:00:00 2001 From: Ohad Ben-Cohen Date: Tue, 27 Sep 2011 11:14:22 +0300 Subject: [PATCH] iommu/core: let drivers k

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-26 Thread Ohad Ben-Cohen
On Mon, Sep 26, 2011 at 5:48 PM, KyongHo Cho wrote: > I am sorry but I still think that > installing default fault handler is quite simple and straightforward. ... and abusing the IOMMU API. Please don't do that. Interfaces are written for specific goals, and this one was added for IOMMU users,

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-26 Thread Ohad Ben-Cohen
Hi, On Mon, Sep 26, 2011 at 12:21 PM, KyongHo Cho wrote: > Every fault in IOMMU (System MMU) is an error logically > and must not happen in our multimedia device drivers > because, our device drivers always construct page table completely > before address translation in System MMU > and TLB loads

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-26 Thread Ohad Ben-Cohen
On Mon, Sep 26, 2011 at 11:58 AM, KyongHo Cho wrote: > As you've noticed, it is default behavior for iommu fault. Then why not add it to the IOMMU core ? it's quite generic and can be useful for others, too. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-26 Thread Ohad Ben-Cohen
2011/9/24 조경호 : > This is the System MMU driver and IOMMU API implementation for > Exynos4 SOC platforms. Exynos4 platforms has more than 10 System > MMUs dedicated for each multimedia accellerators. > > Signed-off-by: KyongHo Cho ... > +static int exynos_iommu_fault_handler(struct iommu_domain *d

Re: [Linaro-mm-sig] [PATCH 2/2] ARM: Samsung: update/rewrite Samsung SYSMMU (IOMMU) driver

2011-09-06 Thread Ohad Ben-Cohen
On Tue, Sep 6, 2011 at 1:27 PM, KyongHo Cho wrote: > On Fri, Sep 2, 2011 at 10:56 PM, Marek Szyprowski >> +static int s5p_sysmmu_map(struct iommu_domain *domain, unsigned long iova, >> +                         phys_addr_t paddr, int gfp_order, int prot) >> +{ >> +       struct s5p_sysmmu_domain *