Re: drm/exynos: g2d userptr memory corruption

2015-08-19 Thread Rob Clark
On Wed, Aug 19, 2015 at 10:08 AM, Jerome Glisse wrote: > On Wed, Aug 19, 2015 at 03:53:44PM +0200, Tobias Jakobi wrote: >> Adding Jérôme to Cc. I think he looked the userptr code before, so maybe >> he has some idea what is going wrong here. >> >> I also had a look at the code, but my knowledge ab

Re: [PATCH 00/21] On-demand device registration

2015-06-03 Thread Rob Clark
On Mon, May 25, 2015 at 10:53 AM, Tomeu Vizoso wrote: > Hello, > > I have a problem with the panel on my Tegra Chromebook taking longer than > expected to be ready during boot (Stéphane Marchesin reported what is > basically the same issue in [0]), and have looked into ordered probing as a > bette

Re: [PATCH 2/5] exynos: add EXYNOS_G2D_EVENT to drmHandleEvent

2015-03-29 Thread Rob Clark
so, iirc, vmwgfx also has some custom events.. not really sure if they have their own hand-rolled drmHandleEvent() or if they have another way of catching those. Maybe we need some more flexible way to register handlers for driver custom events? But everyone adding their own thing to drmHandleEv

Re: [PATCH 04/14] drm/exynos: remove struct *_win_data abstraction on planes

2015-02-05 Thread Rob Clark
On Thu, Feb 5, 2015 at 4:15 AM, Daniel Vetter wrote: > On Thu, Feb 05, 2015 at 11:37:13AM +0900, Joonyoung Shim wrote: >> Hi Daniel, >> >> On 02/04/2015 11:28 PM, Daniel Vetter wrote: >> > On Wed, Feb 04, 2015 at 04:44:12PM +0900, Joonyoung Shim wrote: >> >> Hi, >> >> >> >> On 02/04/2015 04:14 AM,

Re: [PATCH 03/14] drm/bridge: make bridge registration independent of drm flow

2015-01-30 Thread Rob Clark
On Tue, Jan 20, 2015 at 11:38 AM, Ajay Kumar wrote: > Currently, third party bridge drivers(ptn3460) are dependent > on the corresponding encoder driver init, since bridge driver > needs a drm_device pointer to finish drm initializations. > The encoder driver passes the drm_device pointer to the >

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-12 Thread Rob Clark
On Mon, May 12, 2014 at 3:06 AM, Andrzej Hajda wrote: > On 05/09/2014 05:05 PM, Ajay kumar wrote: >> On Fri, May 9, 2014 at 7:29 PM, Rob Clark wrote: >>> On Fri, May 9, 2014 at 5:08 AM, Andrzej Hajda wrote: >>>> On 05/08/2014 08:24 PM, Rob Clark wrote: >&g

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-09 Thread Rob Clark
On Fri, May 9, 2014 at 5:08 AM, Andrzej Hajda wrote: > On 05/08/2014 08:24 PM, Rob Clark wrote: >> On Thu, May 8, 2014 at 2:41 AM, Andrzej Hajda wrote: >>> On 05/05/2014 09:52 PM, Ajay Kumar wrote: >>>> This patchset is based on exynos-drm-next-todo branch of Inki

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-08 Thread Rob Clark
On Thu, May 8, 2014 at 7:57 AM, Inki Dae wrote: > On 2014년 05월 08일 19:52, Ajay kumar wrote: >> +Dave >> +Thierry >> >> On Thu, May 8, 2014 at 1:14 PM, Inki Dae wrote: >>> >>> Just re-sending with text mode. Sorry for this. >>> >>> >>> On 2014년 05월 08일 15:41, Andrzej Hajda wrote: On 05/05/201

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-08 Thread Rob Clark
On Thu, May 8, 2014 at 2:41 AM, Andrzej Hajda wrote: > On 05/05/2014 09:52 PM, Ajay Kumar wrote: >> This patchset is based on exynos-drm-next-todo branch of Inki Dae's tree at: >> git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git >> >> I have just put up Rob's and Sean's idea of

Re: [RFC V2 1/3] drm: implement chaining of drm bridges

2014-05-06 Thread Rob Clark
On Tue, May 6, 2014 at 11:55 AM, Sean Paul wrote: > On Mon, May 5, 2014 at 12:52 PM, Ajay Kumar wrote: >> As of now, we can have only one bridge hanging off the encoder. >> With this patch, we allow multiple bridges to hang onto the same encoder >> with the use of a simple next_bridge ptr. >> >>

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-29 Thread Rob Clark
On Mon, Apr 28, 2014 at 9:08 AM, Ajay kumar wrote: > Daniel, > > On Sun, Apr 27, 2014 at 6:25 PM, Daniel Vetter wrote: >> On Fri, Apr 25, 2014 at 8:17 AM, Ajay kumar wrote: >>> We can call panel_enable/disable at the right point. Even the bridge chips >>> expect the same. So, I am not ok with co

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Rob Clark
On Thu, Apr 24, 2014 at 12:55 PM, Ajay kumar wrote: > Rob, > > On Thu, Apr 24, 2014 at 9:41 PM, Rob Clark wrote: >> On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar wrote: >>> Sorry for the previous reply, >>> >>> Here goes the full explaination: >>&g

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Rob Clark
On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar wrote: > Sorry for the previous reply, > > Here goes the full explaination: > >> Rob, >> >> On Tue, Apr 22, 2014 at 5:04 PM, Rob Clark wrote: >>> So what about, rather than adding drm_panel support to each

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-22 Thread Rob Clark
So what about, rather than adding drm_panel support to each bridge individually, we introduce a drm_panel_bridge (with a form of chaining).. ie: struct drm_panel_bridge { struct drm_bridge base; struct drm_panel *panel; struct drm_bridge *bridge; /* optional */ }; static void dr

Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

2013-12-21 Thread Rob Clark
mabuf); > - if (IS_ERR_OR_NULL(ptr)) > + if (WARN_ON_ONCE(IS_ERR(ptr))) since vmap is optional, the WARN_ON might be a bit strong.. although it would be a bit strange for an exporter to supply a vmap fxn which always returned NULL, not sure about that. Just thought I'd mention

Re: [PATCH V2] drm/exynos: Add fallback option to get non physically continous memory for fb

2013-08-05 Thread Rob Clark
G memory allocation > fails. Reviewed-by: Rob Clark > > Signed-off-by: Vikas Sajjan > Signed-off-by: Arun Kumar > --- > changes since v1: > - Modified to add the fallback patch if CONTIG alloc fails as > suggested > by Rob Clark robdcl...@gmail.com

Re: [PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

2013-08-01 Thread Rob Clark
On Thu, Aug 1, 2013 at 7:20 PM, Tomasz Figa wrote: > Hi Vikas, > > On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote: >> While trying to get boot-logo up on exynos5420 SMDK which has eDP panel >> connected with resolution 2560x1600, following error occured even with >> IOMMU enabled: >> [0

Re: exynos-drm-next todo work.

2013-07-07 Thread Rob Clark
On Fri, Jul 5, 2013 at 2:12 PM, Mark Brown wrote: > On Wed, Jun 19, 2013 at 01:48:15PM +0900, Inki Dae wrote: > >> > Related to HDMI sound support in Alsa, I have posted a working RFC >> > "exynos-hdmi to CDF complaint display driver". It registers a separate >> > sound card by registering hdmi au