[PATCH] spi: s3c64xx: Remove unused platform_device_id entries

2015-12-29 Thread Sylwester Nawrocki
s5pv210 and exynos4 are now DT only platforms hence these entries can now be safely removed from the match table. Signed-off-by: Sylwester Nawrocki --- drivers/spi/spi-s3c64xx.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c

Re: [PATCH 1/2] clk: samsung: exynos5422: add missing parent GSCL block clocks

2015-12-22 Thread Sylwester Nawrocki
Mike, On 22/12/15 19:44, Mike Turquette wrote: > This is superseded by the pull request found in Message-ID: > <5671a456.9030...@samsung.com>, correct? The two pull requests are based on same branch, first 2 commits are tagged with for-4.5-clk-exynos5420 tag and the whole branch is tagged as clk-

Re: [GIT PULL] clk/samsung updates for v4.5

2015-12-22 Thread Sylwester Nawrocki
Hello Mike, On 22/12/15 19:38, Mike Turquette wrote: > Pulled. > > Was it necessary to base on -rc5? That required me to update my tree > from -rc1. > > This is not difficult, but it is a bit annoying when it is not strictly > necessary just to take one PR. Sorry about that, originally I've put

Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

2015-12-16 Thread Sylwester Nawrocki
On 30/11/15 11:08, Mutharaju, Prasanna (P.) wrote: > From: Prasanna Karthik > > Remove unneeded variable used to store return value. > > Signed-off-by: Prasanna Karthik Patch applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a messa

[GIT PULL] clk/samsung updates for v4.5

2015-12-16 Thread Sylwester Nawrocki
The following changes since commit 9f9499ae8e6415cefc4fe0a96ad0e27864353c89: Linux 4.4-rc5 (2015-12-13 17:42:58 -0800) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git tags/clk-samsung-4.5 for you to fetch changes up to c5e949c1c24d67ae2813afdf02408a9b0c6fe55

Re: [PATCH 1/2] clk: samsung: exynos5422: add missing parent GSCL block clocks

2015-12-16 Thread Sylwester Nawrocki
Krzysztof, On 09/12/15 14:36, Krzysztof Kozlowski wrote: > W dniu 09.12.2015 o 19:14, Sylwester Nawrocki pisze: >> > Adding Stephen and linux-clk at Cc. >> > >> > On 09/12/15 05:49, Krzysztof Kozlowski wrote: >>> >> On 08.12.2015 22:46, Marek Szypro

Re: [PATCH] clk: exynos: use irqsave version of spin_lock to avoid deadlock with irqs

2015-12-14 Thread Sylwester Nawrocki
e spin_lock is used by gate/mux clocks during enable/disable calls. > > This deadlock, can be reproduced by enabling CPUfreq (ondemand or > userspace) and decoding video with s5p-mfc driver. > Signed-off-by: Marek Szyprowski > CC: sta...@vger.kernel.org # v4.2+ Acked-by: Sylweste

Re: [PATCH 1/2] clk: samsung: exynos5422: add missing parent GSCL block clocks

2015-12-09 Thread Sylwester Nawrocki
olks, this can go through samsung-soc? I guess it makes more sense that making a stable branch with just this patch to be pulled into arm-soc and clk tree. I'm fine with applying this patch through arm-soc, but I think we also need Mike's or Stephen ack for this. Acked-by: Sylwester Nawrocki

Re: [PATCH v3 06/10] clk: samsung: exynos5800: fix cpu clock configuration data

2015-12-07 Thread Sylwester Nawrocki
Figa > Cc: Mike Turquette > Cc: Javier Martinez Canillas > Cc: Thomas Abraham > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sylwester Nawrocki -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the bod

Re: [PATCH v3 03/10] clk: samsung: exynos5420: add cpu clock configuration data and instantiate cpu clock

2015-12-07 Thread Sylwester Nawrocki
-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sylwester Nawrocki -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

2015-11-19 Thread Sylwester Nawrocki
On 19/11/15 10:16, Tomasz Figa wrote: > 2015-11-19 13:51 GMT+09:00 Krzysztof Kozlowski : >> > On 19.11.2015 13:18, Tomasz Figa wrote: >>> >> However, I don't think we can disable compilation of particular >>> >> 64-bit SoCs, so maybe there isn't much sense in splitting their >>> >> clock drivers i

Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

2015-11-17 Thread Sylwester Nawrocki
under >> EXYNOS7_COMMON_CLK? As for all ARM64 SoC there is single defconfig and >> binary. > > Yes, it can be one config symbol for all clocks of ARMv8 Exynos SoCs. > From my point of view both has some advantages and disadvantages (kernel > size, granularity, number of Kconfig symbols etc.) and I don't mind > choosing different than I selected before. > > Any opinion from Samsung clock maintainers? Which do you prefer? It would have been a bit unfortunate to not be able to exclude the unneeded clk drivers from build. From my side both patches look like a step in right direction. For the $subject patch: Acked-by: Sylwester Nawrocki -- Thanks Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/10] dt-bindings: video: add PCLK clock entry to exynos5433-decon

2015-10-20 Thread Sylwester Nawrocki
On 20/10/15 14:24, Krzysztof Kozlowski wrote: > W dniu 20.10.2015 o 18:22, Andrzej Hajda pisze: >> > DECON IP requires this clock to access configuration registers. >> > >> > Signed-off-by: Andrzej Hajda >> > --- >> > Documentation/devicetree/bindings/video/exynos5433-decon.txt | 2 +- >> > 1 fi

Re: [PATCH 01/10] clk/samsung: exynos5433: add definitions of HDMI-PHY output clocks

2015-10-20 Thread Sylwester Nawrocki
On 20/10/15 12:34, Michael Turquette wrote: >> diff --git a/include/dt-bindings/clock/exynos5433.h >> b/include/dt-bindings/clock/exynos5433.h >> > index 5bd80d5..4f0d566 100644 >> > --- a/include/dt-bindings/clock/exynos5433.h >> > +++ b/include/dt-bindings/clock/exynos5433.h >> > @@ -765,7 +765,

Re: [PATCH] arm: dts: Fix audio card detection on peach boards

2015-10-12 Thread Sylwester Nawrocki
On 12/10/15 08:47, Krzysztof Kozlowski wrote: >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> > index 8f4d76c..525a93a 100644 >> > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >>

Re: [GIT PULL] clk/samsung updates for v4.4

2015-10-06 Thread Sylwester Nawrocki
On 02/10/15 20:37, Stephen Boyd wrote: > On 10/02, Sylwester Nawrocki wrote: ... > Thanks, pulled. I put this patch on top though. Thanks for taking care of this, I'll make sure such issues are fixed before sending any future pull requests. -- Regards, Sylwester -- To unsubscribe fro

Re: [PATCH 5/7] [media] mipi-csis: make sparse happy

2015-10-05 Thread Sylwester Nawrocki
On 05/10/15 13:07, Arnd Bergmann wrote: > On Monday 05 October 2015 12:24:40 Sylwester Nawrocki wrote: >> > On 03/10/15 00:25, Arnd Bergmann wrote: >>> > > On Thursday 01 October 2015 19:17:27 Mauro Carvalho Chehab wrote: >>>>> > >> > diff

Re: [PATCH 5/7] [media] mipi-csis: make sparse happy

2015-10-05 Thread Sylwester Nawrocki
On 03/10/15 00:25, Arnd Bergmann wrote: > On Thursday 01 October 2015 19:17:27 Mauro Carvalho Chehab wrote: >> > diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c >> > b/drivers/media/platform/exynos4-is/mipi-csis.c >> > index d74e1bec3d86..4b85105dc159 100644 >> > --- a/drivers/media/pla

[GIT PULL] clk/samsung updates for v4.4

2015-10-02 Thread Sylwester Nawrocki
The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git tags/clk-samsung-4.4 for you to fetch changes up to 7993b3ebec979b23c2d7425959c9d232c452498

Re: Chromebook snow issues

2015-09-29 Thread Sylwester Nawrocki
On 29/09/15 16:42, Mauro Carvalho Chehab wrote: > Em Tue, 29 Sep 2015 16:32:58 +0200 > Sylwester Nawrocki escreveu: > >> > Adding linux-samsung-soc mailing list at Cc. > > Never mind. My mistake: I forgot to reinstall the modules (mwifiex and mfc > drivers were co

Re: Chromebook snow issues

2015-09-29 Thread Sylwester Nawrocki
Adding linux-samsung-soc mailing list at Cc. On 29/09/15 16:01, Mauro Carvalho Chehab wrote: > Em Tue, 29 Sep 2015 15:37:51 +0200 > Sylwester Nawrocki escreveu: > >> Hi Mauro, >> >> On 29/09/15 14:43, Mauro Carvalho Chehab wrote: >>> Hi Sylwester, >>&g

Re: [PATCH 4/4] ARM64: dts: exynos5433: add jpeg node

2015-09-21 Thread Sylwester Nawrocki
Hi Mauro, On 21/09/15 13:41, Mauro Carvalho Chehab wrote: > Btw, I just got a Samsung TM1 device, with seems to be using an arm64 > SoC. Is this driver providing support for its camera? The TM1 device (Z3) is based on a Qualcomm 64-bit SoC. The $subject patch adds support for a standalone JPEG co

Re: [PATCH 5/7] [media] use v4l2_get_timestamp where possible

2015-09-16 Thread Sylwester Nawrocki
gt; > Signed-off-by: Arnd Bergmann > --- For: drivers/media/platform/exynos4-is/fimc-lite.c drivers/media/platform/s3c-camif/camif-capture.c Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a mes

Re: [PATCH 4/7] [media] exynos4-is: use monotonic timestamps as advertized

2015-09-16 Thread Sylwester Nawrocki
for timestamps across suspend or settimeofday(). > > This changes the driver to use the normal v4l2_get_timestamp() > function like all other drivers. > > Signed-off-by: Arnd Bergmann Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 0/4] Improvements on exynos7 clock

2015-09-15 Thread Sylwester Nawrocki
On 26/08/15 05:30, Alim Akhtar wrote: > This patch series are minor improvement over the current > exynos7 clock file. This fix some bugs and update the clock > bits as per user manual. That one applied as well, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc

Re: [PATCH v2 00/12] clk: samsung: exynos7: Cleanup of clock file

2015-09-15 Thread Sylwester Nawrocki
On 10/09/15 10:44, Alim Akhtar wrote: > Currently there are lots of ambiguity between clock names in clock file > and in user manual, which leads to lots of confusion for the reviewers. > This series attempts to cleanup the exynos7 clock file as per > user manual naming convention. > This also adds

Re: [PATCH] clk: samsung: fix cpu clock's flags checking

2015-08-28 Thread Sylwester Nawrocki
Michael Turquette > Cc: Javier Martinez Canillas > Cc: Thomas Abraham > Reported-by: Dan Carpenter > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

2015-07-25 Thread Sylwester Nawrocki
On 07/22/2015 08:41 AM, Krzysztof Kozlowski wrote: On 22.07.2015 07:42, Stephen Boyd wrote: >On 06/12, Krzysztof Kozlowski wrote: [...] >>Signed-off-by: Krzysztof Kozlowski >>Cc: >>Fixes: c63c57433003 ("ARM: dts: Add ADC's dt data to read raw data for exynos4x12") >>Link:https://lkml.org/lkml

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

2015-07-25 Thread Sylwester Nawrocki
, 0, 0), > GATE(CLK_MIPI_HSI, "mipi_hsi", "aclk133", GATE_IP_FSYS, 10, 0, 0), > GATE(CLK_CHIPID, "chipid", "aclk100", E4X12_GATE_IP_PERIR, 0, 0, 0), > GATE(CLK_SYSREG, "sysreg", "aclk100", E4X12_GATE_IP_PERIR, 1, > -- Sylwester Nawrocki Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/4] clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock

2015-07-15 Thread Sylwester nawrocki
Bartlomiej: - split Exynos5250 support from the original patch - moved E5250_CPU_DIV[0,1]() macros to clk-exynos5250.c Cc: Tomasz Figa Cc: Michael Turquette Cc: Javier Martinez Canillas Signed-off-by: Thomas Abraham Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sylwester Nawrocki -- To

Re: [PATCH v2 4/7] clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock

2015-07-15 Thread Sylwester nawrocki
whole series applied through one, e.g samsung-soc tree? If so, here is my ack. Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

2015-07-09 Thread Sylwester Nawrocki
On 09/07/15 02:23, Krzysztof Kozlowski wrote: > drivers/clk/samsung/clk-exynos4.c | 2 ++ > 1 file changed, 2 insertions(+) > >>> >>> Patch looks good to me. >>> >>> Reviewed-by: Javier Martinez Canillas >>> >> >>> >> Hi Tomasz and Sylwester, >>> >> >>> >

Re: [GIT PULL] clk/samsung updates for 4.2

2015-06-11 Thread Sylwester Nawrocki
On 04/06/15 01:05, Michael Turquette wrote: > One small thing: clk-next isn't considered stable. I had some stuff in > there (Stephen's amba assigned-clock-rates patch) which I had to pull > out (no ACK from maintainer) and it crept back in because this PR was > based on top of it. No big deal bec

[GIT PULL] clk/samsung updates for 4.2

2015-06-03 Thread Sylwester Nawrocki
The following changes since commit 20db7092e478c33a2bf5254063c51f5db6443959: Merge branch 'clk-next-hi6220' into clk-next (2015-05-27 22:06:42 -0700) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git tags/clk-samsung-for-4.2 for you to fetch changes up to e5c

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-05-29 Thread Sylwester Nawrocki
cyclic >> dependency, so it is left as "select". >> >> Signed-off-by: Arun Ramamurthy > > Need your ACK for this patch. For drivers/media/platform/exynos4-is/Kconfig drivers/video/fbdev/exynos/Kconfig Acked-by: Sylwester Nawrocki -- Thanks, Syl

Re: [PATCH] clk: make several parent names const

2015-05-28 Thread Sylwester Nawrocki
On 28/05/15 10:45, Uwe Kleine-König wrote: > Since commit 2893c379461a ("clk: make strings in parent name arrays > const") the name of parent clocks can be const. So add more const in > several clock drivers. > > Signed-off-by: Uwe Kleine-König Thanks for the patch, Ack

Re: ARCH_EXYNOS5433 missing in Kconfig

2015-04-28 Thread Sylwester Nawrocki
Hello, On 28/04/15 11:25, Chanwoo Choi wrote: > Hi Valentin, > > On Mon, Apr 27, 2015 at 3:31 PM, Valentin Rothberg > wrote: >> > Hi Chanwoo, >> > >> > this is a kind reminder that the issue mentioned below is still >> > present and made its way to v4.1-rc1. > > I sent the patch[1] to fix it. An

Re: [PATCH v3 10/10] clk: samsung: exynos5433: Add CLK_IGNORE_UNUSED flag to prevent the hang for suspend-to-ram

2015-04-28 Thread Sylwester Nawrocki
Hi Chanwoo, On 27/04/15 13:36, Chanwoo Choi wrote: > From: Jonghwa Lee > > Some clocks are required being unmasked for suspend-to-ram. Otherwise, > PMU (Power Management Unit) will stick and power line never down. > > Signed-off-by: Jonghwa Lee > Signed-off-by: Chanwoo Choi > --- > @@ -1718,

Re: [PATCH] i2c: s3c2410: Don't enable PM runtime on the adapter device

2015-04-16 Thread Sylwester Nawrocki
On 16/04/15 12:10, Charles Keepax wrote: > Commit 523c5b89640e ("i2c: Remove support for legacy PM") removed the PM > ops from the bus type, which causes the pm operations on the s3c2410 > adapter device to fail (-ENOSUPP in rpm_callback). The adapter device > doesn't get bound to a driver and as s

Re: [PATCH 1/1] clk: exynos5420: Restore GATE_BUS_TOP on suspend

2015-04-08 Thread Sylwester Nawrocki
fff, }, > { .offset = GATE_IP_PERIC, .value = 0x, }, > }; I'm going to tag this patch for inclusion in the stable tree and send it to Mike or Stephen with other clk/samsung fixes after v4.1-rc1 is released. Mike/Stephen, if you're willing to

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-04-01 Thread Sylwester Nawrocki
Hello Javier, On 01/04/15 13:44, Javier Martinez Canillas wrote: > On 04/01/2015 01:03 PM, Sylwester Nawrocki wrote: >> On 31/03/15 22:00, Javier Martinez Canillas wrote: >>> On 03/31/2015 04:38 PM, Abhilash Kesavan wrote: >>>> javier.marti...@collabora.co.uk>

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-04-01 Thread Sylwester Nawrocki
Hello, On 31/03/15 22:00, Javier Martinez Canillas wrote: > On 03/31/2015 04:38 PM, Abhilash Kesavan wrote: >> javier.marti...@collabora.co.uk> wrote: >>> Unfortunately I don't fully understand why this clock needs to be >>> enabled. It would be good if someone at Samsung can explain in >>> more

Re: [RFC PATCH 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend

2015-03-27 Thread Sylwester Nawrocki
Hello Javier, On 27/03/15 15:21, Javier Martinez Canillas wrote: > Commit ae43b3289186 ("ARM: 8202/1: dmaengine: pl330: Add runtime Power > Management support v12") added pm support for the pl330 dma driver but > it makes the clock for the Exynos5420 MDMA0 DMA controller to be gated > during suspe

[GIT PULL] clk: exynos3250 updates for 4.1

2015-03-25 Thread Sylwester Nawrocki
Hello Mike, Please pull the following changes, it seems all we have for next release for clk/samsung. The following changes since commit 5bc43f9b615f02c57b1ca782128ef5daf055: Merge branch 'clk-fixes' into clk-next (2015-03-09 14:23:45 -0700) are available in the git repository at: git

Re: [alsa-devel] [PATCH RESEND] ARM: dts: Support audio on Exynos5422-odroidxu3 using simple-audio-card

2015-03-23 Thread Sylwester Nawrocki
ible = "simple-audio-card"; > + assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>, > + <&clock_audss EXYNOS_MOUT_I2S>, > + <&clock_audss EXYNOS_DOUT_AUD_BUS>; > + assi

Re: [PATCH 1/1] serial: samsung: Clear operation mode on UART shutdown

2015-03-20 Thread Sylwester Nawrocki
free_irq(ourport->tx_irq, ourport); > tx_enabled(port) = 0; > ourport->tx_claimed = 0; > + ourport->tx_mode = 0; > } The patch looks good to me, Robert could you comment on that? Reviewed-by: Sylwester Nawrocki -- Thanks, Sylwes

[PATCH] ASoC: samsung: Enable SND_SIMPLE_CARD for Odroid X2/U3

2015-03-18 Thread Sylwester Nawrocki
Odroid X2/U3 sound support can now be specified in device tree using the simple card binding, make SND_SOC_ODROIDX2 select SND_SIMPLE_CARD to ensure there are always required drivers in place. Reported-by: Tobias Jakobi Signed-off-by: Sylwester Nawrocki --- sound/soc/samsung/Kconfig |1

Re: [PATCH v2] clk: samsung: Add CLKOUT driver support for Exynos3250 SoC.

2015-03-17 Thread Sylwester Nawrocki
On 12/03/15 00:34, Stephen Boyd wrote: > On 03/01/15 18:15, Inha Song wrote: >> > This patch add CLKOUT driver support for Exynos3250 SoC. >> > >> > Exynos3250 SoC PMU_DEBUG is the same with Exynos4's PMU_DEBUG >> > including CLKOUT mux. So, We can use the exynos4's clkout init >> > function for Ex

Re: [PATCH 2/2] ARM: dts: exynos3250: Add assigned clock parents to CMU node

2015-03-17 Thread Sylwester Nawrocki
gt; but it also reduces the risk of accessing the ISP CMU > registers while the ISP power domain remains turned off > (i.e. through the common clock framework by clk_summary) > > Signed-off-by: Beata Michalska > Acked-by: Kyungmin Park Acked-by: Sylwester Nawrocki Kukjin, pleas

Re: [PATCH 1/2] clk: samsung: exynos3250: Add driver for CMU_ISP clock domain

2015-03-17 Thread Sylwester Nawrocki
On 02/03/15 14:17, Beata Michalska wrote: > From: Tomasz Figa > > Add clock controller for CMU ISP clock domain on Exynos3250, > providing clocks for FIMC-IS subsystem. > > [b.michalska:use samsung_cmu_register_one to register > the provider; updated DT binding documentation] Thanks for moving

Re: [RFC PATCH 2/3] arm/exynos/pm_domains: add support for async-bridge clocks

2015-03-12 Thread Sylwester Nawrocki
> > Signed-off-by: Andrzej Hajda Reviewed-by: Sylwester Nawrocki > --- > arch/arm/mach-exynos/pm_domains.c | 27 +++ > 1 file changed, 23 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-exynos/pm_domains.c > b/arch/arm/mach

Re: [RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain

2015-03-12 Thread Sylwester Nawrocki
nd we'll need to address those dependencies somehow. Anyway, the subject patch looks OK to me, given that support for clocks/ clock-names in the exynos power domain device nodes has been merged for quite long already. The entire feature has been merged without PM or clk subsystem maintainer ACK, I

Re: [PATCH RFT] phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations

2015-03-04 Thread Sylwester Nawrocki
Hi, On 04/03/15 13:24, Kishon Vijay Abraham I wrote: > This patch doesn't apply on 4.0-rc1. Can to refresh it to mainline > latest? It depends on Axel's previous patch: "phy: exynos-mipi-video: Fixup the test for state->regmap". Are there any issues even with that patch applied ? -- Thanks Sylw

Re: [PATCH] phy: exynos-dp-video: Kill exynos_dp_video_phy_pwr_isol function

2015-02-27 Thread Sylwester Nawrocki
() instead and return proper return value. > > Signed-off-by: Axel Lin Reviewed-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFT] phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations

2015-02-27 Thread Sylwester Nawrocki
1 seems devastated as far as exynos4 is concerned, it may take some time until I get around and fix all the issues so I tested your patch on v3.19. It all works well as expected. Acked-by: Sylwester Nawrocki Tested-by: Sylwester Nawrocki -- Thanks, Sylwester -- To unsubscribe from this list: sen

Re: [PATCH] phy: exynos-mipi-video: Fixup the test for state->regmap

2015-02-26 Thread Sylwester Nawrocki
On 26/02/15 04:48, Axel Lin wrote: > syscon_regmap_lookup_by_phandle() returns ERR_PTR on error. > Thus don't use null test against state->regmap. > > Signed-off-by: Axel Lin Thanks for the patch, I had this on my todo list. Acked-by: Sylwester Nawrocki -- To unsubscribe

Re: [PATCH] [media] s5p-jpeg: Fix crash in jpeg isr due to multiple interrupts.

2015-02-23 Thread Sylwester Nawrocki
On 17/12/14 07:25, Tony K Nadackal wrote: > In case of corrupt images, multiple interrupts may occur > due to different error scenarios. > > Since we are removing the src and dest buffers in the first > interrupt itself, crash occurs in the second error interrupts. > > Disable the global interrup

Re: [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function

2015-02-23 Thread Sylwester Nawrocki
Hi, On 17/12/14 07:22, Tony K Nadackal wrote: > Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared > on software reset. These bits need to be cleared explicitly. > > Signed-off-by: Tony K Nadackal > --- > This patch is created and tested on top of linux-next-20141210. > It can be clea

Re: [PATCH 1/6] ASoC: max98088: Document DT bindings

2015-02-20 Thread Sylwester Nawrocki
On 20/02/15 01:36, Andreas Färber wrote: >>> >> So it seems the mclk is not always set up properly by the kernel, >>> >> relying on firmware. Who's in charge of setting that clock up? >> > >> > Right, it seems audio is only working due the firmware doing some previous >> > setup. Probably it works

Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs

2015-02-10 Thread Sylwester Nawrocki
On 10/02/15 14:14, Krzysztof Kozlowski wrote: > On wto, 2015-02-10 at 14:00 +0100, Sylwester Nawrocki wrote: >> > On 10/02/15 13:46, Javier Martinez Canillas wrote: >>>>>> > >>>> This debugfs code iterates over list of generic_pm_domains >>>

Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs

2015-02-10 Thread Sylwester Nawrocki
On 10/02/15 13:46, Javier Martinez Canillas wrote: This debugfs code iterates over list of generic_pm_domains (gpd_list). I >> > cannot find function for translating from genpd to its platform device >> > so only genpd->name can be printed. >>> >> >>> >> Then why power domains a

Re: [PATCH 1/4] drm/exynos: dsim: fix to control mipi phy register

2015-02-09 Thread Sylwester Nawrocki
On 09/02/15 13:17, Inki Dae wrote: >> Instead I just added syscon support to the PHY layer, it's not perfect >> > but fixes the issue for both DSI and CSI and doesn't strip the PHY layer >> > which could potentially be useful. > > Ah, Right. I didn't check your patch set. Your way is a better idea

Re: [PATCH 1/4] drm/exynos: dsim: fix to control mipi phy register

2015-02-09 Thread Sylwester Nawrocki
On 07/02/15 12:53, Inki Dae wrote: > This patch fixes the issue that the try to get a phy object is failed > to enable mipi phy. > > System and power management unit registers should be controlled by > syscon framework. So this patch removes existing phy framework based > codes and adds syscon sup

Re: [RESEND PATCH V3 15/15] ARM: dts: Fix I2S1, I2S2 compatible for exynos4 SoCs

2015-02-06 Thread Sylwester Nawrocki
On 05/02/15 20:41, Mark Brown wrote: > On Tue, Feb 03, 2015 at 03:06:22PM +0100, Sylwester Nawrocki wrote: >> I2S1, I2S2 on Exynos4 SoC series have limited functionality compared >> to I2S0, "samsung,s3c6410-i2s" compatible should be used for them. > > I'

[GIT PULL] clk/samsung: clk support for Exynos 5433 SoC

2015-02-05 Thread Sylwester Nawrocki
Hi Mike, This pull request includes driver for clock controller of the Exynos 5433 SoC. As the hardware is quite complex, with many peripherals and corresponding clock management units the driver is rather huge. I guess it will require a bit more cleanups than last time to balance lines intr

Re: [v3,1/9] clk: samsung: exynos5433: Add clocks for CMU_APOLLO domain

2015-02-05 Thread Sylwester Nawrocki
On 05/02/15 08:44, Pankaj Dubey wrote: >> +static struct samsung_gate_clock apollo_gate_clks[] __initdata = { >> > + >> > + /* ENABLE_PCLK_APOLLO */ >> > + GATE(CLK_PCLK_ASAPBMST_CSSYS_APOLLO, "pclk_asapbmst_cssys_apollo", >> > + "div_pclk_dbg_apollo", ENABLE_PCLK_APOLLO, >> > +

Re: [PATCH v5 02/13] clk: samsung: exynos5433: Add clocks using common clock framework

2015-02-04 Thread Sylwester Nawrocki
Hi Chanwoo, On 02/02/15 15:23, Chanwoo Choi wrote: > +/* > + * ATLAS_PLL & APOLLO_PLL & MEM0_PLL & MEM1_PLL & BUS_PLL & MFC_PLL > + * & MPHY_PLL & G3D_PLL & DISP_PLL & ISP_PLL > + */ > +static struct samsung_pll_rate_table exynos5443_pll_rates[] = { > + PLL_35XX_RATE(25, 625, 6, 0), >

Re: [PATCH v5 10/13] clk: samsung: exynos5433: Add clocks for CMU_BUS{0|1|2} domains

2015-02-04 Thread Sylwester Nawrocki
Hi Chanwoo, On 02/02/15 15:24, Chanwoo Choi wrote: > This patch adds the mux/divider/gate clocks for CMU_BUS{0|1|2} domains > which contain global data buses clocked at up the 400MHz. These blocks > transfer data between DRAM and various sub-blocks. These clock domains > also contain global periph

[RESEND PATCH V3 14/15] ARM: dts: Switch Odroid X2/U2 to simple-audio-card

2015-02-03 Thread Sylwester Nawrocki
Now when the CDCLK I2S output clock can be handled through the clock API the Odroid X2/U3 can be switched to the simple-audio-card DT binding. Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos4.dtsi |3 +++ arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 19

[RESEND PATCH V3 15/15] ARM: dts: Fix I2S1, I2S2 compatible for exynos4 SoCs

2015-02-03 Thread Sylwester Nawrocki
I2S1, I2S2 on Exynos4 SoC series have limited functionality compared to I2S0, "samsung,s3c6410-i2s" compatible should be used for them. Cc: sta...@vger.kernel.org Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos4.dtsi |4 ++-- 1 file changed, 2 insertions(+), 2

[RESEND PATCH V3 13/15] ARM: dts: Exynos4 and Odroid X2/U3 sound device nodes update

2015-02-03 Thread Sylwester Nawrocki
-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos4.dtsi |6 ++ arch/arm/boot/dts/exynos4412-odroid-common.dtsi |8 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index

Re: [PATCH V3 13/15] ARM: dts: Exynos4 and Odroid X2/U3 sound device nodes update

2015-02-03 Thread Sylwester Nawrocki
On 03/02/15 14:11, Mark Brown wrote: > On Tue, Feb 03, 2015 at 12:04:16PM +0100, Sylwester Nawrocki wrote: > >>>> > >> Sorry, I should've said - I applied the ASoC patches, not these. >>> > > Shall I take 13 to 15 DT patches in Samsung tree? >

Re: [PATCH v5 08/13] clk: samsung: exynos5433: Add clocks for CMU_DISP domain

2015-02-03 Thread Sylwester Nawrocki
On 03/02/15 13:17, Sylwester Nawrocki wrote: >> diff --git a/drivers/clk/samsung/clk-exynos5433.c >> b/drivers/clk/samsung/clk-exynos5433.c >> > index 3d6164e..cf3f0ac 100644 >> > --- a/drivers/clk/samsung/clk-exynos5433.c >> > +++ b/drivers/clk/samsung

Re: [PATCH v5 08/13] clk: samsung: exynos5433: Add clocks for CMU_DISP domain

2015-02-03 Thread Sylwester Nawrocki
MIF's clocks > related to CMU_DISP should be always on state. Are you sure we need to add anything to CMU_MIF in this patch ? > Also, CMU_DISP must need the source clock of 'sclk_hdmi_spdif_disp' > from CMU_TOP domain. This patch adds the clocks of CMU_TOP related to HDMI. >

Re: [PATCH V3 13/15] ARM: dts: Exynos4 and Odroid X2/U3 sound device nodes update

2015-02-03 Thread Sylwester Nawrocki
On 03/02/15 05:27, Kukjin Kim wrote: > Mark Brown wrote: >> On Wed, Jan 14, 2015 at 07:42:40PM +0100, Sylwester Nawrocki wrote: >>> Clock related properties are added to the Exynos4 I2S device nodes >>> so they can be referred to as clock providers. Missing i2s_opclk

Re: [PATCH v4 01/13] clk: samsung: exynos5433: Add binding document for Exynos5433 clock domains

2015-02-02 Thread Sylwester Nawrocki
Hi Chanwoo, On 02/02/15 16:51, Chanwoo Choi wrote: > On Mon, Feb 2, 2015 at 11:40 PM, Sylwester Nawrocki > wrote: >> > On 02/02/15 15:08, Chanwoo Choi wrote: >> > >>> >> OK, I'll add more following information: >>> >> I'll send

Re: [PATCH v4 01/13] clk: samsung: exynos5433: Add binding document for Exynos5433 clock domains

2015-02-02 Thread Sylwester Nawrocki
On 02/02/15 15:08, Chanwoo Choi wrote: > OK, I'll add more following information: > I'll send only patch1 with following information. > > + - clocks: list of clock identifiers which are fed as the input to > + the given clock controller. Please refer the next section to > + find the i

Re: [PATCH v4 01/13] clk: samsung: exynos5433: Add binding document for Exynos5433 clock domains

2015-02-02 Thread Sylwester Nawrocki
Hi Chanwoo, On 02/02/15 14:01, Chanwoo Choi wrote: > This patch adds devicetree binding document for Exynos5433 SoC system clock > controller. > > Cc: Sylwester Nawrocki > Cc: Tomasz Figa > Signed-off-by: Chanwoo Choi > Acked-by: Inki Dae > --- > .../devicetre

Re: [PATCH 2/2] ARM: dts: Add syscon phandle to the video-phy node for Exynos4

2015-02-02 Thread Sylwester Nawrocki
Hi Kukjin, On 16/01/15 18:30, Sylwester Nawrocki wrote: > This is required to fix regression after introducing the PMU device > nodes required for the PMU driver modified in commit > 14fc8b93d47323561edf5d482d4a4b3ee1b90286 > ("ARM: EXYNOS: Add platform driver support for Exy

Re: [PATCH v3 01/12] clk: samsung: exynos5433: Add clocks using common clock framework

2015-01-29 Thread Sylwester Nawrocki
Hi Chanwoo, On 23/01/15 21:54, Chanwoo Choi wrote: > On Sat, Jan 24, 2015 at 2:40 AM, Sylwester Nawrocki > wrote: >> On 21/01/15 07:26, Chanwoo Choi wrote: >>> +/* list of all parent clock list */ >> >>> +PNAME(mout_bus_pll_user_p) = { "fin_pll"

Re: [PATCH v3 01/12] clk: samsung: exynos5433: Add clocks using common clock framework

2015-01-29 Thread Sylwester Nawrocki
Hi Chanwoo, On 29/01/15 00:38, Chanwoo Choi wrote: ... Right. current samsung clock drivers cannot show the hierarchy among clock domains in DT. >> IOW, there is currently >> no way to ensure proper registration order of the CMUs (clock domains). >> This may be impo

[GIT PULL] clk/samsung updates for v3.20

2015-01-28 Thread Sylwester Nawrocki
Hi Mike, The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672: Linux 3.19-rc1 (2014-12-20 17:08:50 -0800) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git tags/v3.20-exynos-clk for you to fetch changes up to e64fb42da4c6c713cfc7cad607e

Re: [alsa-devel] [PATCH v4 1/3] ASoC: samsung: Add machine driver for Trats2

2015-01-27 Thread Sylwester Nawrocki
On 23/01/15 06:03, Inha Song wrote: > +static int trats2_aif1_startup(struct snd_pcm_substream *substream) > +{ > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > + struct trats2_machine_priv *priv = snd_soc_card_get_drvdata(rtd->card); > + int ret; > + > + ret = clk_p

Re: [PATCH v2 00/16] ASoC: samsung: Add clk provider for I2S internal clocks

2015-01-27 Thread Sylwester Nawrocki
Hello Tobias, On 24/01/15 02:53, Tobias Jakobi wrote: > Hello, > > I've tested the series on my X2 and so far I haven't encountered any > obvious issues with it. > > I have a small question though. With the move to simple-audio-card the > old driver (selected by SND_SOC_ODROIDX2) is probably goi

Re: [PATCH v3 01/12] clk: samsung: exynos5433: Add clocks using common clock framework

2015-01-23 Thread Sylwester Nawrocki
On 21/01/15 07:26, Chanwoo Choi wrote: > +/* list of all parent clock list */ > +PNAME(mout_bus_pll_user_p) = { "fin_pll", "sclk_bus_pll", }; ... > + > +static struct samsung_mux_clock top_mux_clks[] __initdata = { > + MUX(CLK_MOUT_BUS_PLL_USER, "mout_bus_pll_user", mout_bus_pll_user_p, > +

Re: [PATCH v3 01/12] clk: samsung: exynos5433: Add clocks using common clock framework

2015-01-23 Thread Sylwester Nawrocki
On 23/01/15 08:44, Chanwoo Choi wrote: >>> + cmu_top: clock-controller@0x1003 { >>> >> +compatible = "samsung,exynos5433-cmu-top"; >>> >> +reg = <0x1003 0x0c04>; >>> >> +#clock-cells = <1>; >>> >> +}; >>> >> + >>> >> +cmu_fs

Re: [alsa-devel] [PATCH v4 2/3] ASoC: samsung: Document Trats2 audio subsystem bindings

2015-01-23 Thread Sylwester Nawrocki
On 23/01/15 06:03, Inha Song wrote: > This patch add Trats2 audio subsystem bindings document. > > Signed-off-by: Inha Song Reviewed-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord

Re: [alsa-devel] [PATCH v4 3/3] ARM: dts: Add sound nodes for exynos4412-trats2

2015-01-23 Thread Sylwester Nawrocki
On 23/01/15 06:03, Inha Song wrote: > This patch add WM1811 audio codec, I2S interface and the sound > machine nodes to enable audio on exynos4412-trats2 board. > > Signed-off-by: Inha Song Reviewed-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "

Re: [PATCH v3 01/12] clk: samsung: exynos5433: Add clocks using common clock framework

2015-01-22 Thread Sylwester Nawrocki
Hi Chanwoo, On 21/01/15 07:26, Chanwoo Choi wrote: > This patch adds the support for CMU (Clock Management Units) of Exynos5433 > which is 64bit SoC and has Octa-cores. This patch supports necessary clocks > (PLL/MMC/UART/MCT/I2C/SPI) for kernel boot and includes binding documentation > for Exynos

Re: [alsa-devel] [PATCH v3 3/4] ARM: dts: set clock out parent to XUSBXTI

2015-01-22 Thread Sylwester Nawrocki
On 22/01/15 12:18, Inha Song wrote: > This patch set clock out parent to XUSBXTI. > > Signed-off-by: Inha Song > --- > arch/arm/boot/dts/exynos4.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index b8168f1..020bb

Re: [alsa-devel] [PATCH v3 2/4] ASoC: samsung: Document Trats2 audio subsystem bindings

2015-01-22 Thread Sylwester Nawrocki
On 22/01/15 12:18, Inha Song wrote: > This patch add Trats2 audio subsystem bindings document. > > Signed-off-by: Inha Song Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@v

Re: [alsa-devel] [PATCH v3 1/4] ASoC: samsung: Add machine driver for Trats2

2015-01-22 Thread Sylwester Nawrocki
On 22/01/15 12:17, Inha Song wrote: > diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig > index fc67f97..8031423 100644 > --- a/sound/soc/samsung/Kconfig > +++ b/sound/soc/samsung/Kconfig > @@ -245,3 +245,11 @@ config SND_SOC_ARNDALE_RT5631_ALC5631 > depends on SND_SOC_SAM

Re: [alsa-devel] [PATCH v2 3/3] ARM: dts: Add sound nodes for exynos4412-trats2

2015-01-21 Thread Sylwester Nawrocki
Hi, On 19/01/15 10:48, Inha Song wrote: > --- a/arch/arm/boot/dts/exynos4412-trats2.dts > +++ b/arch/arm/boot/dts/exynos4412-trats2.dts > + sound { > + compatible = "samsung,trats2-audio"; > + assigned-clocks = <&pmu_system_controller 0>; > + assigned-cloc

Re: [PATCH] ARM: dts: exynos5422-odroidxu3: add sound nodes

2015-01-21 Thread Sylwester Nawrocki
Hi, On 21/01/15 06:58, Inha Song wrote: > Add MAX98090 audio codec, I2S interface and the sound nodes to support > audio on Odroid-XU3 board. > > Signed-off-by: Inha Song > --- > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 34 > ++ > 1 file changed, 34 insertions(+

Re: [PATCH v4 4/9] clk: samsung: exynos4: Add divider clock id for memory bus frequency

2015-01-20 Thread Sylwester Nawrocki
On 15/01/15 02:50, Chanwoo Choi wrote: > This patch adds the divider clock id for Exynos4 memory bus frequency. > The clock id is used fo DVFS (Dynamic Voltage/Frequency Scaling) > feature of exynos memory bus frequency. > > Cc: Sylwester Nawrocki > Cc: Tomasz Figa > Signed

Re: [PATCH 1/2] clk: exynos5420: Add IDs for clocks used in DISP1 power domain

2015-01-20 Thread Sylwester Nawrocki
ing both patches via arm-soc seems a more sane option in this case. Acked-by: Sylwester Nawrocki -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 09/15] ASoC: samsung: i2s: Protect more registers with a spinlock

2015-01-19 Thread Sylwester Nawrocki
Hi Tuashar, On 17/01/15 06:21, Tushar Behera wrote: > On Thu, Jan 15, 2015 at 3:42 AM, Sylwester Nawrocki > wrote: >> Ensure the I2SMOD, I2SPSR registers, which are also exposed through >> clk API are only accessed with the i2s->spinlock spinlock held. >> >>

[GIT PULL] clk: more Exynos7 clock tree definitions

2015-01-16 Thread Sylwester Nawrocki
Hi Mike, Please find below a few clk updates for exynos7 SoC. I kept them on a separate branch as there will likely be depending dts patches. Please pull for 3.20. The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672: Linux 3.19-rc1 (2014-12-20 17:08:50 -0800) are avai

[PATCH] ARM: dts: Fix CLK_MOUT_CAMn parent clocks assignment for Trats2

2015-01-16 Thread Sylwester Nawrocki
xes commit 0357a4438d531ef3cf529e80ffcd208eb8e35f55 ("ARM: dts: Specify default clocks for Exynos4 camera devices"). Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos4412-trats2.dts |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos4412-trats2.

[PATCH 2/2] ARM: dts: Add syscon phandle to the video-phy node for Exynos4

2015-01-16 Thread Sylwester Nawrocki
I-2 camera sensors working again on Exynos4 boards. Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos4.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index b8168f1..250ee50 100644 --- a/arch/arm/boot/dts/exynos4.

  1   2   3   4   5   6   7   8   9   10   >