Re: [PATCH 7/7] PCI: designware: split samsung and fsl bindings

2014-02-28 Thread Tim Harvey
On Fri, Feb 28, 2014 at 9:28 AM, Lucas Stach wrote: > The glue around the core designware IP is > significantly different between the Exynos and > i.MX, which is reflected in the DT bindings. > > Note that this patch doesn't change any bindings, > but just alters the documentation to match reality

Re: [PATCH 0/7] PCI irq mapping fixes and cleanups

2014-02-28 Thread Tim Harvey
On Fri, Feb 28, 2014 at 9:28 AM, Lucas Stach wrote: > This series cleans up the PCI irq mapping for all > the ARM PCI host drivers, so they handle it in the > way defined in the common PCI bindings. > > Testing appreciated. > > Lucas Stach (7): > ARM: dts: tegra: add PCIe interrupt mapping prope

Re: [PATCH 0/7] PCI irq mapping fixes and cleanups

2014-03-03 Thread Tim Harvey
On Mon, Mar 3, 2014 at 12:11 AM, Jingoo Han wrote: > On Sunday, March 02, 2014 3:31 AM, Jason Gunthorpe wrote: >> On Fri, Feb 28, 2014 at 04:53:33PM -0800, Tim Harvey wrote: >> >> > In testing this on IMX6 I'm finding that 'of_irq_parse_and_map_pci()' >&

Re: [PATCH 0/7] PCI irq mapping fixes and cleanups

2014-03-03 Thread Tim Harvey
On Mon, Mar 3, 2014 at 9:49 AM, Tim Harvey wrote: > On Mon, Mar 3, 2014 at 12:11 AM, Jingoo Han wrote: >> On Sunday, March 02, 2014 3:31 AM, Jason Gunthorpe wrote: >>> On Fri, Feb 28, 2014 at 04:53:33PM -0800, Tim Harvey wrote: >>> > The configuration I'm tes

Re: [PATCH 0/7] PCI irq mapping fixes and cleanups

2014-03-03 Thread Tim Harvey
On Mon, Mar 3, 2014 at 4:01 PM, Jason Gunthorpe wrote: > On Mon, Mar 03, 2014 at 03:40:43PM -0800, Tim Harvey wrote: > >> of_irq_parse_and_map_pci(). The GIC function that translates the >> interrupt per domain is given irq_data: 0x123 0x04 0x00 > > This has been shifted

[PATCH 1/2] of/irq: Fix irq-mapping in of_irq_parse_raw()

2014-03-04 Thread Tim Harvey
pcie host controller driver map_irq function where a P2P bridge is on the bus and legacy PCI interrupts are to be used. Signed-off-by: Tim Harvey Cc: Jason Gunthorpe Cc: Jingoo Han Cc: Lucas Stach Cc: Mark Rutland Cc: linux-samsung-soc Cc: Richard Zhu Cc: Sascha Hauer Cc: Arnd Bergmann Cc

Re: [PATCH 6/7] PCI: designware: use new OF interrupt mapping when possible

2014-03-04 Thread Tim Harvey
On Fri, Feb 28, 2014 at 9:28 AM, Lucas Stach wrote: > This is the recommended method of doing the IRQ > mapping. For old devicetrees we fall back to the > previous practice. > > Signed-off-by: Lucas Stach > --- > drivers/pci/host/pcie-designware.c | 8 +++- > 1 file changed, 7 insertions(+),

Re: [PATCH 1/2] of/irq: Fix irq-mapping in of_irq_parse_raw()

2014-03-04 Thread Tim Harvey
On Tue, Mar 4, 2014 at 6:54 AM, Tim Harvey wrote: > When an interrupt-map contains multiple entries an imap pointer arithmetic > bug can cause only the first entry to be properly evaluated and causes > the out_irq parameters to be incorrect depending on the #interrupt-cells > and #a

Re: [PATCH 1/2] of/irq: Fix irq-mapping in of_irq_parse_raw()

2014-03-11 Thread Tim Harvey
On Tue, Mar 11, 2014 at 1:15 PM, Jason Gunthorpe wrote: > On Tue, Mar 04, 2014 at 06:54:24AM -0800, Tim Harvey wrote: >> When an interrupt-map contains multiple entries an imap pointer arithmetic >> bug can cause only the first entry to be properly evaluated and causes >> t

[PATCH 1/2] ARM: DT: fix gic interrupt controller documentation

2014-03-13 Thread Tim Harvey
When using interrupt-maps, the size of a map entry is #address-cells + #interrupt-cells for the parent interrupt controller. For the ARM GIC address-cells should be 0 as this is not used. This patch fixes the example by correctly specifying #address-cells = 0. Signed-off-by: Tim Harvey Cc

[PATCH 2/2] ARM: dts: imx: fix invalid #address-cells value

2014-03-13 Thread Tim Harvey
when using legacy interrupts. Signed-off-by: Tim Harvey Cc: Jason Gunthorpe Cc: Jingoo Han Cc: Lucas Stach Cc: Mark Rutland Cc: linux-samsung-soc Cc: Richard Zhu Cc: Sascha Hauer Cc: Arnd Bergmann Cc: Stephen Warren Cc: Bjorn Helgaas Cc: Simon Horman Cc: Thierry Reding Cc: Ben Dooks

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-03-13 Thread Tim Harvey
>> >> It works properly on Exynos platform. >> Thank you. > > Looks reasonable, > > Reviewed-by: Marek Vasut > I've tested this on the Gateworks Ventana products with P2P bridges and with the patch I just submitted here: http://thread.gmane.org/gmane.linux.k

Re: [PATCH 1/2] ARM: DT: fix gic interrupt controller documentation

2014-03-13 Thread Tim Harvey
On Thu, Mar 13, 2014 at 11:25 AM, Jason Gunthorpe wrote: > On Thu, Mar 13, 2014 at 11:44:33AM -0600, Stephen Warren wrote: >> On 03/13/2014 11:40 AM, Tim Harvey wrote: >> > When using interrupt-maps, the size of a map entry is #address-cells + >> > #interrupt-cel