Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

2015-11-30 Thread Uwe Kleine-König
er the first triple-dash doesn't make it into the git history, so you are expected to write the S-o-b line above the list of things changed since a previous submission. Other than that the patch looks fine. Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-18 Thread Uwe Kleine-König
we identify driver for these devices. I don't see why you don't use the platform device as parent for mpc8xxx. Note however that I did several updates to the mpc8xxx driver which probably conflict with setting the parent. I'll take care of that. Best regards Uwe -- Pengutroni

[PATCH] clk: make several parent names const

2015-05-28 Thread Uwe Kleine-König
Since commit 2893c379461a ("clk: make strings in parent name arrays const") the name of parent clocks can be const. So add more const in several clock drivers. Signed-off-by: Uwe Kleine-König --- Hello, commit 2893c379461a isn't in Linus Torvald's tree yet, so the commit me

Re: [PATCH] i2c: exynos5: Move initialization code to subsys_initcall()

2015-01-11 Thread Uwe Kleine-König
comment to stop the next person converting it to that. (And if not, please fix accordingly to use deferred probing.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsub

Re: DT on s3c24xx

2014-12-17 Thread Uwe Kleine-König
cfg-gpios = <&gpio4 12 3>, <&gpio2 7 5>; }; Then I think you can fiddle with pinctrl_select_state(). For the gpios you can then use the standard gpiod_{request,direction_{in,out}put} combo. Best regards Uwe -- Pengutronix e.K. | Uwe Klei

Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-17 Thread Uwe Kleine-König
}, > { } > }; > MODULE_DEVICE_TABLE(of, rt5631_i2c_dt_ids); > +#endif An (IMHO nicer) alternative is: -static struct of_device_id rt5631_i2c_dt_ids[] = { +static struct of_device_id rt5631_i2c_dt_ids[] __maybe_unused = { Best regards Uwe -- Pengutronix e.K.

Re: Samsung/S3C6410/Mini6410: how to handle NAND's "clock off"

2014-11-12 Thread Uwe Kleine-König
Hello again, [extending audience a bit] On Tue, Nov 11, 2014 at 07:42:26PM +0100, Uwe Kleine-König wrote: > On Tue, Nov 11, 2014 at 07:10:33PM +0100, Juergen Borleis wrote: > > Hi, > > > > the S3C2410 NAND driver [1] can still be used for NANDs attached to an > >

Re: Samsung/S3C6410/Mini6410: how to handle NAND's "clock off"

2014-11-11 Thread Uwe Kleine-König
hold a reference to hclk_mem0. I assume the system uses a device tree? This is the dm9000 driver? It doesn't seem to use clk stuff, but it should be possible to add an optional clk entry. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industria

Re: [PATCH] clk: don't use __initconst for non-const arrays

2014-09-12 Thread Uwe Kleine-König
Hello Ard, On Fri, Sep 12, 2014 at 09:42:29AM +0200, Ard Biesheuvel wrote: > On 12 September 2014 00:04, Uwe Kleine-König > wrote: > > Hello, > > > > On Thu, Sep 11, 2014 at 11:04:31PM +0200, Uwe Kleine-König wrote: > >> /* Mux parent lists. */ > >> -

Re: [PATCH] clk: don't use __initconst for non-const arrays

2014-09-11 Thread Uwe Kleine-König
Hello, On Thu, Sep 11, 2014 at 11:04:31PM +0200, Uwe Kleine-König wrote: > /* Mux parent lists. */ > -static const char *fin_pll_p[] __initconst = { > +static const char *fin_pll_p[] __initdata = { > "xxti", > "xusbxti" > }; As discussed wit

[PATCH] clk: don't use __initconst for non-const arrays

2014-09-11 Thread Uwe Kleine-König
dditional const must be added such that the whole definition reads: static const char *const name[] __initconst; or where this is not possible __initdata must be used. Signed-off-by: Uwe Kleine-König --- drivers/clk/hisilicon/clk-hix5hd2.c | 6 ++-- drivers/clk/mxs/clk-

Re: [PATCH 1/3] ARM: exynos: remove unused

2014-07-23 Thread Uwe Kleine-König
g.uk/developer/patches/viewpatch.php?id=8113/1 Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in th

Re: [PATCH 1/3] ARM: exynos: remove unused

2014-07-22 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo inf

[PATCH 1/3] ARM: exynos: remove unused

2014-07-02 Thread Uwe Kleine-König
ARCH_EXYNOS doesn't select NEED_MACH_MEMORY_H, so doesn't include and so this file is not used and can go away. Signed-off-by: Uwe Kleine-König --- Cc: Kukjin Kim Cc: linux-samsung-soc@vger.kernel.org --- arch/arm/mach-exynos/include/mach/memory.h | 27 -

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
On Thu, Oct 24, 2013 at 11:48:48AM -0700, Joe Perches wrote: > On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-König wrote: > > On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: > [] > > > Any k.alloc without __GFP_NOWARN does a generic OOM message > > > and

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: > On Thu, 2013-10-24 at 20:26 +0200, Uwe Kleine-König wrote: > > Hello Joe, > > > > On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: > > > Emitting an OOM message isn't necessary after inp

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
s NULL but input_dev isn't the message would still be sensible, wouldn't it? There are several more that suffer the same "problem". Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http:/

Re: [PATCH] i2c: s3c2410: Add SMBus emulation for block read

2013-04-09 Thread Uwe Kleine-König
yte that is read as 0) the is_msglast() test returns 0 which might be wrong. Maybe even if it cannot regularily happen handle it in a sane way? Also I wonder if error checking for byte > I2C_SMBUS_BLOCK_MAX would be needed to prevent a buffer overrun? Best regards Uwe -- Pengutronix e.K.

Re: [PATCH] clk: let mxs specific clk-div clock type be a generic clock type

2013-03-18 Thread Uwe Kleine-König
> > to review the changes. Making it two steps might be helpful for > > reviewer: > > > > 1) git mv drivers/clk/mxs/clk-div.c drivers/clk/clk-divider-status.c > > 2) make changes on drivers/clk/clk-divider-status.c > > Thanks Shawn for your comments. I will split

$(make uImage) is stupid [Was: Re: Early kernel hang with big DTB appended]

2013-01-14 Thread Uwe Kleine-König
ards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.

[PATCH v2 02/15] ARM: mark const init data with __initconst instead of __initdata

2012-03-30 Thread Uwe Kleine-König
y and so cannot contain non-const variables. Signed-off-by: Uwe Kleine-König Cc: Andrew Victor Cc: Nicolas Ferre Cc: Jean-Christophe Plagniol-Villard Cc: Russell King Cc: Sekhar Nori Cc: Kevin Hilman Cc: Kukjin Kim Cc: Sascha Hauer Cc: Shawn Guo Cc: Lennert Buytenhek Cc: Nicolas Pitre Cc:

Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-30 Thread Uwe Kleine-König
Hello Shawn, On Fri, Mar 30, 2012 at 02:11:36PM +0800, Shawn Guo wrote: > On Thu, Mar 29, 2012 at 11:12:20PM +0200, Uwe Kleine-König wrote: > ... > > diff --git a/arch/arm/mach-imx/imx51-dt.c b/arch/arm/mach-imx/imx51-dt.c > > index 5cca573..7e00748 100644 > > --- a/arch

[PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-29 Thread Uwe Kleine-König
y and so cannot contain non-const variables. Signed-off-by: Uwe Kleine-König Cc: Andrew Victor Cc: Nicolas Ferre Cc: Jean-Christophe Plagniol-Villard Cc: Russell King Cc: Sekhar Nori Cc: Kevin Hilman Cc: Kukjin Kim Cc: Sascha Hauer Cc: Shawn Guo Cc: Lennert Buytenhek Cc: Nicolas Pitre Cc:

Re: [PATCH] mmc: card: modify mmc_getgeo function

2011-09-26 Thread Uwe Kleine-König
On Mon, Sep 26, 2011 at 08:41:13AM -0400, Chris Ball wrote: > Hi, > > On Mon, Sep 26 2011, Uwe Kleine-König wrote: > >> Thanks, pushed to mmc-next for 3.2 with a reworded commit message: > > This (i.e. ee9e0e0 (mmc: card: Remove duplicated constants) in next) > >

Re: [PATCH] mmc: card: modify mmc_getgeo function

2011-09-26 Thread Uwe Kleine-König
* [.tmp_vmlinux1] Error 1 make[1]: *** [sub-make] Error 2 make: *** [all] Error 2 (I don't know why clkdev.c is referenced here. I'm not using ccache.) It seems gcc isn't smart enough to notice that it can just use the same generated code ... Having said that AFAI

Re: [PATCH] ARM: S3C64XX: Fix section mismatch from cpufreq init

2011-03-16 Thread Uwe Kleine-König
On Wed, Mar 16, 2011 at 09:49:59AM +, Mark Brown wrote: > On Wed, Mar 16, 2011 at 09:38:11AM +0100, Uwe Kleine-König wrote: > > On Thu, Mar 10, 2011 at 02:58:13PM +, Mark Brown wrote: > > > we don't appear to have annotations which allow us to mark that it'll

Re: [PATCH] ARM: S3C64XX: Fix section mismatch from cpufreq init

2011-03-16 Thread Uwe Kleine-König
q_driver *, int (*)(struct cpufreq_policy *)) (that is pass the init callback to cpufreq_register_driver). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list

Re: [RFC 2/5] ARM: P2V: avoid initializers and assembly using PHYS_OFFSET

2011-02-07 Thread Uwe Kleine-König
Hello again, On Mon, Feb 07, 2011 at 05:51:50PM +0100, Uwe Kleine-König wrote: > nack. 7608d7d2b4a146f560436f5b99b1b93d30049e4e has a better fix. urgs, this was already pointed out, sorry. Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Li

Re: [RFC 2/5] ARM: P2V: avoid initializers and assembly using PHYS_OFFSET

2011-02-07 Thread Uwe Kleine-König
gt; .map_io = mx51_map_io, > .init_irq = mx51_init_irq, > .init_machine = mxc_board_init, nack. 7608d7d2b4a146f560436f5b99b1b93d30049e4e has a better fix. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions

Re: [PATCH] ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig

2010-08-13 Thread Uwe Kleine-König
@ -72,7 +72,7 @@ config S3C2440_PLL_16934400 > > config S3C2440_DMA > bool > - depends on ARCH_S3C2410 && CPU_S3C24405B > + depends on (ARCH_S3C2410 || CPU_S3C24405B) > help > Support for S3C2440 specific DMA code5A all parent

Re: git pre-commit hook running checkpatch.pl

2010-01-20 Thread Uwe Kleine-König
equently do wip-commits that not necessarily are checkpatch-clean. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions| http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "