On Tue, Jul 21, 2015 at 10:14:11AM +0200, Michal Suchanek wrote:
Or alternatively we could publish the limitations of the channel using
capabilities so SPI knows I have a dmaengine channel and it can transfer
max N
length transfers so would be able to break rather than guessing it or
On Sun, Jul 19, 2015 at 09:01:34PM +0200, Michal Suchanek wrote:
Hello,
On 15 July 2015 at 17:59, Brian Norris computersforpe...@gmail.com wrote:
Hi Michal,
On Wed, Jul 15, 2015 at 01:52:27PM +0200, Marek Vasut wrote:
The problem is, if you add a new DT binding, you'd have to support
On Wed, Jun 10, 2015 at 05:22:07PM +0900, Krzysztof Kozlowski wrote:
I can now say for sure that the commits 88987d2c75 and aee4d1fac8 are
the cause for the problem. Audio was working now for 7 days.
+CC Vinod
Gabriel,
I sent a patch which should fix the issue. Could you give it a
On Thu, Jan 15, 2015 at 04:16:03PM +0100, Arnd Bergmann wrote:
Everything uses dmaengine now, so there is no reason to
keep this around any longer. Thanks to everyone who was involved
in moving the users over to use the dmaengine APIs.
Very good indeed :)
Acked-by: Vinod Koul vinod.k
On Tue, Dec 09, 2014 at 08:48:04PM +0530, Jassi Brar wrote:
As Russell pointed out, that ain't the case either.
So we are yet to figure out benefits of having explicit
issue_pending() after tx_submit().
callback ?
--
~Vinod
--
To unsubscribe from this list: send the line unsubscribe
On Sat, Dec 06, 2014 at 12:31:01PM +0530, Jassi Brar wrote:
It does, though, create an awkward situation when a channel is
active while new requests are submitted - why would the channel want
to stop after current transfer and await fresh issue_pending()? It's
not that the request can be
On Mon, Dec 08, 2014 at 02:23:21PM +, Russell King - ARM Linux wrote:
On Mon, Dec 08, 2014 at 06:37:27PM +0530, Vinod Koul wrote:
I actually like the split model, you can also prepare txn ahead of time and
submit them when needed.
Actually, you can't - that's not permitted. I have
On Tue, Dec 02, 2014 at 06:25:49PM +0100, Lars-Peter Clausen wrote:
On 12/02/2014 06:38 AM, Padma Venkat wrote:
Well it doesn't break audio, but I don't think it has the correct
haviour for all cases yet.
Again, the semantics are that it should return the progress of the
transfer for
On Wed, Dec 03, 2014 at 01:21:37PM +0530, Jassi Brar wrote:
On 3 December 2014 at 10:17, Padma Venkat padma@gmail.com wrote:
Hi Lars,
[snip]
+
+ ret = dma_cookie_status(chan, cookie, txstate);
+ if (ret == DMA_COMPLETE || !txstate)
+ return ret;
+
+ used =
On Fri, Aug 01, 2014 at 06:09:48PM +0100, Mark Brown wrote:
From: Mark Brown broo...@linaro.org
When printing size_t values we should use the %zd or %zx format specifier
in order to ensure the value is displayed correctly and avoid warnings from
sparse.
Applied, thanks
--
~Vinod
--
To
On Wed, Nov 13, 2013 at 02:28:58PM +0530, Vinod Koul wrote:
On Tue, Nov 12, 2013 at 07:28:10PM +0900, Kukjin Kim wrote:
Vinod Koul wrote:
On Thu, Oct 31, 2013 at 10:48:09AM +0530, Sachin Kamat wrote:
Use the recently introduced DMA_COMPLETE instead of DMA_SUCCESS.
Without
On Thu, Nov 28, 2013 at 02:33:22PM -0800, Dan Williams wrote:
On Wed, Nov 27, 2013 at 11:25 PM, Vinod Koul vinod.k...@intel.com wrote:
On Wed, Nov 13, 2013 at 02:28:58PM +0530, Vinod Koul wrote:
On Tue, Nov 12, 2013 at 07:28:10PM +0900, Kukjin Kim wrote:
Vinod Koul wrote:
On Thu
On Tue, Nov 12, 2013 at 07:28:10PM +0900, Kukjin Kim wrote:
Vinod Koul wrote:
On Thu, Oct 31, 2013 at 10:48:09AM +0530, Sachin Kamat wrote:
Use the recently introduced DMA_COMPLETE instead of DMA_SUCCESS.
Without this patch we get the following build error:
drivers/dma/s3c24xx-dma.c
: ‘DMA_SUCCESS’ undeclared
(first use in this function)
I missed it because this is not in my tree! This needs to go thru kgene's tree
and for that you can merge dma_complete branch from my tree. I will not rebase
that
Acked-by: Vinod Koul vinod.k...@intel.com
--
~Vinod
Signed-off-by: Sachin Kamat
On Wed, Oct 16, 2013 at 07:32:20AM +0900, Kukjin Kim wrote:
On 10/14/13 03:11, Heiko Stübner wrote:
Am Sonntag, 13. Oktober 2013, 16:56:42 schrieb Vinod Koul:
On Fri, Oct 11, 2013 at 10:59:19AM +0200, Heiko Stübner wrote:
[I messed up the linux-arm-kernel list address yesterday, so I resend
On Fri, Oct 11, 2013 at 11:01:04AM +0200, Heiko Stübner wrote:
The earliest variants of the dma controller did not contain support for
controlling clocks.
Acked-by: Vinod Koul vinod.k...@intel.com
Signed-off-by: Heiko Stuebner he...@sntech.de
---
drivers/dma/s3c24xx-dma.c | 10
On Fri, Oct 11, 2013 at 11:01:33AM +0200, Heiko Stübner wrote:
s3c2410 and s3c2442 share the same dma channels while s3c2440 has
slight differences. But on all three the reachable sources per dma
channel has constraints attached and thus encodes the usable
combinations using the
On Fri, Oct 11, 2013 at 10:59:19AM +0200, Heiko Stübner wrote:
[I messed up the linux-arm-kernel list address yesterday, so I resend it
with a fixed address, sorry for the noise]
When Olof reported the warning about the unused s3c2410_dma_resource, I
thought the best way forward would be to
On Wed, Oct 09, 2013 at 01:37:56PM -0700, Dylan Reid wrote:
On Sun, Oct 6, 2013 at 8:48 PM, Vinod Koul vinod.k...@intel.com wrote:
On Mon, Oct 07, 2013 at 10:39:34AM +0900, Chanho Park wrote:
Why didn't you use a cookie value to track the request?
The cookie is assigned when each
and
slave_sg partially using the spi-s3c64xx driver.
Signed-off-by: Heiko Stuebner he...@sntech.de
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Vinod Koul vinod.k...@intel.com
--
~Vinod
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message
On Mon, Oct 07, 2013 at 10:39:34AM +0900, Chanho Park wrote:
Why didn't you use a cookie value to track the request?
The cookie is assigned when each transfer is submitted.
If you save the value in the desc, we can find the request easily.
If there are several cyclic desc in the work
On Thu, Sep 19, 2013 at 10:48:01PM +0100, Russell King wrote:
The DMA API requires drivers to call the appropriate dma_set_mask()
functions before doing any DMA mapping. Add this required call to
the AMBA PL08x driver.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
Acked-by: Vinod
-off-by: Russell King rmk+ker...@arm.linux.org.uk
Acked-by: Vinod Koul vinod.k...@intel.com
This also brings me question that should we force the driver to use the
dma_set_mask_and_coherent() API or they have below flexiblity too?
~Vinod
---
drivers/dma/edma.c |6 ++
1 files changed
doing any DMA mapping. Add this required call to
the AMBA PL08x driver.
^--- copy and paste error - should of course be PL330
Fixed, thanks.
with fixed changelog...
Acked-by: Vinod Koul vinod.k...@intel.com
~Vinod
--
--
To unsubscribe from this list: send the line
On Wed, Sep 11, 2013 at 11:38:03AM +0530, Padmavathi Venna wrote:
From: Dylan Reid dgr...@chromium.org
Fill txstate.residue with the amount of bytes remaining in the current
transfer if the transfer is not complete. This will be of particular
use to i2s DMA transfers, providing more
On Sun, Aug 11, 2013 at 07:59:12PM +0200, Tomasz Figa wrote:
This is first non-RFC version of my patches extending support of
amba-pl08x DMA engine driver to PL080S DMA engine (PL080 modified by
Samsung) found in Samsung S3C64xx SoCs.
Due to changes scattered across different areas of
On Wed, Aug 28, 2013 at 12:13:51AM +0200, Heiko Stübner wrote:
This adds a new driver to support the s3c24xx dma using the dmaengine
and makes the old one in mach-s3c24xx obsolete in the long run.
Conceptually the s3c24xx-dma feels like a distant relative of the pl08x
with numerous virtual
On Tue, Aug 20, 2013 at 10:23:49AM +0200, Heiko Stübner wrote:
Hi Vinod,
Am Montag, 19. August 2013, 06:48:12 schrieb Vinod Koul:
On Wed, Aug 14, 2013 at 02:00:25PM +0200, Heiko Stübner wrote:
This adds a new driver to support the s3c24xx dma using the dmaengine
and makes the old one
On Wed, Aug 14, 2013 at 02:00:25PM +0200, Heiko Stübner wrote:
This adds a new driver to support the s3c24xx dma using the dmaengine
and makes the old one in mach-s3c24xx obsolete in the long run.
Conceptually the s3c24xx-dma feels like a distant relative of the pl08x
with numerous virtual
On Sat, Jun 22, 2013 at 10:42:33PM +0200, Tomasz Figa wrote:
Further patch will introduce support for PL080S, which requires some
things to be done conditionally, thus increasing indentation level of
some functions even more.
This patch reduces indentation level of pl08x_getbytes_chan()
-by: Vinod Koul vinod.k...@intel.com
--
~Vinod
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
of CH_CONTROL register on PL080S, which
was not a problem witn transfer sizes fitting the original bitfield
of PL080, but now would overwrite other fields.
Signed-off-by: Tomasz Figa tomasz.f...@gmail.com
Acked by: Vinod Koul vinod.k...@intel.com
--
~Vinod
--
To unsubscribe from this list: send
...@linaro.org
---
Based on Vinod Koul next branch.
Changes since V2:
- Removed pl330_free_chan_resources for error handling in probe.
Changes since V1:
- return silently when of_dma_controller_register fails, as
suggested by Arnd.
drivers/dma/pl330.c | 33
On Mon, Apr 01, 2013 at 08:13:31AM -0500, Rob Herring wrote:
On Thu, Mar 21, 2013 at 4:39 AM, Vinod Koul vinod.k...@intel.com wrote:
On Tue, Mar 05, 2013 at 02:55:31PM +0530, Padmavathi Venna wrote:
This patch register the dma controller with generic dma helpers only
in DT case. This also
...@linaro.org
---
Based on Vinod Koul next branch.
Changes since V1:
- return silently when of_dma_controller_register fails, as
suggested by Arnd.
drivers/dma/pl330.c | 38 +++---
1 files changed, 27 insertions(+), 11 deletions(-)
diff
On Tue, Feb 19, 2013 at 11:02:09AM +0900, Boojin Kim wrote:
This patch adds to support burst mode for for dev-to-mem and dev-to-mem
transmit
Signed-off-by: Boojin Kim boojin@samsung.com
---
arch/arm/plat-samsung/dma-ops.c | 10 --
On Thu, Feb 14, 2013 at 11:12:51AM +0530, Padma Venkat wrote:
Hi Vinod,
On Thu, Feb 14, 2013 at 10:17 AM, Vinod Koul vinod.k...@intel.com wrote:
On Wed, Feb 13, 2013 at 09:52:30AM +0530, Padma Venkat wrote:
Hi Vinod,
On Tue, Feb 12, 2013 at 8:19 PM, Vinod Koul vinod.k...@intel.com
This patch set adds support for generic dma device tree bindings for
Samsung platforms and is dependent on the following patches from
Vinod Koul next branch
1)of: Add generic device tree DMA helpers
2)dmaengine: add helper function to request a slave DMA channel
This patch set is made based
On Wed, Feb 13, 2013 at 09:52:30AM +0530, Padma Venkat wrote:
Hi Vinod,
On Tue, Feb 12, 2013 at 8:19 PM, Vinod Koul vinod.k...@intel.com wrote:
On Mon, Feb 11, 2013 at 02:08:20PM +0530, Padmavathi Venna wrote:
This looks fine, I have only question. The code seems to assume that pl330
On Fri, Jan 18, 2013 at 05:03:40PM +0530, Padmavathi Venna wrote:
This patch set adds support for generic dma device tree bindings for
Samsung platforms and is dependent on the following patches from
Vinod Koul next branch
1)of: Add generic device tree DMA helpers
2)dmaengine: add helper
On Fri, Jan 18, 2013 at 05:17:09PM +0530, Padmavathi Venna wrote:
Signed-off-by: Padmavathi Venna padm...@samsung.com
---
include/linux/dmaengine.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index
On Fri, 2012-11-30 at 11:59 +0100, Bartlomiej Zolnierkiewicz wrote:
Acked-by: Jassi Brar jassisinghb...@gmail.com
Vinod/Dan could you please pick this patch for 3.8? Thanks!
I will check and queue it up today
--
~Vinod
--
To unsubscribe from this list: send the line unsubscribe
On Sat, 2012-10-27 at 15:50 +0530, Inderpal Singh wrote:
Hi Vinod,
On 26 October 2012 10:15, Vinod Koul vk...@infradead.org wrote:
On Thu, 2012-10-25 at 16:53 +0530, Inderpal Singh wrote:
This code will get executed only in case of force removal of the
module which was discussed
.
But why are you doing force removal of driver even when client is
holding a reference to you.
What happens when client finally tries to free the channel?
What is the problem you are trying to solve?
Let me know your view.
[1] https://patchwork.kernel.org/patch/1503171/
--
Vinod Koul
);
+
dma_async_device_unregister(pdmac-ddma);
amba_set_drvdata(adev, NULL);
--
Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-start, resource_size(res));
+ kfree(pdmac-peripherals);
kfree(pdmac);
return 0;
This looks fine, but if you use devm_ functions then you dont need to do
all this.
Can you do that conversion instead?
--
Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line
On Fri, 2012-09-07 at 12:14 +0530, Inderpal Singh wrote:
The controller clock is being managed at AMBA bus level probe/remove and
pm_runtime/suspend functions. The existing driver does the clock
enable/disable
again in the same code paths, which unneccessarily increments the usage count
of
On Fri, 2012-09-07 at 14:30 +0900, Kukjin Kim wrote:
Vinod Koul wrote:
On Wed, 2012-08-29 at 10:16 +0530, Tushar Behera wrote:
DMA clients pdma0 and pdma1 are internal to the SoC and are used only
by dedicated peripherals. Since they cannot be used for generic
purpose
On Fri, 2012-09-07 at 12:14 +0530, Inderpal Singh wrote:
The controller clock is being managed at AMBA bus level probe/remove and
pm_runtime/suspend functions. The existing driver does the clock
enable/disable
again in the same code paths, which unneccessarily increments the usage count
of
.c|1 +
2 files changed, 3 insertions(+), 0 deletions(-)
--
~Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2012-05-03 at 17:50 -0700, Thomas Abraham wrote:
The cookie of completed transfer descriptors are marked as zero. In case of
cyclic transfers, a new cookie needs to be assigned to the transfer
descriptors
which are picked up from the work_list list before they are re-enabled for
On Wed, 2012-02-22 at 08:01 +0530, Jassi Brar wrote:
On Wed, Feb 22, 2012 at 7:41 AM, Kukjin Kim kgene@samsung.com wrote:
Sadly, what a mess!!!
Jassi, you don't own the copyright, your company did, as they employed
you to do the job. So both your and Kukjin are not correct in claiming
the
-by: Giridhar Maruthy giridhar.maru...@linaro.org
Signed-off-by: Tushar Behera tushar.beh...@linaro.org
Looks fine to me. Do you want these to go thru slave-dma or samsung
tree.
For latter:
Acked-by: Vinod Koul vinod.k...@linux.intel.com
---
drivers/dma/pl330.c | 17 ++---
1 files
On Thu, 2011-11-03 at 15:48 +0900, Boojin Kim wrote:
This patch adds to fix the build warning as following.
drivers/dma/pl330.c: In function 'pl330_probe':
drivers/dma/pl330.c:859: warning: comparison of distinct pointer types lacks
a cast
Signed-off-by: Boojin Kim boojin@samsung.com
from Vinod for dma
stuff.
Sure, looks fine to me
Acked-by: Vinod Koul vinod.k...@intel.com
--
~Vinod
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2011-09-19 at 19:23 +0900, Kukjin Kim wrote:
Vinod Koul wrote:
On Wed, 2011-09-14 at 17:03 +0530, Jassi Brar wrote:
On 14 September 2011 16:47, Vinod Koul vinod.k...@intel.com wrote:
The changelog for [PATCH v8 04/16] is misleading - we don't need any
modification
On Wed, 2011-09-14 at 17:03 +0530, Jassi Brar wrote:
On 14 September 2011 16:47, Vinod Koul vinod.k...@intel.com wrote:
The changelog for [PATCH v8 04/16] is misleading - we don't need any
modification for the reason mentioned in changelog. But the modification
has positive side-effect
On Wed, 2011-09-14 at 12:00 +0530, Jassi Brar wrote:
On Wed, Sep 14, 2011 at 11:31 AM, Vinod Koul vinod.k...@intel.com wrote:
On Fri, 2011-09-02 at 09:44 +0900, Boojin Kim wrote:
This patchset adds support DMA generic APIs for samsung DMA.
The changes from V7 is following:
- Divides
On Tue, 2011-08-30 at 17:58 +0530, Thomas Abraham wrote:
Hi Vinod,
On 29 August 2011 22:59, Vinod Koul vinod.k...@linux.intel.com wrote:
On Fri, 2011-08-26 at 14:10 +0530, Thomas Abraham wrote:
This patchset adds device tree support for PL330 driver and uses it
to add device tree support
On Thu, 2011-08-25 at 11:13 +0900, Boojin Kim wrote:
This patch updates following 3 items.
@@ -69,6 +70,10 @@ struct dma_pl330_chan {
* NULL if the channel is available to be acquired.
*/
void *pl330_chid;
+
+ /* For D-to-M and M-to-D channels */
+ int burst_sz;
On Mon, 2011-08-29 at 19:25 +0530, Vinod Koul wrote:
On Thu, 2011-08-25 at 11:13 +0900, Boojin Kim wrote:
This patch updates following 3 items.
@@ -69,6 +70,10 @@ struct dma_pl330_chan {
* NULL if the channel is available to be acquired.
*/
void *pl330_chid
On Mon, 2011-08-29 at 19:52 +0530, Vinod Koul wrote:
On Mon, 2011-08-29 at 19:25 +0530, Vinod Koul wrote:
On Thu, 2011-08-25 at 11:13 +0900, Boojin Kim wrote:
This patch updates following 3 items.
@@ -69,6 +70,10 @@ struct dma_pl330_chan {
* NULL if the channel is available
On Fri, 2011-08-26 at 14:10 +0530, Thomas Abraham wrote:
This patchset adds device tree support for PL330 driver and uses it
to add device tree support for Samsung platforms, specifically Exynos4.
The DMA patches looks good to me. Do you want this to go thru slave-dma
tree or somewhere else.
I
...@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
~Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Tue, 2011-07-26 at 18:31 +0900, Boojin Kim wrote:
Vinod Koul Wrote:
Sent: Monday, July 25, 2011 8:17 PM
To: Boojin Kim
Cc: vinod.k...@intel.com; linux-arm-ker...@lists.infradead.org; linux-
samsung-...@vger.kernel.org; Kukjin Kim; Jassi Brar; Grant Likely;
Mark Brown; Dan Williams
On Tue, 2011-07-26 at 23:25 +0530, Jassi Brar wrote:
On Tue, Jul 26, 2011 at 10:50 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Tue, Jul 26, 2011 at 08:07:44PM +0530, Jassi Brar wrote:
Dear Vinod,
Since it came from the RMK, most probably it'll be the best.
But
On Mon, 2011-07-25 at 10:28 +0900, Boojin Kim wrote:
This patchset adds support DMA generic APIs for Samsung DMA
and is re-sent by the request of DMA maintainer, Vinod Koul.
V4 has the changes about 3 patches from V3.
Changes from V3:
- Divided '[03/13 patch] DMA: PL330: Add DMA capabilites
:
+ dev_err(pch-dmac-pif.dev, Not supported command.\n);
+ return -ENXIO;
+ }
return 0;
}
--
~Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More
unused data.
So, I think it's loss that all dma channels hold own 'cyclic_task'.
Could you re-use the tasklet that already exists?
--
~Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
max 32 peripheral interfaces,
--
~Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2011-07-25 at 11:57 +0100, Russell King - ARM Linux wrote:
On Mon, Jul 25, 2011 at 04:18:04PM +0530, Vinod Koul wrote:
On Mon, 2011-07-25 at 11:36 +0100, Russell King - ARM Linux wrote:
On Mon, Jul 25, 2011 at 07:31:45PM +0900, Boojin Kim wrote:
On Mon, Jul 25, 2011 at 10:28
On Mon, 2011-07-25 at 15:47 +0530, Vinod Koul wrote:
On Mon, 2011-07-25 at 10:28 +0900, Boojin Kim wrote:
This patchset adds support DMA generic APIs for Samsung DMA
and is re-sent by the request of DMA maintainer, Vinod Koul.
V4 has the changes about 3 patches from V3.
Changes from V3
-tx_dmach, s3c64xx_spi_dma_client);
- s3c2410_dma_free(sdd-rx_dmach, s3c64xx_spi_dma_client);
+ sdd-ops-release(sdd-rx_ch, s3c64xx_spi_dma_client);
+ sdd-ops-release(sdd-tx_ch, s3c64xx_spi_dma_client);
}
static int s3c64xx_spi_transfer(struct spi_device *spi,
--
~Vinod Koul
On Mon, 2011-07-25 at 12:39 +0100, Russell King - ARM Linux wrote:
On Mon, Jul 25, 2011 at 04:31:57PM +0530, Vinod Koul wrote:
I know that very well thank you. Please look at my previous post in the
previous round of patches, and the response from Boojin Kim to see why
I used
74 matches
Mail list logo
