RE: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

2015-01-12 Thread Tony K Nadackal
Hi Kukjin, On Wednesday, January 07, 2015 6:09 PM, Jacek Anaszewski wrote, > Hi Tony, > > On 01/07/2015 01:08 PM, Tony K Nadackal wrote: > > Dear Jacek, > > > > On Wednesday, January 07, 2015 3:15 PM Jacek Anaszewski wrote, > > > >> Hi Tony, > >> > >> Sorry for late response, just got back from v

Re: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

2015-01-07 Thread Jacek Anaszewski
Hi Tony, On 01/07/2015 01:08 PM, Tony K Nadackal wrote: Dear Jacek, On Wednesday, January 07, 2015 3:15 PM Jacek Anaszewski wrote, Hi Tony, Sorry for late response, just got back from vacation. On 12/19/2014 04:37 AM, Tony K Nadackal wrote: Hi Jacek, On Wednesday, December 17, 2014 7:46 P

RE: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

2015-01-07 Thread Tony K Nadackal
Dear Jacek, On Wednesday, January 07, 2015 3:15 PM Jacek Anaszewski wrote, > Hi Tony, > > Sorry for late response, just got back from vacation. > > On 12/19/2014 04:37 AM, Tony K Nadackal wrote: > > Hi Jacek, > > > > On Wednesday, December 17, 2014 7:46 PM Jacek Anaszewski wrote, > >> Hi Tony,

Re: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

2015-01-07 Thread Jacek Anaszewski
Hi Tony, Sorry for late response, just got back from vacation. On 12/19/2014 04:37 AM, Tony K Nadackal wrote: Hi Jacek, On Wednesday, December 17, 2014 7:46 PM Jacek Anaszewski wrote, Hi Tony, Thanks for the patches. Thanks for the review. Please process them with scripts/checkpatch.pl

RE: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

2014-12-18 Thread Tony K Nadackal
Hi Jacek, On Wednesday, December 17, 2014 7:46 PM Jacek Anaszewski wrote, > Hi Tony, > > Thanks for the patches. > Thanks for the review. > Please process them with scripts/checkpatch.pl as you will be submitting the next > version - they contain many coding style related issues. > I ran che

Re: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

2014-12-17 Thread Jacek Anaszewski
Hi Tony, Thanks for the patches. Please process them with scripts/checkpatch.pl as you will be submitting the next version - they contain many coding style related issues. My remaining comments below. On 12/17/2014 08:27 AM, Tony K Nadackal wrote: Fimp_jpeg used in Exynos7 is a revised versio

[PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

2014-12-16 Thread Tony K Nadackal
Fimp_jpeg used in Exynos7 is a revised version. Some register configurations are slightly different from Jpeg in Exynos4. Added one more variant SJPEG_EXYNOS7 to handle these differences. Signed-off-by: Tony K Nadackal --- This patch is created and tested on top of linux-next-20141210. It can be