Re: [PATCH] ARM: EXYNOS4: Fix incorrect mapping of gpio pull-up macro to register setting

2011-06-09 Thread Grant Likely
On Thu, Jun 9, 2011 at 4:16 PM, Kukjin Kim wrote: > On 06/07/11 10:10, Grant Likely wrote: >> >> On Tue, Jun 07, 2011 at 05:42:47PM +0900, Kyungmin Park wrote: >>> >>> On Tue, Jun 7, 2011 at 5:34 PM, Thomas Abraham >>>  wrote: > > (snip) > >> Applied, thanks. >> >> g. > > Hi Grant, sorry for late

Re: [PATCH] ARM: EXYNOS4: Fix incorrect mapping of gpio pull-up macro to register setting

2011-06-09 Thread Kukjin Kim
On 06/07/11 10:10, Grant Likely wrote: On Tue, Jun 07, 2011 at 05:42:47PM +0900, Kyungmin Park wrote: On Tue, Jun 7, 2011 at 5:34 PM, Thomas Abraham wrote: (snip) Applied, thanks. g. Hi Grant, sorry for late response. Could you please add my ack on this? Acked-by: Kukjin Kim Signed-

Re: [PATCH] ARM: EXYNOS4: Fix incorrect mapping of gpio pull-up macro to register setting

2011-06-07 Thread Grant Likely
On Tue, Jun 07, 2011 at 05:42:47PM +0900, Kyungmin Park wrote: > On Tue, Jun 7, 2011 at 5:34 PM, Thomas Abraham wrote: > > The S3C_GPIO_PULL_UP macro value incorrectly maps to a reserved setting of > > GPIO > > pull up/down registers on Exynos4 platform. Fix this incorrect mapping by > > adding

Re: [PATCH] ARM: EXYNOS4: Fix incorrect mapping of gpio pull-up macro to register setting

2011-06-07 Thread Kyungmin Park
On Tue, Jun 7, 2011 at 5:34 PM, Thomas Abraham wrote: > The S3C_GPIO_PULL_UP macro value incorrectly maps to a reserved setting of > GPIO > pull up/down registers on Exynos4 platform. Fix this incorrect mapping by > adding > wrappers to the s3c_gpio_setpull_updown and s3c_gpio_getpull_updown fun

[PATCH] ARM: EXYNOS4: Fix incorrect mapping of gpio pull-up macro to register setting

2011-06-07 Thread Thomas Abraham
The S3C_GPIO_PULL_UP macro value incorrectly maps to a reserved setting of GPIO pull up/down registers on Exynos4 platform. Fix this incorrect mapping by adding wrappers to the s3c_gpio_setpull_updown and s3c_gpio_getpull_updown functions. Signed-off-by: Thomas Abraham --- drivers/gpio/gpio-exyn

[PATCH] ARM: EXYNOS4: Fix incorrect mapping of gpio pull-up macro to register setting

2011-05-16 Thread Thomas Abraham
The S3C_GPIO_PULL_UP macro value incorrectly maps to a reserved setting of GPIO pull up/down registers on Exynos4 platform. Fix this incorrect mapping by adding wrappers to the s3c_gpio_setpull_updown and s3c_gpio_getpull_updown functions. Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos4/

[PATCH] ARM: EXYNOS4: Fix incorrect mapping of gpio pull-up macro to register setting

2011-04-12 Thread Thomas Abraham
The S3C_GPIO_PULL_UP macro value incorrectly maps to a reserved setting of GPIO pull up/down registers on Exynos4 platform. Fix this incorrect mapping by adding wrappers to the s3c_gpio_setpull_updown and s3c_gpio_getpull_updown functions. Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos4/