[PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-14 Thread Linus Walleij
When refactoring and breaking out the includes for the machine-specific GPIO configuration, two files were created in , but as that namespace shall be used for defining data exchanged between machines and drivers, using it for these broad macros and config settings is wrong. Move the headers back

Re: [PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-14 Thread Mark Brown
On Tue, Jan 14, 2014 at 02:53:38PM +0100, Linus Walleij wrote: > When refactoring and breaking out the includes for the > machine-specific GPIO configuration, two files were created > in , but as > that namespace shall be used for defining data exchanged > between machines and drivers, using it for

Re: [PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-14 Thread Arnd Bergmann
On Tuesday 14 January 2014 14:53:38 Linus Walleij wrote: > When refactoring and breaking out the includes for the > machine-specific GPIO configuration, two files were created > in , but as > that namespace shall be used for defining data exchanged > between machines and drivers, using it for these

Re: [PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-14 Thread Heiko Stübner
Am Dienstag, 14. Januar 2014, 14:53:38 schrieb Linus Walleij: > When refactoring and breaking out the includes for the > machine-specific GPIO configuration, two files were created > in , but as > that namespace shall be used for defining data exchanged > between machines and drivers, using it for

Re: [PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-15 Thread Tushar Behera
On 14 January 2014 19:23, Linus Walleij wrote: > When refactoring and breaking out the includes for the > machine-specific GPIO configuration, two files were created > in , but as > that namespace shall be used for defining data exchanged > between machines and drivers, using it for these broad ma

Re: [PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-15 Thread Arnd Bergmann
On Wednesday 15 January 2014 14:41:01 Tushar Behera wrote: > > diff --git a/arch/arm/plat-samsung/pm-gpio.c > > b/arch/arm/plat-samsung/pm-gpio.c > > index c4efa1c2a5d1..a9f7a37c4173 100644 > > --- a/arch/arm/plat-samsung/pm-gpio.c > > +++ b/arch/arm/plat-samsung/pm-gpio.c > > @@ -19,12 +19,7 @@ >

Re: [PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-15 Thread Linus Walleij
On Wed, Jan 15, 2014 at 10:43 AM, Arnd Bergmann wrote: > On Wednesday 15 January 2014 14:41:01 Tushar Behera wrote: >> >> This inclusion should be protected by a check for CONFIG_ARCH_S3C24XX >> || CONFIG_ARCH_S3C64XX. Currently generating build errors for >> s5p64x0_defconfig, s5pc100_defconfig a

Re: [PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-15 Thread Linus Walleij
On Wed, Jan 15, 2014 at 10:43 AM, Arnd Bergmann wrote: > On Wednesday 15 January 2014 14:41:01 Tushar Behera wrote: >> > diff --git a/arch/arm/plat-samsung/pm-gpio.c >> > b/arch/arm/plat-samsung/pm-gpio.c >> > index c4efa1c2a5d1..a9f7a37c4173 100644 >> > --- a/arch/arm/plat-samsung/pm-gpio.c >> >

Re: [PATCH] ARM: S3C[24|64]xx: move includes back under scope

2014-01-15 Thread Arnd Bergmann
On Wednesday 15 January 2014, Linus Walleij wrote: > When I look at it, the issue also exist in e.g. > drivers/gpio/gpio-samsung.c which can be compiled > (like for allyesconfig) when PLAT_SAMSUNG is set. > > And it is also set to y for ARCH_EXYNOS... which > doesn't have any custom GPIO header. S