RE: [PATCH] ARM: S5PC100: Cleanup the GPIOlib code

Kyungmin Park wrote: > > Hi, > Hi, > There's some comments. > At least the s5p series use the same .config = &gpio_cfg, so move it > to common code and then can delete it at each SOC gpiolib. > Hmm..ok..will consider it later. > Please also check the other team how modified it since there's so

Re: [PATCH] ARM: S5PC100: Cleanup the GPIOlib code

Hi, There's some comments. At least the s5p series use the same .config = &gpio_cfg, so move it to common code and then can delete it at each SOC gpiolib. Please also check the other team how modified it since there's some comments from G "why do you set each config at for loop. just put it at e

[PATCH] ARM: S5PC100: Cleanup the GPIOlib code

This patch clean up the GPIO code and removes useless GPIO addresses. It can be calculated with offset, the 'base' member of s3c_gpio_chip is also initialized in the init function. Signed-off-by: Kukjin Kim --- arch/arm/mach-s5pc100/gpiolib.c| 172 ++-- arch/