RE: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-22 Thread Kukjin Kim
kyungmi...@gmail.com wrote: > > 2011/6/10 Kukjin Kim : > > On 06/07/11 15:36, Russell King - ARM Linux wrote: > >> I see no effort from the Samsung folk to even start considering moving > >> to common APIs - I see precisely the opposite.  They seem to have a > >> strong desire to invent their own

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-16 Thread Kyungmin Park
2011/6/10 Kukjin Kim : > On 06/07/11 15:36, Russell King - ARM Linux wrote: >> I see no effort from the Samsung folk to even start considering moving >> to common APIs - I see precisely the opposite.  They seem to have a >> strong desire to invent their own new APIs all the time rather than >> look

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-09 Thread Kukjin Kim
On 06/07/11 15:36, Russell King - ARM Linux wrote: > I see no effort from the Samsung folk to even start considering moving > to common APIs - I see precisely the opposite. They seem to have a > strong desire to invent their own new APIs all the time rather than > look at existing APIs and discuss

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-08 Thread Mark Brown
On Wed, Jun 08, 2011 at 08:21:08AM +0530, Jassi Brar wrote: > On Wed, Jun 8, 2011 at 3:11 AM, Mark Brown > > That's fairly unusual, though - usually DMA controllers seem to support > > chaining requests before they support circular operation, at which point > > unless the hardware is badly misdone

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-08 Thread Russell King - ARM Linux
On Wed, Jun 08, 2011 at 09:35:34AM +0530, Jassi Brar wrote: > In real life, I saw that with the Samsung's SPDIF controller which has > fifo depth only for a few samples and it gets very demanding if pro > quality is expected. Aggravate that with high irq-latency under system > load. > And in such c

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Wed, Jun 8, 2011 at 3:58 AM, Russell King - ARM Linux wrote: >> > >> >> 2. Circular buffer support has been added - see device_prep_dma_cyclic(). >> > >> >> However, 2 is not really a requirement for audio - you can queue several >> >> single slave transfers (one per period) initially, and then

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Wed, Jun 8, 2011 at 3:11 AM, Mark Brown wrote: > On Wed, Jun 08, 2011 at 12:31:42AM +0530, Jassi Brar wrote: >> On Wed, Jun 8, 2011 at 12:13 AM, Mark Brown > >> > Circular buffers are nice from the point of view of allowing you to >> > (providing the hardware supports it) totally disable the pe

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Russell King - ARM Linux
On Wed, Jun 08, 2011 at 01:16:40AM +0530, Jassi Brar wrote: > IMHO Samsung SoC team (not his majesty Mr Kyungmin Park) are justified > if they are not so eager right now. Since I no more would have to spend > sleepless nights over > SPDIF underruns, I can side with what Kukjin Kim(Samsung maintaine

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Russell King - ARM Linux
On Wed, Jun 08, 2011 at 12:31:42AM +0530, Jassi Brar wrote: > On Wed, Jun 8, 2011 at 12:13 AM, Mark Brown > wrote: > > On Tue, Jun 07, 2011 at 07:29:23PM +0100, Russell King - ARM Linux wrote: > > > >> 2. Circular buffer support has been added - see device_prep_dma_cyclic(). > > > >> However, 2 is

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Mark Brown
On Wed, Jun 08, 2011 at 12:31:42AM +0530, Jassi Brar wrote: > On Wed, Jun 8, 2011 at 12:13 AM, Mark Brown > > Circular buffers are nice from the point of view of allowing you to > > (providing the hardware supports it) totally disable the periodic audio > > interrupts and leave the system to run f

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 11:59 PM, Russell King - ARM Linux wrote: >> The discussion did take off a few months ago, but we didn't reach anywhere. >> Being able to queue request from the 'done' callback, the need of >> circular buffer >> API (possibly a free-running one too) and callbacks in irq-cont

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Wed, Jun 8, 2011 at 12:13 AM, Mark Brown wrote: > On Tue, Jun 07, 2011 at 07:29:23PM +0100, Russell King - ARM Linux wrote: > >> 2. Circular buffer support has been added - see device_prep_dma_cyclic(). > >> However, 2 is not really a requirement for audio - you can queue several >> single slav

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Mark Brown
On Tue, Jun 07, 2011 at 07:29:23PM +0100, Russell King - ARM Linux wrote: > 2. Circular buffer support has been added - see device_prep_dma_cyclic(). > However, 2 is not really a requirement for audio - you can queue several > single slave transfers (one per period) initially, and then you get >

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Russell King - ARM Linux
On Tue, Jun 07, 2011 at 03:45:18PM +0530, Jassi Brar wrote: > On Tue, Jun 7, 2011 at 1:45 PM, Russell King - ARM Linux > wrote: > > On Tue, Jun 07, 2011 at 01:39:43PM +0530, Jassi Brar wrote: > >> Unfortunately, no. There are some features of Samsung's DMA API that > >> the drivers have come to re

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Tushar Behera
Hi Alim, On 7 June 2011 13:18, root wrote: > Signed-off-by: alim.akhtar > --- >  arch/arm/configs/exynos4_defconfig |    1 + >  arch/arm/configs/s5p64x0_defconfig |    1 + >  arch/arm/configs/s5pc100_defconfig |    1 + >  arch/arm/configs/s5pv210_defconfig |    1 + >  arch/arm/plat-samsung/Kconf

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Koul, Vinod
On Tue, 2011-06-07 at 15:45 +0530, Linus Walleij wrote: > On Tue, Jun 7, 2011 at 10:09 AM, Jassi Brar wrote: > > > There are some features of Samsung's DMA API that > > the drivers have come to rely upon. > > Can we get an overview of what these features are? > > When I look at this specific co

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Linus Walleij
On Tue, Jun 7, 2011 at 10:09 AM, Jassi Brar wrote: > There are some features of Samsung's DMA API that > the drivers have come to rely upon. Can we get an overview of what these features are? When I look at this specific code I cannot see anything that the dmaengine does not already support or

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 1:45 PM, Russell King - ARM Linux wrote: > On Tue, Jun 07, 2011 at 01:39:43PM +0530, Jassi Brar wrote: >> Unfortunately, no. There are some features of Samsung's DMA API that >> the drivers have come to rely upon. >> Besides, I am not particularly a fan of the generic API. A

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Kyungmin Park
On Tue, Jun 7, 2011 at 5:15 PM, Russell King - ARM Linux wrote: > On Tue, Jun 07, 2011 at 01:39:43PM +0530, Jassi Brar wrote: >> Unfortunately, no. There are some features of Samsung's DMA API that >> the drivers have come to rely upon. >> Besides, I am not particularly a fan of the generic API. A

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Russell King - ARM Linux
On Tue, Jun 07, 2011 at 01:39:43PM +0530, Jassi Brar wrote: > Unfortunately, no. There are some features of Samsung's DMA API that > the drivers have come to rely upon. > Besides, I am not particularly a fan of the generic API. And IIRC, > neither is Ben Dooks, the designer of the > Samsung's DMA A

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 1:30 PM, Kyungmin Park wrote: > > As I know there's are PL330 DMA implementation by > MODULE_AUTHOR("Jaswinder Singh "); Thanks for CC'ing me, though my current contact is jaswinder.si...@linaro.org or jassisinghb...@gmail.com Perhaps I need to change the email in all locati

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 1:18 PM, root wrote: > Signed-off-by: alim.akhtar > --- >  arch/arm/configs/exynos4_defconfig |    1 + >  arch/arm/configs/s5p64x0_defconfig |    1 + >  arch/arm/configs/s5pc100_defconfig |    1 + >  arch/arm/configs/s5pv210_defconfig |    1 + >  arch/arm/plat-samsung/Kconf