[PATCH] backlight: add regulator support for platform_lcd driver

2011-12-05 Thread Thomas Abraham
The power source to the lcd panel or the lcd interface such as lvds transmitters could be controlled by a regulator supply. Add support for enabling/disabling the regulator when switching power to lcd. Two new elements 'min_uV' and 'max_uV' in the platform data are added to allow platform code to

Re: [PATCH] backlight: add regulator support for platform_lcd driver

2011-12-05 Thread Felipe Balbi
Hi, On Mon, Dec 05, 2011 at 02:18:41PM +0530, Thomas Abraham wrote: The power source to the lcd panel or the lcd interface such as lvds transmitters could be controlled by a regulator supply. Add support for enabling/disabling the regulator when switching power to lcd. Two new elements

Re: [PATCH] backlight: add regulator support for platform_lcd driver

2011-12-05 Thread Thomas Abraham
Hi Felipe, On 5 December 2011 14:22, Felipe Balbi ba...@ti.com wrote: [...] +     if (lcd_power) { +             if (plcd-pdata-min_uV || plcd-pdata-max_uV) +                     if (regulator_set_voltage(lcd_regulator, +                             plcd-pdata-min_uV, plcd-pdata-max_uV)) +

Re: [PATCH] backlight: add regulator support for platform_lcd driver

2011-12-05 Thread Kyungmin Park
On 12/5/11, Thomas Abraham thomas.abra...@linaro.org wrote: The power source to the lcd panel or the lcd interface such as lvds transmitters could be controlled by a regulator supply. Add support for enabling/disabling the regulator when switching power to lcd. Two new elements 'min_uV' and

Re: [PATCH] backlight: add regulator support for platform_lcd driver

2011-12-05 Thread Mark Brown
On Mon, Dec 05, 2011 at 07:10:03PM +0900, Kyungmin Park wrote: + if (plcd-pdata-min_uV || plcd-pdata-max_uV) + if (regulator_set_voltage(lcd_regulator, + plcd-pdata-min_uV, plcd-pdata-max_uV)) +

Re: [PATCH] backlight: add regulator support for platform_lcd driver

2011-12-05 Thread Thomas Abraham
Dear Mr. Park, On 5 December 2011 15:40, Kyungmin Park kmp...@infradead.org wrote: [...] +     /* +      * If power to lcd and/or lcd interface is controlled using a regulator, +      * enable or disable the regulator based in the power setting. +      */ +     lcd_regulator =

Re: [PATCH] backlight: add regulator support for platform_lcd driver

2011-12-05 Thread Mark Brown
On Mon, Dec 05, 2011 at 04:06:17PM +0530, Thomas Abraham wrote: On 5 December 2011 15:40, Kyungmin Park kmp...@infradead.org wrote: Recent regulator discussion. it should be failed instead fall through gracefully. Ok. But in this case, there could be boards that do not use a regulator for