Re: [PATCH 06/10] thermal: exynos: remove redundant threshold_code checks from exynos_tmu_initialize()

2014-05-18 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > Remove runtime checks for negative return values of temp_to_code() > from exynos_tmu_initialize(). The current level temperature data > hardcoded in pdata will never cause a negative temp_to_code() > return values and for the new code potential mistak

Re: [PATCH 06/10] thermal: exynos: remove redundant threshold_code checks from exynos_tmu_initialize()

2014-05-15 Thread Bartlomiej Zolnierkiewicz
On Thursday, May 15, 2014 10:55:52 AM Eduardo Valentin wrote: > Hello Bartlomiej, Hi, > On Mon, May 05, 2014 at 01:15:35PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Remove runtime checks for negative return values of temp_to_code() > > from exynos_tmu_initialize(). The current level temperatur

Re: [PATCH 06/10] thermal: exynos: remove redundant threshold_code checks from exynos_tmu_initialize()

2014-05-15 Thread Eduardo Valentin
Hello Bartlomiej, On Mon, May 05, 2014 at 01:15:35PM +0200, Bartlomiej Zolnierkiewicz wrote: > Remove runtime checks for negative return values of temp_to_code() > from exynos_tmu_initialize(). The current level temperature data > hardcoded in pdata will never cause a negative temp_to_code() > re

[PATCH 06/10] thermal: exynos: remove redundant threshold_code checks from exynos_tmu_initialize()

2014-05-05 Thread Bartlomiej Zolnierkiewicz
Remove runtime checks for negative return values of temp_to_code() from exynos_tmu_initialize(). The current level temperature data hardcoded in pdata will never cause a negative temp_to_code() return values and for the new code potential mistakes should be caught during development/review phases.