RE: [PATCH 1/2] ARM: EXYNOS: add support GPIO for EXYNOS5250

2012-02-09 Thread Kukjin Kim
Grant Likely wrote: On Tue, Jan 31, 2012 at 10:40:43PM +, Russell King - ARM Linux wrote: On Wed, Feb 01, 2012 at 12:50:39AM +0900, Kukjin Kim wrote: From: Sangsu Park sangsu4u.p...@samsung.com This patch adds follwing. - IO-map for EXYNOS5250 GPIO support - EXYNOS5250 GPIO

RE: [PATCH 1/2] ARM: EXYNOS: add support GPIO for EXYNOS5250

2012-02-09 Thread Kukjin Kim
Kyungmin Park wrote: On 2/1/12, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Feb 01, 2012 at 12:50:39AM +0900, Kukjin Kim wrote: From: Sangsu Park sangsu4u.p...@samsung.com This patch adds follwing. - IO-map for EXYNOS5250 GPIO support - EXYNOS5250 GPIO bank

Re: [PATCH 1/2] ARM: EXYNOS: add support GPIO for EXYNOS5250

2012-02-04 Thread Sylwester Nawrocki
On 02/02/2012 07:22 PM, Grant Likely wrote: /* the end of the EXYNOS4 specific gpios */ #define EXYNOS4_GPIO_END (EXYNOS4_GPZ(EXYNOS4_GPIO_Z_NR) + 1) -#define S3C_GPIO_END EXYNOS4_GPIO_END -/* define the number of gpios we need to the one after the GPZ() range */ -#define

[PATCH 1/2] ARM: EXYNOS: add support GPIO for EXYNOS5250

2012-01-31 Thread Kukjin Kim
From: Sangsu Park sangsu4u.p...@samsung.com This patch adds follwing. - IO-map for EXYNOS5250 GPIO support - EXYNOS5250 GPIO bank size/number definitions - memory map definition for S5P GPIO4 Signed-off-by: Sangsu Park sangsu4u.p...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com ---

Re: [PATCH 1/2] ARM: EXYNOS: add support GPIO for EXYNOS5250

2012-01-31 Thread Sylwester Nawrocki
Hi Kukjin, I have few comments below... On 01/31/2012 04:50 PM, Kukjin Kim wrote: From: Sangsu Park sangsu4u.p...@samsung.com This patch adds follwing. s/follwing/following. nit: AFAIK it's a good habit not to start a commit description with This patch.. - IO-map for EXYNOS5250 GPIO

Re: [PATCH 1/2] ARM: EXYNOS: add support GPIO for EXYNOS5250

2012-01-31 Thread Russell King - ARM Linux
On Wed, Feb 01, 2012 at 12:50:39AM +0900, Kukjin Kim wrote: From: Sangsu Park sangsu4u.p...@samsung.com This patch adds follwing. - IO-map for EXYNOS5250 GPIO support - EXYNOS5250 GPIO bank size/number definitions - memory map definition for S5P GPIO4 Signed-off-by: Sangsu Park

Re: [PATCH 1/2] ARM: EXYNOS: add support GPIO for EXYNOS5250

2012-01-31 Thread Kyungmin Park
On 2/1/12, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Feb 01, 2012 at 12:50:39AM +0900, Kukjin Kim wrote: From: Sangsu Park sangsu4u.p...@samsung.com This patch adds follwing. - IO-map for EXYNOS5250 GPIO support - EXYNOS5250 GPIO bank size/number definitions - memory