Re: [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove

2011-12-08 Thread Jassi Brar
On 9 December 2011 08:49, Tushar Behera wrote: > On 12/08/2011 07:02 PM, Jassi Brar wrote: >> >> Guys, any reason to keep me, the author of the driver, out of loop ? >> I almost lost this patch, had it not for chance. > > > Apologies. I didn't realize that I should be adding a cc to you. > > Would

Re: [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove

2011-12-08 Thread Tushar Behera
On 12/08/2011 07:02 PM, Jassi Brar wrote: Guys, any reason to keep me, the author of the driver, out of loop ? I almost lost this patch, had it not for chance. Apologies. I didn't realize that I should be adding a cc to you. Would you please add a valid module author e-mail ID? -- Tushar Behe

Re: [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove

2011-12-08 Thread Jassi Brar
On 8 December 2011 13:46, Vinod Koul wrote: > On Thu, 2011-12-08 at 16:43 +0900, Kukjin Kim wrote: >> Vinod Koul wrote: >> > >> > On Tue, 2011-12-06 at 16:15 +0530, Tushar Behera wrote: >> > > amba_probe() now calls pm_runtime_get_noresume() and pm_runtime_enable() >> > > for the devices before th

RE: [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove

2011-12-08 Thread Vinod Koul
On Thu, 2011-12-08 at 16:43 +0900, Kukjin Kim wrote: > Vinod Koul wrote: > > > > On Tue, 2011-12-06 at 16:15 +0530, Tushar Behera wrote: > > > amba_probe() now calls pm_runtime_get_noresume() and pm_runtime_enable() > > > for the devices before the device probe is called. Hence we don't need > > >

RE: [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove

2011-12-07 Thread Kukjin Kim
Vinod Koul wrote: > > On Tue, 2011-12-06 at 16:15 +0530, Tushar Behera wrote: > > amba_probe() now calls pm_runtime_get_noresume() and pm_runtime_enable() > > for the devices before the device probe is called. Hence we don't need > > to call pm_runtime_get_xxx and pm_runtime_enable() in device pro

Re: [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove

2011-12-07 Thread Vinod Koul
On Tue, 2011-12-06 at 16:15 +0530, Tushar Behera wrote: > amba_probe() now calls pm_runtime_get_noresume() and pm_runtime_enable() > for the devices before the device probe is called. Hence we don't need > to call pm_runtime_get_xxx and pm_runtime_enable() in device probe again. > In the same way,

[PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove

2011-12-06 Thread Tushar Behera
amba_probe() now calls pm_runtime_get_noresume() and pm_runtime_enable() for the devices before the device probe is called. Hence we don't need to call pm_runtime_get_xxx and pm_runtime_enable() in device probe again. In the same way, since amba_remove() calls the respective pm_runtime functions, t