Re: [PATCH 1/2] regulator: max77686: Implement suspend disable for some LDOs

2014-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/21/2014 11:36 AM, Krzysztof Kozlowski wrote: > On wto, 2014-10-21 at 11:10 +0200, Javier Martinez Canillas wrote: >> >> In general, could you please take a look to the latest patches I posted for >> the >> max77802? They are in a topic branch in Mark's regulator tree [1].

Re: [PATCH 1/2] regulator: max77686: Implement suspend disable for some LDOs

2014-10-21 Thread Krzysztof Kozlowski
On wto, 2014-10-21 at 11:10 +0200, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 10/21/2014 10:25 AM, Krzysztof Kozlowski wrote: > > Some LDOs of Maxim 77686 PMIC support disabling during system suspend > > (LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part > > You

Re: [PATCH 1/2] regulator: max77686: Implement suspend disable for some LDOs

2014-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/21/2014 10:25 AM, Krzysztof Kozlowski wrote: > Some LDOs of Maxim 77686 PMIC support disabling during system suspend > (LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part You should also document what each regulator support in the max77686 DT binding doc,

[PATCH 1/2] regulator: max77686: Implement suspend disable for some LDOs

2014-10-21 Thread Krzysztof Kozlowski
Some LDOs of Maxim 77686 PMIC support disabling during system suspend (LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part of set_suspend_mode function. In that case the mode was one of: - disable, - normal mode, - low power mode. However there are no bindings for setting the m