Re: [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-11 Thread Tomasz Figa
On 11.06.2014 20:23, Naveen Krishna Ch wrote: > Hello Tomasz, > > On 11 June 2014 23:20, Tomasz Figa wrote: >> On 11.06.2014 19:27, Javier Martinez Canillas wrote: >>> On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote: On 11 June 2014 16:43, Javier Martinez Canillas wrote: > On 06/11

Re: [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-11 Thread Mark Brown
On Wed, Jun 11, 2014 at 11:53:30PM +0530, Naveen Krishna Ch wrote: > On 11 June 2014 23:20, Tomasz Figa wrote: > > - in DT case, don't do anything in the driver about the GPIO chip > > select, because it will be handled automatically by the core. > But, i see that gpio_request_one is needed in _

Re: [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-11 Thread Naveen Krishna Ch
Hello Tomasz, On 11 June 2014 23:20, Tomasz Figa wrote: > On 11.06.2014 19:27, Javier Martinez Canillas wrote: >> On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote: >>> On 11 June 2014 16:43, Javier Martinez Canillas >>> wrote: On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote: > > [snip

Re: [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-11 Thread Javier Martinez Canillas
Hello Tomasz, On 06/11/2014 07:50 PM, Tomasz Figa wrote: > On 11.06.2014 19:27, Javier Martinez Canillas wrote: >> On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote: >>> On 11 June 2014 16:43, Javier Martinez Canillas >>> wrote: On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote: > > [sni

Re: [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-11 Thread Tomasz Figa
On 11.06.2014 19:27, Javier Martinez Canillas wrote: > On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote: >> On 11 June 2014 16:43, Javier Martinez Canillas >> wrote: >>> On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote: [snip] >>> return ERR_PTR(-EINVAL); } >>>

Re: [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-11 Thread Javier Martinez Canillas
Hello Naveen, On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote: > Hello Javier, > > On 11 June 2014 16:43, Javier Martinez Canillas > wrote: >> Hello Naveen, >> >> Thanks a lot for your patches and sorry that I didn't review your prior two >> versions but I didn't have the time yesterday. >> >> O

Re: [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-11 Thread Naveen Krishna Ch
Hello Javier, On 11 June 2014 16:43, Javier Martinez Canillas wrote: > Hello Naveen, > > Thanks a lot for your patches and sorry that I didn't review your prior two > versions but I didn't have the time yesterday. > > On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote: >> Currently, spi-s3c64

Re: [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-11 Thread Javier Martinez Canillas
Hello Naveen, Thanks a lot for your patches and sorry that I didn't review your prior two versions but I didn't have the time yesterday. On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote: > Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be > defined under "controller-data" node

[PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Naveen Krishna Chatradhi
Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be defined under "controller-data" node under each slave node. &spi_x { cs-gpios <>; ... slave_node { controller-data { cs-gpio = <>; ...