Re: [PATCH 11/11] ARM: S5P6440: Remove redundant defines

2010-05-13 Thread Ben Dooks
On Thu, May 13, 2010 at 10:06:08AM +0100, Russell King - ARM Linux wrote: > On Thu, May 13, 2010 at 01:54:12PM +0900, Kyungmin Park wrote: > > On Thu, May 13, 2010 at 11:02 AM, Ben Dooks wrote: > > > 1) It takes two lines of code, where one is sufficient. > > > > > > 2) You only have to look in th

Re: [PATCH 11/11] ARM: S5P6440: Remove redundant defines

2010-05-13 Thread Ben Dooks
On Thu, May 13, 2010 at 10:06:08AM +0100, Russell King - ARM Linux wrote: > On Thu, May 13, 2010 at 01:54:12PM +0900, Kyungmin Park wrote: > > On Thu, May 13, 2010 at 11:02 AM, Ben Dooks wrote: > > > 1) It takes two lines of code, where one is sufficient. > > > > > > 2) You only have to look in th

Re: [PATCH 11/11] ARM: S5P6440: Remove redundant defines

2010-05-13 Thread Russell King - ARM Linux
On Thu, May 13, 2010 at 01:54:12PM +0900, Kyungmin Park wrote: > On Thu, May 13, 2010 at 11:02 AM, Ben Dooks wrote: > > 1) It takes two lines of code, where one is sufficient. > > > > 2) You only have to look in the relevant .c file to find out the > >   value instead of tracking down a header. Th

Re: [PATCH 11/11] ARM: S5P6440: Remove redundant defines

2010-05-12 Thread Kyungmin Park
On Thu, May 13, 2010 at 11:02 AM, Ben Dooks wrote: > On Thu, May 13, 2010 at 10:49:29AM +0900, Jassi Brar wrote: >> On Thu, May 13, 2010 at 9:28 AM, Kukjin Kim wrote: >> > From: Thomas Abraham >> > --- a/arch/arm/mach-s5p6440/clock.c >> > +++ b/arch/arm/mach-s5p6440/clock.c >> > @@ -357,121 +357

Re: [PATCH 11/11] ARM: S5P6440: Remove redundant defines

2010-05-12 Thread Ben Dooks
On Thu, May 13, 2010 at 10:49:29AM +0900, Jassi Brar wrote: > On Thu, May 13, 2010 at 9:28 AM, Kukjin Kim wrote: > > From: Thomas Abraham > > --- a/arch/arm/mach-s5p6440/clock.c > > +++ b/arch/arm/mach-s5p6440/clock.c > > @@ -357,121 +357,121 @@ static struct clk init_clocks_disable[] = { > >    

Re: [PATCH 11/11] ARM: S5P6440: Remove redundant defines

2010-05-12 Thread Jassi Brar
On Thu, May 13, 2010 at 9:28 AM, Kukjin Kim wrote: > From: Thomas Abraham > --- a/arch/arm/mach-s5p6440/clock.c > +++ b/arch/arm/mach-s5p6440/clock.c > @@ -357,121 +357,121 @@ static struct clk init_clocks_disable[] = { >                .id             = -1, >                .parent         = &cl

[PATCH 11/11] ARM: S5P6440: Remove redundant defines

2010-05-12 Thread Kukjin Kim
From: Thomas Abraham Remove redundant defines in the clock code. Signed-off-by: Thomas Abraham Signed-off-by: Kukjin Kim --- arch/arm/mach-s5p6440/clock.c | 62 +++--- arch/arm/mach-s5p6440/include/mach/regs-clock.h | 49 -- 2 files change