Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-09-03 Thread Naveen Krishna Ch
Hi Olof, On 28 August 2014 09:26, Olof Johansson wrote: > Hi, > > On Wed, Aug 27, 2014 at 03:14:18PM +0530, Naveen Krishna Chatradhi wrote: >> Add initial device tree nodes for EXYNOS7 SoC. >> Also, includes the dt-binding definitions for clock ids. > > Uh, no -- it just adds the dtsi. Ok. Will

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-09-03 Thread Naveen Krishna Ch
Hi Tomasz, On 27 August 2014 17:00, Tomasz Figa wrote: > Hi Naveen, > > Please see my comments inline. > > On 27.08.2014 11:44, Naveen Krishna Chatradhi wrote: >> Add initial device tree nodes for EXYNOS7 SoC. >> Also, includes the dt-binding definitions for clock ids. >> >> Signed-off-by: Naveen

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-09-03 Thread Naveen Krishna Ch
Hi Mark, On 27 August 2014 16:12, Mark Rutland wrote: > Hi Naveen, > > On Wed, Aug 27, 2014 at 10:44:18AM +0100, Naveen Krishna Chatradhi wrote: >> Add initial device tree nodes for EXYNOS7 SoC. >> Also, includes the dt-binding definitions for clock ids. > > Fallout from a rebase? That latter par

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Simon Horman
On Thu, Aug 28, 2014 at 03:23:49PM -0700, Olof Johansson wrote: > On Thu, Aug 28, 2014 at 10:54 AM, Rob Herring wrote: > > On Thu, Aug 28, 2014 at 12:19 PM, Olof Johansson wrote: > >> On Thu, Aug 28, 2014 at 10:03 AM, Mark Rutland > >> wrote: > >>> On Thu, Aug 28, 2014 at 05:28:22PM +0100, Olof

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Olof Johansson
On Thu, Aug 28, 2014 at 10:54 AM, Rob Herring wrote: > On Thu, Aug 28, 2014 at 12:19 PM, Olof Johansson wrote: >> On Thu, Aug 28, 2014 at 10:03 AM, Mark Rutland wrote: >>> On Thu, Aug 28, 2014 at 05:28:22PM +0100, Olof Johansson wrote: On Thu, Aug 28, 2014 at 2:48 AM, Mark Rutland wrote: >

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:47:00PM +0100, Geert Uytterhoeven wrote: > Hi Mark, > > On Thu, Aug 28, 2014 at 7:39 PM, Mark Rutland wrote: > >> >> Ok. If address-cells is kept at 2 the unit address needs to be changed > >> >> to "0,0". So one or the other has to be changed. > >> > > >> > I'm happy e

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Rob Herring
On Thu, Aug 28, 2014 at 12:19 PM, Olof Johansson wrote: > On Thu, Aug 28, 2014 at 10:03 AM, Mark Rutland wrote: >> On Thu, Aug 28, 2014 at 05:28:22PM +0100, Olof Johansson wrote: >>> On Thu, Aug 28, 2014 at 2:48 AM, Mark Rutland wrote: >>> > Hi, >>> > >>> >> > + cpus { >>> >> > + #ad

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Geert Uytterhoeven
Hi Mark, On Thu, Aug 28, 2014 at 7:39 PM, Mark Rutland wrote: >> >> Ok. If address-cells is kept at 2 the unit address needs to be changed >> >> to "0,0". So one or the other has to be changed. >> > >> > I'm happy either way. >> > >> > I'm not sure the rest of the tree had "0," prefixes on all of

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:37:19PM +0100, Marc Zyngier wrote: > On 28/08/14 18:30, Mark Rutland wrote: > > On Thu, Aug 28, 2014 at 06:27:04PM +0100, Marc Zyngier wrote: > >> On 28/08/14 18:03, Mark Rutland wrote: > >> > >>> From 67104ad5a56e4c18f9c41f06af028b7561740afd Mon Sep 17 00:00:00 2001 > >>

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:33:13PM +0100, Rob Herring wrote: > On Thu, Aug 28, 2014 at 12:27 PM, Marc Zyngier wrote: > > On 28/08/14 18:03, Mark Rutland wrote: > > > >> From 67104ad5a56e4c18f9c41f06af028b7561740afd Mon Sep 17 00:00:00 2001 > >> From: Mark Rutland > >> Date: Thu, 28 Aug 2014 17:41

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:19:00PM +0100, Olof Johansson wrote: > On Thu, Aug 28, 2014 at 10:03 AM, Mark Rutland wrote: > > On Thu, Aug 28, 2014 at 05:28:22PM +0100, Olof Johansson wrote: > >> On Thu, Aug 28, 2014 at 2:48 AM, Mark Rutland wrote: > >> > Hi, > >> > > >> >> > + cpus { > >> >> > +

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Marc Zyngier
On 28/08/14 18:30, Mark Rutland wrote: > On Thu, Aug 28, 2014 at 06:27:04PM +0100, Marc Zyngier wrote: >> On 28/08/14 18:03, Mark Rutland wrote: >> >>> From 67104ad5a56e4c18f9c41f06af028b7561740afd Mon Sep 17 00:00:00 2001 >>> From: Mark Rutland >>> Date: Thu, 28 Aug 2014 17:41:03 +0100 >>> Subjec

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Rob Herring
On Thu, Aug 28, 2014 at 12:27 PM, Marc Zyngier wrote: > On 28/08/14 18:03, Mark Rutland wrote: > >> From 67104ad5a56e4c18f9c41f06af028b7561740afd Mon Sep 17 00:00:00 2001 >> From: Mark Rutland >> Date: Thu, 28 Aug 2014 17:41:03 +0100 >> Subject: [PATCH] Doc: dt: arch_timer: discourage clock-frequ

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 06:27:04PM +0100, Marc Zyngier wrote: > On 28/08/14 18:03, Mark Rutland wrote: > > > From 67104ad5a56e4c18f9c41f06af028b7561740afd Mon Sep 17 00:00:00 2001 > > From: Mark Rutland > > Date: Thu, 28 Aug 2014 17:41:03 +0100 > > Subject: [PATCH] Doc: dt: arch_timer: discourage

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Marc Zyngier
On 28/08/14 18:03, Mark Rutland wrote: > From 67104ad5a56e4c18f9c41f06af028b7561740afd Mon Sep 17 00:00:00 2001 > From: Mark Rutland > Date: Thu, 28 Aug 2014 17:41:03 +0100 > Subject: [PATCH] Doc: dt: arch_timer: discourage clock-frequency use > > The ARM Generic Timer (AKA the architected timer

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Olof Johansson
On Thu, Aug 28, 2014 at 10:03 AM, Mark Rutland wrote: > On Thu, Aug 28, 2014 at 05:28:22PM +0100, Olof Johansson wrote: >> On Thu, Aug 28, 2014 at 2:48 AM, Mark Rutland wrote: >> > Hi, >> > >> >> > + cpus { >> >> > + #address-cells = <2>; >> >> > + #size-cells = <0>; >> >> >

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 05:28:22PM +0100, Olof Johansson wrote: > On Thu, Aug 28, 2014 at 2:48 AM, Mark Rutland wrote: > > Hi, > > > >> > + cpus { > >> > + #address-cells = <2>; > >> > + #size-cells = <0>; > >> > >> Why size-cells=2? Can you not fit a cpuid in 32 bits? > > >

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Olof Johansson
On Thu, Aug 28, 2014 at 2:48 AM, Mark Rutland wrote: > Hi, > >> > + cpus { >> > + #address-cells = <2>; >> > + #size-cells = <0>; >> >> Why size-cells=2? Can you not fit a cpuid in 32 bits? > > As of commit 72aea393a2e7 (arm64: smp: honour #address-size when parsing > CPU reg

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Mark Rutland
Hi, > > + cpus { > > + #address-cells = <2>; > > + #size-cells = <0>; > > Why size-cells=2? Can you not fit a cpuid in 32 bits? As of commit 72aea393a2e7 (arm64: smp: honour #address-size when parsing CPU reg property) Linux can handle single-cell cpu node reg entries where

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-28 Thread Marc Zyngier
On 28/08/14 04:56, Olof Johansson wrote: > Hi, > > On Wed, Aug 27, 2014 at 03:14:18PM +0530, Naveen Krishna Chatradhi wrote: >> Add initial device tree nodes for EXYNOS7 SoC. >> Also, includes the dt-binding definitions for clock ids. > > Uh, no -- it just adds the dtsi. > >> Signed-off-by: Nave

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-27 Thread Olof Johansson
Hi, On Wed, Aug 27, 2014 at 03:14:18PM +0530, Naveen Krishna Chatradhi wrote: > Add initial device tree nodes for EXYNOS7 SoC. > Also, includes the dt-binding definitions for clock ids. Uh, no -- it just adds the dtsi. > Signed-off-by: Naveen Krishna Chatradhi > Cc: Thomas Abraham > Cc: Rob He

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-27 Thread Catalin Marinas
On Wed, Aug 27, 2014 at 11:42:31AM +0100, Mark Rutland wrote: > On Wed, Aug 27, 2014 at 10:44:18AM +0100, Naveen Krishna Chatradhi wrote: > > + cpus { > > + #address-cells = <2>; > > + #size-cells = <0>; > > + > > + cpu@0 { > > +

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-27 Thread Tomasz Figa
Hi Naveen, Please see my comments inline. On 27.08.2014 11:44, Naveen Krishna Chatradhi wrote: > Add initial device tree nodes for EXYNOS7 SoC. > Also, includes the dt-binding definitions for clock ids. > > Signed-off-by: Naveen Krishna Chatradhi > Cc: Thomas Abraham > Cc: Rob Herring > Cc: C

Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-27 Thread Mark Rutland
Hi Naveen, On Wed, Aug 27, 2014 at 10:44:18AM +0100, Naveen Krishna Chatradhi wrote: > Add initial device tree nodes for EXYNOS7 SoC. > Also, includes the dt-binding definitions for clock ids. Fallout from a rebase? That latter part doesn't seem to be relevant. > Signed-off-by: Naveen Krishna Ch

[PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7

2014-08-27 Thread Naveen Krishna Chatradhi
Add initial device tree nodes for EXYNOS7 SoC. Also, includes the dt-binding definitions for clock ids. Signed-off-by: Naveen Krishna Chatradhi Cc: Thomas Abraham Cc: Rob Herring Cc: Catalin Marinas --- arch/arm64/boot/dts/exynos7.dtsi | 553 ++ 1 file cha