Re: [PATCH 2/2] driver: ata: add new Exynos5250 SATA PHY controller driver

2013-02-06 Thread Vasanth Ananthan
Hi Tomasz, On Tue, Feb 5, 2013 at 7:53 PM, Tomasz Figa wrote: > > Hi Vasanth, > > Please see my comments inline. They are basically related to the same > issues as I pointed in previous version of this patch. > > On Tuesday 29 of January 2013 20:49:18 Vasanth Ananthan wrote: > > Adding platform d

Re: [PATCH 2/2] driver: ata: add new Exynos5250 SATA PHY controller driver

2013-02-05 Thread Tomasz Figa
Hi Vasanth, Please see my comments inline. They are basically related to the same issues as I pointed in previous version of this patch. On Tuesday 29 of January 2013 20:49:18 Vasanth Ananthan wrote: > Adding platform driver and I2C client driver for SATA PHY controller > for Samsung Exynos5250.

RE: [PATCH 2/2] driver: ata: add new Exynos5250 SATA PHY controller driver

2013-01-29 Thread Kukjin Kim
Vasanth Ananthan wrote: > > Adding platform driver and I2C client driver for SATA PHY controller > for Samsung Exynos5250. > Well, I think, if required, you need to implement that via DT... > The PHY controller in Exynos5250 has both the APB interface > and I2C client interface, hence it require

[PATCH 2/2] driver: ata: add new Exynos5250 SATA PHY controller driver

2013-01-29 Thread Vasanth Ananthan
Adding platform driver and I2C client driver for SATA PHY controller for Samsung Exynos5250. The PHY controller in Exynos5250 has both the APB interface and I2C client interface, hence it requires both a platform driver and an I2C client driver. The PHY controller's primary charecteristics are han