Re: [PATCH 2/2] misc: c2c: Add C2C(Chip to Chip) device driver for EXYNOS

2012-02-06 Thread Mark Brown
On Sat, Feb 04, 2012 at 05:15:03PM +0900, Kisang Lee wrote: > Cc: Arnd Bergmann arndb.de> > Cc: Greg Kroah-Hartman kroah.com> > > Signed-off-by: Kisang Lee What is a chip to chip driver? It looks like there is some overlap with the remoteproc work that Ohad Ben-Cohen has been doing, or I thin

Re: [PATCH 2/2] misc: c2c: Add C2C(Chip to Chip) device driver for EXYNOS

2012-02-04 Thread Russell King - ARM Linux
On Sat, Feb 04, 2012 at 05:15:03PM +0900, Kisang Lee wrote: > Cc: Arnd Bergmann arndb.de> > Cc: Greg Kroah-Hartman kroah.com> > > Signed-off-by: Kisang Lee What follows is a quick review of this driver. I think there's quite a number of issues which need to be fixed before this driver is read

Re: [PATCH 2/2] misc: c2c: Add C2C(Chip to Chip) device driver for EXYNOS

2012-02-04 Thread Sylwester Nawrocki
Hi, On 02/04/2012 09:15 AM, Kisang Lee wrote: > Cc: Arnd Bergmann arndb.de> > Cc: Greg Kroah-Hartman kroah.com> Commit description aren't expected to be empty, especially when you're adding a new driver. There is little clue what the driver is needed for. Could you please be a little bit more v

[PATCH 2/2] misc: c2c: Add C2C(Chip to Chip) device driver for EXYNOS

2012-02-04 Thread Kisang Lee
Cc: Arnd Bergmann arndb.de> Cc: Greg Kroah-Hartman kroah.com> Signed-off-by: Kisang Lee --- drivers/misc/Kconfig |1 + drivers/misc/Makefile |1 + drivers/misc/c2c/Kconfig | 10 + drivers/misc/c2c/Makefile |5 + drivers/misc/c2c/samsung-c2c.c | 500