Re: [PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-13 Thread Heiko Stübner
Am Dienstag, 13. Dezember 2011, 15:49:44 schrieb Heiko Stübner: > Am Montag, 5. Dezember 2011, 17:50:13 schrieb Mark Brown: > > Enable and disable the clocks to the SPI controller using runtime PM. > > This serves the dual purpose of reducing power consumption a little and > > letting the core know

Re: [PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-13 Thread Heiko Stübner
Am Montag, 5. Dezember 2011, 17:50:13 schrieb Mark Brown: > Enable and disable the clocks to the SPI controller using runtime PM. This > serves the dual purpose of reducing power consumption a little and letting > the core know when the device is idle. > > Signed-off-by: Mark Brown Acked-by: Heik

Re: [PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-06 Thread Linus Walleij
On Tue, Dec 6, 2011 at 12:16 AM, Mark Brown wrote: > I do also think that if we do decide to move more platforms to central > management it's going to be easier to first transition all their drivers > to a repetitive style of clock management and then do a big factor out > once the pattern is cle

Re: [PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-05 Thread Mark Brown
On Mon, Dec 05, 2011 at 10:41:21PM +0100, Linus Walleij wrote: > Just wanted to mention that I had this discussion with Magnus Damm > about how they do this in shmobile: in there their central runtime PM > policy in arch/arm/mach-shmobile/pm_runtime.c adds in the > pm_clk_notifier from drivers/bas

Re: [PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-05 Thread Linus Walleij
On Mon, Dec 5, 2011 at 5:50 PM, Mark Brown wrote: > Enable and disable the clocks to the SPI controller using runtime PM. This > serves the dual purpose of reducing power consumption a little and letting > the core know when the device is idle. (...) > +#ifdef CONFIG_PM_RUNTIME > +static int s3c6

[PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-05 Thread Mark Brown
Enable and disable the clocks to the SPI controller using runtime PM. This serves the dual purpose of reducing power consumption a little and letting the core know when the device is idle. Signed-off-by: Mark Brown --- drivers/spi/spi-s3c64xx.c | 39 +++ 1 f