Re: [PATCH 2/3] ARM: S5P: Add initial map for GPIO2 and GPIO3

2010-08-22 Thread Kyungmin Park
On Mon, Aug 23, 2010 at 11:15 AM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Mon, Aug 23, 2010 at 9:18 AM, Kukjin Kim wrote: >> > Kyungmin Park wrote: >> >> >> >> NAK. >> >> >> > I don't know why I need your ack for this...if any opinions, just > comments >> > is enough. >> >> Okay I said

RE: [PATCH 2/3] ARM: S5P: Add initial map for GPIO2 and GPIO3

2010-08-22 Thread Kukjin Kim
Kyungmin Park wrote: > > On Mon, Aug 23, 2010 at 9:18 AM, Kukjin Kim wrote: > > Kyungmin Park wrote: > >> > >> NAK. > >> > > I don't know why I need your ack for this...if any opinions, just comments > > is enough. > > Okay I said in other word, I can't agree this patch. > > > > >> This approac

Re: [PATCH 2/3] ARM: S5P: Add initial map for GPIO2 and GPIO3

2010-08-22 Thread Kyungmin Park
On Mon, Aug 23, 2010 at 9:18 AM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> NAK. >> > I don't know why I need your ack for this...if any opinions, just comments > is enough. Okay I said in other word, I can't agree this patch. > >> This approach don't make a common GPIO framework. I already

RE: [PATCH 2/3] ARM: S5P: Add initial map for GPIO2 and GPIO3

2010-08-22 Thread Kukjin Kim
Kyungmin Park wrote: > > NAK. > I don't know why I need your ack for this...if any opinions, just comments is enough. > This approach don't make a common GPIO framework. I already send the > common GPIO framework which send the base address to GPIO framework > and handle it regradless GPIO is on

Re: [PATCH 2/3] ARM: S5P: Add initial map for GPIO2 and GPIO3

2010-08-21 Thread Kyungmin Park
NAK. This approach don't make a common GPIO framework. I already send the common GPIO framework which send the base address to GPIO framework and handle it regradless GPIO is one or three. http://lists.infradead.org/pipermail/linux-arm-kernel/2010-August/022513.html With this patch, we can use t

[PATCH 2/3] ARM: S5P: Add initial map for GPIO2 and GPIO3

2010-08-20 Thread Kukjin Kim
From: Jongpill Lee This patch adds initial map for GPIO2 and GPIO3. S5PV310/S5PC210 has separated GPIO1, GPIO2 and GPIO3. Signed-off-by: Jongpill Lee Signed-off-by: Kukjin Kim --- arch/arm/mach-s5pv310/cpu.c | 10 ++ arch/arm/plat-s5p/include/plat/map-s5p.h |2 ++ 2