On Thu, Feb 7, 2013 at 1:09 AM, Amit Daniel Kachhap
amit.dan...@samsung.com wrote:
This patch adds dvfs support for exynos5440 SOC. The nature of exynos5440
clock controller is different from previous exynos controllers so not using
the common exynos cpufreq framework. Also, the device tree
On Thu, Feb 7, 2013 at 10:39 AM, Inderpal Singh
inderpal.si...@linaro.org wrote:
+#define DRIVER_NAMEexynos5440_dvfs
+static struct cpufreq_driver exynos_driver = {
+ .name = DRIVER_NAME,
+};
+
Since this driver is only for exynos5440, having the same names as
On 7 February 2013 16:49, Viresh Kumar viresh.ku...@linaro.org wrote:
On Thu, Feb 7, 2013 at 10:39 AM, Inderpal Singh
inderpal.si...@linaro.org wrote:
+#define DRIVER_NAMEexynos5440_dvfs
+static struct cpufreq_driver exynos_driver = {
+ .name = DRIVER_NAME,
+};
Hi Viresh,
Thanks for the detailed review. Will try to handle them in the next version,
On Thu, Feb 7, 2013 at 3:17 AM, Viresh Kumar viresh.ku...@linaro.org wrote:
On Thu, Feb 7, 2013 at 1:09 AM, Amit Daniel Kachhap
amit.dan...@samsung.com wrote:
This patch adds dvfs support for exynos5440
On 8 February 2013 00:38, amit kachhap amit.kach...@gmail.com wrote:
Hi Viresh,
Thanks for the detailed review. Will try to handle them in the next version,
np. I haven't seen reply to few questions, you missed them or accept them.
General tip: Leave a blank line before and after your
On Thu, Feb 7, 2013 at 6:42 PM, Viresh Kumar viresh.ku...@linaro.org wrote:
On 8 February 2013 00:38, amit kachhap amit.kach...@gmail.com wrote:
Hi Viresh,
Thanks for the detailed review. Will try to handle them in the next version,
np. I haven't seen reply to few questions, you missed them
On 8 February 2013 08:56, amit kachhap amit.kach...@gmail.com wrote:
+ dvfs_info-dvfs_init = true;
why do you need this ?
This is added to synchronize the interrupts.
How? You are setting it once in init() and not touching it afterwards. :)
Yes but during init also if interrupts
This patch adds dvfs support for exynos5440 SOC. The nature of exynos5440
clock controller is different from previous exynos controllers so not using
the common exynos cpufreq framework. Also, the device tree parsing is added
to get different parameters like frequency, voltage etc.
Signed-off-by:
On 7 February 2013 01:09, Amit Daniel Kachhap amit.dan...@samsung.com wrote:
This patch adds dvfs support for exynos5440 SOC. The nature of exynos5440
clock controller is different from previous exynos controllers so not using
the common exynos cpufreq framework. Also, the device tree parsing
