Re: [PATCH 2/3] regulator: s2mps11: Add set_suspend_disable for S2MPS14

2014-03-10 Thread Lee Jones
> > > Anyway can you look at other two patches and apply them if they are OK? > > > They don't depend on this. > > > > There appears to be some external dependency for the definition of > > macros like S2MPS14X? > The patchset depends on S2MPS14 support for MFD driver. This was applied > by Lee he

Re: [PATCH 2/3] regulator: s2mps11: Add set_suspend_disable for S2MPS14

2014-03-07 Thread Krzysztof Kozlowski
On Fri, 2014-03-07 at 10:37 +0800, Mark Brown wrote: > On Thu, Mar 06, 2014 at 03:42:22PM +0100, Krzysztof Kozlowski wrote: > > > However in that case the driver won't be able later to change that value > > back to "normal enable" (enable_mask). Consider such flow: > > 1. System is going to suspen

Re: [PATCH 2/3] regulator: s2mps11: Add set_suspend_disable for S2MPS14

2014-03-06 Thread Krzysztof Kozlowski
On Fri, 2014-03-07 at 09:51 +0800, Mark Brown wrote: > On Thu, Mar 06, 2014 at 10:48:54AM +0100, Krzysztof Kozlowski wrote: > > > Anyway can you look at other two patches and apply them if they are OK? > > They don't depend on this. > > There appears to be some external dependency for the definit

Re: [PATCH 2/3] regulator: s2mps11: Add set_suspend_disable for S2MPS14

2014-03-06 Thread Mark Brown
On Thu, Mar 06, 2014 at 03:42:22PM +0100, Krzysztof Kozlowski wrote: > However in that case the driver won't be able later to change that value > back to "normal enable" (enable_mask). Consider such flow: > 1. System is going to suspend. > 2. Some regulator has "rstate->disabled" so set_suspend_di

Re: [PATCH 2/3] regulator: s2mps11: Add set_suspend_disable for S2MPS14

2014-03-06 Thread Mark Brown
On Thu, Mar 06, 2014 at 10:48:54AM +0100, Krzysztof Kozlowski wrote: > Anyway can you look at other two patches and apply them if they are OK? > They don't depend on this. There appears to be some external dependency for the definition of macros like S2MPS14X? signature.asc Description: Digital

Re: [PATCH 2/3] regulator: s2mps11: Add set_suspend_disable for S2MPS14

2014-03-06 Thread Krzysztof Kozlowski
On Thu, 2014-03-06 at 17:38 +0800, Mark Brown wrote: > On Wed, Mar 05, 2014 at 10:22:52AM +0100, Krzysztof Kozlowski wrote: > > > + ret = regmap_read(rdev->regmap, rdev->desc->enable_reg, &data); > > + if (ret < 0) > > + return ret; > > + > > + /* > > +* Don't enable suspend mo

Re: [PATCH 2/3] regulator: s2mps11: Add set_suspend_disable for S2MPS14

2014-03-06 Thread Krzysztof Kozlowski
On Thu, 2014-03-06 at 17:38 +0800, Mark Brown wrote: > On Wed, Mar 05, 2014 at 10:22:52AM +0100, Krzysztof Kozlowski wrote: > > > + ret = regmap_read(rdev->regmap, rdev->desc->enable_reg, &data); > > + if (ret < 0) > > + return ret; > > + > > + /* > > +* Don't enable suspend mo

Re: [PATCH 2/3] regulator: s2mps11: Add set_suspend_disable for S2MPS14

2014-03-06 Thread Mark Brown
On Wed, Mar 05, 2014 at 10:22:52AM +0100, Krzysztof Kozlowski wrote: > + ret = regmap_read(rdev->regmap, rdev->desc->enable_reg, &data); > + if (ret < 0) > + return ret; > + > + /* > + * Don't enable suspend mode if regulator is already disabled because > + * this

Re: [PATCH 2/3] regulator: s2mps11: Add set_suspend_disable for S2MPS14

2014-03-05 Thread Lee Jones
> S2MPS14 regulators support suspend mode where their status is controlled > by PWREN coming from SoC. This patch implements the set_suspend_disable > for S2MPS14 regulators. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/regulator/s2mps11.c | 26 ++ > i

[PATCH 2/3] regulator: s2mps11: Add set_suspend_disable for S2MPS14

2014-03-05 Thread Krzysztof Kozlowski
S2MPS14 regulators support suspend mode where their status is controlled by PWREN coming from SoC. This patch implements the set_suspend_disable for S2MPS14 regulators. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/s2mps11.c | 26 ++ include/linux/mfd