[PATCH 2/3] spi: s3c64xx: validate s3c64xx_spi_csinfo before using

2014-07-15 Thread Naveen Krishna Chatradhi
This patch validates the cs-line (Chip select gpio) and struct s3c64xx_spi_csinfo *cs object for both DT and NON-DT platforms before using in .setup(). Also, check gpio_is_valid(spi-cs_gpio) in cleanup() before freeing up. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Cc: Javier

Re: [PATCH 2/3] spi: s3c64xx: validate s3c64xx_spi_csinfo before using

2014-07-15 Thread Tomasz Figa
Hi Naveen, Please see my comments inline. On 15.07.2014 14:20, Naveen Krishna Chatradhi wrote: This patch validates the cs-line (Chip select gpio) and struct s3c64xx_spi_csinfo *cs object for both DT and NON-DT platforms before using in .setup(). Also, check gpio_is_valid(spi-cs_gpio) in

Re: [PATCH 2/3] spi: s3c64xx: validate s3c64xx_spi_csinfo before using

2014-07-15 Thread Javier Martinez Canillas
Hello Naveen, On 07/15/2014 07:49 PM, Tomasz Figa wrote: In general, I liked previous version of this series much more, as it was doing what it should as opposed to this one. Best regards, Tomasz I agree with Tomasz. I think version v6 of your series was (almost) correct while this is